Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-04-20 Thread Ajay Tripathi
Hello, Update, created draft pulls for: 1. https://github.com/openwisp/netjsonconfig/pull/152 2. https://github.com/openwisp/openwisp-controller/pull/190 (Relevant questions exist in the description of the pull request!) Best, Ajay Tripathi -- You received this message because you are subsc

Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-04-10 Thread Ajay Tripathi
On Friday, April 10, 2020 at 9:42:44 PM UTC+5:30, Federico Capoano wrote: > > Converting the device configuration to NetJSON on the device is not viable > right now, because the logic to do that resides on netjsonconfig, which > runs on the server. > Therefore at the moment the only option that a

Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-04-10 Thread Federico Capoano
Hey Ajay, On Fri, Apr 10, 2020 at 6:45 AM Ajay Tripathi wrote: > Hi, > > I have started working on merging openwisp-controller and > django-netjsonconfig. > Great news! > Meanwhile, these PRs are currently open for review: > > 1. https://github.com/openwisp/netjsonconfig/pull/149 > 2. https:/

Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-04-10 Thread Ajay Tripathi
Hi, I have started working on merging openwisp-controller and django-netjsonconfig. Meanwhile, these PRs are currently open for review: 1. https://github.com/openwisp/netjsonconfig/pull/149 2. https://github.com/openwisp/django-x509/pull/87 3. https://github.com/openwisp/openwisp-ipam/pull/27 O

Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-03-29 Thread Federico Capoano
Hi Ajay, On Fri, Mar 27, 2020 at 8:31 AM Ajay Tripathi wrote: > Hi, > > Thanks for the review, I was under the impression that the issues that are > not directly related to the title of the proposal shall be kept only on > GitHub. > > Now, I've added these three issues that you mentioned in the

Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-03-27 Thread Ajay Tripathi
Hi, Thanks for the review, I was under the impression that the issues that are not directly related to the title of the proposal shall be kept only on GitHub. Now, I've added these three issues that you mentioned in the proposal. I'll look more into these issues and start working on them asap. I

Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-03-25 Thread Federico Capoano
Hi Ajay, the proposal looks a good start. As I mentioned to you a few days ago, since you've been involved with the project for some time, I believe this project is too easy for you as it is now. Since you have the talent to do a more complex project or achieve better results, it would be a shame

Re: [openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-03-23 Thread Federico Capoano
Hi Ajay, On Sun, Mar 22, 2020 at 9:12 AM Ajay Tripathi wrote: > Hi, > > 1. I updated this pull request: > https://github.com/openwisp/openwisp-ipam/pull/27 > Great, will review it asap. 2. In `openwisp_radius`, is backward compatibility for settings variable > names required? I am assuming it'

[openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-03-22 Thread Ajay Tripathi
Hi, 1. I updated this pull request: https://github.com/openwisp/openwisp-ipam/pull/27 2. In `openwisp_radius`, is backward compatibility for settings variable names required? I am assuming it's not required since it's not released yet. 3. I have submitted a draft for GSoC proposal on the websi

[openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-03-08 Thread Ajay Tripathi
Hi, On Wednesday, March 4, 2020 at 7:05:30 AM UTC+5:30, Federico Capoano wrote: > > Great, can you open a pull request from that branch? > Yes, here it is: https://github.com/openwisp/openwisp-ipam/pull/27 The `sample_app` in this repository uses openwisp_ipam without multi-tenancy because I a

[openwisp] Re: [GSoC 2020] Merge OpenWISP django modules

2020-03-03 Thread Federico Capoano
On Tuesday, March 3, 2020 at 5:57:50 AM UTC-5, Ajay Tripathi wrote: > > Hi, > > > I like this project as it'll be really useful for us in maintenance in the > future. > I've started for this project with openwisp-ipam in the branch here: > https://github.com/atb00ker/openwisp-ipam/tree/gsoc-202