Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Alberto Bursi
On 10/01/21 22:40, Sven Roederer wrote: Am Sonntag, 10. Januar 2021, 09:47:27 CET schrieb Andre Heider: Same. I would personally like this as default sysupgrade procedure, as that's what makes most sense imho. If I have disabled a service it makes sense that after a firmware upgrade it

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Alberto Bursi
On 10/01/21 22:50, Stijn Segers wrote: Hi Sven, Op zondag 10 januari 2021 om 22u28 schreef Sven Roederer : Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers:  > @@ -228,6 +229,7 @@ do_save_conffiles() {  >  > if [ "$SAVE_INSTALLED_PKGS" -eq 1 ]; then  > echo

Re: [PATCHv3 3/3] busybox: remove useless busybox patches

2021-01-10 Thread Rosen Penev
On Fri, Jan 8, 2021 at 1:38 PM Andrey Jr. Melnikov wrote: > > Rosen Penev wrote: > > The first two are useless as /bin/sh can execute those scripts just > > fine. Shellcheck reports no problems. > > > Telnet patch is useless as telnet is no longer used in OpenWrt. > telnetd ..

Re: [PATCHv3 1/3] base-files: use hwclock --systz

2021-01-10 Thread Rosen Penev
On Sun, Jan 10, 2021 at 10:47 AM Hannu Nyman wrote: > > Hannu Nyman kirjoitti 10.1.2021 klo 19.25: > > Rosen Penev kirjoitti 8.1.2021 klo 5.30: > >> The date -k patch is non standard and will be removed in the next > >> commit. > >> > >> ... > >> > >> ---

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Stijn Segers
Hi Sven, Op zondag 10 januari 2021 om 22u28 schreef Sven Roederer : Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers: > @@ -228,6 +229,7 @@ do_save_conffiles() { > > if [ "$SAVE_INSTALLED_PKGS" -eq 1 ]; then > echo "${INSTALLED_PACKAGES}" >> "$CONFFILES" > +

[no subject]

2021-01-10 Thread Stephen Walker via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Branch: refs/heads/master

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Paul Spooren
On So, Jan 10, 2021 at 22:40, Sven Roederer wrote: Am Sonntag, 10. Januar 2021, 09:47:27 CET schrieb Andre Heider: > Same. I would personally like this as default sysupgrade procedure, as > that's what makes most sense imho. > If I have disabled a service it makes sense that after a

Re: [PATCH buildbot 3/3] docker,worker: install qemu-utils

2021-01-10 Thread Paul Spooren
On So, Jan 10, 2021 at 10:25, Paul Spooren wrote: To convert x86 images to VDI/VMDK the `qemu-img` tools is required, which is part of Debians `qemu-utils` package. The goal is to remove the ancient in-tree `qemu-img` version and replace it with a recent host installed package. Related:

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Sven Roederer
Am Sonntag, 10. Januar 2021, 09:47:27 CET schrieb Andre Heider: > > Same. I would personally like this as default sysupgrade procedure, as > > that's what makes most sense imho. > > If I have disabled a service it makes sense that after a firmware > > upgrade it remains disabled. > > Seconded. >

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Sven Roederer
Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers: > > @@ -228,6 +229,7 @@ do_save_conffiles() { > > > > if [ "$SAVE_INSTALLED_PKGS" -eq 1 ]; then > > echo "${INSTALLED_PACKAGES}" >> "$CONFFILES" > > + echo "${SERVICE_STATUS}" >> "$CONFFILES" > > mkdir -p

RE: [PATCH] dnsmasq: Ignore carrier status for bridge interfaces

2021-01-10 Thread Reuben Dowle
I agree that there does seem to be a bug in netifd here. That said, it also does not make sense to look at the carrier status of some types of interface that don't have this information. A bridge interface can never have carrier down status. The interface itself can be up or down, but not the

[PATCH buildbot 2/3] docker,worker: install gcc-mulitlib

2021-01-10 Thread Paul Spooren
>From openwrt/docker[1]: This is required for luajit, which is in packages feed. While it works fine for ARMv8 (tested by using Github Actions: aarch64_cortex-a53) and x84_x64 (tested inside Docker container, it does not work for 32-bits target and because of that we need to install

[PATCH buildbot 1/3] docker,worker: alphabetically sort packages

2021-01-10 Thread Paul Spooren
Improve readability of installed packages in the worker container. Signed-off-by: Paul Spooren --- docker/buildslave/Dockerfile | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docker/buildslave/Dockerfile b/docker/buildslave/Dockerfile index

[PATCH buildbot 3/3] docker,worker: install qemu-utils

2021-01-10 Thread Paul Spooren
To convert x86 images to VDI/VMDK the `qemu-img` tools is required, which is part of Debians `qemu-utils` package. The goal is to remove the ancient in-tree `qemu-img` version and replace it with a recent host installed package. Related: https://github.com/openwrt/openwrt/pull/3739/

Re: [PATCH 1/3] build/json: generate json file for initramfs images

2021-01-10 Thread Paul Spooren
On Sa, Jan 9, 2021 at 00:51, Moritz Warning wrote: The initramfs images are missing from the profiles.json files. Signed-off-by: Moritz Warning --- Superseded by GitHub patch[1]. Overall I'm not happy with this approach as it complicates multiple ends, instead I suggested a simpler

Re: [PATCHv3 1/3] base-files: use hwclock --systz

2021-01-10 Thread Hannu Nyman
Hannu Nyman kirjoitti 10.1.2021 klo 19.25: Rosen Penev kirjoitti 8.1.2021 klo 5.30: The date -k patch is non standard and will be removed in the next commit. ... --- a/package/base-files/files/etc/init.d/system +++ b/package/base-files/files/etc/init.d/system @@ -27,7 +27,7 @@ system_config()

[PATCH uci] delta: allow clearing delta path

2021-01-10 Thread Leonardo Mörlein
The delta path can now be cleared from libuci, lua/uci and the cli. Only the savedir remains in the delta path after clearing. This enables safely committing new changes from scripts without also comitting potentially existing uncommited user changes. This introduces: - the cli option '-x'. - the

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Luiz Angelo Daros de Luca
> When saving the list of installed pkgs, also store the status of the > system services. The list is created in the etc/backup folder also > and formated as: > > /etc/init.d/ {enable|disable} > > This way it can be sourced after sysupgrade, to restore the previous > state. I also liked the idea.

Re: [PATCHv3 1/3] base-files: use hwclock --systz

2021-01-10 Thread Hannu Nyman
Rosen Penev kirjoitti 8.1.2021 klo 5.30: The date -k patch is non standard and will be removed in the next commit. ... --- a/package/base-files/files/etc/init.d/system +++ b/package/base-files/files/etc/init.d/system @@ -27,7 +27,7 @@ system_config() { ln -sf

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Alberto Bursi
On 10/01/21 08:26, Reiner Karlsberg wrote: Am 10.01.2021 um 03:32 schrieb Alberto Bursi: > > > On 09/01/21 12:56, Reiner Karlsberg wrote: >> Am 09.01.2021 um 13:28 schrieb Stijn Segers: >> >>  > Currently all services get enabled during image creation. This can cause >>  > issues

[PATCH v3 2/3] base-files: replace PKG_RELEASE with commitcount

2021-01-10 Thread Paul Spooren
The newly added `commitcount` function does automatic versioning based on the number of Git commits of a package. Replace *tedious to bump* and *merge conflict causing* `PKG_RELEASE` and replace it with `commitcount`. Signed-off-by: Paul Spooren --- package/base-files/Makefile | 3 +-- 1 file

[PATCH v3 1/3] rules: add commitcount function

2021-01-10 Thread Paul Spooren
`commitcount` returns the number of commits affecting the current folder. The newly added function can be used for packages that do not follow a traditional versioning schema, most prominent `base-files` which requires tedious `PKG_RELEASE` bumps. Below a naming example:

[PATCH v3 3/3] uboot-envtools: use `commitcount` for release

2021-01-10 Thread Paul Spooren
Use `commitcount` function rather than manually setting a PKG_RELEASE. Signed-off-by: Paul Spooren --- package/boot/uboot-envtools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/boot/uboot-envtools/Makefile b/package/boot/uboot-envtools/Makefile index

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Andre Heider
On 10/01/2021 02:37, Alberto Bursi wrote: On 09/01/21 12:28, Stijn Segers wrote: Hi, Op zondag 3 januari 2021 om 23u14 schreef Sven Roederer : When saving the list of installed pkgs, also store the status of the system services. The list is created in the etc/backup folder also and