[PATCH] hostapd: keep HE capability after channel switch in AP+STA/Mesh

2021-12-21 Thread Arnout Vandecappelle (Essensium/Mind)
The auto-ht option already kept HT and VHT support, but wasn't updated to support HE (11ax). Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- This is a drive-by contribution that I just noticed while looking at the patch. I haven't even build tested. --- .../network/services/hostapd

Upstreaming hostapd patches 300-noscan.patch and 360-ctrl_iface_reload.patch

2021-12-16 Thread Arnout Vandecappelle
 Hi Felix,  Since I want to use these features outside of OpenWrt, I'd like to upstream the patches 300-noscan.patch and 360-ctrl_iface_reload.patch to hostap.  First of all, I'd like confirmation from you that it's OK to redistribute those patches under hostap's BSD-3-Clause license rather

Re: [PATCH v2] ubusd: convert tx_queue to linked list

2021-03-29 Thread Arnout Vandecappelle
Hi Felix, On 25/03/2021 23:56, Felix Fietkau wrote: [snip] > The data structure changes that I pointed out are not a blocker for me. > I do want to see at least a per-client message limit (in order to not > regress on accidental DoS). I posted a v3 with exactly that at around the time you

[PATCH v3 1/2] ubusd: convert tx_queue to linked list

2021-03-25 Thread Arnout Vandecappelle (Essensium/Mind)
ction when it hasn't become writeable after some timeout. Fixes: https://bugs.openwrt.org/index.php?do=details_id=1525 Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- v3: - remove the txq_ofs change - reduce the diff a bit by adding "ub = ubl->msg;" v2: workarounds for clan

[PATCH v3 2/2] ubusd: add per-client tx queue limit

2021-03-25 Thread Arnout Vandecappelle (Essensium/Mind)
No new message can be enqueued if this brings the total queue length of that client over UBUS_CLIENT_MAX_TXQ_LEN. Set UBUS_CLIENT_MAX_TXQ_LEN to UBUS_MAX_MSGLEN, i.e. 1MB. This limit should be plenty for any practical use case. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- v3: new

Re: [PATCH] ubusd: convert tx_queue to linked list

2021-03-25 Thread Arnout Vandecappelle
On 25/03/2021 10:09, Sergey Zakharchenko wrote: > Hi Arnout, > > JFYI: Much of your patch resembles > https://patchwork.ozlabs.org/project/lede/patch/20180503100622.11168-1-i@qbox.audio/ > which was marked superseded for no apparent reason, but "anonymous > remembers":). It's delegated to

Re: [PATCH v2] ubusd: convert tx_queue to linked list

2021-03-25 Thread Arnout Vandecappelle
On 25/03/2021 10:48, Felix Fietkau wrote: > > On 2021-03-24 13:27, Arnout Vandecappelle (Essensium/Mind) wrote: >> ubusd maintains a per-client tx_queue containing references to message >> buffers that have not been sent yet (due to the socket blocking). This >> is

Re: [PATCH] ubusd: convert tx_queue to linked list

2021-03-25 Thread Arnout Vandecappelle
On 24/03/2021 09:31, Petr Štetiar wrote: > Arnout Vandecappelle (Essensium/Mind) [2021-03-23 16:23:25]: > > Hi, > >> Note that this infinite tx_queue opens the door to a DoS attack. > > memory is not infinite, so I think, that some sensible upper limit should be

[PATCH v2] ubusd: convert tx_queue to linked list

2021-03-24 Thread Arnout Vandecappelle (Essensium/Mind)
do=details_id=1525 Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- v2: workarounds for clang static analysis false positives: - use list_for_each_safe instead of a while loop; - hide the free() by moving it to ubusd.c. --- ubusd.c | 30 +- ubusd.h

Re: [PATCH] ubusd: convert tx_queue to linked list

2021-03-24 Thread Arnout Vandecappelle
On 24/03/2021 08:52, Arnout Vandecappelle wrote: > > > On 23/03/2021 17:16, Petr Štetiar wrote: >> Arnout Vandecappelle (Essensium/Mind) [2021-03-23 16:23:25]: >> >> Hi, >> >>> To maintain the linked list, an additional structure ubus_msg_buf_lis

Re: [PATCH] ubusd: convert tx_queue to linked list

2021-03-24 Thread Arnout Vandecappelle
On 23/03/2021 17:16, Petr Štetiar wrote: > Arnout Vandecappelle (Essensium/Mind) [2021-03-23 16:23:25]: > > Hi, > >> To maintain the linked list, an additional structure ubus_msg_buf_list >> is created. We could also have added the linked list to the ubus_

[PATCH] ubusd: convert tx_queue to linked list

2021-03-23 Thread Arnout Vandecappelle (Essensium/Mind)
do=details_id=1525 Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- ubusd.c | 23 ++- ubusd.h | 10 +++--- ubusd_main.c | 45 + ubusd_proto.c | 1 + 4 files changed, 43 insertions(+), 36 deletions(-) diff -