Re: [OpenWrt-Devel] merge: add OpenWrt branding

2017-10-24 Thread Jo-Philipp Wich
Hi, comments inline. > Signed-off-by: Imre Kaloz Given the fact that we explicitely wanted to avoid @openwrt.org mails and that this was one of the discussion points leading to the split I find it delicate to seal the merging commit with exactly such a S-o-b. Combined with

Re: [OpenWrt-Devel] openwrt and lede - remerge proposal V3

2017-06-13 Thread Jo-Philipp Wich
Hi, NACK from me - not that it makes a difference but I do not like to operate under the OpenWrt name. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] openwrt and lede - remerge proposal V3

2017-05-29 Thread Jo-Philipp Wich
Hi Tom, > I'd vote for re-enabling trac for all users, instead of wasting time and > resources on another flyspray instance or even existing one which > compared to trac does not bring any breakthrough features. Compared to Flyspray, Trac is a nightmare to administer. It leaks resources like a

Re: [OpenWrt-Devel] SHA256 hashes for packages

2017-01-05 Thread Jo-Philipp Wich
Hi Heinrich, LEDE recently introduced PKG_HASH which accepts both SHA256 and MD5 sums, so in doubt simply declare both PKG_MD5SUM holding an md5 sum and PKG_HASH holding the sha256 equivalent. ~ Jo ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] Any interest in adding runit to OpenWRT?

2016-12-03 Thread Jo-Philipp Wich
Hi Denys, > Well, we certainly can fix the ntpd start scritps, > but this is a generic problem, right? We'd want ANY > daemons to be run "properly", with their output logged. > With log size and location controlled. With log rotation. > Etc. etc etc. Controlling log rotation, sizes etc. is the

Re: [OpenWrt-Devel] [LEDE-DEV] LED uci policy for not actively used LEDs

2016-11-10 Thread Jo-Philipp Wich
Hi Karl, I think there is not much speaking against making the led init script run earlier. I think it would make sense to have it START=11, right after /etc/init.d/boot. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [LEDE-DEV] LED uci policy for not actively used LEDs

2016-11-10 Thread Jo-Philipp Wich
Hi Sven, imho it is preferable to have usable, but inactive LEDs available by default in the system configuration. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] base-files: Prefer busybox arp over /proc/net/arp alias

2016-11-10 Thread Jo-Philipp Wich
Hi, pushed with http://git.lede-project.org/9978a3e and added the missing ">" to the first S-o-b. Thanks, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] Recently added feature in UCI - mandatory anonymous sections

2016-11-10 Thread Jo-Philipp Wich
On 11/08/2016 05:13 PM, Antonio Paunovic wrote: > Hello everyone, > > recently there was a change in default UCI behaviour which you can > see here: > > http://git.openwrt.org/?p=project/uci.git;a=commit;h=df72af474075159ab79ed190d2109eb2d86709bf > > While change in implementation is minor, this

Re: [OpenWrt-Devel] [LEDE-DEV] rpcd-mod-nosql - prpl funding proposal

2016-11-10 Thread Jo-Philipp Wich
Hi Luka, in rpcd there already is the ability to store arbitrarily nested key-value data in the session namespace which is even persistent over daemon reloads. Is this not sufficient? And if not, what is missing? ~ Jo ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH RFC firewall3] musl-compat: avoid kernel header conflicts

2016-11-06 Thread Jo-Philipp Wich
Hi again, > Will see if I find another solution... I managed to find a solution that works for me on a Linux 4.6.0 system with glibc, a Linux 4.6.0 system with unpatched musl and a Linux 4.4 system with patched kernel headers. I pushed this change along with a few others that should aid in

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH firewall3] iptables: optional loading of static extensions

2016-11-06 Thread Jo-Philipp Wich
Hi Ralph, I took the CMakeLists.txt change as-is but modified the rest to use no-op declarations of init_extensions{,4,6}() in order to avoid sprinkling too much ifdefs around. Thanks, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH RFC firewall3] musl-compat: avoid kernel header conflicts

2016-11-06 Thread Jo-Philipp Wich
Hi Ralph, unfortunately this breaks building on a glibc system for me: -- 8< -- $ make [ 7%] Building C object CMakeFiles/firewall3.dir/iptables.c.o In file included from /usr/include/linux/netfilter_ipv4.h:8:0, from /usr/include/linux/netfilter_ipv4/ip_tables.h:21,

Re: [OpenWrt-Devel] [PATCH firewall3] iptables: fix loading standard target

2016-11-05 Thread Jo-Philipp Wich
Hi Ralph, thanks - applied with minor code style change in 010723e. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH firewall3] iptables: add support for version 1.6.0

2016-11-04 Thread Jo-Philipp Wich
Hi Ralph, pushed to http://git.lede-project.org/dd01372 - thank you! ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Is there a way I can restore balance to the force?

2016-10-25 Thread Jo-Philipp Wich
Hi David, I did not personally attend but from a quick private talk with blogic it sounded to me like there's been some constructive discussion in a calm atmosphere that at least helped to clear up the status quo. Hauke currently tries to organize a follow up conference call to further discuss

Re: [OpenWrt-Devel] [PATCH] iwinfo: add device id for Ubiquiti NanoStation Loco M2

2016-10-15 Thread Jo-Philipp Wich
Hi Sven, pushed to iwinfo.git - thanks! Will update it in LEDE master soon. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] openwrt userspace git repo location

2016-09-27 Thread Jo-Philipp Wich
Hi Luka, > GitHub proved to be convinient in attracting easier collaboration. I'm > wondering what the community thinks about this proposal. Thoughts? If there is a decision to put those projects on Github I'd like to not have them under the OpenWrt project org but let the individual authors

Re: [OpenWrt-Devel] [LEDE-DEV] RFC netifd: UCI parameter to sort name servers in resolv.conf.auto

2016-09-05 Thread Jo-Philipp Wich
Hi Hans, imho it would also make sense to take any existing metric setting into account as well. At least I'd expect that if I have a wan1 with metric 10 and a wan2 with metric 20 that the DNS server entries "inherit" the same weight/order. So priority wise I'd first order by dns metric, then by

Re: [OpenWrt-Devel] LuaJIT Vs Lua and other questions

2016-06-30 Thread Jo-Philipp Wich
Hi Anton, the problem is that there is no working PROVIDES mechanism in the buildroot. We could only modify the Lua package to either build Luajit (for supported arches) or PUC 5.1 one, depending on a menuconfig setting. Can't think of a better solution. ~ Jo

Re: [OpenWrt-Devel] Support for callable metatable for ubus-lua

2016-06-29 Thread Jo-Philipp Wich
Hi Anton, personally I do not like peeking into foreign objects meta tables just to find out whether they're callable. Maybe we should simply stop checking the type entirely and instead rely on lua_pcall() to deal with non-callables and other runtime errors. What do you think? ~ Jo

Re: [OpenWrt-Devel] LuaJIT Vs Lua and other questions

2016-06-29 Thread Jo-Philipp Wich
Hi Anton, > First I've tried to name package as "luajit" and add CONFLICTS:=lua > (version should be provided to conflict with) and PROVIDES:=lua > variables like for RPM to make a replacement package, but I get a > dependency loop. Therefore, I name produceable packages "lua" and > "liblua". The

Re: [OpenWrt-Devel] [RFD] Future

2016-06-29 Thread Jo-Philipp Wich
Hi Imre, can you provide a summary of the discussion? Thank you, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Response to LEDE proposal/queries/mail?

2016-06-27 Thread Jo-Philipp Wich
Hi Mike, given sufficient and reasonable agreements I am certainly willing to help implementing our desired changes. Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Response to LEDE proposal/queries/mail?

2016-06-27 Thread Jo-Philipp Wich
Hi Zoltan, we started a discussion on OpenWrt re-merge conditions over at lede-dev and waited for a while to solicit more feedback. Since no other people expressed further wishes and since you repeatedly asked for a list of things the LEDE folks would like to see in OpenWrt I'm going to

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH libubox 3/3] blobmsg_json: add new functions blobmsg_format_json_value*

2016-06-21 Thread Jo-Philipp Wich
of a > JSON object). > > To avoid breaking software relying on this behaviour, introduce new > functions which will never print the blob_attr name and thus always > produce valid JSON. > > Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Acked-by: Jo-Philipp Wi

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH libubox 2/3] loop: make uloop_run() return the cancelling signal

2016-06-21 Thread Jo-Philipp Wich
d definition against the other is > not possible. > > [1] https://www.cons.org/cracauer/sigint.html > > Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Acked-by: Jo-Philipp Wich <j...@mein.io> > --- > uloop.c | 14 -- > uloop.h | 6 +++--- &g

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

2016-06-21 Thread Jo-Philipp Wich
Hi, first of all, thanks for putting work into that - I like the changes in general. Have a few comments inline below. ~ Jo > Consistently handle allocation failures. Some functions are changed to > return bool instead of void to allow returning an error. > > Also fix a buffer size

Re: [OpenWrt-Devel] [PATCH] [rpcd] iwinfo: zero out ccode buffer since library doesn't

2016-06-05 Thread Jo-Philipp Wich
Pushed to rpcd.git, thanks Denis. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] OpenWrt / LEDE

2016-05-26 Thread Jo-Philipp Wich
Dear Kathy, > I appreciate your well-written summary and the notable improvements. > Moving to git and keeping history, improving the web site and > documentation to enable more collaboration, making workflows more > efficient and open, etc. had been discussed during face-to-face > gatherings of

Re: [OpenWrt-Devel] OpenWrt / LEDE

2016-05-26 Thread Jo-Philipp Wich
Hi all, I think the status quo has now been described several times and can be summarized as: - Launching the new LEDE project/fork/reboot without discussing matters in advance with the developers not being involved was perceived in a hostile action damaging OpenWrt - It has been

Re: [OpenWrt-Devel] [OT] Implemented: not an ML erase button but at least a rethink switch

2016-05-26 Thread Jo-Philipp Wich
Hi Daniel, hope you're doing well nowadays. I sincerely appreciate your participation in the discussions surrounding the whole OpenWrt/LEDE topic especially since it helps giving another, outside perspective to the entire issue. What I noticed is that you're sometimes generating like 80% of the

Re: [OpenWrt-Devel] [OpenWrt-Users] [PROPOSAL] move OpenWrt codebase to Git and GitHub

2016-05-24 Thread Jo-Philipp Wich
Hi, here's a few numbers we gathered with our buildbot setup: We currently need roughly 35GB per target when building OpenWrt plus the entire package world and currently there are roughly ~70 target/subtarget combinations in the OpenWrt tree. If fast build tests are desired then the only way to

Re: [OpenWrt-Devel] [PROPOSAL] move OpenWrt codebase to Git and GitHub

2016-05-24 Thread Jo-Philipp Wich
Hi Luka, this is fantastic news! I'd be very interested in your future progress on the CI front. If drone.io is able to accommodate the resources required for building the entire OpenWrt then it sounds like a good solution for other projects too. Regards, Jo

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Jo-Philipp Wich
Hi Hans, > I wanted to preserve the ntp server behavior and only change the > behavior when configured in order to keep backwards compatibility. You > favour enabling DHCP ntp server config without explicit config ? Personally I do because thats likely what most users expect, but then trusting

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-19 Thread Jo-Philipp Wich
Hi Hans, staged into https://git.lede-project.org/?p=lede/jow/staging.git A few improvement ideas though; - maybe we can make the jsonfilter dependency conditionally depending on the ntpd applet - maybe pipe the ubus interface status dump directly to jsonfilter - is there any reason to

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] conntrack: enable support for netfilter conntrack zones

2016-05-19 Thread Jo-Philipp Wich
Hi Alin, I merged your patch into my staging tree at https://git.lede-project.org/?p=lede/jow/staging.git;a=commitdiff;h=6c9231baa9c5341c6ee2e213618dcde72d42288b Since your change lacked a proper Signed-off-by I added it on your behalf. Please review the link above and give me your ACK, then

[OpenWrt-Devel] Introducing the LEDE project

2016-05-03 Thread Jo-Philipp Wich
with a simplified release process If you're interested in participating or want to learn more about the project, check out https://www.lede-project.org/. Sincerely, Jo-Philipp Wich, John Crispin, Daniel Golle, Felix Fietkau, Hauke Mehrtens John Crispin Matthias Schiffer, Steven Barth

Re: [OpenWrt-Devel] [PATCH] load running state after lock is acquired

2016-05-02 Thread Jo-Philipp Wich
Hi Alin, thanks! Pushed to firewall3.git. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] firewall3: Fix multicast ICMPv6 replies not being sent by default anymore.

2016-05-02 Thread Jo-Philipp Wich
Hi Vittorio, can you move the "mcdst" declaration to the top of the function? ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] set mark for locally generated traffic in OUTPUT chain

2016-04-28 Thread Jo-Philipp Wich
Hi Daniel, thanks for the explaination, I was missing the function context. The change is indeed fine, pushed to firewall3.git - thanks! ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] set mark for locally generated traffic in OUTPUT chain

2016-04-28 Thread Jo-Philipp Wich
Hi Daniel, my stomach feeling tells me that this is okay but can you elaborate on the change? ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 1/6] netifd: Make sending DHCP release configurable via uci when client exits

2016-04-28 Thread Jo-Philipp Wich
Hi, I assume this one supersedes "netifd: Send DHCP release when client exits" ? Asking because I see no deletion of the "-R" option which would be introduced by the other patch. If this is the case can you slightly reword it to "Add configurable DHCP release behaviour" or something? Sorry for

Re: [OpenWrt-Devel] [PATCH] [firewall3] defaults.c: remove toplevel_rule struct

2016-04-27 Thread Jo-Philipp Wich
Hi Alexandru, pushed to master - thanks! ~ Jo On 27.04.2016 08:16, Alexandru Ardelean wrote: > From: Alexandru Ardelean > > Since commit 60f1444 , this struct is no longer used. > > Signed-off-by: Alexandru Ardelean > --- > defaults.c | 7

Re: [OpenWrt-Devel] [PATCH 02/05] [tools] findutils glibc >= 2.23 compat

2016-04-25 Thread Jo-Philipp Wich
Hi, this should be handled already, configure uses AC_HEADER_MAJOR and mountlist.c does: #ifdef MAJOR_IN_SYSMACROS #include #define HAVE_MAJOR ... did you patched findutils proactively or was there an actual build issue? ~ Jo ___ openwrt-devel

Re: [OpenWrt-Devel] [PATCH 01/??] [tools] make-ext4fs glibc >= 2.23 compat

2016-04-25 Thread Jo-Philipp Wich
Hi, no, I only cared about make-ext4fs as I maintain this fork. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 01/??] [tools] make-ext4fs glibc >= 2.23 compat

2016-04-25 Thread Jo-Philipp Wich
Hi! Thanks for the patch, I fixed the include issue directly in Git, so this patch can be dropped and make-ext4fs should be updated in tools/ to a newer version instead. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] upstream opkg

2016-04-21 Thread Jo-Philipp Wich
Hi, Yocto made opkg unusable for us. Current upstream is *far* too big for use in OpenWrt. The now required libarchive alone is larger than our current opkg version. I took a look at packaging current opkg a while back and got stuck at bringing libarchive down to a sane size, therfor I gave up

Re: [OpenWrt-Devel] [UCI] uci import -m duplicates list options

2016-04-15 Thread Jo-Philipp Wich
Hi. Just truncate the destination file beforehand. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] rsync mirror of download.openwrt.org ?

2016-04-12 Thread Jo-Philipp Wich
Hi Dape, you need to ask Kaloz to setup rsync access for you I guess. Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] rsync mirror of download.openwrt.org ?

2016-04-12 Thread Jo-Philipp Wich
Hi Daniel, the entire downloads.openwrt.org is around 720GB while the 15.05.1 release is 36GB in total. Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 2/3] [rpcd] file: handle return output of b64_decode

2016-04-12 Thread Jo-Philipp Wich
Hi Luka, Please use ssize_t instead. Regards, Jo > Am 11.04.2016 um 18:56 schrieb Luka Perkov : > > Solve this compile warning: > > file.c:300:16: error: comparison of unsigned expression < 0 is always false > [-Werror,-Wtautological-compare] >if (data_len <

Re: [OpenWrt-Devel] [PATCH 1/2] dnsmasq: Fix dhcp option parsing

2016-03-31 Thread Jo-Philipp Wich
Hi, various configurations out there use "option dhcp_option ..." still, did you check whether this works yet after your patch? ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH netifd] alias : Fix interface aliased on top of a static interface not getting active

2016-03-31 Thread Jo-Philipp Wich
Hi Hans, pushed into netifd.git, thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v3] ipvs: Linux IP Virtual Server kernel modules (netfilter.mk patch)

2016-03-11 Thread Jo-Philipp Wich
Hi, seems that change fails all builds now due to undeclared symbols: * * IPVS application helper * FTP protocol helper (IP_VS_FTP) [N/m/?] (NEW) aborted! Please fix. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Question regarding call python script

2016-03-10 Thread Jo-Philipp Wich
Hi Jason, no reason against it per se but it would introduce a new build prereq I suppose. If possible we'd like to stick to things we already require (perl, awk, shell). Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] downloads.openwrt.org

2016-03-08 Thread Jo-Philipp Wich
Failed builds, stay tuned. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 1/5] [package] iptables: Disable IPv6 support

2016-03-08 Thread Jo-Philipp Wich
Hi, your change makes no sense, the logic is the very same. It is possible that yours is not even working and will now always disable IPv6, even if its actually enable. I believe the actual problem is that CONFIG_IPV6 refers to the kernel config symbol here, not to the one from our build

Re: [OpenWrt-Devel] Read-only mirror https://github.com/openwrt/openwrt is stuck since 12 days ago

2016-03-08 Thread Jo-Philipp Wich
Hi. > Not to pile on, but is there any way to have the commit hashes on github > match those at openwrt.org (e.g., a true mirror)? No. We'll make the openwrt.git on github available as git.openwrt.org/source.git eventually but git.openwrt.org/openwrt.git will stay as-is. ~ Jow

Re: [OpenWrt-Devel] Setting uci defaults in trunk

2016-02-26 Thread Jo-Philipp Wich
Hi. > In r48800 this file seems to have been replaced by > /etc/board.d/02_network instead. Unfortunately "raw" uci commands does > not work since its generating /etc/board.json instead? Am I correct? > > If I do this then "dhcp" is ignored and the interface is set to static > anyway: >

Re: [OpenWrt-Devel] uci_lookup_ptr() seg fault

2016-02-17 Thread Jo-Philipp Wich
Hi. > I am getting seg fault sometimes on the uci_lookup_ptr() call. here is > the way I call this function: > It happens I would say once every couple of hundred calls. My gut feeling is that one of the "file_name", "section_name", "section_value" or "option_name" pointers becomes stale. Your

Re: [OpenWrt-Devel] Plans for CC 15.05.1 or DD 16.xx release?

2016-02-10 Thread Jo-Philipp Wich
The release will be delayed due to infrastructure problems. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Native IPv6 Broken in recent trunk

2016-02-09 Thread Jo-Philipp Wich
Hi. > config interface 'lan' > option force_link '1' > option type 'bridge' > option proto 'static' > option netmask '255.255.255.0' > option ip6assign '64' > option dns 'x' > option ipaddr '172.18.18.1' > option

Re: [OpenWrt-Devel] Question about custom script at init on Trunk.-

2016-01-27 Thread Jo-Philipp Wich
Hi, > So, /etc/uci-defaults/z999-something works, but is there a > better way? Not yet - but we could start changing packages to use numerical prefixes. I do not suppose that sooo many uci-default scripts are used. ~ Jow ___ openwrt-devel mailing

Re: [OpenWrt-Devel] [PATCH 1/4] base-files: add option to specify netdev led mode in configuration generation

2016-01-19 Thread Jo-Philipp Wich
Hi, see inline comments. ~ Jow On 01/07/2016 01:40 AM, Tal Keren wrote: > This is necessary for controlling leds of RJ45 port, when one indicate the > link > status and the other indicate data transfer. > > Signed-off-by: Tal Keren > --- >

Re: [OpenWrt-Devel] [PATCH 1/4] base-files: add option to specify netdev led mode in configuration generation

2016-01-19 Thread Jo-Philipp Wich
Hi, thought some more about it and we want to have the proper defaults in board.json already, therefore disregard my previous comments and stick to the ones below. Sorry for the bikeshedding here. Thanks, Jow > On 01/07/2016 01:40 AM, Tal Keren wrote: >> This is necessary for controlling leds

Re: [OpenWrt-Devel] [PATCH][package] Allow UCI dhcp classifier to accept a list of MAC

2016-01-18 Thread Jo-Philipp Wich
Hi. The change is fine with me but shouldn't we keep checking whether there's at least one mac given? ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 1/1] package/libs/libiconv: function names

2016-01-18 Thread Jo-Philipp Wich
Applied in r48301 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH][RFC] x86: Save and restore partition table during upgrade

2016-01-17 Thread Jo-Philipp Wich
Hi. > This patch will save the partition table before an upgrade. > If the installed image has not changed the partition structure > the saved table will be restored, ensuring any user created > partitions will be present after the upgrade. That sounds odd. If I'd start to rely on such a feature

Re: [OpenWrt-Devel] Plans for CC 15.05.1 or DD 16.xx release?

2016-01-12 Thread Jo-Philipp Wich
On 01/12/2016 09:19 AM, Nishant Sharma wrote: > Hi, > > On Monday 11 January 2016 05:42 PM, John Crispin wrote: > >> days. with a bit of luck 15.05.1 is ready early next week. > How do I bump my local git cloned source to 15.05.1? > > A simple git pull in the source directory should be able to

Re: [OpenWrt-Devel] Need help with Makefile error *** missing separator

2016-01-05 Thread Jo-Philipp Wich
/files/luci/i18n/chinadns.zh-cn.lmo" ]; thenbash: -c: line 1: > syntax e r ror: unexpected end of filemake[2]: *** [/home/Openwrt/witi-openwrt/bin/ramips/packages/base/luci-app-chinadns_1.3.8-1_all.ipk] Error 1make[2]: Leaving directory `/home/Openwrt/witi-openwrt/package/my_package

Re: [OpenWrt-Devel] Need help with Makefile error *** missing separator

2016-01-04 Thread Jo-Philipp Wich
Hi. Lines in the isntall section must be indented with at least one tab since they're shell instructions. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-30 Thread Jo-Philipp Wich
Hi Yousong. NAK - thats by design. If a network config is present then there is no point in regenerating it. I'd prefer if the Malta target would simply drop its default config and switch to board.d, this could be useful to e.g. dynamically handle different amounts of eth* devices: eth0 -> lan

Re: [OpenWrt-Devel] Board detection for Lamobo R1 fails

2015-12-10 Thread Jo-Philipp Wich
Hi Vasco, thats certainly possible, I merely did a logical translation of the code. Can you please check that after changing "Lamobo R1" in the case switch to "Lamobo Banana Pi R1" the defaults are working properly? You can test with the following command: rm -f /etc/board.json

Re: [OpenWrt-Devel] [PATCH v2] axs10x: initilaze network for wireless access-point

2015-12-07 Thread Jo-Philipp Wich
Hi Alexey, > Any thoughts how I may setup a bridge on eth0 in init scripts in board.d? with board.d, the lan interface will always be of type bridge. There is no way to declare non-bridge lan ifaces anymore. ~ Jow ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH] lantiq: fix logic error in dsl board.d code

2015-12-06 Thread Jo-Philipp Wich
Hi Mathias, you're right - I accidentally inverted the logic. Patch committed with r47793. ~ Jow signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] [make_ext4fs] Explicitly call setlocale() before sorting the source directory

2015-12-02 Thread Jo-Philipp Wich
Hi Wojtek, applied to Git in http://git.openwrt.org/?p=project/make_ext4fs.git;a=commit;h=bd53eaafbc2a89a57b8adda38f53098a431fa8f4 and updated in OpenWrt with r47689 ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] procd: hotplug.json: allow passing hotplug events from all subsystems

2015-11-30 Thread Jo-Philipp Wich
Hi all, as an intermediate solution we could simply allow qemu specific events. I'm with John here that passing on uevents unfiltered is probably no good idea. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [CC 15.05] polarssl: Security update (CVE-2015-5291)

2015-11-29 Thread Jo-Philipp Wich
Hi, > Why does this not show up in the CC git tree? [...] >> * >> http://git.openwrt.org/?p=15.05/openwrt.git;a=commit;h=72f741c118ac89f4fb6f03211227ec86c2eb5f6d >> * >> http://git.openwrt.org/?p=15.05/openwrt.git;a=commit;h=c3eab1cd32f7576a9aa21f7554cb31daeaab5e3b >> * >>

Re: [OpenWrt-Devel] [PATCH firewall] zones : Redirect incoming WAN traffic only when the destination IP address matches the IP masquerading address

2015-11-26 Thread Jo-Philipp Wich
Hi, did you consider to simply add "src_dport" to the redirect rule? ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH firewall] zones : Redirect incoming WAN traffic only when the destination IP address matches the IP masquerading address

2015-11-26 Thread Jo-Philipp Wich
> did you consider to simply add "src_dport" to the redirect rule? Or rather, "src_dip" in this case as it is about redirecting the proper wan ip. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Syntax to call ubus registered function (having arguments) from lua

2015-11-20 Thread Jo-Philipp Wich
PM, Jo-Philipp Wich <j...@openwrt.org > <mailto:j...@openwrt.org>> wrote: > > Hi. > > > I am trying to call a function registered on ubus from lua script. I > > know how to call a argument less function but don't know the syntax of a > >

Re: [OpenWrt-Devel] Syntax to call ubus registered function (having arguments) from lua

2015-11-20 Thread Jo-Philipp Wich
Hi. > I am trying to call a function registered on ubus from lua script. I > know how to call a argument less function but don't know the syntax of a > function with args (also how to add ubus timeout). Simply pass a table with your arguments as 3rd argument: conn:call(object, function, {

Re: [OpenWrt-Devel] [PATCH] ar71xx: fix wndr3700_board_detect for some NETGEAR WNDR3700v2 (again)

2015-11-20 Thread Jo-Philipp Wich
Applied in r47538 - thank you! ~ Jow signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 4/4] conntrack-tools: preserve /etc/conntrackd during upgrade

2015-11-11 Thread Jo-Philipp Wich
Hi, > + $(INSTALL_DATA) ./files/conntrackd.upgrade > $(1)/lib/upgrade/keep.d/conntrackd please don't ship keep.d files manually, use the define Package/.../conffile macro (yes it works for directories as well). ~ Jow signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] polluted env-space after running OpenWrt-helper scripts

2015-11-03 Thread Jo-Philipp Wich
Hi, > some things are easy for getting rid of: > one can call 'network_flush_cache()' from > /lib/functions/network.sh > > but i'am unsure how to unset all these vars: Whenever a script calls uci_load(), the previous state vars are discarded, see the declaration of uci_load in

Re: [OpenWrt-Devel] How to get uhttpd logs

2015-10-29 Thread Jo-Philipp Wich
Hi, can you execute this .lp file on the shell? uhttpd is a cgi server, it executes scripts as commands so they need to be world-readable and executable. LuaPages appear to be specific to CGILua or the Kepler project, uhttpd does not support this syntax out of the box. ~ Jow

Re: [OpenWrt-Devel] How to get uhttpd logs

2015-10-29 Thread Jo-Philipp Wich
Hi, > ./index.lp: line1: can't open ?lua: no such file > ./index.lp: line2: syntax error: unexpected word (expecting ")") As expected, so its not actually a standalone CGI program but a script similar to a PHP file. > How to support LuaPages in uhttpd ? You need to associate an interpreter

Re: [OpenWrt-Devel] AR9344 Openwrt - LAN and WAN interface link issue

2015-10-28 Thread Jo-Philipp Wich
Hi Afkar, WAN: swconfig dev switch0 port 1 get link LAN: swconfig dev switch0 port 1 get link swconfig dev switch0 port 2 get link swconfig dev switch0 port 3 get link swconfig dev switch0 port 4 get link ~ Jow ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] AR9344 Openwrt - LAN and WAN interface link issue

2015-10-28 Thread Jo-Philipp Wich
Hi Afkar, > The same thing if we connect only WAN cable and check "cat > /sys/class/net/eth0.1/carrier" and "cat /sys/class/net/eth0.2/carrier" > both returns "1" . But it should not be like this. This is expected since both eth0.1 and eth0.2 are actually SoC connection to the external switch

Re: [OpenWrt-Devel] [PATCH] toolchain: fix PKG_SOURCE_URL for gdb

2015-10-26 Thread Jo-Philipp Wich
Hi Philipp, applied in r47277 with a minor edit (added "CC: " tag to subject line). Please consider this from now on whenever a patch is meant for a specific branch instead of trunk. Thanks! ~ Jow ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] SVN to GIT transition

2015-10-09 Thread Jo-Philipp Wich
Hi. > Moving to Git seemed to have lots of traction at the summit, and I'll > add my voice that this sounds like a step in the right direction for > OpenWrt. I'm assuming that we would want to do a proper SVN to Git > conversion, and Eric's help on this would be great, I think. My > discussion

Re: [OpenWrt-Devel] uhttpd: chunked output from cgi script

2015-10-08 Thread Jo-Philipp Wich
Hi Luigi, > I tested another patch of mine (really noobish i know :) ) > still against commit: 993cace15114a0f06f720f34a4748ab54b695f0d > [...] > and it seems to works for the reasons I tried to explain in my previous > mail. Right, it will work but emit invalid HTTP responses if a CGI handler

Re: [OpenWrt-Devel] uhttpd: chunked output from cgi script

2015-10-07 Thread Jo-Philipp Wich
Hi Luigi, thank you for your patch proposal, it prompted me to take a deeper look into the problem. The issue should be fixed with the following commit: http://nbd.name/gitweb.cgi?p=uhttpd2.git;a=commitdiff;h=7ed2edc40dd6d0171266f3bfbc96466e1d25e3cd Regards, Jow signature.asc Description:

Re: [OpenWrt-Devel] [PATCH v3] lantiq: get more status information from xDSL

2015-10-03 Thread Jo-Philipp Wich
Hi, the patch caused a regression in LuCI, please see https://dev.openwrt.org/ticket/20607#comment:6 Basically the problem is that the current "lucistatus" code emits invalid Lua code by providing no value for these parameters: dsl.errors_crc_p_near= dsl.errors_crc_p_far=

Re: [OpenWrt-Devel] [PATCH firewall] zones : Redirect incoming WAN traffic only when the destination IP address matches the IP masquerading address

2015-10-01 Thread Jo-Philipp Wich
Hi, wouldn't this break port forwards to hosts not being within the range of the on-link lan subnet? I also read the patch description three times and still am not sure what that change attempts to achive. Can you further explain the problem please and provide a before/after "fw3 print" diff so

Re: [OpenWrt-Devel] How to add ubus users?

2015-09-28 Thread Jo-Philipp Wich
Hi Christoph, there is no PAM support yet but the appropriate place to add it would be rpc_login_test_login() of rpcd's session.c [1] I wouldn't mind adding PAM support if it is possible to make it optional at runtime. Haven't yet investigated whether it is feasible to dlopen() libpam if

Re: [OpenWrt-Devel] How to add ubus users?

2015-09-25 Thread Jo-Philipp Wich
Hi Ronaldo, if you refer to the JSON-RPC/UBUS bridge in uhttpd then you can specify "option no_ubusauth 1" in /etc/config/uhttpd, this will bypass any permission checks. Keep in mind that this gives full access to anything exposed by ubus to any HTTP client! ~ Jow signature.asc Description:

Re: [OpenWrt-Devel] [PATCH v4] base-files: add /etc/profile.d support

2015-09-04 Thread Jo-Philipp Wich
Hi. > Why the -e? You only got existing files in the glob above right? Almost. If the directory does not exist or is empty then the glob pattern is returned literally, e.g. "echo /tmp/*" will expand to a list of files but "echo /does_not_exist/*" will return "/does_not_exist/*" literaly so the

Re: [OpenWrt-Devel] ar71xx: RB435G PCI does not support minipci sata module (PER-C20S)

2015-08-17 Thread Jo-Philipp Wich
Hi. Is the PCI subsystem on this board supported only for wireless cards? Yes. The hardware controller cannot handle PCI I/O resources, therefore only a subset of available miniPCI cards do work with it. Anything requiring I/O resources is a no-go. HTH, Jow

<    1   2   3   4   5   6   7   8   9   10   >