Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-14 Thread Antonio Quartulli
On 14/01/14 18:34, John Crispin wrote: > > On 14/01/2014 18:06, Antonio Quartulli wrote: >> On 13/01/14 11:26, John Crispin wrote: >>> i will pull this patch into the tree after lunch. >>> >> maybe this patch got forgotten after the lunch break? :D >> >> Cheers, > not really, but thanks for wastin

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-14 Thread John Crispin
On 14/01/2014 18:06, Antonio Quartulli wrote: > On 13/01/14 11:26, John Crispin wrote: >> i will pull this patch into the tree after lunch. >> > maybe this patch got forgotten after the lunch break? :D > > Cheers, not really, but thanks for wasting time with this mail _

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-14 Thread Antonio Quartulli
On 13/01/14 11:26, John Crispin wrote: > > i will pull this patch into the tree after lunch. > maybe this patch got forgotten after the lunch break? :D Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature ___ openwrt

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread Antonio Quartulli
On 13/01/14 12:57, Bluse wrote: > Hi all, > > 3 days ago I also sent a patch to fix a bug in netifd, where the uci > mcast_rate setting is not properly used anymore. > See attched email I have sent to the list. > I am not sure if Antonios patch covers the same here ? Hi Bluse, I saw your patch.

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread Bluse
Hi all, 3 days ago I also sent a patch to fix a bug in netifd, where the uci mcast_rate setting is not properly used anymore. See attched email I have sent to the list. I am not sure if Antonios patch covers the same here ? Greetings Thomas This patch fixes a bug in /lib/netifd/wireless/mac8021

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread Antonio Quartulli
On 13/01/14 11:26, John Crispin wrote: > Hi, > > ok, a prime example of why the description should state the bug that > was fixed and not leave it as a readers exercise :) you got a point here! :) > > i will pull this patch into the tree after lunch. > Thanks! Cheers, -- Antonio Quartulli

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread John Crispin
Am 1/13/14 10:59 AM, schrieb Antonio Quartulli: > On 13/01/14 10:48, John Crispin wrote: >> Hi, >> >> looking at the code i wonder if this is a actual bug fix or just >> a cleanup ?! >> >> does the code behave different before and after the patch ? > > It's a bug fix (this is why we have the Int

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread Antonio Quartulli
On 13/01/14 10:59, Antonio Quartulli wrote: > $mcast_rate contains the raw value (i.e. 11), while wpa_supplicant of course I meant 11000 here (11Mbps). Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature ___ openwr

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread Antonio Quartulli
On 13/01/14 10:48, John Crispin wrote: > Hi, > > looking at the code i wonder if this is a actual bug fix or just a > cleanup ?! > > does the code behave different before and after the patch ? It's a bug fix (this is why we have the Introduced-by clause and I explicitly said "fix" in the subject

Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread John Crispin
Hi, looking at the code i wonder if this is a actual bug fix or just a cleanup ?! does the code behave different before and after the patch ? John On 13/01/14 10:45, Antonio Quartulli wrote: Introduced by ("netifd: add wireless configuration support and port mac80211 to the new fra

[OpenWrt-Devel] [PATCH] wpa_supplicant: fix mcast_rate setting

2014-01-13 Thread Antonio Quartulli
Introduced by ("netifd: add wireless configuration support and port mac80211 to the new framework") Reported-by: René van Weert Signed-off-by: Antonio Quartulli --- package/network/services/hostapd/files/netifd.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/netwo