Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services

2024-02-16 Thread Jo-Philipp Wich
Hi Rafał, Extend sysupgrade to check for disabled services, generate uci-defaults script disabling them and include it in backup. Cc: Christian Marangi Cc: Jo-Philipp Wich Cc: Jonas Gorski Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich

Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services

2024-02-15 Thread Rafał Miłecki
On 15.02.2024 18:46, Paul D wrote: On 2024-02-15 15:42, Rafał Miłecki wrote: On 14.02.2024 21:50, Paul D wrote: Would services not do better to be tracked within uci and its config files in /etc/config? Well, it's a part of a mess we have in our init/config code. It was only last week that

Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services

2024-02-15 Thread Paul D
On 2024-02-15 15:42, Rafał Miłecki wrote: On 14.02.2024 21:50, Paul D wrote: Would services not do better to be tracked within uci and its config files in /etc/config? Well, it's a part of a mess we have in our init/config code. It was only last week that Jo was discussing it with Ansuel. In

Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services

2024-02-15 Thread Eric via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- On Thursday, February 15th, 2024

Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services

2024-02-15 Thread Rafał Miłecki
On 14.02.2024 21:50, Paul D wrote: Would services not do better to be tracked within uci and its config files in /etc/config? Well, it's a part of a mess we have in our init/config code. It was only last week that Jo was discussing it with Ansuel. In short we have: 1. Packages with no UCI

Re: [PATCH] base-files: sysupgrade: include uci-defaults script disabling services

2024-02-14 Thread Paul D
(Not directly commenting on this change set) Would services not do better to be tracked within uci and its config files in /etc/config? Or do changes to those files there risk triggering other procd actions to the services they dictate? On 2024-02-14 16:05, Rafał Miłecki wrote: From:

[PATCH] base-files: sysupgrade: include uci-defaults script disabling services

2024-02-14 Thread Rafał Miłecki
From: Rafał Miłecki Disabled services should be kept disabled after sysupgrade. This can be easily handled using a proper uci-defaults script. Extend sysupgrade to check for disabled services, generate uci-defaults script disabling them and include it in backup. Cc: Christian Marangi Cc: