Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Birger Koblitz writes: > On 15.03.22 15:10, Bjørn Mork wrote: >> Bjørn Mork writes: >> >>> Just drop the unnecssary I2C_SMBUS dependency. AFAICS, you're only >>> using i2c_smbus_xfer() which is part of the i2c core. > The reason for the ifdefs were mdio_smbus_alloc(). I still can't see

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Hi Bjørn, On 15.03.22 15:10, Bjørn Mork wrote: > Bjørn Mork writes: > >> Just drop the unnecssary I2C_SMBUS dependency. AFAICS, you're only >> using i2c_smbus_xfer() which is part of the i2c core. The reason for the ifdefs were mdio_smbus_alloc(). > > Looking further at this, I believe there

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Bjørn Mork writes: > Just drop the unnecssary I2C_SMBUS dependency. AFAICS, you're only > using i2c_smbus_xfer() which is part of the i2c core. Looking further at this, I believe there are good reasons to simply merge the mdio-smbus implementation into mdio-i2c: You seem to have lost some

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Birger Koblitz writes: > Well, we can of course always compile SMBus support in, i.e. make CONFIG_SFP > depend on CONFIG_MDIO_SMBUS, > this is already done for the I2C equivalent and this is where we started: > config SFP > tristate "SFP cage support" > depends on I2C && PHYLINK

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Hi, On 15.03.22 13:32, Bjørn Mork wrote: > Birger Koblitz writes: > Yuck! > > Why the heck can't this be made generic, auto-configured by DTS props > and upstreamed? There is a reason for this, you know: > > bjorn@miraculix:/usr/local/src/git/linux$ git grep -E '^#ifdef' >

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Birger Koblitz writes: > --- > a/target/linux/realtek/patches-5.10/712-net-phy-sfp-add-support-for-SMBus.patch > +++ > b/target/linux/realtek/patches-5.10/712-net-phy-sfp-add-support-for-SMBus.patch > @@ -10,10 +10,11 @@ Signed-off-by: Antoine Tenart > > --- a/drivers/net/phy/sfp.c > +++

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Hi, On 14.03.22 23:53, Hauke Mehrtens wrote: > On 3/14/22 06:56, Birger Koblitz wrote: >> Hi, >> >> CONFIG_SFP should only depend on CONFIG_MDIO_SMBUS on the RTL93xx platforms. >> This is because only on those platforms there is hardware support for an >> SMBus >> controller which is used for

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

On 3/14/22 06:56, Birger Koblitz wrote: Hi, CONFIG_SFP should only depend on CONFIG_MDIO_SMBUS on the RTL93xx platforms. This is because only on those platforms there is hardware support for an SMBus controller which is used for the MDIO of the SFP ports. If we had known about the worning, then

Re: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Hi, CONFIG_SFP should only depend on CONFIG_MDIO_SMBUS on the RTL93xx platforms. This is because only on those platforms there is hardware support for an SMBus controller which is used for the MDIO of the SFP ports. If we had known about the worning, then we would have tried to fix it by making

[PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

CONFIG_SFP depends on CONFIG_MDIO_SMBUS now and this depends on CONFIG_I2C_SMBUS. Activate the missing kernel compile options. This fixes the following warning: WARNING: unmet direct dependencies detected for MDIO_SMBUS Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] &&