Re: [PATCH] realtek: correct egress frame port verification

2022-06-19 Thread Sander Vanheule
Hi Birger, On Sun, 2022-06-19 at 11:40 +0200, Birger Koblitz wrote: > Hi, > > On 19.06.22 10:56, Sander Vanheule wrote: > > > -   h->cpu_tag[1] = h->cpu_tag[2] = 0; > > -   if (prio >= 0) > > -   h->cpu_tag[2] = BIT(13) | prio << 8; // Enable and set > > Priority Queue > > +

Re: [PATCH] realtek: correct egress frame port verification

2022-06-19 Thread Arinc UNAL (Xeront) via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- On 19.06.2022 11:56, Sander Vanheu

Re: [PATCH] realtek: correct egress frame port verification

2022-06-19 Thread Birger Koblitz
Hi, On 19.06.22 10:56, Sander Vanheule wrote: > - h->cpu_tag[1] = h->cpu_tag[2] = 0; > - if (prio >= 0) > - h->cpu_tag[2] = BIT(13) | prio << 8; // Enable and set Priority > Queue > + h->cpu_tag[1] = 0; > + /* Enable (AS_QID) and set Priority Queue (QID) */ > + h-

[PATCH] realtek: correct egress frame port verification

2022-06-19 Thread Sander Vanheule
Destination switch ports for outgoing frame can range from 0 to CPU_PORT-1, and frame priorities should also always be positive. Refactor the code to only generate egress frame CPU headers when the a valid destination port number is available, and make the code a bit more consistent between differ