RE: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-19 Thread Adrian Schmutzler
> -Original Message- > From: Rafał Miłecki [mailto:ra...@milecki.pl] > Sent: Dienstag, 19. Januar 2021 19:09 > To: Adrian Schmutzler > Cc: 'Rafał Miłecki' ; openwrt-devel@lists.openwrt.org; > nolt...@gmail.com > Subject: Re: [PATCH 2/2] bcm4908: buil

Re: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-19 Thread Rafał Miłecki
On 2021-01-19 12:32, Adrian Schmutzler wrote: > cp $(KDIR)/bcm63xx-cfe/$(subst _,$(comma),$(DEVICE_NAME))/cferam.000 > $@-bootfs/ > > This will remove the additional variable by simply making the current > soft rule to have matching device definition name and compatible a > hard one. Are you sti

RE: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-19 Thread Adrian Schmutzler
t.org > Subject: Re: [PATCH 2/2] bcm4908: build flashable & bootable firmware > images > > On 2021-01-18 12:29, Adrian Schmutzler wrote: > >> Do you mean "files" as "directories" (I know every dir is a file ;) )? > >> If you talk > >> ab

RE: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-19 Thread Adrian Schmutzler
> > cp $(KDIR)/bcm63xx-cfe/$(subst > _,$(comma),$(DEVICE_NAME))/cferam.000 > > $@-bootfs/ > > > > This will remove the additional variable by simply making the current > > soft rule to have matching device definition name and compatible a > > hard one. > > Are you still planning on adding generic

Re: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-18 Thread Rafał Miłecki
On 2021-01-18 12:50, Adrian Schmutzler wrote: > Note that if you do apply these two "changes", you get rid of the > COMPATIBLE variable at all for the proposed patch, and this is > probably the reason why a variable like this is not needed for "build > steps" in the other targets (at least those

RE: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-18 Thread Adrian Schmutzler
> > Note that if you do apply these two "changes", you get rid of the > > COMPATIBLE variable at all for the proposed patch, and this is > > probably the reason why a variable like this is not needed for "build > > steps" in the other targets (at least those I know closer by now), > > which simply

Re: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-18 Thread Rafał Miłecki
On 2021-01-18 12:29, Adrian Schmutzler wrote: Do you mean "files" as "directories" (I know every dir is a file ;) )? If you talk about "asus,gt-ac5300", it's used by the: cp -r $(COMPATIBLE)/* $@-bootfs/ line in the Build/bcm4908img. Ah, okay. Yes, I was referring to the directory names here.

RE: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-18 Thread Adrian Schmutzler
> Do you mean "files" as "directories" (I know every dir is a file ;) )? If you > talk > about "asus,gt-ac5300", it's used by the: > cp -r $(COMPATIBLE)/* $@-bootfs/ > line in the Build/bcm4908img. Ah, okay. Yes, I was referring to the directory names here. I personally consider a comma in a fil

Re: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-17 Thread Rafał Miłecki
On 15.01.2021 16:18, Adrian Schmutzler wrote: -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Rafal Milecki Sent: Freitag, 15. Januar 2021 10:44 To: openwrt-devel@lists.openwrt.org Cc: Rafał Miłecki Subject: [PATCH 2/2] bcm4908: build

RE: [PATCH 2/2] bcm4908: build flashable & bootable firmware images

2021-01-15 Thread Adrian Schmutzler
Hi, some format nitpicking again and some other comments below: > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Rafal Milecki > Sent: Freitag, 15. Januar 2021 10:44 > To: openwrt-devel@lists.openwrt.org > Cc: Rafał Miłecki > Subj