Re: [PATCH] x86 64: Add new device Cordoba Edge Platform

2023-11-04 Thread Philip Prindeville
lip Prindeville > Sent: Saturday, October 28, 2023 11:09 AM > To: Xiaojun Liu > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [PATCH] x86 64: Add new device Cordoba Edge Platform > > LGTM > > >> On Oct 23, 2023, at 8:52 PM, Xiaojun Liu wrote: >> >>

Re: [PATCH] x86 64: Add new device Cordoba Edge Platform

2023-11-04 Thread Philip Prindeville
> On Oct 30, 2023, at 11:17 AM, Paul Spooren wrote: > > Hi, > > We kind of don’t add image just to contain extra drivers. Extra UCI defaults > for eth ordering are fine but please don’t add an extra image if it just > contains 1-2 extra packages, installable via the ImageBuilder or OPKG. >

RE: [PATCH] x86 64: Add new device Cordoba Edge Platform

2023-10-31 Thread Xiaojun Liu
Hi, Thank you for your guide! I will resubmit it. -Original Message- From: Paul Spooren Sent: Tuesday, October 31, 2023 1:18 AM To: Xiaojun Liu Cc: Philip Prindeville ; openwrt-devel Subject: Re: [PATCH] x86 64: Add new device Cordoba Edge Platform Hi, We kind of don’t add image

Re: [PATCH] x86 64: Add new device Cordoba Edge Platform

2023-10-30 Thread Paul Spooren
Hi, We kind of don’t add image just to contain extra drivers. Extra UCI defaults for eth ordering are fine but please don’t add an extra image if it just contains 1-2 extra packages, installable via the ImageBuilder or OPKG. > >> On Oct 23, 2023, at 8:52 PM, Xiaojun Liu wrote: >> >> Add new

RE: [PATCH] x86 64: Add new device Cordoba Edge Platform

2023-10-29 Thread Xiaojun Liu
Hi Philip, Thank you! Do you know when it will be merged to Openwrt main thread ? -Original Message- From: Philip Prindeville Sent: Saturday, October 28, 2023 11:09 AM To: Xiaojun Liu Cc: openwrt-devel@lists.openwrt.org Subject: Re: [PATCH] x86 64: Add new device Cordoba Edge Platform

Re: [PATCH] x86 64: Add new device Cordoba Edge Platform

2023-10-27 Thread Philip Prindeville
LGTM > On Oct 23, 2023, at 8:52 PM, Xiaojun Liu wrote: > > Add new device Cordoba Edge Platform > Device name:Cordoba Edge Platform > hardware specifications: CPU - Intel Atom C3000 > WiFi - mt7915e > > Signed-off-by: Xiaojun Liu mailto:xiaojun@silicom.co.il >