Thanks Achim!
regards
Grzegorz
2017-11-26 19:59 GMT+01:00 'Achim Nierbeck' via OPS4J <
ops4j@googlegroups.com>:
> Some more updates regarding the tests.
> We finally have all current version 6.0.x, 6.1.x and master successfully
> build on Jenkins \o/
> I'll try to fix the cirlce-ci build also, s
Some more updates regarding the tests.
We finally have all current version 6.0.x, 6.1.x and master successfully
build on Jenkins \o/
I'll try to fix the cirlce-ci build also, so we have a better automatic
testing for the Pull-Requests.
regards, Achim
2017-11-25 18:28 GMT+01:00 Achim Nierbeck :
>
Ok guys,
I've been working on fixing those issues.
First of all I made sure the doclint-java8-disable profile is always
enabled.
It turned out, due to this the rat profile wasn't working either ...
Second thing I'm trying to fix now is the failing jetty handler test.
it seems to have been introdu
right now the master branch fails on circle ci cause the junit dependencies
itself seem to be missing :/
2017-11-22 13:09 GMT+01:00 Grzegorz Grzybek :
>
>
> 2017-11-22 12:18 GMT+01:00 'Achim Nierbeck' via OPS4J <
> ops4j@googlegroups.com>:
>
>> Yes and no :)
>>
>> if you work on a jetty related
2017-11-22 12:18 GMT+01:00 'Achim Nierbeck' via OPS4J <
ops4j@googlegroups.com>:
> Yes and no :)
>
> if you work on a jetty related bug and just want to make sure your build
> cycle is fast, those profiles are a nice to have.
> for circle-ci I just enabled those profiles as we have them for the
>
Yes and no :)
if you work on a jetty related bug and just want to make sure your build
cycle is fast, those profiles are a nice to have.
for circle-ci I just enabled those profiles as we have them for the jenkins
build.
regards, Achim
2017-11-22 11:45 GMT+01:00 Grzegorz Grzybek :
> Hello
>
> I
Hello
IMO, we don't need special tomcat/jetty/undertow profiles at all... But
that's my suggestion - I always built them all.
regards
Grzegorz Grzybek
2017-11-22 11:28 GMT+01:00 Stephan Siano :
> Hi,
>
> OK, that explains it. If ANY profile is active, the profiles which are
> activeByDefault ar
Hi,
OK, that explains it. If ANY profile is active, the profiles which are
activeByDefault are not active. Your change enables the doclint-java-8
profile if the build is running on JDK 8 or later (so always...).
@Achim: The problem is not that the containers are not tested, but that
they are n
Hello, I can answer to:
Why are these profiles there at all? Wouldn't it be easier to remove all
> these profiles and build all containers by default?
>
The problem is with Maven itself. After I introduced:
doclint-java8-disable
[1.8,)
-Xdoclint:none
Ma
Hi Stephan,
I'm not sure I follow on the profiles, but all containers should be tested
if no profiles are selected. The profiles are were intended to make life
easier when only working on one container.
Regarding Travis CI I played around with it on the weekend, and looks like
I forgot to cherry p
Hi,
I have a few (not really related) questions concerning pax-web:
1. There are separate profiles for building tomcat, jetty, and undertow
support. At least when I do the builds locally none of these profiles is
activated by default. The workaround for my local build is to use the
-Prelease p
11 matches
Mail list logo
