Re: [PATCH] memory: respect _bitset length bounds in page_range_allocator

So, it is possible to reproduce the issue with a unit test, however it requires specifying an explicit memory size to the run script. The issue only occurs when the bitset size is an exact multiple of mmu::huge_page_size. In that case, the first mmap that is greater than or equal to mmu::huge_

Re: golang-example fails with general protection or page fault

Yep I will try to follow your advice about the "least resistance" order. I could not find anything about " TLS-related" or "the order of when the TLS variables were allocated or initialized" related patches. Is it maybe here - https://groups.google.com/forum/#!searchin/osv-dev/Golang$20and$20TL

Re: [PATCH] linux: arch_prctl() system call

Anybody has an idea if this patch is still relevant? None of the golang tests I have conducted exposed any issues possibly related to lack of arch_prctl SYSCALL. On Wednesday, August 31, 2016 at 11:22:37 AM UTC-4, Nadav Har'El wrote: > > > On Wed, Aug 31, 2016 at 4:04 PM, Benoit Canet > wrote:

Re: [PATCH] Added number of syscalls to support golang

I forgot about mentioning Benoit. Shall I add "Signed by" him line or mention that he is the author of most changes? I am not sure about sys_ioctl - I simply copied it from Benoit's branch. I will look into it. Please see my other comments below. I will submit new patch without pselect to make it

Re: [PATCH] memory: respect _bitset length bounds in page_range_allocator

I don’t know. I could only ever reproduce it on 1 CPU setups on a specific hypervisor. I’ll investigate reproducing it via a unit test. Timmons From: OSv Gopher on behalf of Waldek Kozaczuk Date: Monday, January 15, 2018 at 2:19 PM To: OSv Gopher Subject: Re: [PATCH] memory: respect _bits

Re: [PATCH] memory: respect _bitset length bounds in page_range_allocator

How difficult would it be to create a unit test around this bug to prove what it fixes? On Monday, January 15, 2018 at 12:52:24 PM UTC-5, Timmons C. Player wrote: > > The page_range_allocator attempts to merge neighbor page ranges > when a page range is freed in order to minimize memory fragment

[PATCH] memory: respect _bitset length bounds in page_range_allocator

The page_range_allocator attempts to merge neighbor page ranges when a page range is freed in order to minimize memory fragmentation. However, the original implementation didn't validate indexes before checking the _bitset to determine whether a page range had a neighbor or not. This change make

Re: [PATCH] memory: fix off by 1 error in page_range_allocator

Also… I don’t understand the finer details of this code either. After thinking about it, I think this patch is in error. A corrected fix is forthcoming… Timmons From: OSv Gopher on behalf of Timmons Player Date: Monday, January 15, 2018 at 8:51 AM To: Nadav Har'El , Paweł Dziepak Cc: OSv

Re: [PATCH] fix kafka mirror url (error 404)

Hello Nadav/All, Indeed, I'm also facing the same issue and I think the problem is this: [2018-01-15 14:27:27,398] INFO Opening socket connection to server *localhost/127.0.0.1:2181 *. Will not attempt to authenticate using SASL (unknown error) (org.apache.zookeeper.ClientC

Re: [PATCH] memory: fix off by 1 error in page_range_allocator

I found a scenario that would reliably mmap anonymous memory from a page range at the end of the bitmap. When the memory was munmap-ed , the index calculated on the patched line exceeded the size of _bitmap by 1. Interestingly, I could only reproduce this on 1 CPU instances (in EC2, no less) an

[COMMIT osv-apps master] fix activemq mirror url (error 404)

From: geraldo netto Committer: Nadav Har'El Branch: master fix activemq mirror url (error 404) Signed-off-by: geraldo netto Message-Id: <1515724041-3645-1-git-send-email-geraldone...@gmail.com> --- diff --git a/apache-activemq/Makefile b/apache-activemq/Makefile --- a/apache-activemq/Makefil

Re: [PATCH] fix kafka mirror url (error 404)

Thanks. I committed this (and going through your other patches as well). However, if I do scripts/build image=apache-kafka scripts/run.py I get all sorts of connection refused errors, and messages like org.I0Itec.zkclient.exception.ZkTimeoutException: Unable to connect to zookeeper server within

[COMMIT osv-apps master] fix kafka mirror url (error 404)

From: geraldo netto Committer: Nadav Har'El Branch: master fix kafka mirror url (error 404) Signed-off-by: geraldo netto Message-Id: <1515724275-3769-1-git-send-email-geraldone...@gmail.com> --- diff --git a/apache-kafka/Makefile b/apache-kafka/Makefile --- a/apache-kafka/Makefile +++ b/apac

[COMMIT osv-apps master] fix zookeeper mirror url (error 404)

From: geraldo netto Committer: Nadav Har'El Branch: master fix zookeeper mirror url (error 404) Signed-off-by: geraldo netto Message-Id: <1515725047-9836-1-git-send-email-geraldone...@gmail.com> --- diff --git a/apache-zookeeper/Makefile b/apache-zookeeper/Makefile --- a/apache-zookeeper/Mak

[COMMIT osv-apps master] fix jruby url

From: geraldo netto Committer: Nadav Har'El Branch: master fix jruby url Signed-off-by: geraldo netto Message-Id: <1515729142-1887-2-git-send-email-geraldone...@gmail.com> --- diff --git a/jruby-sinatra-example/GET b/jruby-sinatra-example/GET --- a/jruby-sinatra-example/GET +++ b/jruby-sinat

[COMMIT osv-apps master] update jruby version from 9.0.0.0 to 9.1.15.0

From: geraldo netto Committer: Nadav Har'El Branch: master update jruby version from 9.0.0.0 to 9.1.15.0 Signed-off-by: geraldo netto Message-Id: <1515729142-1887-3-git-send-email-geraldone...@gmail.com> --- diff --git a/jruby-sinatra-example/GET b/jruby-sinatra-example/GET --- a/jruby-sinat

Re: golang-example fails with general protection or page fault

On Mon, Jan 15, 2018 at 6:35 AM, Waldek Kozaczuk wrote: > I think I have gotten to the point where Go work reasonably well on OSv so > I will be sending the patches. Here is the order of the patches and how I > am planning to break them down: > >- Add missing SYSCALLs to linux.cc >- SYSCA

Re: [PATCH] Added number of syscalls to support golang

On Mon, Jan 15, 2018 at 11:02 AM, Nadav Har'El wrote: > > > + >> +static int pselect6(int nfds, fd_set *readfds, fd_set *writefds, >> + fd_set *exceptfds, const struct timespec *timeout_ts, >> + void *sig) >> +{ >> +const sigset_t *sigmask = NULL; >> +i

Re: [PATCH] Added number of syscalls to support golang

On Mon, Jan 15, 2018 at 7:55 AM, Waldemar Kozaczuk wrote: > This patch adds number of syscalls to that are needed to make Golang > apps run on OSv. > Is this based on Benoit's earlier patches or your new additions? If it's based on Benoit's patch please mention him in the commit message as well.