Re: [PATCH] Added number of syscalls to support golang

2018-01-17 Thread Nadav Har'El
On Wed, Jan 17, 2018 at 6:59 AM, Waldek Kozaczuk wrote: > The sys_ioctl was probably added to conform with Linux implementation - > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/ > linux.git/tree/fs/ioctl.c. And ioctl function is variadic. > I still don't understand why any of this ma

Re: [PATCH] Added number of syscalls to support golang

2018-01-16 Thread Waldek Kozaczuk
The sys_ioctl was probably added to conform with Linux implementation -https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ioctl.c. And ioctl function is variadic. On Tuesday, January 16, 2018 at 5:19:24 AM UTC-5, Nadav Har'El wrote: > > > On Mon, Jan 15, 2018 at 10:22 P

Re: [PATCH] Added number of syscalls to support golang

2018-01-16 Thread Nadav Har'El
On Mon, Jan 15, 2018 at 10:22 PM, Waldek Kozaczuk wrote: > I forgot about mentioning Benoit. Shall I add "Signed by" him line or > mention that he is the author of most changes? > I'm not sure "signed-off-by" is supposed to indicates authorship. You can perhaps just add a textual line (or, Benoi

Re: [PATCH] Added number of syscalls to support golang

2018-01-15 Thread Waldek Kozaczuk
I forgot about mentioning Benoit. Shall I add "Signed by" him line or mention that he is the author of most changes? I am not sure about sys_ioctl - I simply copied it from Benoit's branch. I will look into it. Please see my other comments below. I will submit new patch without pselect to make it

Re: [PATCH] Added number of syscalls to support golang

2018-01-15 Thread Nadav Har'El
On Mon, Jan 15, 2018 at 11:02 AM, Nadav Har'El wrote: > > > + >> +static int pselect6(int nfds, fd_set *readfds, fd_set *writefds, >> + fd_set *exceptfds, const struct timespec *timeout_ts, >> + void *sig) >> +{ >> +const sigset_t *sigmask = NULL; >> +i

Re: [PATCH] Added number of syscalls to support golang

2018-01-15 Thread Nadav Har'El
On Mon, Jan 15, 2018 at 7:55 AM, Waldemar Kozaczuk wrote: > This patch adds number of syscalls to that are needed to make Golang > apps run on OSv. > Is this based on Benoit's earlier patches or your new additions? If it's based on Benoit's patch please mention him in the commit message as well.

[PATCH] Added number of syscalls to support golang

2018-01-14 Thread Waldemar Kozaczuk
This patch adds number of syscalls to that are needed to make Golang apps run on OSv. Signed-off-by: Waldemar Kozaczuk --- linux.cc | 54 ++ 1 file changed, 54 insertions(+) diff --git a/linux.cc b/linux.cc index d8ed544..cfb0a0e 100644 --- a