Re: [ovs-dev] [PATCH] documentation: Windows support multiple VTEP/NICs

2017-01-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 1/26/17, 6:30 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Multiple VTEP and multiple physical NICs are supported on Hyper-V now. >Update the documentation > >Signed-off-by: Alin Gabriel Serdean >--- >Intended for master and branch-

[ovs-dev] [PATCH v2] Windows: Fix wmi.c to use count of wchar_t instead of sizeof

2017-01-26 Thread Sairam Venugopal
wcscat_s and wcscpy_s requires number of elements as argument. wchar_t uses 2 bytes for storage and using sizeof(internal_port_query) causes access violation error on Windows 2012 R2 (64 bit). This patch introduces a #define WMI_QUERY_COUNT set to 2048 and uses that instead. Signed-off-by: Sairam

Re: [ovs-dev] [PATCH] windows: WSAPoll broken on windows

2017-01-26 Thread Sairam Venugopal
Thanks for the patch. Acked-by: Sairam Venugopal On 12/15/16, 6:50 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Unfortunately, WSAPoll misbehaves on Windows please view detailed behavior >on: >https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_o

Re: [ovs-dev] [PATCH] Windows: Fix wmi.c to use count of wchar_t instead of sizeof

2017-01-26 Thread Sairam Venugopal
Yes, my initial thought was to define 2048 and re-use it. I added in the define in case we use something other than 2048 in the future. I am okay with either one of the approaches. I can send out a new patch with - #define WMI_QUERY_ARRAY_SIZE set to 2048. We can do an incremental for checking

[ovs-dev] [PATCH 3/3] tests: rstp close input file

2017-01-26 Thread Alin Serdean
Close the 'input_file' after data is read. Signed-off-by: Alin Gabriel Serdean --- tests/test-rstp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-rstp.c b/tests/test-rstp.c index 2ee8c7e..7bcff83 100644 --- a/tests/test-rstp.c +++ b/tests/test-rstp.c @@ -691,6 +691,7 @@ test_rs

[ovs-dev] [PATCH 2/3] tests dpdk: ring_client, client_id is unsigned

2017-01-26 Thread Alin Serdean
'client_id' is of type unsigned int. Change the printf specifier to match it. Signed-off-by: Alin Gabriel Serdean --- tests/dpdk/ring_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/dpdk/ring_client.c b/tests/dpdk/ring_client.c index 8a43c64..b153713 100644 ---

[ovs-dev] [PATCH 1/3] ovn-trace: Possible null dereference

2017-01-26 Thread Alin Serdean
Found by inspection. Signed-off-by: Alin Gabriel Serdean --- ovn/utilities/ovn-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 307556b..2e2859a 100644 --- a/ovn/utilities/ovn-trace.c +++ b/ovn/utilities/ovn-t

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-26 Thread Alin Serdean
> -Original Message- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Friday, January 27, 2017 8:01 AM > To: Alin Serdean ; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] windows: wmi add include > > Hi Alin, > > I investigated the issue and have sent out a patch for

Re: [ovs-dev] [PATCH] Windows: Fix wmi.c to use count of wchar_t instead of sizeof

2017-01-26 Thread Alin Serdean
Thanks for catching this! It slipped my mind when I wrote the code. Mind adding a define for the number of element instead and passing that in? i.e. #define WMI_QUERY 2048 wchar_t internal_port_query[WMI_QUERY] = L"SELECT * from " L"Msvm_EthernetPortAllocationSettingData WHERE Elemen

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 1/26/17, 2:15 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Add 'util.h' to includes otherwise the definition of the function >ovs_format_message will be unknown and an abort with the following stacktrace >will be triggered: >*1

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-26 Thread Sairam Venugopal
Hi Alin, I investigated the issue and have sent out a patch for this - https://patchwork.ozlabs.org/patch/720476/ This is the associated stack trace: https://github.com/openvswitch/ovs-issues/issues/121 I will ack this change. Thanks, Sairam On 1/26/17, 4:47 PM, "Alin Serdean" wrote: >

[ovs-dev] [PATCH] Windows: Fix wmi.c to use count of wchar_t instead of sizeof

2017-01-26 Thread Sairam Venugopal
wcscat_s and wcscpy_s requires number of elements as argument. wchar_t uses 2 bytes for storage and using sizeof(internal_port_query) causes access violation error on Windows 2012 R2 (64 bit). This patch introduces a count_of() function to return the count of the wchar_t array. Signed-off-by: Sair

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

2017-01-26 Thread Daniele Di Proietto
On 26/01/2017 12:35, "Ansis Atteka" wrote: > > >On 26 January 2017 at 21:24, Aaron Conole > wrote: > >Daniele Di Proietto writes: > >> On 25/01/2017 00:01, "Ansis Atteka" wrote: >> >>>On Jan 25, 2017 4:22 AM, "Daniele Di Proietto" >>>wrote: >>> >>>Current SELinux policy in RHEL and Fedo

Re: [ovs-dev] [userspace meter v3 3/5] dpif: Meter framework.

2017-01-26 Thread Jarno Rajahalme
It feels weird reviewing my own code from past. What if I make a pass of fixing the problems I see and send a new version of the remaining patches for review? Jarno > On Jan 24, 2017, at 10:45 PM, Andy Zhou wrote: > > From: Jarno Rajahalme > > Add DPIF-level infrastructure for meters. All

[ovs-dev] [PATCH] documentation: Windows support multiple VTEP/NICs

2017-01-26 Thread Alin Serdean
Multiple VTEP and multiple physical NICs are supported on Hyper-V now. Update the documentation Signed-off-by: Alin Gabriel Serdean --- Intended for master and branch-2.7 --- Documentation/faq/releases.rst | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Documentation/

Re: [ovs-dev] [PATCH 4/6] datapath-windows: VXLAN Check for flow destination port

2017-01-26 Thread Alin Serdean
We shouldn't if you look at the userspace code it is set as BE: https://github.com/openvswitch/ovs/blob/bef503e8c094456ca82fefd044a8c3341d9d21ac/lib/odp-util.c#L2038 I also checked/rechecked with the debugger. Here is a snippet of debugging with the patchset applied: OvsDoEncapVxlan 2: kd> ??tun

Re: [ovs-dev] [userspace meter v3 2/5] dp-packet: Enhance packet batch APIs.

2017-01-26 Thread Andy Zhou
On Wed, Jan 25, 2017 at 4:50 PM, Jarno Rajahalme wrote: > Trusting you address the comments below: > > Acked-by: Jarno Rajahalme > Thanks for the review. Pushed with fixes. > > > > On Jan 24, 2017, at 10:45 PM, Andy Zhou wrote: > > > > One common use case of 'struct dp_packet_batch' is to pro

[ovs-dev] [PATCH v14 6/6] ovn: specify options:nat-addresses as "router"

2017-01-26 Thread Mickey Spiegel
Currently in OVN, the "nat-addresses" in the "options" column of a logical switch port of type "router" must be specified manually. Typically the user would specify as "nat-addresses" all of the NAT external IP addresses and load balancer IP addresses that have already been specified separately on

[ovs-dev] [PATCH v14 3/6] ovn: distributed NAT flows

2017-01-26 Thread Mickey Spiegel
This patch implements the flows required in the ingress and egress pipeline stages in order to support NAT on a distributed logical router. NAT functionality is associated with the logical router gateway port. The flows that carry out NAT functionality all have match conditions on inport or outpor

[ovs-dev] [PATCH v14 5/6] ovn: rewrite redirect-chassis description in ovn-nb.xml

2017-01-26 Thread Mickey Spiegel
This optional patch addresses offline comments that the documentation in ovn-nb.xml should not describe southbound constructs or flow details, since it is user facing documentation. Signed-off-by: Mickey Spiegel Acked-by: Gurucharan Shetty --- ovn/ovn-nb.xml | 36 ++-

[ovs-dev] [PATCH v14 4/6] ovn: ovn-nbctl commands for distributed NAT

2017-01-26 Thread Mickey Spiegel
This patch adds the new optional arguments "logical_port" and "external_mac" to lr-nat-add, and displays that information in lr-nat-list. Signed-off-by: Mickey Spiegel Acked-by: Gurucharan Shetty --- ovn/utilities/ovn-nbctl.8.xml | 27 +++--- ovn/utilities/ovn-nbctl.c | 54 +

[ovs-dev] [PATCH v14 2/6] ovn: avoid snat recirc only on gateway routers

2017-01-26 Thread Mickey Spiegel
Currently, for performance reasons on gateway routers, ct_snat that does not specify an IP address does not immediately trigger recirculation. On gateway routers, ct_snat that does not specify an IP address happens in the UNSNAT pipeline stage, which is followed by the DNAT pipeline stage that tri

[ovs-dev] [PATCH v14 1/6] ovn: move load balancing flows after NAT flows

2017-01-26 Thread Mickey Spiegel
This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel Acked-by: Gurucharan Shet

[ovs-dev] [PATCH v14 0/6] ovn: add distributed NAT capability

2017-01-26 Thread Mickey Spiegel
PATCH v13 -> PATCH v14 Rebase. In patch 5 (rewrite redirect-chassis description in ovn-nb.xml), emphasized the need to set the peer logical switch port's "addresses" column to the string "router". Added a little more detail explaining what this does. Currently OVN supports NAT functionality by c

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-26 Thread Alin Serdean
Answer inline. Thanks, Alin. > -Original Message- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Friday, January 27, 2017 2:36 AM > To: Alin Serdean ; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] windows: wmi add include > > Hi Alin, > > Does this fix the access

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-26 Thread Sairam Venugopal
Hi Alin, Does this fix the access violation error in wcscat_s inside create_wmi_port()? I ran into this issue when creating a bridge previously. I will apply this patch and re-test. Thanks, Sairam On 1/26/17, 2:15 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Ad

[ovs-dev] [PATCH v2][branch-2.3] lacp: fix build failure with inline declaration

2017-01-26 Thread Shu Shen
Previous commit 336a5584 has a variable declared inline, while -Wdeclaration-after-statement flag is enabled on this branch. This causes build failure: lib/lacp.c:620:9: error: mixing declarations and code The declaration of the variable "enable" has been moved in this change to comply with th

[ovs-dev] [PATCH] lacp: fix build failure with inline declaration

2017-01-26 Thread Shu Shen
Previous commit 336a5584 has a variable declared inline, while -Wdeclaration-after-statement flag is enabled on this branch. This causes build failure: lib/lacp.c:620:9: error: mixing declarations and code The declaration of the variable "enable" has been moved in this change to comply with th

[ovs-dev] [PATCH v3 2/4] datapath-windows: Add function to get continuous buffer from context

2017-01-26 Thread Alin Serdean
From: Alin Serdean This patch extracts the code that tries to get a continuous IPv4 header buffer from the function 'OvsUpdateIPv4Header' and moves it to a new function 'OvsGetHeaderBySize'. The new function can be used later when trying to change the UDP/TCP/MPLS etc., headers. Signed-off-by:

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-26 Thread Alin Serdean
Forgot to add version number. Please ignore this patch. Alin. > -Original Message- > From: Alin Serdean > Sent: Friday, January 27, 2017 1:41 AM > To: d...@openvswitch.org > Cc: Alin Serdean > Subject: [PATCH 4/4] datapath-windows: Add support for > OVS_KEY_ATTR_TCP set action > > From

[ovs-dev] [PATCH v3 4/4] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-26 Thread Alin Serdean
From: Alin Serdean This patch adds support for set action with OVS_KEY_ATTR_TCP attribute (change TCP source or destination port). If the source or destination TCP port was changed, update the TCP checksum. A sample flow can look like the following: set(tcp(src=80,dst=443)) Signed-off-by: Alin

Re: [ovs-dev] [PATCH v3 2/4] datapath-windows: Add function to get continuous buffer from context

2017-01-26 Thread Alin Serdean
Forgot to add version number. Please ignore this patch. Alin. > -Original Message- > From: Alin Serdean > Sent: Friday, January 27, 2017 1:38 AM > To: d...@openvswitch.org > Cc: Alin Serdean > Subject: [PATCH v3 2/4] datapath-windows: Add function to get continuous > buffer from context

Re: [ovs-dev] [PATCH 3/4] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

2017-01-26 Thread Alin Serdean
Forgot to add version number. Please ignore this patch. Alin. > -Original Message- > From: Alin Serdean > Sent: Friday, January 27, 2017 1:40 AM > To: d...@openvswitch.org > Cc: Alin Serdean > Subject: [PATCH 3/4] datapath-windows: Add support for > OVS_KEY_ATTR_UDP set action > > From

[ovs-dev] [PATCH v3 3/4] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

2017-01-26 Thread Alin Serdean
From: Alin Serdean This patch adds support for set action with OVS_KEY_ATTR_UDP attribute (change UDP source or destination port). If the source or destination UDP port was changed, update the UDP checksum. A sample flow can look like the following: set(udp(src=67,dst=68)) Signed-off-by: Alin

[ovs-dev] [PATCH 4/4] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-26 Thread Alin Serdean
From: Alin Serdean This patch adds support for set action with OVS_KEY_ATTR_TCP attribute (change TCP source or destination port). If the source or destination TCP port was changed, update the TCP checksum. A sample flow can look like the following: set(tcp(src=80,dst=443)) Signed-off-by: Alin

[ovs-dev] [PATCH 3/4] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

2017-01-26 Thread Alin Serdean
From: Alin Serdean This patch adds support for set action with OVS_KEY_ATTR_UDP attribute (change UDP source or destination port). If the source or destination UDP port was changed, update the UDP checksum. A sample flow can look like the following: set(udp(src=67,dst=68)) Signed-off-by: Alin

[ovs-dev] [PATCH v3 2/4] datapath-windows: Add function to get continuous buffer from context

2017-01-26 Thread Alin Serdean
From: Alin Serdean This patch extracts the code that tries to get a continuous IPv4 header buffer from the function 'OvsUpdateIPv4Header' and moves it to a new function 'OvsGetHeaderBySize'. The new function can be used later when trying to change the UDP/TCP/MPLS etc., headers. Signed-off-by:

[ovs-dev] [PATCH v3 1/4] datapath-windows: OvsUpdateIPv4Header remove unnecessary addition

2017-01-26 Thread Alin Serdean
From: Alin Serdean bufferStart can be used directly to access the data of the net buffer. Add the MDL offset to save unnecessary additions. Signed-off-by: Alin Gabriel Serdean Acked-by: Sairam Venugopal --- v3: add acked v2: no change --- datapath-windows/ovsext/Actions.c | 8 1 file

Re: [ovs-dev] [userspace meter v3 1/5] netdev-dummy: Add --len option for netdev-dummy/receive command

2017-01-26 Thread Andy Zhou
On Wed, Jan 25, 2017 at 4:16 PM, Jarno Rajahalme wrote: > With two small nits below: > > Acked-by: Jarno Rajahalme > Thanks. > > > On Jan 24, 2017, at 10:45 PM, Andy Zhou wrote: > > > > Currently, there is no way to specify the packet size when injecting > > a packet via "netdev-dummy/receive

[ovs-dev] [PATCH v2] windows: Change driver and MSI company name to LF

2017-01-26 Thread Alin Serdean
From: Alin Serdean Until now we used 'Open vSwitch' as the company/organization name. The project is now under The Linux Foundation ownership. This patch updates the MSI and driver attributes to reflect that ownership. Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff Acked-by: Sairam

Re: [ovs-dev] [PATCH] lib: Remove generated ovs-fields.7 manpage on make clean.

2017-01-26 Thread Ben Pfaff
On Thu, Jan 26, 2017 at 02:36:41PM -0800, Joe Stringer wrote: > On 26 January 2017 at 11:28, Ben Pfaff wrote: > > Found by travis. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Joe Stringer Thanks, applied to master and branch-2.7. ___ dev mailing l

Re: [ovs-dev] [PATCH] lib: Remove generated ovs-fields.7 manpage on make clean.

2017-01-26 Thread Joe Stringer
On 26 January 2017 at 11:28, Ben Pfaff wrote: > Found by travis. > > Signed-off-by: Ben Pfaff Acked-by: Joe Stringer ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/1] dpif-netdev: Conditional EMC insert

2017-01-26 Thread Kevin Traynor
On 01/22/2017 09:07 PM, Jan Scheurich wrote: > Hi Kevin > >>> The performance results are very impressive - it looks like ~50% >>> performance improvement after about 10K flows. >>> >>> Did you measure any negative effects when the the emc is not full? >> Hi Kevin, >> >> When the EMC is not full t

[ovs-dev] [PATCH] windows: wmi add include

2017-01-26 Thread Alin Serdean
Add 'util.h' to includes otherwise the definition of the function ovs_format_message will be unknown and an abort with the following stacktrace will be triggered: *1 ovs-vswitchd.exe!_output_l(_iobuf * stream=0x00bb711dcbf0, const char * format=0x7ff6016a2c12, localeinfo_struct * plo

[ovs-dev] GLUCKWUNSCHE [ IHRE E-mail HAT GEWONNEN {REF NR , 575061725 } ] !! (Warnung: Endgültige Anmeldung): - Diese Transaktion ist 100% garantiert legitim..!

2017-01-26 Thread lukas-meyer
UNITED STATES OF AMERICA LOTTO INC. ADRESSE: OSTWESTLANDSTRASSE 1325 STADT: SILBERNER FRUHLING STATE/PROVINCE: MARYLAND POSTCODE: 20110 LAND: USA INC. REF NR: .575061725 STAPEL NR: .6485769789/646

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

2017-01-26 Thread Ansis Atteka
On 26 January 2017 at 04:03, Daniele Di Proietto wrote: > > > > > > On 25/01/2017 00:01, "Ansis Atteka" wrote: > > > > > > >On Jan 25, 2017 4:22 AM, "Daniele Di Proietto" > wrote: > > > >Current SELinux policy in RHEL and Fedora doesn't allow the creation of > >TAP devices. > > > >A tap device

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

2017-01-26 Thread Ansis Atteka
On 26 January 2017 at 21:24, Aaron Conole wrote: > Daniele Di Proietto writes: > > > On 25/01/2017 00:01, "Ansis Atteka" wrote: > > > >>On Jan 25, 2017 4:22 AM, "Daniele Di Proietto" > wrote: > >> > >>Current SELinux policy in RHEL and Fedora doesn't allow the creation of > >>TAP devices. > >>

[ovs-dev] [PATCH] python windows: Allow clients to read from server before disconnect

2017-01-26 Thread Alin Serdean
Wait for clients to read from the pipe before disconnecting the server. Signed-off-by: Alin Gabriel Serdean --- Intended for master and branch-2.7 --- python/ovs/stream.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/ovs/stream.py b/python/ovs/stream.py index 58c4925..be69534 10

[ovs-dev] [PATCH v13 6/6] ovn: specify options:nat-addresses as "router"

2017-01-26 Thread Mickey Spiegel
Currently in OVN, the "nat-addresses" in the "options" column of a logical switch port of type "router" must be specified manually. Typically the user would specify as "nat-addresses" all of the NAT external IP addresses and load balancer IP addresses that have already been specified separately on

[ovs-dev] [PATCH v13 3/6] ovn: distributed NAT flows

2017-01-26 Thread Mickey Spiegel
This patch implements the flows required in the ingress and egress pipeline stages in order to support NAT on a distributed logical router. NAT functionality is associated with the logical router gateway port. The flows that carry out NAT functionality all have match conditions on inport or outpor

[ovs-dev] [PATCH v13 5/6] ovn: rewrite redirect-chassis description in ovn-nb.xml

2017-01-26 Thread Mickey Spiegel
This optional patch addresses offline comments that the documentation in ovn-nb.xml should not describe southbound constructs or flow details, since it is user facing documentation. Signed-off-by: Mickey Spiegel Acked-by: Gurucharan Shetty --- ovn/ovn-nb.xml | 25 ++--- 1 fi

[ovs-dev] [PATCH v13 4/6] ovn: ovn-nbctl commands for distributed NAT

2017-01-26 Thread Mickey Spiegel
This patch adds the new optional arguments "logical_port" and "external_mac" to lr-nat-add, and displays that information in lr-nat-list. Signed-off-by: Mickey Spiegel Acked-by: Gurucharan Shetty --- ovn/utilities/ovn-nbctl.8.xml | 27 +++--- ovn/utilities/ovn-nbctl.c | 54 +

[ovs-dev] [PATCH v13 2/6] ovn: avoid snat recirc only on gateway routers

2017-01-26 Thread Mickey Spiegel
Currently, for performance reasons on gateway routers, ct_snat that does not specify an IP address does not immediately trigger recirculation. On gateway routers, ct_snat that does not specify an IP address happens in the UNSNAT pipeline stage, which is followed by the DNAT pipeline stage that tri

[ovs-dev] [PATCH v13 1/6] ovn: move load balancing flows after NAT flows

2017-01-26 Thread Mickey Spiegel
This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel Acked-by: Gurucharan Shet

[ovs-dev] [PATCH v13 0/6] ovn: add distributed NAT capability

2017-01-26 Thread Mickey Spiegel
PATCH v12 -> PATCH v13 Addressed minor comments from shettyg on nat flows patch. Currently OVN supports NAT functionality by connecting each distributed logical router to a centralized "l3gateway" router that resides on a single chassis. NAT is only carried out in the "l3gateway" router. This p

[ovs-dev] [PATCH] lib: Remove generated ovs-fields.7 manpage on make clean.

2017-01-26 Thread Ben Pfaff
Found by travis. Signed-off-by: Ben Pfaff --- lib/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/automake.mk b/lib/automake.mk index 0acbac9..abc9d0d 100644 --- a/lib/automake.mk +++ b/lib/automake.mk @@ -1,4 +1,4 @@ -# Copyright (C) 2009, 2010, 2011, 2012,

Re: [ovs-dev] [PATCH v2] libX.pc: use the correct output directory

2017-01-26 Thread Aaron Conole
Aaron Conole writes: > When the ovsdb library pkgconfig changes were introduced, they placed > generated output in the src directory. This is incorrect, however, as > the output files should actually be placed in the build directory. It > is only seen when running `make distcheck` after enablin

[ovs-dev] [PATCH v2] libX.pc: use the correct output directory

2017-01-26 Thread Aaron Conole
When the ovsdb library pkgconfig changes were introduced, they placed generated output in the src directory. This is incorrect, however, as the output files should actually be placed in the build directory. It is only seen when running `make distcheck` after enabling shared libraries (ex: `./conf

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

2017-01-26 Thread Aaron Conole
Daniele Di Proietto writes: > On 25/01/2017 00:01, "Ansis Atteka" wrote: > >>On Jan 25, 2017 4:22 AM, "Daniele Di Proietto" wrote: >> >>Current SELinux policy in RHEL and Fedora doesn't allow the creation of >>TAP devices. >> >>A tap device is used by dpif-netdev to create internal devices. >>

[ovs-dev] [PATCH] windows: Allow clients to read from server before disconnect

2017-01-26 Thread Alin Serdean
Wait for clients to read from the pipe before disconnecting the server. Found while testing. Signed-off-by: Alin Gabriel Serdean --- Intended for master and branch-2.7 --- lib/stream-windows.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/stream-windows.c b/lib/stream-windows.c ind

Re: [ovs-dev] [PATCH 1/3] rhel: Fix ifdown for OVSDPDKBond.

2017-01-26 Thread Aaron Conole
Daniele Di Proietto writes: > The OVSDPDKBond case wasn't handled in the rhel ifdown script. > > Fixes: f6bf8880613a ("rhel: Add support DPDK port creation via network > scripts") > Signed-off-by: Daniele Di Proietto > --- D'oh! Acked-by: Aaron Conole

Re: [ovs-dev] [PATCH] Add ovs-fields.7 to lib/.gitignore

2017-01-26 Thread Ben Pfaff
On Thu, Jan 26, 2017 at 06:37:42PM +, Alin Serdean wrote: > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean Thanks, applied to master and branch-2.7. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listin

[ovs-dev] [PATCH] Add ovs-fields.7 to lib/.gitignore

2017-01-26 Thread Alin Serdean
Found by inspection. Signed-off-by: Alin Gabriel Serdean --- lib/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/.gitignore b/lib/.gitignore index 9f6e924..0680af6 100644 --- a/lib/.gitignore +++ b/lib/.gitignore @@ -9,6 +9,7 @@ /ofp-actions.inc2 /ofp-errors.inc /ofp-msgs.i

Re: [ovs-dev] [PATCH] test windows: appctl - route/add with gateway

2017-01-26 Thread Alin Serdean
Thanks Guru! Can you apply it on branch-2.7 as well? Thanks, Alin. From: Guru Shetty [mailto:g...@ovn.org] Sent: Thursday, January 26, 2017 8:03 PM To: Alin Serdean Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] test windows: appctl - route/add with gateway On 26 January 2017 at 09:5

[ovs-dev] [PATCH] tests windows: change service test

2017-01-26 Thread Alin Serdean
Skip the test if the service 'ovsdb-server' is already defined. The arguments of the service are incomplete: in the former state it will try to create the pidfile and unixctl in the configuration path. This patch adds those arguments. Signed-off-by: Alin Gabriel Serdean --- Intended for master a

[ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to groff encodings.

2017-01-26 Thread Ben Pfaff
It turns out that, since groff 1.20 around 2009, groff comes with a preprocessor named "preconv" that can fix encoding issues. Use it instead of the existing hack. Signed-off-by: Ben Pfaff --- build-aux/extract-ofp-fields | 8 lib/automake.mk | 4 ++-- 2 files changed, 2 i

Re: [ovs-dev] [PATCH] test windows: appctl - route/add with gateway

2017-01-26 Thread Guru Shetty
On 26 January 2017 at 09:57, Alin Serdean wrote: > This test passes on Windows, change the test accordingly. > > Signed-off-by: Alin Gabriel Serdean > Thanks, applied. > --- > tests/ovs-router.at | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/ovs-router.at b/tests/ovs-router.a

[ovs-dev] [PATCH] test windows: appctl - route/add with gateway

2017-01-26 Thread Alin Serdean
This test passes on Windows, change the test accordingly. Signed-off-by: Alin Gabriel Serdean --- tests/ovs-router.at | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/ovs-router.at b/tests/ovs-router.at index 93a730a..4e0abdf 100644 --- a/tests/ovs-router.at +++ b/tests/ovs-router.at @@

Re: [ovs-dev] [PATCH v11 3/5] ovn: distributed NAT flows

2017-01-26 Thread Guru Shetty
On 26 January 2017 at 09:47, Mickey Spiegel wrote: > > On Thu, Jan 26, 2017 at 8:53 AM, Guru Shetty wrote: > >> >> >> On 21 January 2017 at 16:52, Mickey Spiegel >> wrote: >> >>> This patch implements the flows required in the ingress and egress >>> pipeline stages in order to support NAT on a

Re: [ovs-dev] [PATCH 1/1] dpif-netdev: Conditional EMC insert

2017-01-26 Thread Loftus, Ciara
> > 2017-01-25 7:52 GMT-08:00 Loftus, Ciara : > >> 2017-01-22 11:45 GMT-08:00 Jan Scheurich : > >> > > >> >> It's not a big deal, since the most important use case we have for > >> >> dpif-netdev is with dpdk, but I'd still like the code to behave > >> >> similarly on different platforms. How abo

[ovs-dev] [PATCH v2] dpif-netdev: Conditional EMC insert

2017-01-26 Thread Ciara Loftus
Unconditional insertion of EMC entries results in EMC thrashing at high numbers of parallel flows. When this occurs, the performance of the EMC often falls below that of the dpcls classifier, rendering the EMC practically useless. Instead of unconditionally inserting entries into the EMC when a mi

Re: [ovs-dev] [PATCH v11 4/5] ovn: ovn-nbctl commands for distributed NAT

2017-01-26 Thread Mickey Spiegel
On Thu, Jan 26, 2017 at 9:20 AM, Guru Shetty wrote: > > > On 21 January 2017 at 16:52, Mickey Spiegel wrote: > >> This patch adds the new optional arguments "logical_port" and >> "external_mac" to lr-nat-add, and displays that information in >> lr-nat-list. >> >> Signed-off-by: Mickey Spiegel >

Re: [ovs-dev] [PATCH v11 3/5] ovn: distributed NAT flows

2017-01-26 Thread Mickey Spiegel
On Thu, Jan 26, 2017 at 8:53 AM, Guru Shetty wrote: > > > On 21 January 2017 at 16:52, Mickey Spiegel wrote: > >> This patch implements the flows required in the ingress and egress >> pipeline stages in order to support NAT on a distributed logical router. >> >> NAT functionality is associated w

Re: [ovs-dev] [PATCH v11 5/5] ovn: rewrite redirect-chassis description in ovn-nb.xml

2017-01-26 Thread Guru Shetty
On 21 January 2017 at 16:52, Mickey Spiegel wrote: > This optional patch addresses offline comments that the documentation > in ovn-nb.xml should not describe southbound constructs or flow > details, since it is user facing documentation. > > Signed-off-by: Mickey Spiegel > Acked-by: Gurucharan

Re: [ovs-dev] [PATCH v11 4/5] ovn: ovn-nbctl commands for distributed NAT

2017-01-26 Thread Guru Shetty
On 21 January 2017 at 16:52, Mickey Spiegel wrote: > This patch adds the new optional arguments "logical_port" and > "external_mac" to lr-nat-add, and displays that information in > lr-nat-list. > > Signed-off-by: Mickey Spiegel > Acked-by: Gurucharan Shetty On a different note, can the exte

Re: [ovs-dev] [PATCH v11 3/5] ovn: distributed NAT flows

2017-01-26 Thread Guru Shetty
On 21 January 2017 at 16:52, Mickey Spiegel wrote: > This patch implements the flows required in the ingress and egress > pipeline stages in order to support NAT on a distributed logical router. > > NAT functionality is associated with the logical router gateway port. > The flows that carry out N

[ovs-dev] [PATCH v3 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

2017-01-26 Thread Zoltán Balogh
From: Sugesh Chandran Openvswitch datapath recirculates packets for tunneling, i.e. the incoming packets are encapsulated at first pass. Further actions are applied on encapsulated packets on the second pass after recirculating. The proposed patch compute and append the post tunnel actions at the

[ovs-dev] [PATCH v3 2/2] Fix test suite failures on tunneling CLONE action.

2017-01-26 Thread Zoltán Balogh
From: Sugesh Chandran Following tunneling specific test cases are failing due to the introduction of new CLONE action for the tunnel push. 769: tunnel_push_pop_ipv6 - action FAILED (tunnel-push-pop-ipv6.at:92) 767: tunnel_push_pop - actionFAILED (tunne

[ovs-dev] [PATCH v3 0/2] tunneling : Improving tunneling performance by avoiding the recirculation on datapath.

2017-01-26 Thread Zoltán Balogh
From: Sugesh Chandran MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch set removes the recirculation of encapsulated tunnel packets by computing the post tunnel actions at the time of translation. V3 - Use only single

[ovs-dev] Annual Reward.

2017-01-26 Thread Lauren Moriarty.
View The Enclosed Attached And Redeem Your Reward. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-26 Thread Mickey Spiegel
Currently in OVN, the "nat-addresses" in the "options" column of a logical switch port of type "router" must be specified manually. Typically the user would specify as "nat-addresses" all of the NAT external IP addresses and load balancer IP addresses that have already been specified separately on

[ovs-dev] [PATCH v12 3/6] ovn: distributed NAT flows

2017-01-26 Thread Mickey Spiegel
This patch implements the flows required in the ingress and egress pipeline stages in order to support NAT on a distributed logical router. NAT functionality is associated with the logical router gateway port. The flows that carry out NAT functionality all have match conditions on inport or outpor

[ovs-dev] [PATCH v12 4/6] ovn: ovn-nbctl commands for distributed NAT

2017-01-26 Thread Mickey Spiegel
This patch adds the new optional arguments "logical_port" and "external_mac" to lr-nat-add, and displays that information in lr-nat-list. Signed-off-by: Mickey Spiegel --- ovn/utilities/ovn-nbctl.8.xml | 27 +++--- ovn/utilities/ovn-nbctl.c | 54 ++

[ovs-dev] [PATCH v12 5/6] ovn: rewrite redirect-chassis description in ovn-nb.xml

2017-01-26 Thread Mickey Spiegel
This optional patch addresses offline comments that the documentation in ovn-nb.xml should not describe southbound constructs or flow details, since it is user facing documentation. Signed-off-by: Mickey Spiegel --- ovn/ovn-nb.xml | 25 ++--- 1 file changed, 10 insertions(+),

[ovs-dev] [PATCH v12 2/6] ovn: avoid snat recirc only on gateway routers

2017-01-26 Thread Mickey Spiegel
Currently, for performance reasons on gateway routers, ct_snat that does not specify an IP address does not immediately trigger recirculation. On gateway routers, ct_snat that does not specify an IP address happens in the UNSNAT pipeline stage, which is followed by the DNAT pipeline stage that tri

[ovs-dev] [PATCH v12 1/6] ovn: move load balancing flows after NAT flows

2017-01-26 Thread Mickey Spiegel
This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel Acked-by: Gurucharan Shet

[ovs-dev] [PATCH v12 0/6] ovn: add distributed NAT capability

2017-01-26 Thread Mickey Spiegel
PATCH v11 -> PATCH v12 Added a patch to automatically add router NAT and load balancer IP addresses to "options:nat-addresses" of type "router" lsps, in order to trigger gratuitous ARPs. This patch is for existing gateway routers. A separate patch (not yet ready) is being developed to extend grat