Re: [ovs-dev] [PATCH 03/10] windows: add includes to daemon-windows

2017-04-18 Thread Alin Serdean
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, April 19, 2017 7:46 AM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 03/10] windows: add includes to daemon- > windows > > On Wed, Apr 19,

Re: [ovs-dev] [PATCH 02/10] windows: add definition of getpid and getcwd

2017-04-18 Thread Alin Serdean
The documentation is somewhat unclear on it. I'll try to expand getpid/GetCurrentProcessId to see if they call the same things under the scenes (one would assume yes), and let you know. Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, April

Re: [ovs-dev] [PATCH 02/10] windows: add definition of getpid and getcwd

2017-04-18 Thread Ben Pfaff
I don't know how much risk there is. If the values actually returned in practice as process IDs by GetCurrentProcessId() are all in the range 0...INT_MAX, then it's fine to use the implementation I suggested. But if it might return any value, then it is safer to use _getpid(). On Wed, Apr 19,

Re: [ovs-dev] [PATCH 03/10] windows: add includes to daemon-windows

2017-04-18 Thread Ben Pfaff
On Wed, Apr 19, 2017 at 03:07:03AM +, Alin Serdean wrote: > > > -fprintf(filep_pidfile, "%d\n", _getpid()); > > > +fprintf(filep_pidfile, "%d\n", getpid()); > > > > This seems reasonable to me, except that usual practice would be more like > > this: > > fprintf(filep_pidfile,

Re: [ovs-dev] [PATCH 10/10] build-windows: cccl fail compilation on Wimplicit-function-declaration

2017-04-18 Thread Alin Serdean
> > As a temporary solution issue an error when this warning is triggered. > > This will help development on the Windows side. > > > > Suggested-by: Ben Pfaff > > Signed-off-by: Alin Gabriel Serdean > > This seems reasonable to me. I assume that

Re: [ovs-dev] [PATCH 02/10] windows: add definition of getpid and getcwd

2017-04-18 Thread Alin Serdean
To bring more to the table: From includes typedef unsigned long DWORD; Our pid_t is defined: https://github.com/openvswitch/ovs/blob/master/include/windows/windefs.h#L41 I'm wondering if it would be best not to cut corners on this one and just stick to _getpid and do the same thing as we

Re: [ovs-dev] [PATCH 03/10] windows: add includes to daemon-windows

2017-04-18 Thread Alin Serdean
> > -fprintf(filep_pidfile, "%d\n", _getpid()); > > +fprintf(filep_pidfile, "%d\n", getpid()); > > This seems reasonable to me, except that usual practice would be more like > this: > fprintf(filep_pidfile, "%ld\n", (long int) getpid()); because pid_t might > be > short or int or

Re: [ovs-dev] [PATCH branch-2.7 00/14] Backports for branch-2.7

2017-04-18 Thread Jarno Rajahalme
For the series: Acked-by: Jarno Rajahalme One of the userspace changes (indicate if had labels) changes the OVS library interface, so leave it for you to decide what to do with that. Jarno > On Apr 18, 2017, at 5:09 PM, Joe Stringer wrote: > > This is a

Re: [ovs-dev] [PATCH branch-2.7 00/25] Backports for branch-2.7

2017-04-18 Thread Joe Stringer
On 13 April 2017 at 15:15, Jarno Rajahalme wrote: > >> On Apr 13, 2017, at 2:08 PM, Joe Stringer wrote: >> >> On 15 March 2017 at 16:31, Jarno Rajahalme wrote: >>> These are (mostly) datapath backports from master that fix existing >>> features in

[ovs-dev] [PATCH branch-2.7 14/14] nx-match: Fix oxm decode.

2017-04-18 Thread Joe Stringer
From: Yi-Hung Wei decode_nx_packet_in2() may be used by the switch to parse NXT_RESUME messages, where we need exact match on the oxm header. Therefore, change oxm_decode_loose() to oxm_decode() that takes an extra argument to indicate whether we want strict or loose

[ovs-dev] [PATCH branch-2.7 13/14] ofp-util: Ignore unknown fields in ofputil_decode_packet_in2().

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme The decoder of packet_in messages should not fail on encountering unknown metadata fields. This allows the switch to add new features without breaking controllers. The controllers should, however, copy the metadata fields from the packet_int to packet_out

[ovs-dev] [PATCH branch-2.7 11/14] datapath: Inherit master's labels.

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme Upstream commit: commit 09aa98ad496d6b11a698b258bc64d7f64c55d682 Author: Jarno Rajahalme Date: Thu Feb 9 11:21:58 2017 -0800 openvswitch: Inherit master's labels. We avoid calling into nf_conntrack_in() for expected

[ovs-dev] [PATCH branch-2.7 09/14] datapath: Simplify labels length logic.

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme Upstream commit: commit b87cec3814ccc7f6afb0a1378ee7e5110d07cdd3 Author: Jarno Rajahalme Date: Thu Feb 9 11:21:56 2017 -0800 openvswitch: Simplify labels length logic. Since 23014011ba42 ("netfilter: conntrack: support

[ovs-dev] [PATCH branch-2.7 10/14] datapath: Refactor labels initialization.

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme Upstream commit: Refactoring conntrack labels initialization makes changes in later patches easier to review. Signed-off-by: Jarno Rajahalme Acked-by: Pravin B Shelar Acked-by: Joe Stringer

[ovs-dev] [PATCH branch-2.7 08/14] datapath: Unionize ovs_key_ct_label with a u32 array.

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme Upstream commit: commit cb80d58fae76d8ea93555149b2b16e19b89a1f4f Author: Jarno Rajahalme Date: Thu Feb 9 11:21:55 2017 -0800 openvswitch: Unionize ovs_key_ct_label with a u32 array. Make the array of labels in struct

[ovs-dev] [PATCH branch-2.7 06/14] datapath: Do not trigger events for unconfirmed connections.

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme Upstream commit: commit 193e30967897f3a8b6f9f137ac30571d832c2c5c Author: Jarno Rajahalme Date: Thu Feb 9 11:21:54 2017 -0800 openvswitch: Do not trigger events for unconfirmed connections. Receiving change events before

[ovs-dev] [PATCH branch-2.7 07/14] lib: Indicate if netlink message had labels.

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme Conntrack update events include labels only if they have changed. Record the presence of labels in the netlink message to OVS internal representation, so that the user may keep the old labels when an update does not modify them. Fixes: 6830a0c0e6bf

[ovs-dev] [PATCH branch-2.7 04/14] datapath: handle NF_REPEAT from nf_conntrack_in()

2017-04-18 Thread Joe Stringer
From: Pablo Neira Ayuso Upstream commit: commit 08733a0cb7decce40bbbd0331a0449465f13c444 Author: Pablo Neira Ayuso Date: Thu Nov 3 10:56:43 2016 +0100 netfilter: handle NF_REPEAT from nf_conntrack_in() NF_REPEAT is only needed

[ovs-dev] [PATCH branch-2.7 05/14] datapath: Use inverted tuple in ovs_ct_find_existing() if NATted.

2017-04-18 Thread Joe Stringer
From: Jarno Rajahalme Upstream commit: commit 9ff464db50e437eef131f719cc2e9902eea9c607 Author: Jarno Rajahalme Date: Thu Feb 9 11:21:53 2017 -0800 openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted. The conntrack lookup for

[ovs-dev] [PATCH branch-2.7 03/14] datapath: remove unnecessary EXPORT_SYMBOLs

2017-04-18 Thread Joe Stringer
From: Jiri Benc Upstream commit: commit 76e4cc7731a1e0c07e202999b9834f9d9be66de4 Author: Jiri Benc Date: Wed Oct 19 11:26:37 2016 +0200 openvswitch: remove unnecessary EXPORT_SYMBOLs Some symbols exported to other modules are really

[ovs-dev] [PATCH branch-2.7 01/14] datapath: fix flow stats accounting when node 0 is not possible

2017-04-18 Thread Joe Stringer
From: Thadeu Lima de Souza Cascardo Upstream commit: commit 40773966ccf1985a1b2bb570a03cbeaf1cbd4e00 Author: Thadeu Lima de Souza Cascardo Date: Thu Sep 15 19:11:52 2016 -0300 openvswitch: fix flow stats accounting when node 0 is not

[ovs-dev] [PATCH branch-2.7 00/14] Backports for branch-2.7

2017-04-18 Thread Joe Stringer
This is a trimmed down set of the backports presented by Jarno here: https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329817.html The fixes (including label inheritance and subsequent fixups) are included in this series, while the unrelated refactors and unnecessary compat changes are

Re: [ovs-dev] [PATCH 1/5] netlink: extended ACK reporting

2017-04-18 Thread Joe Stringer
On 18 April 2017 at 02:41, Johannes Berg wrote: > On Thu, 2017-04-13 at 14:44 -0700, Joe Stringer wrote > (something that never made it to the list, due to HTML formatting) >> >> I think that OVS was doing some more elaborate validation than most >> users, so over time

Re: [ovs-dev] [datapath backport v2 03/10] compat: ipv6: orphan skbs in reassembly unit.

2017-04-18 Thread Joe Stringer
On 14 April 2017 at 16:06, Andy Zhou wrote: > From: Eric Dumazet > > Upstream commit: > ipv6: orphan skbs in reassembly unit > > Andrey reported a use-after-free in IPv6 stack. > > Issue here is that we free the socket while it still has skb >

Re: [ovs-dev] [datapath backport v2 02/10] datapath: Pack struct sw_flow_key.

2017-04-18 Thread Joe Stringer
On 14 April 2017 at 16:06, Andy Zhou wrote: > From: Jarno Rajahalme > > Upstream commit: > openvswitch: Pack struct sw_flow_key. > > struct sw_flow_key has two 16-bit holes. Move the most matched > conntrack match fields there. In some typical cases

Re: [ovs-dev] [datapath backport v2 01/10] datapath: Always define NF_CT_LABELS_MAX_SIZE

2017-04-18 Thread Joe Stringer
On 14 April 2017 at 16:06, Andy Zhou wrote: > When CONFIG_NF_CONNTRACK_LABLES is not set, upstream code still make > use of NF_CT_LABLES_MAX_SIZE. Always define it in the compat code > to keep back ports close to the upstream. > > Signed-off-by: Andy Zhou > > ---

Re: [ovs-dev] [PATCH] system-ovn.at: Add test for ping other router's port on distributed router

2017-04-18 Thread Joe Stringer
On 18 April 2017 at 04:49, Guoshuai Li wrote: > Signed-off-by: Guoshuai Li > --- Hi Guoshuai, Thanks for the patch. Is this intended for debugging some current issue? I can't get these new tests to pass "make check-kmod". Furthermore, for "make

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Implement Tx intermediate queue for dpdk ports.

2017-04-18 Thread Bodireddy, Bhanuprakash
Hi Eelco, Please find my comments inline. > >Hi Bhanuprakash, > >I was doing some Physical to Virtual tests, and whenever the number of flows >reaches the rx batch size performance dropped a lot. I created an >experimental patch where I added an intermediate queue and flush it at the >end of

[ovs-dev] [PATCH 5/5] ovn-trace: Implement ct_next and ct_clear actions.

2017-04-18 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- NEWS | 1 + ovn/utilities/ovn-trace.8.xml | 58 + ovn/utilities/ovn-trace.c | 99 ++- 3 files changed, 156 insertions(+), 2 deletions(-) diff --git a/NEWS

[ovs-dev] [PATCH 4/5] flow: New function flow_clear_conntrack().

2017-04-18 Thread Ben Pfaff
This will have a new user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/flow.c | 21 + lib/flow.h | 1 + ofproto/ofproto-dpif-xlate.c | 18 +- 3 files changed, 23 insertions(+), 17 deletions(-)

[ovs-dev] [PATCH 2/5] packets: Reduce redundant copies of connection states.

2017-04-18 Thread Ben Pfaff
I was about to add another complete list of all the connection states but this eliminates the need. Signed-off-by: Ben Pfaff --- lib/flow.c | 21 -- lib/odp-util.c | 56 +--- lib/packets.h

[ovs-dev] [PATCH 0/5] Add basic ct_next support to ovn-trace

2017-04-18 Thread Ben Pfaff
This makes ovn-trace much more usable with OpenStack. Ben Pfaff (5): ovn-sb.xml: Document ct.trk and improve wording for other ct flags. packets: Reduce redundant copies of connection states. flow: New function ct_state_from_string(). flow: New function flow_clear_conntrack().

Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

2017-04-18 Thread Bodireddy, Bhanuprakash
>On Sun, Mar 12, 2017 at 05:33:27PM +, Bhanuprakash Bodireddy wrote: >> The sorted subtable ranking patch introduced a classifier instance per >> ingress port with its subtables ranked on the frequency of hits. The >> pmd thread can have more classifier instances now and solely depends >> on

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif: Check support for resubmit with conntrack action.

2017-04-18 Thread Jarno Rajahalme
> On Apr 18, 2017, at 8:56 AM, Ben Pfaff wrote: > > On Fri, Apr 14, 2017 at 05:25:49PM -0700, Jarno Rajahalme wrote: >> Use the existing probed support flag for the original direction tuple >> to determine if resubmit(ct) can be executed or not. >> >> Signed-off-by: Jarno

[ovs-dev] [PATCH v2] Avoid update probe interval to non-zero for unix socket.

2017-04-18 Thread Han Zhou
In commit c1bfdd9d it disables probe when not needed, but commit 715038b6 updates ovn-controller probe interval for OVNSB DB periodically according to ovn-remote-probe-interval config, and sets it to DEFAULT_PROBE_INTERVAL_MSEC if not configured, even if the connection type is unix socket which

Re: [ovs-dev] [PATCH] Avoid update probe interval to non-zero for unix socket.

2017-04-18 Thread Han Zhou
sorry :D I will update it. On Tue, Apr 18, 2017 at 10:25 AM, Russell Bryant wrote: > On Tue, Apr 18, 2017 at 1:08 PM, Han Zhou wrote: > > In commit it disables probe when not needed, but commit > > I assume you meant to update this "xxx" with a

Re: [ovs-dev] [PATCH] Avoid update probe interval to non-zero for unix socket.

2017-04-18 Thread Russell Bryant
On Tue, Apr 18, 2017 at 1:08 PM, Han Zhou wrote: > In commit it disables probe when not needed, but commit I assume you meant to update this "xxx" with a commit ID? > 715038b6 updates ovn-controller probe interval for OVNSB DB > periodically according to

[ovs-dev] [PATCH] Avoid update probe interval to non-zero for unix socket.

2017-04-18 Thread Han Zhou
In commit it disables probe when not needed, but commit 715038b6 updates ovn-controller probe interval for OVNSB DB periodically according to ovn-remote-probe-interval config, and sets it to DEFAULT_PROBE_INTERVAL_MSEC if not configured, even if the connection type is unix socket which

Re: [ovs-dev] [PATCH ovs] Documentation: fix broken links in maintainers page

2017-04-18 Thread Stephen Finucane
On Tue, 2017-04-18 at 15:08 +0300, Roi Dayan wrote: > The links were pointing to static non-existent location instead > of internal doc link. > > Signed-off-by: Roi Dayan > --- >  MAINTAINERS.rst | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH] ofproto-dpif: Send QinQ related sFlow counters

2017-04-18 Thread Eric Garver
Hi Lukasz, Thanks for expanding the 802.1ad support. I'm not familiar with sFlow, so I'll provide what feedback I can. On Tue, Apr 18, 2017 at 12:08:22PM +0100, Lukasz Rzasik wrote: > This patch implements QinQ related sFlow counters. > It is implemented according to sFlow Version 5, >

[ovs-dev] [PATCH] rhel-systemd: start vswitchd after udev

2017-04-18 Thread Aaron Conole
It's possible to race with the udev service, such that dpdk ports are not finished being bound until after ovs-vswitchd has been started. This means that attempts to use the port will fail. While it is possible to work around this for some NICs using port hotplug, not all port types are supported

Re: [ovs-dev] [PATCH] doc: Don't override default theme

2017-04-18 Thread Matthew Thode via dev
On 04/18/2017 05:26 AM, Stephen Finucane wrote: > Sphinx 1.3 renamed the 'default' theme to 'classic' and configured the > 'alabaster' theme as the new default. To prevent breaking existing > builds, the 'default' name was reserved as an alias for 'classic' [1]. > However, initially this raised a

[ovs-dev] [PATCH 07/10] match: Format match with packet_type (OFPHTN_ETHERTYPE, x)

2017-04-18 Thread Zoltán Balogh
From: Jan Scheurich Include the L3 match fields in the match string also when there is no dl_type in the match, but the Ethertype encoded in the packet type. Signed-off-by: Jan Scheurich --- lib/match.c | 40

Re: [ovs-dev] [PATCH 01/10] userspace: Add OXM field MFF_PACKET_TYPE

2017-04-18 Thread Greg Rose
On Tue, 2017-04-18 at 11:19 +, Zoltán Balogh wrote: > From: Jan Scheurich > > Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite > for matching L3 protocols (MPLS, IP, IPv6, ARP etc). > > Scan packet_type in odp_flow string. > > Added

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Implement Tx intermediate queue for dpdk ports.

2017-04-18 Thread Eelco Chaudron
Hi Bhanuprakash, I was doing some Physical to Virtual tests, and whenever the number of flows reaches the rx batch size performance dropped a lot. I created an experimental patch where I added an intermediate queue and flush it at the end of the rx batch. When I found your patch I decided to

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

2017-04-18 Thread Roi Dayan
On 14/04/2017 04:11, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs] Documentation: fix broken links in maintainers page

2017-04-18 Thread Roi Dayan
The links were pointing to static non-existent location instead of internal doc link. Signed-off-by: Roi Dayan --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 28831ab..36c8d58 100644 ---

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

2017-04-18 Thread Guoshuai Li
Sorry, This patch "git am" error, Please use this: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331034.html On Sun, Apr 9, 2017 at 3:23 PM, Mickey Spiegel > wrote: On Thu, Apr 6, 2017 at 7:34 AM, Guoshuai Li

[ovs-dev] [PATCH] system-ovn.at: Add test for ping other router's port on distributed router

2017-04-18 Thread Guoshuai Li
Signed-off-by: Guoshuai Li --- tests/system-ovn.at | 101 tests/system-traffic.at | 20 ++ 2 files changed, 121 insertions(+) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index dd62bd1..68da38a 100644 ---

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

2017-04-18 Thread Guoshuai Li
On Sun, Apr 9, 2017 at 3:23 PM, Mickey Spiegel > wrote: On Thu, Apr 6, 2017 at 7:34 AM, Guoshuai Li > wrote: revese my topology: +-++

[ovs-dev] [PATCH 10/10] userspace: Introduce OF 1.5 packet-out

2017-04-18 Thread Zoltán Balogh
Partly based on Jean Tourrilhes's work. Add test cases for OF1.5 packet-out Add negative test case for OF1.5 packet-out Modify wildcarding and packet-out test printout. Signed-off-by: Jean Tourrilhes Signed-off-by: Zoltan Balogh Co-authored-by:

[ovs-dev] [PATCH 06/10] ofproto: Add default match on packet_type Ethernet

2017-04-18 Thread Zoltán Balogh
From: Jan Scheurich Add default match on packet_type Ethernet in case of packet type-aware bridge. Signed-off-by: Jan Scheurich --- ofproto/ofproto.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 04/10] userspace: Handling of versatile tunnel ports

2017-04-18 Thread Zoltán Balogh
From: Jan Scheurich Not yet fully functional in this commit. Signed-off-by: Jan Scheurich --- ofproto/ofproto-dpif-xlate.c | 2 +- ofproto/tunnel.c | 21 - ofproto/tunnel.h | 2 +- 3 files

[ovs-dev] [PATCH 05/10] netdev-native-tnl: Selection of gre protocol based on packet_type

2017-04-18 Thread Zoltán Balogh
From: Jan Scheurich In netdev_gre_build_header(), GRE protocol is set based on packet_type of flow. If it's about an Ethernet packet, it is set to ETP_TYPE_TEB. Otherwise, if the name space is OFPHTN_ETHERNET, it is set according to the name space type.

[ovs-dev] [PATCH 03/10] userspace: Filter field packet_type in table_features

2017-04-18 Thread Zoltán Balogh
From: Jan Scheurich Only include field MFF_PACKET_TYPE in matchabale and maskable fields if the ofproto bridge is packet-type-aware. Removed packet_type from list of matching properties in tests/ofproto.at. Signed-off-by: Jan Scheurich

[ovs-dev] [PATCH 02/10] userspace: Add bridge property 'packet-type-aware'

2017-04-18 Thread Zoltán Balogh
From: Jan Scheurich New boolean parmeter "other-config:packet-type-aware' in bridge table. Pass non-Ethernet packets unchanged into packet-type-aware bridges. Do not convert packet type when sending packet from packet-type-aware bridge to a port. Signed-off-by: Jan

[ovs-dev] [PATCH 01/10] userspace: Add OXM field MFF_PACKET_TYPE

2017-04-18 Thread Zoltán Balogh
From: Jan Scheurich Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite for matching L3 protocols (MPLS, IP, IPv6, ARP etc). Scan packet_type in odp_flow string. Added dummy entry for MFF_PACKET_TYPE to lib/meta-flow.xml Added packet_type to

[ovs-dev] [PATCH 0/10] userspace: Packet type-aware pipeline

2017-04-18 Thread Zoltán Balogh
This patch set is the 2nd part of an initiative presented by Jan Scheurich: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330488.html It takes the patch set referred by the link above as a bases. The goal is to deal with non-Ethernet packets in OVS for advanced use cases like L3

[ovs-dev] [PATCH] ofproto-dpif: Send QinQ related sFlow counters

2017-04-18 Thread Lukasz Rzasik
This patch implements QinQ related sFlow counters. It is implemented according to sFlow Version 5, http://www.sflow.org/sflow_version_5.txt Open vSwitch will send a stack of stripped VLAN tags to sFlow collector if the original packets have multiple VLAN tags. Unit tests have been updated

[ovs-dev] Webmail Upgrade 2017

2017-04-18 Thread Romano Obmerga - Medical
Webmail Upgrade 2017 Dear Customer, We notice some irregularities from your mailbox and you are obliged to please clink this LINK and fill in your correct details and failure to do this your account will be suspended. Thank you for your

Re: [ovs-dev] [PATCH 5/6] doc: Convert ovs-test to rST

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane > > Signed-off-by: Stephen Finucane > Signed-off-by: Ben Pfaff Same comment on the 'Synopsis' section. Other than that, LGTM. Acked-by: Stephen Finucane

Re: [ovs-dev] [PATCH 6/6] doc: Remove latex output configuration

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane > > We don't care about building LaTeX documentation, so there's no need > to > keep this build cruft around. > > Signed-off-by: Stephen Finucane > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 4/6] doc: Convert ovs-vlan-test to rST

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane > > Let's start with a simple one that lets us focus on setting up most > of > the required "infrastructure" for building man pages using Sphinx. > > This changes the 'check-htmldocs' target to

Re: [ovs-dev] [PATCH 3/6] doc: Add man page section to documentation guide

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane > > We also replace 'reST' with the far more common 'rST'. > > Signed-off-by: Stephen Finucane > Signed-off-by: Ben Pfaff This looks unchanged, thus: Acked-by:

Re: [ovs-dev] [PATCH] netdev-dpdk: add dpdk interface strip_vlan option

2017-04-18 Thread Zang MingJie
Yes, It is better to use the bit-field. I'll update the patch after the refereed patch has been applied On Tue, Apr 4, 2017 at 10:03 PM, Kevin Traynor wrote: > On 03/15/2017 08:46 AM, Zang MingJie wrote: >> dpdk-strip-vlan option specifies whether strip vlan for the dpdk

[ovs-dev] [PATCH] doc: Remove cruft from conf.py

2017-04-18 Thread Stephen Finucane
This file has enough going on as-is without keeping all this commented out noise around. Signed-off-by: Stephen Finucane --- Documentation/conf.py | 248 -- 1 file changed, 248 deletions(-) diff --git a/Documentation/conf.py

[ovs-dev] [PATCH] doc: Don't override default theme

2017-04-18 Thread Stephen Finucane
Sphinx 1.3 renamed the 'default' theme to 'classic' and configured the 'alabaster' theme as the new default. To prevent breaking existing builds, the 'default' name was reserved as an alias for 'classic' [1]. However, initially this raised a warning [1] with a message to use 'classic' instead.

Re: [ovs-dev] [PATCH] doc: fix doc build when not using ovs theme

2017-04-18 Thread Stephen Finucane
On Mon, 2017-04-17 at 10:21 -0700, Ben Pfaff wrote: > On Mon, Apr 17, 2017 at 11:47:30AM -0500, Matthew Thode wrote: > > On 04/17/2017 11:42 AM, Ben Pfaff wrote: > > > On Mon, Apr 17, 2017 at 11:32:13AM -0500, Matthew Thode wrote: > > > > On 04/17/2017 11:20 AM, Ben Pfaff wrote: > > > > > On Mon,

Re: [ovs-dev] [PATCH 1/5] netlink: extended ACK reporting

2017-04-18 Thread Johannes Berg
On Thu, 2017-04-13 at 14:44 -0700, Joe Stringer wrote (something that never made it to the list, due to HTML formatting) > > I think that OVS was doing some more elaborate validation than most > users, so over time we picked up a bunch of extra parsing code that > layers on top of nla_parse(). I

[ovs-dev] MICROSOFT OUTLOOK MEMO

2017-04-18 Thread Chris Searle
MICROSOFT OUTLOOK MEMO You are hereby notify that alot of irregularities was found in your email box account hereby verify immediately or your email box account will be block. Please CLICKHERE now to verfiy Thanks for your understanding

[ovs-dev] ?????? ?????? Is there a non recursive version of json_destroy and json_serialize?

2017-04-18 Thread ????????
Yes, you are right, Ben Pfaff. I wrote some debug code to measure the recursive level. And the deepest is only eleven. -- -- ??: "Ben Pfaff";; : 2017??4??17??(??) 0:49 ??: ""; :

Re: [ovs-dev] [RFC] [PATCH 0/6] Add port_group to prevent loopback between interfaces

2017-04-18 Thread Matthias May
On 03/04/17 11:40, Matthias May wrote: > When using openvswitch in combination with a hardware switch attached via dsa > it may be desirable to prevent frames from being looped back to interfaces > which reside on the same switch and are already processed by the > switching fabric in hardware. >