Re: [ovs-dev] [PATCH] datapath: backport: vxlan: do not output confusing error message

2017-05-04 Thread Pravin Shelar
On Thu, May 4, 2017 at 10:01 AM, Joe Stringer wrote: > On 3 May 2017 at 19:05, Pravin B Shelar wrote: >> From: Jiri Benc >> >> Upstream commit: >> commit baf4d7860771287f30fbe9b6b2dc18b04361439d >> Author: Jiri Benc >> Date: Thu Apr 27 21:24:36 2017 +0200 >> >> vxlan: do not o

Re: [ovs-dev] ovsdb-idl: Need details/examples on one of the comment mentioned in ovsdb-idl.h

2017-05-04 Thread Arunkumar Rg
Thanks Ben for clarifying!! On Fri, May 5, 2017 at 1:37 AM, Ben Pfaff wrote: > Yes. The effects of a transaction are visible to the client that is > constructing it, in the process of constructing it. > > On Thu, May 04, 2017 at 08:00:07AM +0530, Arunkumar Rg wrote: > > Say there is a client us

Re: [ovs-dev] [PATCH v4 2/7] userspace: Support for push_eth and pop_eth actions

2017-05-04 Thread Jiri Benc
On Thu, 4 May 2017 12:53:25 -0700, Joe Stringer wrote: > On 4 May 2017 at 12:51, Joe Stringer wrote: > > Really? Previously the OVS usage of netlink always validated that > > netlink attributes are exactly as long as expected and that there's no > > trailing data. > > With a glance at __ovs_nla_c

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2017-05-04 Thread Michael Qiu
Hi, Ben 在 2017/5/5 7:00, Darrell Ball 写道: On 5/1/17, 11:10 PM, "ovs-dev-boun...@openvswitch.org on behalf of Michael Qiu" wrote: From: Michael Qiu When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's ve

Re: [ovs-dev] [PATCH] Windows: Secure the namedpipe implementation

2017-05-04 Thread Ben Pfaff
Usually if we're taking the size of a variable, it makes sense to really take the size of that variable, e.g. sa.nLength = sizeof sa; On Fri, May 05, 2017 at 12:40:02AM +, Sairam Venugopal wrote: > Hi Ben, > > Regarding the usage of sizeof - I think the current implementation is in li

Re: [ovs-dev] [PATCH v5 3/6] ovn: extend expr symbols for ND

2017-05-04 Thread Numan Siddique
On Fri, May 5, 2017 at 5:21 AM, Ben Pfaff wrote: > On Thu, May 04, 2017 at 08:43:26PM +0530, nusid...@redhat.com wrote: > > From: Zong Kai LI > > > > This patch updates symbols in logical-fields for ND, such as "nd", > > "nd.target", "nd.sll", "nd.tll", to describe more clear about > "icmp6.type

Re: [ovs-dev] [PATCH v5 0/6] ovn: Add IPv6 Router Solicitation responder support

2017-05-04 Thread Numan Siddique
On Fri, May 5, 2017 at 9:31 AM, Ben Pfaff wrote: > On Fri, May 05, 2017 at 09:20:37AM +0530, Numan Siddique wrote: > > On Thu, May 4, 2017 at 8:48 PM, Aaron Conole wrote: > > > > > Hi Numan, > > > > > > nusid...@redhat.com writes: > > > > > > > From: Numan Siddique > > > > > > > > I have picked

Re: [ovs-dev] [PATCH v5 0/6] ovn: Add IPv6 Router Solicitation responder support

2017-05-04 Thread Ben Pfaff
On Fri, May 05, 2017 at 09:20:37AM +0530, Numan Siddique wrote: > On Thu, May 4, 2017 at 8:48 PM, Aaron Conole wrote: > > > Hi Numan, > > > > nusid...@redhat.com writes: > > > > > From: Numan Siddique > > > > > > I have picked up the patch series authored by Zong Kai LI to support IPv6 > > > Rou

Re: [ovs-dev] [PATCH v5 0/6] ovn: Add IPv6 Router Solicitation responder support

2017-05-04 Thread Numan Siddique
On Thu, May 4, 2017 at 8:48 PM, Aaron Conole wrote: > Hi Numan, > > nusid...@redhat.com writes: > > > From: Numan Siddique > > > > I have picked up the patch series authored by Zong Kai LI to support IPv6 > > Router Advertisement in ovn - > > https://mail.openvswitch.org/pipermail/ovs-dev/2016-O

[ovs-dev] 答复: Re: 答复: Re: [PATCH] ovn-controller: Support vxlan tunnel in ovn

2017-05-04 Thread wang . qianyu
We want to use ovn in the scenary that ovs-computer node and sriov computer node all managed by openstack. However, in our analysis that ovn-controller-vtep could only be used to forwards traffic between networks managed by openstack and physical network openstack not managed. Do we misundersta

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

2017-05-04 Thread Joe Stringer
On 4 May 2017 at 04:39, Zoltán Balogh wrote: >> I think that what's happening is that when build_tunnel_send() >> serializes the ODP action for push_tunnel, it doesn't update the >> 'flow' to reflect the new encapsulated state of the packet. Then, when >> calling apply_nested_clone_actions() it pe

Re: [ovs-dev] [PATCH v5 3/6] ovn: extend expr symbols for ND

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 08:43:26PM +0530, nusid...@redhat.com wrote: > From: Zong Kai LI > > This patch updates symbols in logical-fields for ND, such as "nd", > "nd.target", "nd.sll", "nd.tll", to describe more clear about "icmp6.type" > predicate. > It adds new symbols: > - "nd_rs" stands for

Re: [ovs-dev] [PATCH v5 2/6] lib: rename ovs_nd_opt to ovs_nd_lla_opt

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 08:42:54PM +0530, nusid...@redhat.com wrote: > From: Zong Kai LI > > Since ovs_nd_mtu_opt and ovs_nd_prefix_opt is introducted, rename > ovs_nd_opt to ovs_nd_lla_opt to specify it's Source/Target Link-layer > Address Option. > > Signed-off-by: Zongkai LI > Signed-off-by:

Re: [ovs-dev] [PATCH v5 1/6] packets: add compose_nd_ra

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 08:42:30PM +0530, nusid...@redhat.com wrote: > From: Zong Kai LI > > This patch introduces methods to compose a Router Advertisement (RA) packet, > introduces flags for RA. RA packet composed structures against specification > in RFC4861. > > Caller can use compse_nd_ra_w

[ovs-dev] [PATCH 3/3] ofp-parse: Parse pipeline fields in OF1.5 packet-out

2017-05-04 Thread Yi-Hung Wei
This patch adds support for parsing the pipeline match fields of OpenFlow 1.5 packet-out messages. With this patch, we can use ovs-ofctl to specify tunnel id and table metadata for a packet-out message. Signed-off-by: Yi-Hung Wei --- lib/ofp-parse.c | 21 - tests/ofp

[ovs-dev] [PATCH 2/3] ofproto: Add OpenFlow 1.5 packet-out support

2017-05-04 Thread Yi-Hung Wei
OpenFlow 1.5 enables setting pipeline fields in packet-out messages. This patch implements the encoding and decoding of the new packet-out format, populates the pipeline fields to dpif, and adds test cases to verify the encoding and decoding. Currently, the supported pipeline fields are in_port, tu

[ovs-dev] [PATCH 0/3] Support OpenFlow 1.5 packet-out

2017-05-04 Thread Yi-Hung Wei
This patch series add support to OpenFlow 1.5 packet-out message that enables setting pipeline fields. While there are six pipeline match fields as listed in OpenFlow spec 1.5.1, this patch series implements three of them (OXM_OF_IN_PORT, OXM_OF_METADATA, and OXM_OF_TUNNEL_ID), since the rest of th

[ovs-dev] [PATCH 1/3] ofp-util: Add flow metadata to ofputil_packet_out

2017-05-04 Thread Yi-Hung Wei
This patch adds flow metadata to ofputil_packet_out. It does not make any functional change. The flow metadata will be useful to support new packet-out message format in OpenFlow 1.5. Signed-off-by: Yi-Hung Wei --- include/openvswitch/ofp-util.h | 2 +- lib/learning-switch.c | 3 ++-

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2017-05-04 Thread Darrell Ball
On 5/1/17, 11:10 PM, "ovs-dev-boun...@openvswitch.org on behalf of Michael Qiu" wrote: From: Michael Qiu When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's very important for DPDK port when copying

Re: [ovs-dev] [PATCH 3/6] ovs-pki: add option to suppress generated id in common name

2017-05-04 Thread Ben Pfaff
On Mon, May 01, 2017 at 10:13:16AM -0400, Lance Richardson wrote: > For some applications, it is desirable to have full control of > the common name field in generated certificates. Add a command-line > option to suppress appending " id:" to the user- > specified name. > > Signed-off-by: Lance Ri

Re: [ovs-dev] [PATCH 2/6] ovsdb: refactor utility functions into separate file

2017-05-04 Thread Ben Pfaff
On Mon, May 01, 2017 at 10:13:11AM -0400, Lance Richardson wrote: > Move local db access functions to a new file and make give them > global scope so they can be included in the ovsdb library and used > by other ovsdb library functions. > > Signed-off-by: Lance Richardson Thank you! I applied t

Re: [ovs-dev] [PATCH 1/6] stream: store stream peer id with stream state

2017-05-04 Thread Ben Pfaff
On Mon, May 01, 2017 at 10:13:02AM -0400, Lance Richardson wrote: > Track authenticated stream peer ID. For SSL connections, the > authenticated ID is the CN (Common Name) field extracted from > the peer's SSL certificate. > > Signed-off-by: Lance Richardson Looks good, thanks! I moved declarat

[ovs-dev] [PATCH v8 2/5] datapath-windows: Added Ipv4 fragments support in Conntrack

2017-05-04 Thread Anand Kumar
This patch adds support for tracking Ipv4 fragments in conntrack module. Individual fragments are not tracked and are consumed by the fragmentation/reassembly. Only the reassembled Ipv4 datagram is tracked and treated as a single ct entry. Signed-off-by: Anand Kumar --- v7->v8: No change v6->v7:

[ovs-dev] [PATCH v8 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-05-04 Thread Anand Kumar
This patch adds functionalities to support IPv4 fragments, which will be used by Conntrack module. Added a new structure to hold the Ipv4 fragments and a hash table to hold Ipv4 datagram entries. Also added a clean up thread that runs every minute to delete the expired IPv4 datagram entries. The

[ovs-dev] [PATCH v8 4/5] datapath-windows: Updated OvsTcpSegmentNBL to handle IP fragments.

2017-05-04 Thread Anand Kumar
With this patch, OvsTcpSegmentNBL not only supports fragmenting NBL to TCP segments but also Ipv4 fragments. To reflect the new changes, renamed function name from OvsTcpSegmentNBL to OvsFragmentNBL and created a wrapper for OvsTcpSegmentNBL. Signed-off-by: Anand Kumar --- v7->v8: No change v6->

[ovs-dev] [PATCH v8 5/5] datapath-windows: Fragment NBL based on MRU size

2017-05-04 Thread Anand Kumar
This patch adds support for Fragmenting NBL based on the MRU value. MRU value is updated only for Ipv4 fragments, if it is non zero, then fragment the NBL and send out the new NBL to the vnic. Signed-off-by: Anand Kumar --- v7->v8: No change v6->v7: Fragment the NBL for tunnel packets v5->v6: No

[ovs-dev] [PATCH v8 3/5] datapath-windows: Retain MRU value in the _OVS_BUFFER_CONTEXT.

2017-05-04 Thread Anand Kumar
This patch introduces a new field MRU(Maximum Recieved Unit) in the _OVS_BUFFER_CONTEXT and it is used only for Ip Fragments to retain MRU for the reassembled IP datagram when the packet is forwarded to userspace. Signed-off-by: Anand Kumar --- v7->v8: No change v6->v7: Increase value size in OVS

[ovs-dev] [PATCH v8 0/5] datapath-windows: Add support for Ipv4 fragments

2017-05-04 Thread Anand Kumar
Add support for maintaining and tracking IPv4 fragments. This patch adds new files IpFragment.c and IpFragment.h which include Ipv4 fragment related API’s. --- v7->v8: Rebase and address locking issues found by inspection. v6->v7: Rebase and address comments v5->v6: Rebase v4->v5: - Modified Pat

Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2017-05-04 Thread Ben Pfaff
On Tue, May 02, 2017 at 02:10:43PM +0800, Michael Qiu wrote: > From: Michael Qiu > > When a packet is from DPDK source, and it contains > multiple segments, data_len is not equal to the > packet size. This patch fix this issue. > > Signed-off-by: Michael Qiu > Signed-off-by: Marcin Ksiadz > Si

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2017-05-04 Thread Ben Pfaff
On Tue, May 02, 2017 at 02:10:41PM +0800, Michael Qiu wrote: > From: Michael Qiu > > When building with DPDK, and using xmalloc() to get a new packet, > field mbuf of the packet will not be initialized, but it's very important for > DPDK port when copying the data to DPDK mbuf, because if ol_flag

Re: [ovs-dev] [PATCH] Documentation: Add ovn-openstack tutorial to index.

2017-05-04 Thread Joe Stringer
On 4 May 2017 at 13:48, Ben Pfaff wrote: > On Thu, May 04, 2017 at 01:35:34PM -0700, Joe Stringer wrote: >> This makes the tutorial easier to find from the main page at >> docs.openvswitch.org. >> >> Signed-off-by: Joe Stringer > > Acked-by: Ben Pfaff Applied. __

Re: [ovs-dev] [PATCH] Documentation: Add ovn-openstack tutorial to index.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 01:35:34PM -0700, Joe Stringer wrote: > This makes the tutorial easier to find from the main page at > docs.openvswitch.org. > > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://

[ovs-dev] [PATCH] Documentation: Add ovn-openstack tutorial to index.

2017-05-04 Thread Joe Stringer
This makes the tutorial easier to find from the main page at docs.openvswitch.org. Signed-off-by: Joe Stringer --- Documentation/index.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/index.rst b/Documentation/index.rst index 5210a5630951..836c37fc3de9 1006

Re: [ovs-dev] [PATCH v3 4/4] Documentation: Add an OVN tutorial for OpenStack.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 01:09:38PM -0700, Andy Zhou wrote: > On Thu, May 4, 2017 at 1:01 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > Acked-by: Andy Zhou > > It is good to go. Thanks. Thanks! I applied this series to master. ___ dev mailin

Re: [ovs-dev] [RFC 0/2] Rename libopenvswitch to include MAJOR.MINOR number.

2017-05-04 Thread Ben Pfaff
On Wed, Apr 26, 2017 at 04:08:01PM -0700, Joe Stringer wrote: > I have recently been looking into backporting a fix for variable-length > metadata fields from master to branch-2.7. Unfortunately, the fix makes > several > changes to libopenvswitch APIs, in particular some files under > include/ope

Re: [ovs-dev] [PATCH v3 4/4] Documentation: Add an OVN tutorial for OpenStack.

2017-05-04 Thread Andy Zhou
On Thu, May 4, 2017 at 1:01 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou It is good to go. Thanks. > --- > Documentation/automake.mk |1 + > Documentation/tutorials/index.rst |1 + > Documentation/tutorials/ovn-openstack.rst | 1922 > +

Re: [ovs-dev] [PATCH v3 1/4] ovn-trace: Add support for partial UUID matches for ports and datapaths.

2017-05-04 Thread Andy Zhou
On Thu, May 4, 2017 at 1:01 PM, Ben Pfaff wrote: > This makes ovn-trace commands easier to type. > > Signed-off-by: Ben Pfaff Thanks for the change. Acked-by: Andy Zhou > --- > ovn/utilities/ovn-trace.c | 55 > +++ > 1 file changed, 46 insertions(+

Re: [ovs-dev] ovsdb-idl: Need details/examples on one of the comment mentioned in ovsdb-idl.h

2017-05-04 Thread Ben Pfaff
Yes. The effects of a transaction are visible to the client that is constructing it, in the process of constructing it. On Thu, May 04, 2017 at 08:00:07AM +0530, Arunkumar Rg wrote: > Say there is a client using ovsdb-idl for all transactions and reading data > from ovsdb-server's db. Now the cli

Re: [ovs-dev] [PATCH v2 11/13] ovn-trace: Accept human-friendly logical port and datapath names.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 10:48:58AM -0700, Ben Pfaff wrote: > On Thu, May 04, 2017 at 02:01:03AM -0700, Andy Zhou wrote: > > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > > This allows the user to specify these names in a natural way, e.g. > > > "ovn-trace myswitch 'inport == "myport"' inste

[ovs-dev] [PATCH v3 4/4] Documentation: Add an OVN tutorial for OpenStack.

2017-05-04 Thread Ben Pfaff
Signed-off-by: Ben Pfaff Acked-by: Andy Zhou --- Documentation/automake.mk |1 + Documentation/tutorials/index.rst |1 + Documentation/tutorials/ovn-openstack.rst | 1922 + 3 files changed, 1924 insertions(+) create mode 100644 Documen

[ovs-dev] [PATCH v3 3/4] ovn-trace: Display friendlier port and datapath names.

2017-05-04 Thread Ben Pfaff
This makes ovn-trace use short name instead of UUIDs (etc.) in its own output, by default. Since it's possible that there's software out there parsing ovn-trace output, it also adds a --no-friendly-names option. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou --- ovn/utilities/ovn-trace.8.xml |

[ovs-dev] [PATCH v3 2/4] ovn-trace: Accept human-friendly logical port and datapath names.

2017-05-04 Thread Ben Pfaff
This allows the user to specify these names in a natural way, e.g. "ovn-trace myswitch 'inport == "myport"' instead of having to specify whatever UUID or other horrible name the CMS invented. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 26 -- 1 file changed,

[ovs-dev] [PATCH v3 0/4] Add OVN tutorial for OpenStack

2017-05-04 Thread Ben Pfaff
This is what I'm planning to present at OpenStack Boston. The tutorial itself is pretty simple; I spent most of the time working on it either trying to figure how to do things in OpenStack or figuring out ways to improve the OVN utilities that make them easier to use in an OpenStack environment.

[ovs-dev] [PATCH v3 1/4] ovn-trace: Add support for partial UUID matches for ports and datapaths.

2017-05-04 Thread Ben Pfaff
This makes ovn-trace commands easier to type. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 55 +++ 1 file changed, 46 insertions(+), 9 deletions(-) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 860fd4b26be0..f89d

Re: [ovs-dev] [PATCH v2 12/13] ovn-trace: Display friendlier port and datapath names.

2017-05-04 Thread Andy Zhou
On Thu, May 4, 2017 at 10:55 AM, Ben Pfaff wrote: > On Thu, May 04, 2017 at 02:37:43AM -0700, Andy Zhou wrote: >> On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: >> > This makes ovn-trace use short name instead of UUIDs (etc.) in its own >> > output, by default. Since it's possible that there's

Re: [ovs-dev] [PATCH v4 2/7] userspace: Support for push_eth and pop_eth actions

2017-05-04 Thread Joe Stringer
On 4 May 2017 at 12:51, Joe Stringer wrote: > On 4 May 2017 at 11:13, Jiri Benc wrote: >> On Thu, 4 May 2017 10:02:22 +, Zoltán Balogh wrote: >>> I'm afraid the kernel would not accept that OVS_ACTION_ATTR_PUSH_ETH >>> action in this case. >>> >>> Jiri, could you confirm, please? >> >> It wou

Re: [ovs-dev] [PATCH v4 2/7] userspace: Support for push_eth and pop_eth actions

2017-05-04 Thread Joe Stringer
On 4 May 2017 at 11:13, Jiri Benc wrote: > On Thu, 4 May 2017 10:02:22 +, Zoltán Balogh wrote: >> I'm afraid the kernel would not accept that OVS_ACTION_ATTR_PUSH_ETH >> action in this case. >> >> Jiri, could you confirm, please? > > It would accept it and it would ignore the eth_type field. T

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 11:14:01AM -0700, Han Zhou wrote: > On Thu, May 4, 2017 at 10:58 AM, Ben Pfaff wrote: > > > > On Thu, May 04, 2017 at 10:34:38AM -0700, Han Zhou wrote: > > > On Thu, May 4, 2017 at 10:05 AM, Ben Pfaff wrote: > > > > > > > > On Wed, May 03, 2017 at 11:43:15PM -0700, Han Zho

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-04 Thread Han Zhou
On Thu, May 4, 2017 at 10:58 AM, Ben Pfaff wrote: > > On Thu, May 04, 2017 at 10:34:38AM -0700, Han Zhou wrote: > > On Thu, May 4, 2017 at 10:05 AM, Ben Pfaff wrote: > > > > > > On Wed, May 03, 2017 at 11:43:15PM -0700, Han Zhou wrote: > > > > On Wed, May 3, 2017 at 4:55 PM, Ben Pfaff wrote: > >

Re: [ovs-dev] [PATCH v4 2/7] userspace: Support for push_eth and pop_eth actions

2017-05-04 Thread Jiri Benc
On Thu, 4 May 2017 10:02:22 +, Zoltán Balogh wrote: > I'm afraid the kernel would not accept that OVS_ACTION_ATTR_PUSH_ETH > action in this case. > > Jiri, could you confirm, please? It would accept it and it would ignore the eth_type field. The kernel does not verify whether netlink attribut

Re: [ovs-dev] 答复: Re: [PATCH] ovn-controller: Support vxlan tunnel in ovn

2017-05-04 Thread Russell Bryant
ovn-controller-vtep is discussed in the "Life Cycle of a VTEP Gateway" section in ovn-architecture(7). http://openvswitch.org/support/dist-docs/ovn-architecture.7.html On Thu, May 4, 2017 at 12:41 PM, Ben Pfaff wrote: > OVS already has a VXLAN hardware switch story via ovn-controller-vtep. > > O

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 10:34:38AM -0700, Han Zhou wrote: > On Thu, May 4, 2017 at 10:05 AM, Ben Pfaff wrote: > > > > On Wed, May 03, 2017 at 11:43:15PM -0700, Han Zhou wrote: > > > On Wed, May 3, 2017 at 4:55 PM, Ben Pfaff wrote: > > > > > > > > On Wed, May 03, 2017 at 07:42:46PM -0400, Russell

Re: [ovs-dev] [PATCH v2 13/13] Documentation: Add an OVN tutorial for OpenStack.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 03:03:28AM -0700, Andy Zhou wrote: > On Wed, May 3, 2017 at 8:46 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > Acked-by: Andy Zhou > > git am complained about white spaces. > > Applying: Documentation: Add an OVN tutorial for OpenStack. > /home/azhou/projs/ovs-

Re: [ovs-dev] [PATCH v2 12/13] ovn-trace: Display friendlier port and datapath names.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 02:37:43AM -0700, Andy Zhou wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > This makes ovn-trace use short name instead of UUIDs (etc.) in its own > > output, by default. Since it's possible that there's software out there > > parsing ovn-trace output, it als

Re: [ovs-dev] [PATCH v2 11/13] ovn-trace: Accept human-friendly logical port and datapath names.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 02:01:03AM -0700, Andy Zhou wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > This allows the user to specify these names in a natural way, e.g. > > "ovn-trace myswitch 'inport == "myport"' instead of having to specify > > whatever UUID or other horrible name th

Re: [ovs-dev] [PATCH v2 10/13] ovn-trace: Add support for partial UUID matches for ports and datapaths.

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 01:53:31AM -0700, Andy Zhou wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > This makes ovn-trace commands easier to type. > > > > Signed-off-by: Ben Pfaff > > --- > > ovn/utilities/ovn-trace.c | 44 > > 1 file cha

Re: [ovs-dev] [PATCH v2 09/13] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-04 Thread Ben Pfaff
On Wed, May 03, 2017 at 06:43:32PM -0700, Mickey Spiegel wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > > Without this support, ovn-trace is not very useful with OpenStack, which > > uses connection tracking extensively. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Mickey S

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-04 Thread Han Zhou
On Thu, May 4, 2017 at 10:05 AM, Ben Pfaff wrote: > > On Wed, May 03, 2017 at 11:43:15PM -0700, Han Zhou wrote: > > On Wed, May 3, 2017 at 4:55 PM, Ben Pfaff wrote: > > > > > > On Wed, May 03, 2017 at 07:42:46PM -0400, Russell Bryant wrote: > > > > On Wed, May 3, 2017 at 11:45 AM, Ben Pfaff wrot

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-04 Thread Ben Pfaff
Yes, I'm in favor of having generic names available. On Thu, May 04, 2017 at 09:49:30AM +0200, Miguel Angel Ajo Pelayo wrote: > Isn't neutron:network_name and neutron:router_name very openstack specific? > > May we introduce more generic names in a way that other systems could > eventually use th

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-04 Thread Ben Pfaff
On Wed, May 03, 2017 at 11:43:15PM -0700, Han Zhou wrote: > On Wed, May 3, 2017 at 4:55 PM, Ben Pfaff wrote: > > > > On Wed, May 03, 2017 at 07:42:46PM -0400, Russell Bryant wrote: > > > On Wed, May 3, 2017 at 11:45 AM, Ben Pfaff wrote: > > > > It's much easier to see what's going on in the south

[ovs-dev] naming ports and networks in OVN (was: Re: [PATCH v2 01/13] ovn-northd: Propagate Neutron port names to southbound database.)

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 10:01:00AM +0200, Miguel Angel Ajo Pelayo wrote: > Relates to previous comments: would it make sense to use a more generic > name instead of 'neutron' to avoid coupling to one solution? Yes. The situation we have now, for Logical_Switch, is that "name" is a unique identifi

Re: [ovs-dev] [PATCH] datapath: backport: vxlan: do not output confusing error message

2017-05-04 Thread Joe Stringer
On 3 May 2017 at 19:05, Pravin B Shelar wrote: > From: Jiri Benc > > Upstream commit: > commit baf4d7860771287f30fbe9b6b2dc18b04361439d > Author: Jiri Benc > Date: Thu Apr 27 21:24:36 2017 +0200 > > vxlan: do not output confusing error message > > The message "Cannot bind p

Re: [ovs-dev] 答复: Re: [PATCH] ovn-controller: Support vxlan tunnel in ovn

2017-05-04 Thread Ben Pfaff
OVS already has a VXLAN hardware switch story via ovn-controller-vtep. On Thu, May 04, 2017 at 07:51:01PM +0800, wang.qia...@zte.com.cn wrote: > In most telecom carriers network architecture, they may demand hardware > switches for performance consideration. > The network architecture is as follo

Re: [ovs-dev] [PATCH ovs V8 01/26] tc: Add tc flower interface

2017-05-04 Thread Simon Horman
On Wed, May 03, 2017 at 06:07:52PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add tc flower interface that will be used to offload flows via tc > flower classifier. Depending on the flag used (skip_sw/hw) flower > will pass those to HW or handle them itself. > Move some tc related functions

Re: [ovs-dev] [PATCH v5 0/6] ovn: Add IPv6 Router Solicitation responder support

2017-05-04 Thread Aaron Conole
Hi Numan, nusid...@redhat.com writes: > From: Numan Siddique > > I have picked up the patch series authored by Zong Kai LI to support IPv6 > Router Advertisement in ovn - > https://mail.openvswitch.org/pipermail/ovs-dev/2016-October/242988.html > as this patch series was inactive for quite a lon

[ovs-dev] [PATCH v5 6/6] ovn-northd: Add IPv6 RS responder support

2017-05-04 Thread nusiddiq
From: Zong Kai LI This patch adds logical flows for IPv6 Router Advertisements in reply to the IPv6 Router Solicitation requests. It uses the actions "nd_ra", "put_nd_ra_mode", "put_nd_opt_mtu" and "put_nd_opt_prefix". These logical flows are added in the new ingress stage "lr_in_rs_rsp" in the l

[ovs-dev] [PATCH v5 5/6] ovn-controller: add 'put_nd_ra_addr_mode' and 'put_nd_opt_*' actions support

2017-05-04 Thread nusiddiq
From: Zong Kai LI This patch adds action 'nd_ra' specific inner actions 'put_nd_ra_addr_mode', 'put_nd_opt_prefix', 'put_nd_opt_mtu' and 'put_nd_opt_sll'. Action put_nd_ra_addr_mode takes the RA address mode as argument and sets the address configuration field in the Router Advertisement (RA) IP

[ovs-dev] [PATCH v5 4/6] ovn-controller: add 'nd_ra' action

2017-05-04 Thread nusiddiq
From: Zong Kai LI This patchs add a new action 'nd_ra' against current 'nd_na' action, to work as a Router Solicitation packet responder. The inner actions to set fields, flags, options in RA packet will be introduced in the following patch. Signed-off-by: Zongkai LI Signed-off-by: Numan Siddiq

[ovs-dev] [PATCH v5 3/6] ovn: extend expr symbols for ND

2017-05-04 Thread nusiddiq
From: Zong Kai LI This patch updates symbols in logical-fields for ND, such as "nd", "nd.target", "nd.sll", "nd.tll", to describe more clear about "icmp6.type" predicate. It adds new symbols: - "nd_rs" stands for Router Solicitation message, - "nd_ra" stands for Router Advertisement message, S

[ovs-dev] [PATCH v5 2/6] lib: rename ovs_nd_opt to ovs_nd_lla_opt

2017-05-04 Thread nusiddiq
From: Zong Kai LI Since ovs_nd_mtu_opt and ovs_nd_prefix_opt is introducted, rename ovs_nd_opt to ovs_nd_lla_opt to specify it's Source/Target Link-layer Address Option. Signed-off-by: Zongkai LI Signed-off-by: Numan Siddique --- lib/flow.c| 38 ++--- lib/odp-e

[ovs-dev] [PATCH v5 1/6] packets: add compose_nd_ra

2017-05-04 Thread nusiddiq
From: Zong Kai LI This patch introduces methods to compose a Router Advertisement (RA) packet, introduces flags for RA. RA packet composed structures against specification in RFC4861. Caller can use compse_nd_ra_with_sll_mtu_opts to compose a RA packet with Source Link-layer Address Option and M

[ovs-dev] [PATCH v5 0/6] ovn: Add IPv6 Router Solicitation responder support

2017-05-04 Thread nusiddiq
From: Numan Siddique I have picked up the patch series authored by Zong Kai LI to support IPv6 Router Advertisement in ovn - https://mail.openvswitch.org/pipermail/ovs-dev/2016-October/242988.html as this patch series was inactive for quite a long time. v4 -> v5 Rebased the patches t

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

2017-05-04 Thread William Tu
On Thu, May 4, 2017 at 4:39 AM, Zoltán Balogh wrote: >> I think that what's happening is that when build_tunnel_send() >> serializes the ODP action for push_tunnel, it doesn't update the >> 'flow' to reflect the new encapsulated state of the packet. Then, when >> calling apply_nested_clone_actions

Re: [ovs-dev] [PATCH] tests/ofproto.at: Workaround some races

2017-05-04 Thread Ben Pfaff
On Thu, May 04, 2017 at 12:37:41PM +0200, Timothy M. Redaelli wrote: > On 05/03/2017 10:28 PM, Ben Pfaff wrote: > > On Thu, Apr 27, 2017 at 05:24:22PM +0200, Timothy Redaelli wrote: > >> Port commit a6d1a2997db4: > >> ofproto.at: Workaround a race > >> > >> While a barrier serializes reques

[ovs-dev] [PATCH v3] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-05-04 Thread Billy O'Mahony
From: billyom Previously if there is no available (non-isolated) pmd on the numa node for a port then the port is not polled at all. This can result in a non-operational system until such time as nics are physically repositioned. It is preferable to operate with a pmd on the 'wrong' numa node alb

Re: [ovs-dev] [PATCH v2] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-05-04 Thread O Mahony, Billy
Hi Ian, > -Original Message- > From: Stokes, Ian > Sent: Thursday, May 4, 2017 2:19 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v2] dpif-netdev: Assign ports to pmds on non- > local numa node. > > > Hi Ian, > > > > Sorry for delay responding. Some comme

Re: [ovs-dev] [PATCH v2] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-05-04 Thread Stokes, Ian
> Hi Ian, > > Sorry for delay responding. Some comment below. > > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > boun...@openvswitch.org] On Behalf Of O Mahony, Billy > > Sent: Tuesday, April 25, 2017 11:15 AM > > To: Stokes, Ian ; d...@openvswitch.org

Re: [ovs-dev] [PATCH v4 2/7] userspace: Support for push_eth and pop_eth actions

2017-05-04 Thread Yang, Yi Y
Zoltan, original l3 userspace patch set gets ether_type from packet->md. eh->eth_type = packet->md.packet_ethertype; I think we should keep struct ovs_action_push_eth consistent in both kernel and userspace, we can use the way in original l3 userspace patch set to get ether_type. -Original

[ovs-dev] 答复: Re: [PATCH] ovn-controller: Support vxlan tunnel in ovn

2017-05-04 Thread wang . qianyu
In most telecom carriers network architecture, they may demand hardware switches for performance consideration. The network architecture is as follow: --- | ovn-sb | --- || || -- -

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

2017-05-04 Thread Zoltán Balogh
> I think that what's happening is that when build_tunnel_send() > serializes the ODP action for push_tunnel, it doesn't update the > 'flow' to reflect the new encapsulated state of the packet. Then, when > calling apply_nested_clone_actions() it performs lookup in the second > bridge using the unm

Re: [ovs-dev] [PATCH] tests/ofproto.at: Workaround some races

2017-05-04 Thread Timothy M. Redaelli
On 05/03/2017 10:28 PM, Ben Pfaff wrote: > On Thu, Apr 27, 2017 at 05:24:22PM +0200, Timothy Redaelli wrote: >> Port commit a6d1a2997db4: >> ofproto.at: Workaround a race >> >> While a barrier serializes requests from the same connection, >> it doesn't wait for requests from other conne

Re: [ovs-dev] [PATCH v2 13/13] Documentation: Add an OVN tutorial for OpenStack.

2017-05-04 Thread Andy Zhou
On Wed, May 3, 2017 at 8:46 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou git am complained about white spaces. Applying: Documentation: Add an OVN tutorial for OpenStack. /home/azhou/projs/ovs-review/ovs/.git/rebase-apply/patch:251: trailing whitespace. See /home/azh

Re: [ovs-dev] [PATCH v4 2/7] userspace: Support for push_eth and pop_eth actions

2017-05-04 Thread Zoltán Balogh
> On Tue, Apr 25, 2017 at 04:30:23PM +, Zoltán Balogh wrote: > > From: Jan Scheurich > > > > Add support for actions push_eth and pop_eth to the netdev datapath and > > the supporting libraries. This patch relies on the support for these actions > > in the kernel datapath to be present. > > H

Re: [ovs-dev] [PATCH v2 12/13] ovn-trace: Display friendlier port and datapath names.

2017-05-04 Thread Andy Zhou
On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > This makes ovn-trace use short name instead of UUIDs (etc.) in its own > output, by default. Since it's possible that there's software out there > parsing ovn-trace output, it also adds a --no-friendly-names option. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

2017-05-04 Thread Kavanagh, Mark B
>在 2017年5月3日,下午11:37,Kavanagh, Mark B 写道: > >>> >>> From: Michael Qiu >>> >>> When doing packet clone, if packet source is from DPDK driver, >>> multi-segment must be considered, and copy the segment's >>> data one by one. >>> >>> Signed-off-by: Michael Qiu >>> --- >>> lib/dp-packet.c | 27 +

Re: [ovs-dev] [PATCH 0/5 v2] DPDK multi-segment mbuf support

2017-05-04 Thread Kavanagh, Mark B
> > > >Thanks, >Michael >在 2017年5月3日,下午11:28,Kavanagh, Mark B 写道: > >>> >>> Currently, OVS only support DPDK single segment mbuf, >>> it could lead problems, like a large non-DPDK source >>> packet transmit to dpdk port. >>> >>> Also, OVS doesn't copy enough info in mbuf when do >>> packet copy. >

Re: [ovs-dev] [PATCH v2 11/13] ovn-trace: Accept human-friendly logical port and datapath names.

2017-05-04 Thread Andy Zhou
On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > This allows the user to specify these names in a natural way, e.g. > "ovn-trace myswitch 'inport == "myport"' instead of having to specify > whatever UUID or other horrible name the CMS invented. > > Signed-off-by: Ben Pfaff > --- > ovn/utilitie

Re: [ovs-dev] [PATCH v2 10/13] ovn-trace: Add support for partial UUID matches for ports and datapaths.

2017-05-04 Thread Andy Zhou
On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > This makes ovn-trace commands easier to type. > > Signed-off-by: Ben Pfaff > --- > ovn/utilities/ovn-trace.c | 44 > 1 file changed, 36 insertions(+), 8 deletions(-) > > diff --git a/ovn/utilities/ovn

Re: [ovs-dev] [RFC] [PATCH 3/6] port_group: bridge: set port_group in port config

2017-05-04 Thread Darrell Ball
On 4/3/17, 2:40 AM, "ovs-dev-boun...@openvswitch.org on behalf of Matthias May" wrote: Signed-off-by: Matthias May --- vswitchd/bridge.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 867a26d8d..316e474

Re: [ovs-dev] [RFC] [PATCH 0/6] Add port_group to prevent loopback between interfaces

2017-05-04 Thread Darrell Ball
On 4/3/17, 2:40 AM, "ovs-dev-boun...@openvswitch.org on behalf of Matthias May" wrote: When using openvswitch in combination with a hardware switch attached via dsa it may be desirable to prevent frames from being looped back to interfaces which reside on the same switch and are a

Re: [ovs-dev] [PATCH v2 01/13] ovn-northd: Propagate Neutron port names to southbound database.

2017-05-04 Thread Miguel Angel Ajo Pelayo
Relates to previous comments: would it make sense to use a more generic name instead of 'neutron' to avoid coupling to one solution? On May 3, 2017 11:57 PM, "Andy Zhou" wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > This makes it possible for southbound utilities to use friendli

Re: [ovs-dev] [PATCH v2 06/13] ovn-sbctl: Add --ovs option to "lflow-list", for listing OpenFlow flows.

2017-05-04 Thread Miguel Angel Ajo Pelayo
Very nice addition :) On May 4, 2017 1:19 AM, "Ben Pfaff" wrote: > On Wed, May 03, 2017 at 03:59:52PM -0700, Andy Zhou wrote: > > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > > This is like the --ovs option to ovn-trace, but it applies to every > flow > > > dumped, so it has different a

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-04 Thread Miguel Angel Ajo Pelayo
Isn't neutron:network_name and neutron:router_name very openstack specific? May we introduce more generic names in a way that other systems could eventually use them too? On May 4, 2017 8:43 AM, "Han Zhou" wrote: > On Wed, May 3, 2017 at 4:55 PM, Ben Pfaff wrote: > > > > On Wed, May 03, 2017 a

Re: [ovs-dev] [PATCH] tests: Only run python SSL test if SSL support is configured

2017-05-04 Thread Simon Horman
On Wed, May 03, 2017 at 10:56:39AM -0700, Ben Pfaff wrote: > On Wed, May 03, 2017 at 05:55:51PM +0200, Simon Horman wrote: > > Only run python SSL test, which invokes ovsdb with a --remote=pssl, > > if SSL support is configured. > > > > Without this change the following error appears when running