It's becoming more common that OSes include "ip" but not "ifconfig", so
it's best to avoid using the latter. This commit removes most references
to "ifconfig" and replaces them by "ip". It also adds a build-time check
to make it harder to introduce new uses of "ifconfig".
Signed-off-by: Ben Pfaf
On Thu, May 25, 2017 at 03:48:22PM -0700, Joe Stringer wrote:
> On 25 May 2017 at 13:54, Ben Pfaff wrote:
> > It's becoming more common that OSes include "ip" but not "ifconfig", so
> > it's best to avoid using the latter. This commit removes most references
> > to "ifconfig" and replaces them by
On Tue, May 23, 2017 at 03:13:08PM +0200, Daniel Alvarez Sanchez wrote:
> On Tue, May 23, 2017 at 10:01 AM, Miguel Angel Ajo Pelayo <
> majop...@redhat.com> wrote:
>
> > If we forsee use cases with several local ports by logical switch/chassis
> > could one option be to allocate a bit in REG10 to
On Thu, 2017-05-25 at 09:53 -0700, Greg Rose wrote:
> On Mon, 2017-05-22 at 07:40 -0700, Greg Rose wrote:
> > On Mon, 2017-05-22 at 12:55 +0800, Yunjian Wang wrote:
> > > The memory leak was triggered each time on calling netflow_unref() with
> > > containing netflow_flows. And flows need to be rem
On 5/22/17, 4:44 PM, "ovs-dev-boun...@openvswitch.org on behalf of Joe
Stringer" wrote:
On 20 May 2017 at 11:09, Darrell Ball wrote:
> The checks to populate ct_orig_tuple in miniflow_extract
> includes recirc_id being non-zero. This is changed here
> to populate the ct_orig_
On 5/25/17, 2:04 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Wed, May 24, 2017 at 12:48:24PM +, 王志克 wrote:
> Reading the release note of DPDK section for OVS2.6, I note below:
>
> * Basic connection tracking for the userspace datapath (no AL
Zoltan has done that way.
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org]
Sent: Friday, May 26, 2017 5:00 AM
To: Jan Scheurich
Cc: Yang, Yi Y ; Zoltán Balogh
; 'd...@openvswitch.org'
Subject: Re: [ovs-dev] [PATCH v6 5/5] userspace: add vxlan gpe support to vport
On Mon, May 2
This patch introduces multi-threading for ovn-controller and use
dedicated thread for packet-in processing as a start. It decouples
packet-in processing and ovs flow computing, so that packet-in inputs
won't trigger flow recomputing, and flow computing won't block
packet-in processing. In large sca
Abstract as a function so that it can be used by other modules.
Signed-off-by: Han Zhou
---
ovn/controller/ovn-controller.c | 66 ++---
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-control
This change is to prepare for the future change for multi-threading.
Both binding_run() and get_br_int() are needed by pinctrl thread,
but we don't want to update SB DB or create bridges in that scenario,
so need "readonly" mode for these functions.
Signed-off-by: Han Zhou
---
ovn/controller/bin
We figure out local datapaths in binding_run() but update the field
localnet_port for each local datapath that has localnet port in
patch_run(). This patch updates the localnet_port field in binding_run
directly and removes the logic in patch_run(), since the logic is
more about port-binding proces
This patch series is the first attempt of ovn-controller multi-threading.
The intention is to avoid flow re-computing being triggered by unrelated
input. An obvious example is that packet-in message from vswitchd to
ovn-controller will trigger full round of flow computing before processing
the actu
- Minimum valid fragment size is 400 bytes, any fragment smaller
is likely to be intentionally crafted.
- Validate maximum length of an Ip datagram
- Added counters to keep track of number of fragments for a given
Ip datagram.
Signed-off-by: Anand Kumar
---
datapath-windows/ovsext/Actions.c
On 25 May 2017 at 13:54, Ben Pfaff wrote:
> It's becoming more common that OSes include "ip" but not "ifconfig", so
> it's best to avoid using the latter. This commit removes most references
> to "ifconfig" and replaces them by "ip". It also adds a build-time check
> to make it harder to introdu
On Thu, May 25, 2017 at 1:55 AM, wrote:
> From: Numan Siddique
>
> This patch adds the following functions
> - start_nb_ovsdb, stop_nb_ovsdb, restart_nb_ovsdb to start, stop and
> restart the OVN NB DB ovsdb-server independently.
> - start_sb_ovsdb, stop_sb_ovsdb, restart_sb_ovsdb to sta
On Thu, May 25, 2017 at 02:29:55PM -0400, Aaron Conole wrote:
> Hi Ben,
>
> Ben Pfaff writes:
>
> > Until now, most ovs-ofctl commands have not accepted names for ports, only
> > numbers, and have not been able to display port names either. It's a lot
> > easier for users if they can use and se
On Mon, May 22, 2017 at 11:56:50AM +, Alin Serdean wrote:
> From: Alin Serdean
>
> Gcc compiler argument -Wall contains -Wimplicit-function-declaration which
> gives warnings when a function is used before declared.
> Map VStudio compiler error C4013 to it.
> More info on C4013:
> https://msd
On Sat, May 20, 2017 at 09:01:34PM -0700, Greg Rose wrote:
> On Sat, 2017-05-20 at 16:57 -0700, Ben Pfaff wrote:
> > pinctrl_handle_put_dhcpv6_opts() and pinctrl_handle_dns_lookup() were not
> > checking that a full UDP header was present before reading its udp_len
> > field. This patch fixes the
On Sat, May 20, 2017 at 08:59:39PM -0700, Greg Rose wrote:
> On Sat, 2017-05-20 at 16:41 -0700, Ben Pfaff wrote:
> > msg->size isn't the relevant measurement here because we're only supposed
> > to read 'len' bytes. Reading more than that causes 'len' to underflow to a
> > large number at the end
Avoiding checksum validation in conntrack module if it is already verified
in DPDK physical NIC ports.
Signed-off-by: Sugesh Chandran
---
lib/conntrack.c | 58 -
1 file changed, 37 insertions(+), 21 deletions(-)
diff --git a/lib/conntrack.
On Wed, May 24, 2017 at 12:48:24PM +, 王志克 wrote:
> Reading the release note of DPDK section for OVS2.6, I note below:
>
> * Basic connection tracking for the userspace datapath (no ALG,
>fragmentation or NAT support yet)
>
> I am wondering for the missing part (no ALG, fragmentat
On 25 May 2017 at 13:54, Ben Pfaff wrote:
> On Thu, May 25, 2017 at 01:18:21PM -0700, Joe Stringer wrote:
>> On 25 May 2017 at 10:42, Ben Pfaff wrote:
>> > On Tue, May 23, 2017 at 04:02:15PM -0700, Joe Stringer wrote:
>> >> Clang 4.0 complains:
>> >>
>> >> ../tests/test-hash.c:160:16: error: taki
On 25 May 2017 at 13:55, Ben Pfaff wrote:
> On Thu, May 25, 2017 at 01:08:21PM -0700, Joe Stringer wrote:
>> On 25 May 2017 at 10:36, Ben Pfaff wrote:
>> > On Tue, May 23, 2017 at 04:02:14PM -0700, Joe Stringer wrote:
>> >> When running 256B hash check, we currently iterate from 0 up to and
>> >>
On Mon, May 22, 2017 at 03:10:56PM +, Jan Scheurich wrote:
> I had a similar comment to avoid bit-fields in the nsh_hdr struct in the NSH
> patch series.
> @Yi: Have a look at the restructured nsh.h in my new branch.
>
> I suggest you just add any required vxlan-gpe specific items to the VXLA
On Wed, May 24, 2017 at 08:42:04AM -0600, Raymond Burkholder wrote:
> This probably isn’t an optimal solution, as openvswitch runs on a
> number of different platforms. I am not sure how to perform a proper
> selection of ifconfig vs ip link. But i think I noticed some other
> openvswitch scripts
On Thu, May 25, 2017 at 01:52:16PM -0700, Joe Stringer wrote:
> On 25 May 2017 at 13:35, Ben Pfaff wrote:
> > On Thu, May 25, 2017 at 01:05:11PM -0700, Joe Stringer wrote:
> >> On 24 May 2017 at 20:02, Ben Pfaff wrote:
> >> > On Tue, May 23, 2017 at 04:02:12PM -0700, Joe Stringer wrote:
> >> >> C
On Thu, May 25, 2017 at 01:18:21PM -0700, Joe Stringer wrote:
> On 25 May 2017 at 10:42, Ben Pfaff wrote:
> > On Tue, May 23, 2017 at 04:02:15PM -0700, Joe Stringer wrote:
> >> Clang 4.0 complains:
> >>
> >> ../tests/test-hash.c:160:16: error: taking address of packed member 'b' of
> >> class or s
On Thu, May 25, 2017 at 01:08:21PM -0700, Joe Stringer wrote:
> On 25 May 2017 at 10:36, Ben Pfaff wrote:
> > On Tue, May 23, 2017 at 04:02:14PM -0700, Joe Stringer wrote:
> >> When running 256B hash check, we currently iterate from 0 up to and
> >> including bit 2048, which is beyond the range of
It's becoming more common that OSes include "ip" but not "ifconfig", so
it's best to avoid using the latter. This commit removes most references
to "ifconfig" and replaces them by "ip". It also adds a build-time check
to make it harder to introduce new uses of "ifconfig".
Signed-off-by: Ben Pfaf
On 25 May 2017 at 13:35, Ben Pfaff wrote:
> On Thu, May 25, 2017 at 01:05:11PM -0700, Joe Stringer wrote:
>> On 24 May 2017 at 20:02, Ben Pfaff wrote:
>> > On Tue, May 23, 2017 at 04:02:12PM -0700, Joe Stringer wrote:
>> >> Clang 4.0 complains:
>> >>
>> >> ../lib/odp-execute.c:61:37: error: takin
I know of two reasons to mark a structure as "packed". The first is
because the structure must match some defined interface and therefore
compiler-inserted padding between or after members would cause its layout
to diverge from that interface. This is not a problem in a structure that
follows the
On 21 May 2017 at 21:55, Yunjian Wang wrote:
> The memory leak was triggered each time on calling netflow_unref() with
> containing netflow_flows. And flows need to be removed and destroyed.
>
> Signed-off-by: Yunjian Wang
> ---
Does this also need to netflow_expire__() the flows? Would it make
On Thu, May 25, 2017 at 01:05:11PM -0700, Joe Stringer wrote:
> On 24 May 2017 at 20:02, Ben Pfaff wrote:
> > On Tue, May 23, 2017 at 04:02:12PM -0700, Joe Stringer wrote:
> >> Clang 4.0 complains:
> >>
> >> ../lib/odp-execute.c:61:37: error: taking address of packed member
> >> 'eth_dst' of
> >>
On 25 May 2017 at 13:10, Ben Pfaff wrote:
> On Tue, May 23, 2017 at 05:57:16PM -0700, Joe Stringer wrote:
>> Many standard library functions are wrapped in OVS, so check for usage
>> of the original versions and suggest that authors replace them with the
>> OVS versions.
>>
>> Signed-off-by: Joe S
On 25 May 2017 at 10:42, Ben Pfaff wrote:
> On Tue, May 23, 2017 at 04:02:15PM -0700, Joe Stringer wrote:
>> Clang 4.0 complains:
>>
>> ../tests/test-hash.c:160:16: error: taking address of packed member 'b' of
>> class or structure 'offset_ovs_u128' may result in an unaligned pointer value
>>
On Tue, May 23, 2017 at 05:57:16PM -0700, Joe Stringer wrote:
> Many standard library functions are wrapped in OVS, so check for usage
> of the original versions and suggest that authors replace them with the
> OVS versions.
>
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
__
On 25 May 2017 at 10:36, Ben Pfaff wrote:
> On Tue, May 23, 2017 at 04:02:14PM -0700, Joe Stringer wrote:
>> When running 256B hash check, we currently iterate from 0 up to and
>> including bit 2048, which is beyond the range of bits that 256B holds.
>> For bit 2048, set_bit128() doesn't set a bit
On 24 May 2017 at 20:02, Ben Pfaff wrote:
> On Tue, May 23, 2017 at 04:02:12PM -0700, Joe Stringer wrote:
>> Clang 4.0 complains:
>>
>> ../lib/odp-execute.c:61:37: error: taking address of packed member 'eth_dst'
>> of
>> class or structure 'eth_header' may result in an unaligned pointer value
>>
On 25 May 2017 at 04:00, wrote:
> From: Antonio Fischetti
>
> With conntrack enabled, packets get recirculated and this impacts
> the performance with thousands of active concurrent connections.
>
> This patch is aimed at avoiding recirculation for packets belonging to
> established connections
Joe Stringer writes:
> Many standard library functions are wrapped in OVS, so check for usage
> of the original versions and suggest that authors replace them with the
> OVS versions.
>
> Signed-off-by: Joe Stringer
> ---
> v2: Drop checks for functions that don't replace library functions
>
On Thu, May 25, 2017 at 5:12 AM, Miguel Angel Ajo Pelayo
wrote:
>
>
> On Wed, May 24, 2017 at 7:39 PM, Russell Bryant wrote:
>>
>> On Wed, May 24, 2017 at 7:19 AM, Miguel Angel Ajo Pelayo
>> wrote:
>> > I wanted to share a small status update:
>> >
>> > Anil and I have been working on this [1] a
On Thu, May 25, 2017 at 08:21:11AM -0700, Guru Shetty wrote:
> On 24 May 2017 at 16:51, Flavio Leitner wrote:
>
> > On Tue, May 16, 2017 at 11:05:24AM -0700, Guru Shetty wrote:
> > > On 15 May 2017 at 16:49, Joe Stringer wrote:
> > >
> > > > On 12 May 2017 at 07:45, Timothy Redaelli
> > wrote:
Hi Ben,
Ben Pfaff writes:
> Until now, most ovs-ofctl commands have not accepted names for ports, only
> numbers, and have not been able to display port names either. It's a lot
> easier for users if they can use and see meaningful names instead of
> arbitrary numbers. This commit adds that su
On Tue, May 23, 2017 at 04:02:15PM -0700, Joe Stringer wrote:
> Clang 4.0 complains:
>
> ../tests/test-hash.c:160:16: error: taking address of packed member 'b' of
> class or structure 'offset_ovs_u128' may result in an unaligned pointer value
> [-Werror,-Waddress-of-packed-member]
>
On Tue, May 23, 2017 at 04:02:14PM -0700, Joe Stringer wrote:
> When running 256B hash check, we currently iterate from 0 up to and
> including bit 2048, which is beyond the range of bits that 256B holds.
> For bit 2048, set_bit128() doesn't set a bit due to the range check.
> Simplify the code by
On Fri, May 19, 2017 at 10:48:06AM +0100, Stephen Finucane wrote:
> On Thu, 2017-05-18 at 16:02 -0700, Ben Pfaff wrote:
> > Bravo. This must have been a lot of work.
> >
> > More comments follow...
> >
> > On Wed, May 10, 2017 at 09:32:19PM -0400, Stephen Finucane wrote:
> > > This is the larges
Hi Aaron
Thanks
I see there are 2 approaches as mentioned by you
1. Regarding the first I assume u mean creating another netns and creating
peers between ethwan1 and veth1
Say we have another netns lying outside ovs whose one interface (say veth1
lying inside netns test) is linked to ovs internal
Thanks a lot!
Alin.
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Thursday, May 25, 2017 6:52 PM
To: Alin Serdean
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 3/3] appveyor: Add new make target
On 23 May 2017 at 10:59, Alin Serdean
mailto:aserd...@cloudbasesolutions.com>> wrote:
Th
On Mon, 2017-05-22 at 07:40 -0700, Greg Rose wrote:
> On Mon, 2017-05-22 at 12:55 +0800, Yunjian Wang wrote:
> > The memory leak was triggered each time on calling netflow_unref() with
> > containing netflow_flows. And flows need to be removed and destroyed.
> >
> > Signed-off-by: Yunjian Wang
>
On Mon, May 22, 2017 at 01:43:25PM +, Jan Scheurich wrote:
> > I think that parse_gre_header() should perhaps be pickier about the
> > Ethertypes it accepts, since values below 0x600 are not valid
> > Ethertypes and sometimes they are used for special purposes, for example
> > OpenFlow uses 0x5
From: Antonio Fischetti
With conntrack enabled, packets get recirculated and this impacts
the performance with thousands of active concurrent connections.
This patch is aimed at avoiding recirculation for packets belonging to
established connections in steady state. This is achieved by
manipulat
On 23 May 2017 at 10:59, Alin Serdean
wrote:
> This patch adds the new make target 'datapath_windows_analyze' (static
> analysis over the windows datapath code) to the appveyor build.
>
> Signed-off-by: Alin Gabriel Serdean
>
I applied this series to master
> ---
> appveyor.yml | 1 +
> 1 fi
I think the issue is with my git configuration, sorry for that.
I'll resubmit this patch.
- Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Greg Rose
> Sent: Thursday, May 25, 2017 3:15 PM
> To: ovs-dev@openvswi
From: Georg Schmuecking
This patch is based on the "datapath: enable vxlangpe creation in compat mode"
from Yi Yang. It introduces an extension option "gpe" to the vxlan port in the
netdev-dpdk datapath. Description of vxlan gpe protocoll was added to header
file lib/packets.h. In the vxlan speci
From: Jan Scheurich
Add a boolean "layer3" configuration option for tunnel vports.
The layer3 option defaults to false for all ports except LISP.
GRE ports accept both true and false for "layer3".
A tunnel vport configured with layer3=true receives L3 packets.
which are then converted to Etherne
From: Jan Scheurich
Ports have a new layer3 attribute if they send/receive L3 packets.
The packet_type included in structs dp_packet and flow is considered in
ofproto-dpif. The classical L2 match fields (dl_src, dl_dst, dl_type, and
vlan_tci, vlan_vid, vlan_pcp) now have Ethernet as pre-requisit
From: Jan Scheurich
This patch set is part of an initiative to deal with non-Ethernet packets in
OVS for advanced use cases like L3 tunneling or NSH. The initiative is
centering on the new OpenFlow concepts of "Packet type-aware pipeline" (PTAP)
and "Generic encap/decap actions" (EXT-382). The
On 24 May 2017 at 16:51, Flavio Leitner wrote:
> On Tue, May 16, 2017 at 11:05:24AM -0700, Guru Shetty wrote:
> > On 15 May 2017 at 16:49, Joe Stringer wrote:
> >
> > > On 12 May 2017 at 07:45, Timothy Redaelli
> wrote:
> > > > RHEL 6 is not supported anymore since it uses Python 2.6 and GCC
>
akshay6 agarwal writes:
> Hi All
>
> My objective is to use fast failover using linux nat in OVS but before
> implementing that I am stuck in NAT
> (ip tables) issue.
>
> I have one ovs bridge with 2 lan interface ( 1 virtual interface (ethlan)and
> one physical interface(eth1.4))
> Also added
Hi Pravin,
So far, I have seen 2 bugs related to memory alignment on SPARC. The
fixes are small:
Most of these bugs have small fixes and the location of the fix can
easily be found by running gdb on ovs-vswitchd. Here are the bugs that
have been encountered on SPARC systems so far in OVS 2.7
On Thu, 2017-05-25 at 07:08 -0700, Greg Rose wrote:
> On Thu, 2017-05-25 at 13:36 +, Fischetti, Antonio wrote:
> > This patch doesn't seem to be in Patchwork.
> >
>
> Perhaps because it was sent as RFC?
Hmm... well, I see other RFC's in there. Not sure why it's not showing
up then.
One of
On Thu, 2017-05-25 at 13:36 +, Fischetti, Antonio wrote:
> This patch doesn't seem to be in Patchwork.
>
Perhaps because it was sent as RFC?
- Greg
> > -Original Message-
> > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> > boun...@openvswitch.org] On Behalf Of antonio.fis
Hi All
My objective is to use fast failover using linux nat in OVS but before
implementing that I am stuck in NAT(ip tables) issue.
I have one ovs bridge with 2 lan interface ( 1 virtual interface
(ethlan)and one physical interface(eth1.4))
Also added 2 wan virtual interfaces to ovs bridge(ethwa
The first time after boot, when openvswitch is started by using
--delete-transient-ports-on-boot ovs-ctl option, all transient ports will be
removed.
Signed-off-by: Timothy Redaelli
---
Changed since v1:
* Added --delete-transient-ports-on-boot flag to manpage
utilities/ovs-ctl.8 | 13 +
This patch doesn't seem to be in Patchwork.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of antonio.fische...@intel.com
> Sent: Thursday, May 25, 2017 12:01 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH RFC]
From: Antonio Fischetti
With conntrack enabled, packets get recirculated and this impacts
the performance with thousands of active concurrent connections.
This patch is aimed at avoiding recirculation for packets belonging to
established connections in steady state. This is achieved by
manipulat
NOTE: If you received this message in your SPAM/BULK folder, that is because of
the restrictions implemented by your Internet Service Provider, we (BMW) urge
you to treat it genuinely.
Dear BMW Enthusiast,
This is to inform you that you have been selected for a prize of a brand new
2016 Model
On Wed, May 24, 2017 at 7:39 PM, Russell Bryant wrote:
> On Wed, May 24, 2017 at 7:19 AM, Miguel Angel Ajo Pelayo
> wrote:
> > I wanted to share a small status update:
> >
> > Anil and I have been working on this [1] and we expect to post
> > some preliminary patches before the end of the week.
From: Numan Siddique
This patch adds the following functions
- start_nb_ovsdb, stop_nb_ovsdb, restart_nb_ovsdb to start, stop and
restart the OVN NB DB ovsdb-server independently.
- start_sb_ovsdb, stop_sb_ovsdb, restart_sb_ovsdb to start, stop and
restart the OVN SB DB ovsdb-server i
69 matches
Mail list logo
