Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

2017-08-28 Thread Yang, Yi
On Tue, Aug 29, 2017 at 07:31:22AM +0800, Jan Scheurich wrote: > Hi Yi, > > Thanks for the fixes. Please find my individual comments inline. > > BR, Jan > > > -Original Message- > > -#define OVS_ENCAP_NSH_MAX_MD_LEN 16 > > /* > > * struct ovs_action_encap_nsh - %OVS_ACTION_ATTR_ENCAP_

[ovs-dev] [RFC] Deploy HA for Ovn-controller-vtep

2017-08-28 Thread wang . qianyu
Hi everyone Ovn-controller-vtep is the link of logical switch and pysical switch. Whether we should deploy the Ovn-controller-vtep and vtep db with HA? Thanks. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-

[ovs-dev] [PATCH 2/2] tests/odp: Add set vlan test to odp testsuite

2017-08-28 Thread Roi Dayan
From: Paul Blakey We support parsing set(vlan(vid,pcp,cfi)) so let's test it. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- tests/odp.at | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/odp.at b/tests/odp.at index 0e8cbed..cd01b32 100644 --- a/tests/odp.at +++ b/tests/od

[ovs-dev] [PATCH 0/2] fix odp parsing of set masked action

2017-08-28 Thread Roi Dayan
Hi, The first commit is a fix for parsing set masked action and the second commit is adding a test. Before the fix the addtion of the tests fails with the following: # make check TESTSUITEFLAGS=436 # ./tests/ovstest test-odp parse-actions < ./tests/testsuite.dir/0436/actions.txt > outact && diff

[ovs-dev] [PATCH 1/2] lib/odp: Fix handling of set masked action in parse_odp_action

2017-08-28 Thread Roi Dayan
From: Paul Blakey If we find that we need to change from a SET to SET_MASKED action, then we write the mask to the actions opfbuf. But if there was netlink pad added to the buffer when writing the key, mask won't follow the key data as per SET_MASKED spec. Fix that by removing the padding before

[ovs-dev] [PATCH] netdev-tc-offloads: Fix offloading when tunnel id is 0

2017-08-28 Thread Roi Dayan
From: Paul Blakey Currently we test the tunnel id value and not the mask so matching on tunnel id 0 is skipped and we fail to offload the rule with an unknown attribute error. Fix this by testing the mask of tunnel id instead. Fixes: 8f283af89298 ("netdev-tc-offloads: Implement netdev flow put

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-28 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal Sent: Monday, August 28, 2017 4:56 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries The current implementation lack

[ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-28 Thread Sairam Venugopal
The current implementation lacked an upper bound of number of entries in the system. Set the size to ~2M (2^21) for the time being. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 6 ++ datapath-windows/ovsext/Conntrack.h | 1 + 2 files changed, 7 insertions(+) dif

Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

2017-08-28 Thread Jan Scheurich
Hi Yi, Thanks for the fixes. Please find my individual comments inline. BR, Jan > -Original Message- > -#define OVS_ENCAP_NSH_MAX_MD_LEN 16 > /* > * struct ovs_action_encap_nsh - %OVS_ACTION_ATTR_ENCAP_NSH > * @flags: NSH header flags. > + * @ttl: NSH header TTL. > * @mdtype: NSH

[ovs-dev] The HetNet Ecosystem (Small Cells, Carrier Wi-Fi, C-RAN & DAS): 2017 – 2030

2017-08-28 Thread James Bennett
The HetNet Ecosystem (Small Cells, Carrier Wi-Fi, C-RAN & DAS): 2017 – 2030 – Opportunities, Challenges, Strategies & Forecasts Report Information Release Year: 2017 Number of Pages: 1,000 Number of Figures: 271 Report Overview Driven by the growing demand for in-building wireless coverage an

Re: [ovs-dev] [PATCH v3 2/2] rhel: delete transient ports on boot when starting ovsdb-server

2017-08-28 Thread Aaron Conole
"Timothy M. Redaelli" writes: > On 08/11/2017 07:12 PM, Aaron Conole wrote: >> Timothy Redaelli writes: >> >>> Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server. >>> >>> This feature can be disabled by appending >>> --no-delete-transient-ports-on-boot >>> to OPTIONS in /etc/sy

Re: [ovs-dev] Improved Packet Drop Statistics in OVS

2017-08-28 Thread Darrell Ball
Hi Rohith Thanks for the improvement proposal and writeup. I wonder if it possible to divide the document by pipeline stage and type somehow – like receive drops, flow processing drops and transmit drops. Flow processing drops due to xlate processing error drops, explicit openflow drop and reso

Re: [ovs-dev] [RFC PATCH 1/2] sflow: introduce egress flow sampling

2017-08-28 Thread Neil McKee
If you add an egress sampling action like this it ends up violating the sFlow spec. To understand why, first see this thread back in 2013 when we switched from per-interface datasources to per-bridge datasources: https://mail.openvswitch.org/pipermail/ovs-dev/2013-April/270575.html Having the p

[ovs-dev] [PATCH, RFC] tests: Add a default timeout for control utilities

2017-08-28 Thread Alin Gabriel Serdean
Let's suppose that ovsdb-server is running properly, but ovs-vswitchd is not responsive/crashed. We try to add a port via ovs-vsctl and it will hang. This patch aims at that scenario and tries to make life easier when debugging hanging tests. Some shells do not allow dashes in function names (defa

Re: [ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

2017-08-28 Thread Stokes, Ian
> Force 64-bit arithmetic to be used when converting uint32_t rate and burst > parameters from kilobits per second to bytes per second, avoiding > incorrect behavior for rates exceeding UINT_MAX bits per second. > Good catch Lance, thanks for the fix. Acked-by: ian.sto...@intel.com Tested-by: ia

[ovs-dev] [PATCH] sparse: eliminate "duplicate initialization" warning

2017-08-28 Thread Lance Richardson
Sparse version 0.5.1 will be released in the near future. Prepare for it by eliminating the only new warning (as of 0.5.1-rc5): ofproto/fail-open.c:134:22: error: Initializer entry defined twice ofproto/fail-open.c:135:22: also defined here MATCH_CATCHALL_INITIALIZER effectively sets all fields

Re: [ovs-dev] [PATCH v6 5/6] dpif-netdev: Change pmd selection order.

2017-08-28 Thread Ilya Maximets
> Up to his point rxqs are sorted by processing cycles they > consumed and assigned to pmds in a round robin manner. > > Ian pointed out that on wrap around the most loaded pmd will be > the next one to be assigned an additional rxq and that it would be > better to reverse the pmd order when wrapa

Re: [ovs-dev] [PATCH v6 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

2017-08-28 Thread Ilya Maximets
> Previously rxqs were assigned to pmds by round robin in > port/queue order. > > Now that we have the processing cycles used for existing rxqs, > use that information to try and produced a better balanced > distribution of rxqs across pmds. i.e. given multiple pmds, the > rxqs which have consumed

Re: [ovs-dev] [PATCH v6 3/6] dpif-netdev: Count the rxq processing cycles for an rxq.

2017-08-28 Thread Ilya Maximets
> Count the cycles used for processing an rxq during the > pmd rxq interval. As this is an in flight counter and > pmds run independently, also store the total cycles used > during the last full interval. > > Signed-off-by: Kevin Traynor > --- > lib/dpif-netdev.c | 75 >

Re: [ovs-dev] [PATCH v6 2/6] dpif-netdev: Add rxq processing cycle counters.

2017-08-28 Thread Ilya Maximets
> Add counters to dp_netdev_rxq which will later be used for storing the > processing cycles of an rxq. Processing cycles will be stored in reference > to a defined time interval. We will store the cycles of the current in > progress > interval, a number of completed intervals and the sum of the c

Re: [ovs-dev] [PATCH v3 2/2] rhel: delete transient ports on boot when starting ovsdb-server

2017-08-28 Thread Timothy M. Redaelli
On 08/11/2017 07:12 PM, Aaron Conole wrote: > Timothy Redaelli writes: > >> Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server. >> >> This feature can be disabled by appending --no-delete-transient-ports-on-boot >> to OPTIONS in /etc/sysconfig/openvswitch >> >> Signed-off-by: Timo

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

2017-08-28 Thread Stokes, Ian
Hi Zhenyu, Sincere apologies for the delay, I’ll be reviewing the patch this week and hope to have feedback by Friday for you. If you could rebase that would be helpful for testing. Thanks Ian From: Gao Zhenyu [mailto:sysugaozhe...@gmail.com] Sent: Friday, August 18, 2017 2:28 AM To: Stokes, I

Re: [ovs-dev] [PATCH v4 3/3] nsh: add dec_nsh_ttl action

2017-08-28 Thread Jan Scheurich
> -Original Message- > From: Yi Yang [mailto:yi.y.y...@intel.com] > > +static bool > +compose_dec_nsh_ttl_action(struct xlate_ctx *ctx) { > +struct flow *flow = &ctx->xin->flow; > + > +if ((flow->packet_type == htonl(PT_NSH)) || > +(flow->dl_type == htons(ETH_TYPE_NSH))) {

Re: [ovs-dev] [PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len

2017-08-28 Thread Jan Scheurich
> static inline uint16_t > nsh_hdr_len(const struct nsh_hdr *nsh) > { > -return 4 * (ntohs(nsh->ver_flags_len) & NSH_LEN_MASK) >> > NSH_LEN_SHIFT; > +return ((ntohs(nsh->ver_flags_len) & NSH_LEN_MASK) >> > + NSH_LEN_SHIFT) << 2; > } > Why do you not just add the missing braces? retur

Re: [ovs-dev] [RFC PATCH v1 1/3] vswitch.xml: Detail ipsec user interface.

2017-08-28 Thread Stokes, Ian
> On 18 May 2017 at 02:15, Ian Stokes wrote: > > This commit adds details to the vswitch xml regarding the use of the > > ipsec interface type. This patch is not intended for upstreaming and > > simply seeks to solicit feedback on the user interface design of the > > ipsec port type as described i

[ovs-dev] For Mutual Benefit

2017-08-28 Thread Mr. Peter
Dear Beneficiary I am Peter Douglas Director Inspection Unit United Nations Inspection Agent in Hartsfield–Jackson Atlanta International Airport Atlanta GA. We are rounding up for the second Quater of the auditing, all abandom Consignment in US Airports are being transfer to our facilities here

[ovs-dev] [PATCH] timeval: Fix misleading function descriptions.

2017-08-28 Thread Ilya Maximets
TIME_UPDATE_INTERVAL was removed long time ago. Now each call leads to time update via syscall and it's granularity is system dependent. Fixes: 31ef9f5178de ("timeval: Remove CACHE_TIME scheme.") Signed-off-by: Ilya Maximets --- lib/timeval.c | 10 -- 1 file changed, 4 insertions(+), 6 d