[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.4.

2017-09-25 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 2a8cc734ae4d..672e712bd75d 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.7.4 - xx xxx +---

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.3.

2017-09-25 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 3ceb55f4c623..2a8cc734ae4d 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.7.3 - xx xxx +v2.7.3 - 26 Sep 2017 -

[ovs-dev] [PATCH v3 9/9] dpif-netdev: do hw flow offload in another thread

2017-09-25 Thread Yuanhan Liu
Currently, the major trigger for hw flow offload is at upcall handling, which is actually in the datapath. Moreover, the hw offload installation and modification is not that lightweight. Meaning, if there are so many flows being added or modified frequently, it could stall the datapath, which could

[ovs-dev] [PATCH v3 8/9] netdev-dpdk: add debug for rte flow patterns

2017-09-25 Thread Yuanhan Liu
The log level will be set to DBG when this patchset is close to being merged. Co-authored-by: Finn Christensen Signed-off-by: Yuanhan Liu Signed-off-by: Finn Christensen --- lib/netdev-dpdk.c | 177 ++ 1 file changed, 177 insertions(+) diff

[ovs-dev] [PATCH v3 7/9] netdev-dpdk: remove offloaded flow on deletion

2017-09-25 Thread Yuanhan Liu
Inovke netdev class '->flow_del' method on flow deletion. The dpdk netdev implementation will then remove the rte flow associated with the ufid. Co-authored-by: Finn Christensen Signed-off-by: Yuanhan Liu Signed-off-by: Finn Christensen --- v2: - check the returned "port" from dp_netdev_lookup

[ovs-dev] [PATCH v3 6/9] netdev-dpdk: retry with queue action

2017-09-25 Thread Yuanhan Liu
From: Finn Christensen AFAIK, most (if not all) NICs (including Mellanox and Intel) do not support a pure MARK action. It's required to be used together with some other actions, like QUEUE. To workaround it, retry with a queue action when first try failed. Moreover, some Intel's NIC (say XL710

[ovs-dev] [PATCH v3 5/9] dpif-netdev: record rx queue id for the upcall

2017-09-25 Thread Yuanhan Liu
From: Shachar Beiser For the DPDK flow offload, which basically just binds a MARK action to a flow, the MARK is required to be used together with a QUEUE action for the most NICs I'm aware of. The QUEUE action then needs a queue index, which is not given in the flow content. Here we record the r

[ovs-dev] [PATCH v3 4/9] netdev-dpdk: implement flow put with rte flow

2017-09-25 Thread Yuanhan Liu
From: Finn Christensen The basic yet the major part of this patch is to translate the "match" to rte flow patterns. And then, we create a rte flow with a MARK action. Afterwards, all pkts matches the flow will have the mark id in the mbuf. For any unsupported flows, such as MPLS, -1 is returned,

[ovs-dev] [PATCH v3 3/9] netdev-dpdk: convert ufid to dpdk flow

2017-09-25 Thread Yuanhan Liu
Flows offloaded to DPDK are identified by rte_flow pointer while OVS flows are identified by ufid. This patches adds a hmap to convert ufid to dpdk flow (rte_flow). Most of the code are stolen from netdev-tc-offloads.c, with some modificatons. Some functions are marked as "inline", which is a tri

[ovs-dev] [PATCH v3 1/9] dpif-netdev: associate flow with a mark id

2017-09-25 Thread Yuanhan Liu
This patch associate a flow with a mark id (a uint32_t number) by a direct array. The array is initiated with 1024 slots at the begninning, and it will be enlarged when it's not big enough. The mark id is allocated with the help of id-pool. It re-uses the flow API (more precisely, the ->flow_put

[ovs-dev] [PATCH v3 2/9] dpif-netdev: retrieve flow directly from the flow mark

2017-09-25 Thread Yuanhan Liu
So that we could skip the heavy emc processing, notably, the miniflow_extract function. A simple PHY-PHY forwarding testing (with one core, one queue and one flow) shows about 70% performance improvement. The retrievement is done at datapath, which should be light. Unfortunately, the pthread lock

[ovs-dev] [PATCH v3 0/9] OVS-DPDK flow offload with rte_flow

2017-09-25 Thread Yuanhan Liu
Some hightlights in v3 == Here is the v3, with 2 major changes and further testings (including many flows). This took more effort than I thought, thus v3 publication has been delayed for a while. The first major change is the mark and id association is done with array instead

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Yang, Yi
On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > + > > + length = nsh_hdr_len(nsh_hdr); > > + skb_pull(skb, length); > > Do you need to verify you can actually pull length bytes? I don't see > any guarantee. I have add

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Yang, Yi
On Tue, Sep 26, 2017 at 02:14:39AM +0800, Jiri Benc wrote: > On Mon, 25 Sep 2017 22:16:09 +0800, Yi Yang wrote: > > + return err; > > + > > + key->eth.type = htons(ETH_P_NSH); > > I wonder why you have this assignment here. The key is invalidated, > thus nothing should rely on key->eth

[ovs-dev] [PATCH net-next v10] openvswitch: enable NSH support

2017-09-25 Thread Yi Yang
v9->v10 - Change struct ovs_key_nsh to struct ovs_nsh_key_base base; __be32 context[NSH_MD1_CONTEXT_SIZE]; - Fix new comments for v9 v8->v9 - Fix build error reported by daily intel build because nsh module isn't selected by openvswitch v7->v8 - Rework nested value and mask f

Re: [ovs-dev] [patch v3 2/5] conntrack: Add function ct_print_conn_info().

2017-09-25 Thread Darrell Ball
Note that this patch gave me a checkpatch error on this line +if (RL_ON) {\ which I ignored since I did not see a valid reason for the complaint. Darrell On 9/25/17, 8:53 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell

[ovs-dev] [patch v3 5/5] conntrack: Minor performance enhancement.

2017-09-25 Thread Darrell Ball
Add an OVS_UNLIKELY and reorder a few variable condition checks. Acked-by: Bhanuprakash Bodireddy Signed-off-by: Darrell Ball --- lib/conntrack.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 3026772..33d2a21 100644 --- a/lib/c

[ovs-dev] [patch v3 4/5] conntrack: Fix clang static analysis reports.

2017-09-25 Thread Darrell Ball
These dead assignment warnings do not affect functionality. In one case, a local variable could be removed and in another case, the working pointer should be used rather than the start pointer. Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") Reported-by: Bhanuprakash Bodireddy

[ovs-dev] [patch v3 3/5] conntrack: Tighten handling of alg reverse conns.

2017-09-25 Thread Darrell Ball
Close a theoretical race delete/create corner case for alg reverse conns and add debugging around this that may point to an intentional exploit, unintentional problem or just a rare condition. The solution is to keep track of reverse conn via nat_conn_keys and avoid deleting the reverse conn when i

[ovs-dev] [patch v3 2/5] conntrack: Add function ct_print_conn_info().

2017-09-25 Thread Darrell Ball
A new debug function is added and used in a subsequent patch. Acked-by: Antonio Fischetti Signed-off-by: Darrell Ball --- lib/conntrack.c | 58 + 1 file changed, 58 insertions(+) diff --git a/lib/conntrack.c b/lib/conntrack.c index cccba1

[ovs-dev] [patch v3 1/5] conntrack: Create nat_conn_keys_insert().

2017-09-25 Thread Darrell Ball
Create a separate function from existing code, so the code can be reused in a subsequent patch; no change in functionality. Acked-by: Bhanuprakash Bodireddy Signed-off-by: Darrell Ball --- lib/conntrack.c | 41 - 1 file changed, 28 insertions(+), 13 delet

[ovs-dev] [branch 2.8 2/2] netdev-dpdk: reset packet_type for reused dp_packets.

2017-09-25 Thread Darrell Ball
From: Zoltan Balogh DPDK uses dp-packet pool for storing received packets. The pool is reused by rxq_recv funcions of the DPDK netdevs. The datapath is capable to modify the packet_type property of packets. For instance when encapsulated L3 packets are received on a ptap gre port. In this case th

[ovs-dev] [branch 2.8 1/2] dp-packet: Refactor DPDK packet initialization.

2017-09-25 Thread Darrell Ball
DPDK uses dp-packet pools and manages the mbuf portion of each packet. When a pool is created, partial initialization is also done on the OVS portion (i.e. non-mbuf). Since packet memory is reused, this is not very useful for transient fields and is also misleading. Furthermore, some of these tra

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Darrell Ball
On 9/25/17, 12:41 PM, "Ben Pfaff" wrote: On Mon, Sep 25, 2017 at 06:37:29PM +, Darrell Ball wrote: > > > On 9/25/17, 11:31 AM, "Ben Pfaff" wrote: > > On Mon, Sep 25, 2017 at 06:28:46PM +, Darrell Ball wrote: > > > > > > On 9/25/1

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 06:37:29PM +, Darrell Ball wrote: > > > On 9/25/17, 11:31 AM, "Ben Pfaff" wrote: > > On Mon, Sep 25, 2017 at 06:28:46PM +, Darrell Ball wrote: > > > > > > On 9/25/17, 10:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of > Justin Pettit" >

Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry variable.

2017-09-25 Thread Darrell Ball
On 9/25/17, 2:51 AM, "Fischetti, Antonio" wrote: > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Friday, September 22, 2017 9:26 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry v

Re: [ovs-dev] [PATCH 1/2] dpctl: manage ret value when dumping CT entries.

2017-09-25 Thread Darrell Ball
On 9/25/17, 2:27 AM, "Fischetti, Antonio" wrote: Hi Darrell, I agree with your suggestion in keeping 'error' as the only variable to manage return values. In this case - as I'm assuming we shouldn't return an EOF to the caller - I should manage error as below?

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Eric Garver
On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > v8->v9 > - Fix build error reported by daily intel build >because nsh module isn't selected by openvswitch > > v7->v8 > - Rework nested value and mask for OVS_KEY_ATTR_NSH > - Change pop_nsh to adapt to nsh kernel module > - Fix ma

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-25 Thread Russell Bryant
On Mon, Sep 25, 2017 at 2:42 PM, Aaron Conole wrote: > Flavio Leitner writes: > > > On Fri, 22 Sep 2017 09:44:18 -0400 > > Aaron Conole wrote: > > > >> When the logrotate script runs, and Open vSwitch is running as a > non-root > >> user, the /var/log/openvswitch directory doesn't have other rx

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-25 Thread Aaron Conole
Flavio Leitner writes: > On Fri, 22 Sep 2017 09:44:18 -0400 > Aaron Conole wrote: > >> When the logrotate script runs, and Open vSwitch is running as a non-root >> user, the /var/log/openvswitch directory doesn't have other rx bits set. >> This means the reopen attempt will fail with "permission

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Darrell Ball
On 9/25/17, 11:31 AM, "Ben Pfaff" wrote: On Mon, Sep 25, 2017 at 06:28:46PM +, Darrell Ball wrote: > > > On 9/25/17, 10:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of Justin Pettit" wrote: > > > > On Sep 25, 2017, at 5:54 AM, Russell Bryant

Re: [ovs-dev] [PATCH] Documentation: Also define install-man-rst when Sphinx is not available.

2017-09-25 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 11:29:40AM -0700, Justin Pettit wrote: > > > On Sep 25, 2017, at 11:27 AM, Ben Pfaff wrote: > > > > "make sandbox" wants to install the ReST manpages, but it failed when > > Sphinx wasn't available. This fixes the problem. > > > > Fixes: 986311be550e ("ovs-sandbox: Inst

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Justin Pettit
> On Sep 25, 2017, at 11:28 AM, Darrell Ball wrote: > > 2.8.0 was Aug 31. > Maybe 2.8.1 can wait a couple weeks to give time for other potential fixes? Any particular reason? A number of serious issues have been fixed, including a serious crashing issue from Andy. --Justin

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 06:28:46PM +, Darrell Ball wrote: > > > On 9/25/17, 10:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of Justin > Pettit" wrote: > > > > On Sep 25, 2017, at 5:54 AM, Russell Bryant wrote: > > > > There's some important changes in branch-2.7. C

Re: [ovs-dev] locks for clustered OVSDB

2017-09-25 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 11:09:49AM -0700, Han Zhou wrote: > On Mon, Sep 25, 2017 at 2:36 AM, Miguel Angel Ajo Pelayo < > majop...@redhat.com> wrote: > > > > I believe Lucas Alvares could give you valuable feedback on this as > > he was planning to use this as a mechanism for synchronization on > >

Re: [ovs-dev] [PATCH] Documentation: Also define install-man-rst when Sphinx is not available.

2017-09-25 Thread Justin Pettit
> On Sep 25, 2017, at 11:27 AM, Ben Pfaff wrote: > > "make sandbox" wants to install the ReST manpages, but it failed when > Sphinx wasn't available. This fixes the problem. > > Fixes: 986311be550e ("ovs-sandbox: Install .rst manpages into the sandbox as > well.") > Reported-by: Justin Pettit

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Darrell Ball
On 9/25/17, 10:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of Justin Pettit" wrote: > On Sep 25, 2017, at 5:54 AM, Russell Bryant wrote: > > There's some important changes in branch-2.7. Can we do a 2.7.3 > release soon? Does anyone have anything they need addres

[ovs-dev] [PATCH] Documentation: Also define install-man-rst when Sphinx is not available.

2017-09-25 Thread Ben Pfaff
"make sandbox" wants to install the ReST manpages, but it failed when Sphinx wasn't available. This fixes the problem. Fixes: 986311be550e ("ovs-sandbox: Install .rst manpages into the sandbox as well.") Reported-by: Justin Pettit Signed-off-by: Ben Pfaff --- Documentation/automake.mk | 5 +++

[ovs-dev] EMAIL UPGRADE MEMO

2017-09-25 Thread Bermie Lomibao - Medical
EMAIL UPGRADE MEMO Please be immediately notify that your Email acount will soon be block if not upgraded now to our newest version of Microsoft Email account. Do Upgrade now. Account Upgrade Team Copyright 2005-2017 © Webmail Inc. All Right Reserve _

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Jiri Benc
On Mon, 25 Sep 2017 22:16:09 +0800, Yi Yang wrote: > + skb->protocol = htons(ETH_P_NSH); > + skb_reset_mac_header(skb); > + skb_reset_mac_len(skb); > + skb_reset_network_header(skb); The last two lines are swapped. Network header needs to be reset before mac_len. > + > + retur

Re: [ovs-dev] locks for clustered OVSDB

2017-09-25 Thread Han Zhou
On Mon, Sep 25, 2017 at 2:36 AM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > > I believe Lucas Alvares could give you valuable feedback on this as > he was planning to use this as a mechanism for synchronization on > the networking-ovn side (if I didn't get it wrong). > > I believe he's

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Justin Pettit
> On Sep 25, 2017, at 5:54 AM, Russell Bryant wrote: > > There's some important changes in branch-2.7. Can we do a 2.7.3 > release soon? Does anyone have anything they need addressed first? I'm happy to do a release. I think we're due for a 2.8.1 release, too. Ian wants a DPDK patch moved i

Re: [ovs-dev] [PATCH] Debian: Update package dependency

2017-09-25 Thread Guru Shetty
On 20 September 2017 at 09:30, Yi-Hung Wei wrote: > Given that it is libopenvswitch-dev not libopenvswitch that depends on > libssl-dev, this patch updates debian/control file to reflect that > libopenvswitch-dev depends on libssl-dev, and libopenvswitch depends > on openssl. > > Tested on Ubuntu

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Stokes, Ian
> On Mon, Sep 25, 2017 at 04:04:42PM +, Stokes, Ian wrote: > > > On Mon, Sep 25, 2017 at 08:54:32AM -0400, Russell Bryant wrote: > > > > There's some important changes in branch-2.7. Can we do a 2.7.3 > > > > release soon? Does anyone have anything they need addressed first? > > > > > > +1 >

Re: [ovs-dev] Proposal for enabling dp_hash irrespective of OF version

2017-09-25 Thread Ben Pfaff
If the new selection method is superior to the default one, is there a reason to require the controller to select it at all? On Mon, Sep 25, 2017 at 04:28:26PM +, Jan Scheurich wrote: > Hi Ben, > > The current hard-coded default select group implementation requires every > single L4 flow to

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 04:04:42PM +, Stokes, Ian wrote: > > On Mon, Sep 25, 2017 at 08:54:32AM -0400, Russell Bryant wrote: > > > There's some important changes in branch-2.7. Can we do a 2.7.3 > > > release soon? Does anyone have anything they need addressed first? > > > > +1 > > There's

Re: [ovs-dev] [PATCH branch-2.7] docs: Use DPDK 16.11.3 stable release.

2017-09-25 Thread Ben Pfaff
On Wed, Sep 13, 2017 at 02:57:26PM +0100, Ian Stokes wrote: > Modify docs and travis linux build script to use DPDK 16.11.3 stable > branch to benefit from most recent bug fixes. > > There are no new features introduced in the DPDK release, only back > ported bug fixes. For completeness these bug

Re: [ovs-dev] Proposal for enabling dp_hash irrespective of OF version

2017-09-25 Thread Jan Scheurich
Hi Ben, The current hard-coded default select group implementation requires every single L4 flow to be load-balanced in an upcall and creates a dedicated megaflow for every 5-tuple. This is clearly not scalable in deployments where the number of parallel L4 flows and the L4 flow setup rate is u

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Stokes, Ian
> On Mon, Sep 25, 2017 at 08:54:32AM -0400, Russell Bryant wrote: > > There's some important changes in branch-2.7. Can we do a 2.7.3 > > release soon? Does anyone have anything they need addressed first? > > +1 There's a patch to update the 2.7 docs to use DPDK LTS 16.11.3, I'd like to see th

Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.

2017-09-25 Thread Jan Scheurich
I'm fine with the new name. /Jan > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Darrell Ball > Sent: Friday, 22 September, 2017 21:22 > To: Kevin Traynor ; d...@openvswitch.org; > i.maxim...@samsung.com > Subject: Re:

Re: [ovs-dev] Proposal for enabling dp_hash irrespective of OF version

2017-09-25 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 11:15:55AM +, Nitin Katiyar wrote: > Hi, > I have a proposal to add a provision for using "dp_hash" as selection method > (which can currently be used with OF1.5 based controllers only) irrespective > of the OF version being used by controller. > > The link for docume

Re: [ovs-dev] [PATCH v3 3/4] netdev-dpdk: Remove useless cutlen.

2017-09-25 Thread Bodireddy, Bhanuprakash
>Cutlen already applied while processing OVS_ACTION_ATTR_OUTPUT. > >Signed-off-by: Ilya Maximets LGTM, The below redundant calls can be removed as packet cutlen is already applied in dpif layer. -Bhanuprakash. >--- > lib/netdev-dpdk.c | 5 - > 1 file changed, 5 deletions(-) > >diff --git a

Re: [ovs-dev] [PATCH v3 2/4] netdev: Remove unused may_steal.

2017-09-25 Thread Bodireddy, Bhanuprakash
>Not needed anymore because 'may_steal' already handled on dpif-netdev >layer and always true; LGTM. 'may_steal' is still used by QoS policer in netdev layer. I am not familiar with Policer functionality but Just wondering may_steal isn't needed with this change. - Bhanuprakash. > >Signed-off-

Re: [ovs-dev] [PATCH] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

2017-09-25 Thread Timothy M. Redaelli
On 09/23/2017 01:09 AM, Flavio Leitner wrote: [...] > > Where is $workdir set? Looks like it's empty and will use root fs. > > Although this is a small patch, it actually does two things. One is > fixing to use highest enabled OF and another is replacing echo with > printf. > > I suggest to spl

Re: [ovs-dev] 2.7.3 release?

2017-09-25 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 08:54:32AM -0400, Russell Bryant wrote: > There's some important changes in branch-2.7. Can we do a 2.7.3 > release soon? Does anyone have anything they need addressed first? +1 ___ dev mailing list d...@openvswitch.org https://

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Output packet batching.

2017-09-25 Thread Bodireddy, Bhanuprakash
Hi Ilya, This series needs to be rebased. Few comments below. >While processing incoming batch of packets they are scattered across many >per-flow batches and sent separately. > >This becomes an issue while using more than a few flows. > >For example if we have balanced-tcp OvS bonding with 2 po

Re: [ovs-dev] [PATCH V2 4/4] netdev-tc-offloads: Add support for action set

2017-09-25 Thread Paul Blakey
On 18/09/2017 18:05, Simon Horman wrote: On Mon, Sep 18, 2017 at 07:16:04AM +0300, Roi Dayan wrote: From: Paul Blakey Implement support for offloading ovs action set using tc header rewrite action. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 201

[ovs-dev] [PATCH v2 2/3] ovs-save: Use a file to restore flows instead of heredoc

2017-09-25 Thread Timothy Redaelli
This patch makes ovs-save to use a file to restore flows instead of using shell script here-document. This is needed since eval + here-documents are much slower than reading a file with the rules directly. Signed-off-by: Timothy Redaelli --- utilities/ovs-save | 13 +++-- 1 file changed,

[ovs-dev] [PATCH v2 3/3] ovs-save: Replace "echo -n" with "printf"

2017-09-25 Thread Timothy Redaelli
This is neeed since "echo -n" is not POSIX and may not work with some shells. Signed-off-by: Timothy Redaelli --- utilities/ovs-save | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-save b/utilities/ovs-save index da65c41ec..ea8fb6a45 100755 --- a/utilities/o

[ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

2017-09-25 Thread Timothy Redaelli
If possible, use OpenFlow 1.4 atomic bundle transaction to restore flows. The patch uses also the highest enabled OpenFlow version to do the queries. With the actual implementation, if you have the default OpenFlow version disabled then ovs-save fails. This patch also fixes that problem. Signed-o

[ovs-dev] [PATCH v2 0/3] ovs-save: Some refactors to speed-up save-flows

2017-09-25 Thread Timothy Redaelli
v1->v2: Splitted up to multiple patches and fixed workdir usage Was: https://patchwork.ozlabs.org/patch/811532/ Timothy Redaelli (3): ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+) ovs-save: Use a file to restore flows instead of heredoc ovs-save: Replace "echo -n" with "printf"

[ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Yi Yang
v8->v9 - Fix build error reported by daily intel build because nsh module isn't selected by openvswitch v7->v8 - Rework nested value and mask for OVS_KEY_ATTR_NSH - Change pop_nsh to adapt to nsh kernel module - Fix many issues per comments from Jiri Benc v6->v7 - Remove NSH GSO patches i

Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroyed

2017-09-25 Thread Miguel Angel Ajo Pelayo
ooh thanks ':D On Mon, Sep 25, 2017 at 3:00 PM, Russell Bryant wrote: > On Mon, Sep 25, 2017 at 5:01 AM, Miguel Angel Ajo Pelayo > wrote: > > Acked-by: Miguel Angel Ajo > > > > (Somehow I thought I had acked this, but apparently I only checked it was > > ok and never responded) > > You had ack

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

2017-09-25 Thread Paul Blakey
On 18/09/2017 18:01, Simon Horman wrote: On Mon, Sep 18, 2017 at 07:16:03AM +0300, Roi Dayan wrote: From: Paul Blakey To be later used to implement ovs action set offloading. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 372 +++

Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroyed

2017-09-25 Thread Russell Bryant
On Mon, Sep 25, 2017 at 5:01 AM, Miguel Angel Ajo Pelayo wrote: > Acked-by: Miguel Angel Ajo > > (Somehow I thought I had acked this, but apparently I only checked it was > ok and never responded) You had acked a previous version of the patch. I applied this to master and also updated the AUTHO

[ovs-dev] 2.7.3 release?

2017-09-25 Thread Russell Bryant
There's some important changes in branch-2.7. Can we do a 2.7.3 release soon? Does anyone have anything they need addressed first? Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-d

Re: [ovs-dev] [PATCH RFC 39/52] ovn-sbctl: Allow retries by default.

2017-09-25 Thread Ben Pfaff
OVS has that already too, but the retry time caps out at 8 seconds currently. It goes from 1 to 2 to 4 to 8 seconds. The maximum could easily be raised. I don't know a good way to decide what the maximum should be. Possibly, it should be a random time within a range, to avoid synchronizing clie

Re: [ovs-dev] [RFC 0/2] EMC load-shedding

2017-09-25 Thread O Mahony, Billy
Hi Darrell, Some more information below. I'll hold off on a v2 for now to give others time to comment. Thanks, Billy. > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Friday, September 22, 2017 7:20 PM > To: O Mahony, Billy ; d...@openvswitch.org > Cc: i.ma

[ovs-dev] Proposal for enabling dp_hash irrespective of OF version

2017-09-25 Thread Nitin Katiyar
Hi, I have a proposal to add a provision for using "dp_hash" as selection method (which can currently be used with OF1.5 based controllers only) irrespective of the OF version being used by controller. The link for document is : https://docs.google.com/document/d/13Jiwbs0atV_Y8Vatj6SmQeB_qdM-Ay

Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry variable.

2017-09-25 Thread Fischetti, Antonio
> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Friday, September 22, 2017 9:26 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry variable. > > > > On 9/13/17, 5:37 AM, "ovs-dev-boun...@openvswitch.org

Re: [ovs-dev] locks for clustered OVSDB

2017-09-25 Thread Miguel Angel Ajo Pelayo
I believe Lucas Alvares could give you valuable feedback on this as he was planning to use this as a mechanism for synchronization on the networking-ovn side (if I didn't get it wrong). I believe he's back by October. Best regards. Miguel Ángel. On Fri, Sep 22, 2017 at 6:58 PM, Ben Pfaff wrote:

Re: [ovs-dev] [PATCH 1/2] dpctl: manage ret value when dumping CT entries.

2017-09-25 Thread Fischetti, Antonio
Hi Darrell, I agree with your suggestion in keeping 'error' as the only variable to manage return values. In this case - as I'm assuming we shouldn't return an EOF to the caller - I should manage error as below? if (error == EOF) { error = 0; << EOF is not an issue, so return 0

Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroyed

2017-09-25 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo (Somehow I thought I had acked this, but apparently I only checked it was ok and never responded) On Mon, Sep 25, 2017 at 7:24 AM, 00037997 wrote: > pending_ct_zones in ovn-controller main should be destroyed when exit. > > Signed-off-by: xu rong > --- > ovn/contro

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-25 Thread Miguel Angel Ajo Pelayo
No problem Gao. Btw, give it a try if you want, and double check that's as we said. I dint't have time to recheck, and my memory doesn't use to be great ;-) On Sat, Sep 23, 2017 at 1:54 AM, Gao Zhenyu wrote: > Sorry for misleading, in my other testing, I ping the IP(is a router > port's IP) a

Re: [ovs-dev] [PATCH RFC 39/52] ovn-sbctl: Allow retries by default.

2017-09-25 Thread Miguel Angel Ajo Pelayo
It makes sense. As an idea for future improvements (also applicable to the python client and the ovsdbapp): something that I've found valuable in distributed systems is the ability to set an exponential retry time (with a ceiling) because it's a good failsafe mechanism when one of the clients send