Re: [ovs-dev] [PATCH] RPM: Improve doc to use builddep tool.

2017-11-14 Thread Aaron Conole
Flavio Leitner writes: > Instead of listing all the dependencies, use the RPM group > 'Development Tools' and the builddep tool to find specific > ones. > > Signed-off-by: Flavio Leitner > --- > Documentation/intro/install/fedora.rst | 54 > +++--- > Documentation/i

Re: [ovs-dev] [PATCH] Skip processing actions when batch is emptied.

2017-11-14 Thread Vishal Deep Ajmera
Hi, Do anyone see any issues with the approach below of skipping ovs actions when batch is emptied ? Warm Regards, Vishal -Original Message- From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Vishal Deep Ajmera Sent: Wednesday, November 08, 2017

Re: [ovs-dev] [PATCH] openvswitch: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_start

2017-11-14 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 14 Nov 2017 14:26:16 -0600 > It seems that the intention of the code is to null check the value > returned by function genlmsg_put. But the current code is null > checking the address of the pointer that holds the value returned > by genlmsg_put. > > Fix th

Re: [ovs-dev] [PATCH v2] netdev, dpif: fix the crash/assert on port delete

2017-11-14 Thread Ashish Varma
Tested the patch with the steps causing the crash. No problem detected. Also ran make check with no issues. On Mon, Nov 13, 2017 at 2:06 PM, Ben Pfaff wrote: > I sent a patch series that should help a little. Would you mind testing > it against the case that was causing problems? The series is

[ovs-dev] 12 Temas INEDITOS

2017-11-14 Thread Auditoría y Control Interno
Ponemos a su alcance por primera vez y por tiempo limitado, un exclusivo programa con 12 Temas INEDITOS específicamente creados para mejorar su negocio en forma completa, conveniente y accesible . Con este programa usted y sus colaboradores podrán obtener 12 conferencias a las cuales podrán ten

Re: [ovs-dev] [PATCH v2 0/8] Add minimum network namespace support.

2017-11-14 Thread Gregory Rose
On 11/9/2017 9:30 AM, Flavio Leitner wrote: Today Open vSwitch doesn't know about network namespaces (netns), but users are moving internal ports to other namespaces. Although packets are still flowing, the daemon fails to find out basic port information, like if it is UP or DOWN, for instance.

Re: [ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

2017-11-14 Thread Flavio Leitner
On Wed, 8 Nov 2017 12:18:36 -0800 Ben Pfaff wrote: > On Wed, Nov 08, 2017 at 03:31:48PM -0200, Flavio Leitner wrote: > > On Wed, 01 Nov 2017 13:21:22 -0400 > > Aaron Conole wrote: > > > > > Guru Shetty writes: > > > > > > > On 31 October 2017 at 13:06, Aaron Conole wrote: > > > > > > > > Be

[ovs-dev] [PATCH] RPM: Improve doc to use builddep tool.

2017-11-14 Thread Flavio Leitner
Instead of listing all the dependencies, use the RPM group 'Development Tools' and the builddep tool to find specific ones. Signed-off-by: Flavio Leitner --- Documentation/intro/install/fedora.rst | 54 +++--- Documentation/intro/install/rhel.rst | 34 ++

Re: [ovs-dev] [PATCH 1/3] netdev: Indentation and style fixes.

2017-11-14 Thread Gregory Rose
On 11/13/2017 2:04 PM, Ben Pfaff wrote: White space changes only. Signed-off-by: Ben Pfaff --- lib/netdev.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index 0c1545a83e3d..7792b1b75681 100644 --- a/lib/netde

[ovs-dev] [PATCH] openvswitch: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_start

2017-11-14 Thread Gustavo A. R. Silva
It seems that the intention of the code is to null check the value returned by function genlmsg_put. But the current code is null checking the address of the pointer that holds the value returned by genlmsg_put. Fix this by properly null checking the value returned by function genlmsg_put in order

[ovs-dev] Virtualization Clients/Customer List

2017-11-14 Thread Erin Marino
Hello there, I would like to know if you are interested in acquiring Virtualization Contact List. Information fields: Names, Title, Email, Phone, Company Name, Company URL, Company physical address, SIC Code, Industry, Company Size (Revenue and Employee). If you are interested, let me know you

[ovs-dev] [PATCH v2 2/2] util: Add high resolution sleep support.

2017-11-14 Thread Bhanuprakash Bodireddy
This commit introduces xnanosleep() for the threads needing high resolution sleep timeouts. usleep() that provides microsecond granularity is deprecated and threads wanting sub-second(ms,us,ns) granularity can use this implementation. CC: Aaron Conole CC: Alin Gabriel Serdean CC: Ben Pfaff Sig

[ovs-dev] [PATCH v2 1/2] timeval: Introduce macros to convert timespec and timeval.

2017-11-14 Thread Bhanuprakash Bodireddy
This commit replaces the numbers with MSEC_PER_SEC, NSEC_PER_SEC and USEC_PER_MSEC macros when dealing with timespec and timeval. This commit doesn't change functionality. Signed-off-by: Bhanuprakash Bodireddy --- lib/timeval.c| 29 - lib/timeval.h

Re: [ovs-dev] [PATCH v2 3/8] vport: retrieve the netnsid if available.

2017-11-14 Thread Gregory Rose
On 11/9/2017 9:31 AM, Flavio Leitner wrote: Recent kernels provide the network namespace ID of a port, so use that to discover where the port currently is. Signed-off-by: Flavio Leitner --- datapath/linux/compat/include/linux/openvswitch.h | 2 ++ lib/dpif-netlink.c

[ovs-dev] [PATCH v1 3/3] datapath-windows: Optimize conntrack lock implementation.

2017-11-14 Thread Anand Kumar
Currently, there is one global lock for conntrack module, which protects conntrack entries and conntrack table. All the NAT operations are performed holding this lock. This becomes inefficient, as the number of conntrack entries grow. With new implementation, we will have two PNDIS_RW_LOCK_EX lock

[ovs-dev] [PATCH v1 2/3] datapath-windows: Add a global level RW lock for NAT

2017-11-14 Thread Anand Kumar
Currently NAT module relies on the existing conntrack lock. This patch provides a basic lock implementation for NAT module in conntrack. Signed-off-by: Anand Kumar --- datapath-windows/ovsext/Conntrack.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH v1 1/3] datapath-windows: Refactor conntrack code.

2017-11-14 Thread Anand Kumar
Some of the functions and code are refactored so that new conntrack lock can be implemented Signed-off-by: Anand Kumar --- datapath-windows/ovsext/Conntrack-nat.c | 11 +-- datapath-windows/ovsext/Conntrack.c | 170 ++-- datapath-windows/ovsext/Conntrack.h |

[ovs-dev] [PATCH v1 0/3] datapath-windows: New lock implementation in conntrack

2017-11-14 Thread Anand Kumar
This patch series replaces existing one RW lock implemenation in conntrack with two RW locks in conntrack and one RW lock in NAT. Anand Kumar (3): datapath-windows: Refactor conntrack code. datapath-windows: Add a global level RW lock for NAT datapath-windows: Optimize conntrack lock impleme

Re: [ovs-dev] [PATCH] ovn.at: Fix MSYS IPv6 interpretation

2017-11-14 Thread aserdean
> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, November 14, 2017 8:16 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] ovn.at: Fix MSYS IPv6 interpre

Re: [ovs-dev] [PATCH] ovn.at: Fix MSYS IPv6 interpretation

2017-11-14 Thread Ben Pfaff
On Tue, Nov 14, 2017 at 03:49:44AM +0200, Alin Gabriel Serdean wrote: > Unfortunately MSYS transforms `0::` into the location of the binaries i.e.: > c:\MinGW\msys\1.0\64. > > Currently the test: > `testing ovn -- IPv6 Neighbor Solicitation for unknown MAC` > fails because of the above: > "ovn-nbc

[ovs-dev] [PATCH v2 2/2] netdev: Eliminate redundant ifindex mapping.

2017-11-14 Thread Ben Pfaff
Until now, the code for mapping ODP port number to ifindexes and vice versa has maintained two completely separate data structures, one for each direction. It was possible for the two mappings to become out of sync with each other since either one could change independently. This commit merges th

[ovs-dev] [PATCH v2 1/2] netdev: Indentation and style fixes.

2017-11-14 Thread Ben Pfaff
White space changes only. Signed-off-by: Ben Pfaff --- lib/netdev.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index 7aa3e0aedb4c..8dd35864d7cb 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -2314,10 +2314,10 @@ netdev_

[ovs-dev] [PATCH v2 0/2] ifindex mapping fixes

2017-11-14 Thread Ben Pfaff
v1->v2: Applied and dropped patch 2. Ben Pfaff (2): netdev: Indentation and style fixes. netdev: Eliminate redundant ifindex mapping. lib/netdev.c | 77 1 file changed, 20 insertions(+), 57 deletions(-) -- 2.10.2 ___

Re: [ovs-dev] [PATCH 2/3] netdev: Change macro to function.

2017-11-14 Thread Ben Pfaff
On Mon, Nov 13, 2017 at 06:41:20PM -0800, Gregory Rose wrote: > > > On 11/13/2017 2:04 PM, Ben Pfaff wrote: > >There was no reason that this should have been a macro. > > > >Signed-off-by: Ben Pfaff > >--- > > lib/netdev.c | 17 ++--- > > 1 file changed, 10 insertions(+), 7 deletion

Re: [ovs-dev] [PATCH] tests: Try harder to figure out whether IPv6 is supported.

2017-11-14 Thread Ben Pfaff
On Tue, Nov 14, 2017 at 10:08:54AM -0800, Ben Pfaff wrote: > On Mon, Nov 13, 2017 at 07:36:39PM -0800, Gregory Rose wrote: > > On 11/13/2017 4:58 PM, Ben Pfaff wrote: > > >Until now, the tests have tried to create an IPv6 socket to figure out > > >whether the system under test supports IPv6. Recen

Re: [ovs-dev] [PATCH] tests: Try harder to figure out whether IPv6 is supported.

2017-11-14 Thread Ben Pfaff
On Mon, Nov 13, 2017 at 07:36:39PM -0800, Gregory Rose wrote: > On 11/13/2017 4:58 PM, Ben Pfaff wrote: > >Until now, the tests have tried to create an IPv6 socket to figure out > >whether the system under test supports IPv6. Recently we've seen test > >failures on Travis which appear to be becaus

Re: [ovs-dev] [PATCH] tests: Try harder to figure out whether IPv6 is supported.

2017-11-14 Thread William Tu
On Mon, Nov 13, 2017 at 7:36 PM, Gregory Rose wrote: > On 11/13/2017 4:58 PM, Ben Pfaff wrote: >> >> Until now, the tests have tried to create an IPv6 socket to figure out >> whether the system under test supports IPv6. Recently we've seen test >> failures on Travis which appear to be because, al

Re: [ovs-dev] [PATCH net-next] openvswitch: Using kfree_rcu() to simplify the code

2017-11-14 Thread David Miller
From: Wei Yongjun Date: Tue, 14 Nov 2017 06:27:12 + > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > Signed-off-by: Wei Yongjun Applied. ___ dev mailing list d.

Re: [ovs-dev] [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static

2017-11-14 Thread David Miller
From: Wei Yongjun Date: Tue, 14 Nov 2017 06:27:03 + > Fixes the following sparse warnings: > > net/openvswitch/flow_netlink.c:340:8: warning: > symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Applied. __

Re: [ovs-dev] [PATCH net-next] openvswitch: Fix return value check in ovs_meter_cmd_features()

2017-11-14 Thread David Miller
From: Wei Yongjun Date: Tue, 14 Nov 2017 06:20:16 + > In case of error, the function ovs_meter_cmd_reply_start() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") > Signe

[ovs-dev] [PATCH v6 1/2] netdev-dpdk: extend netdev_dpdk_get_status to include if_type and if_descr

2017-11-14 Thread Michal Weglicki
This commit extends netdev_dpdk_get_status API to include additional driver-related information: if_type and if_descr. v2->v3: Code rebase. v3->v4: Minor comments applied. v5->v6: Adds DPDK port specific description in documentation. Co-authored-by: Michal Weglicki Signed-off-by: Michal Weglicki

[ovs-dev] [PATCH v6 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

2017-11-14 Thread Michal Weglicki
Extend flow key part of data record to include following Information Elements: - ingressInterface - ingressInterfaceType - egressInterface - egressInterfaceType - interfaceName - interfaceDescription In case of input sampling we don't have information about egress port. Define templates depending

Re: [ovs-dev] [PATCH net-next] openvswitch: Using kfree_rcu() to simplify the code

2017-11-14 Thread Pravin Shelar
On Tue, Nov 14, 2017 at 11:57 AM, Wei Yongjun wrote: > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > Signed-off-by: Wei Yongjun Acked-by: Pravin B Shelar ___ dev ma

Re: [ovs-dev] [PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static

2017-11-14 Thread Pravin Shelar
On Tue, Nov 14, 2017 at 11:57 AM, Wei Yongjun wrote: > Fixes the following sparse warnings: > > net/openvswitch/flow_netlink.c:340:8: warning: > symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static? > Acked-by: Pravin B Shelar > Signed-off-by: Wei Yongjun > --- > net/openvswi

Re: [ovs-dev] [PATCH net-next] openvswitch: Fix return value check in ovs_meter_cmd_features()

2017-11-14 Thread Pravin Shelar
On Tue, Nov 14, 2017 at 11:50 AM, Wei Yongjun wrote: > In case of error, the function ovs_meter_cmd_reply_start() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") > Signed-off

Re: [ovs-dev] [PATCH 3/7] util: High resolution sleep support for windows.

2017-11-14 Thread Bodireddy, Bhanuprakash
Hi Alin, >Thanks a lot for the patch. > >I have a few comments inlined. > >> -Original Message- >> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy >> Sent: Wednesday, November 8, 2017 6:36 PM >> To: d...@openvswitch.org

Re: [ovs-dev] [PATCH v4 2/2] OVN: Add support for periodic router advertisements.

2017-11-14 Thread Numan Siddique
A few comments inline, otherwise LGTM. Thanks Numan On Mon, Nov 13, 2017 at 8:50 AM, Mark Michelson wrote: > This change adds three new options to the Northbound > Logical_Router_Port's ipv6_ra_configs option: > > * send_periodic: If set to "true", then OVN will send periodic router > advertis

[ovs-dev] I’m passionate to discuss something with you, Can i confide in you? Please confirm if you did receive my letter

2017-11-14 Thread Mrs Jemilah Wahab
Dear beloved in the lord, God bless you. Am sorry if my letter surprised you. I am writing this letter in confidence believing that it is the will of God to meet with you since we have not meet before. As you can see I'm passionate to discuss something with you,Because i have a pressing story w

Re: [ovs-dev] [PATCH v4 1/2] OVN: Add multicast keep-local flag.

2017-11-14 Thread Numan Siddique
On Mon, Nov 13, 2017 at 8:50 AM, Mark Michelson wrote: > When this flag is set, then a multicast packet that would normally be > delivered to ports on multiple hypervisors is only delivered to ports > on the local hypervisor. > > The primary known use case for this is when multicast packets origi