Re: [ovs-dev] [PATCH] cmap: Use PADDED_MEMBERS macro for cmap_bucket padding.

On 30.11.2017 20:42, Ben Pfaff wrote: > On Thu, Nov 30, 2017 at 03:55:03PM +0300, Ilya Maximets wrote: >> Current implementation of manual padding inside struct cmap_bucket >> doesn't work for some cacheline sizes. For example, if CACHE_LINE_SIZE >> equals to 128, compiler adds an additional 8

Re: [ovs-dev] [PATCH V3 0/2] DPDK v17.11 Support

I do not see a difference with v2. Did you re-send the old patches? Best regards, Ilya Maximets. On 30.11.2017 17:54, Mark Kavanagh wrote: > This patchset adds support for DPDK v17.11: > - the first patch introduces minor code updates to accomodate DPDK API > changes, and also updates

[ovs-dev] Contributing to OVS

Hi, I am interested in contributing to OVS development. I have sent multple subscription request but i have not got any response on the same. Thanks, Pavan ___ dev mailing list d...@openvswitch.org

[ovs-dev] Guía para Elaborar un Mapeo de Procesos

En línea y en Vivo / Para todo su Equipo con una sola Conexión Guía para Elaborar un Mapeo de Proceso 14 de diciembre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs. Esta Capacitación Online en Vivo está diseñado, para mostrar los pasos a seguir y realizar el mapeo del proceso

Re: [ovs-dev] [PATCHv2] netdev: netdev_get_etheraddr is not functioning as advertised.

On Thu, Nov 30, 2017 at 08:31:24AM -0800, Yifeng Sun wrote: > netdev_get_etheraddr claims to clear 'mac' on error, but it fails to do so. > When looking further into both netdev_windows_get_etheraddr() and > netdev_linux_get_etheraddr(), 'mac' is also not cleared. This will lead to > usage of

[ovs-dev] [PATCHv2] netdev: netdev_get_etheraddr is not functioning as advertised.

netdev_get_etheraddr claims to clear 'mac' on error, but it fails to do so. When looking further into both netdev_windows_get_etheraddr() and netdev_linux_get_etheraddr(), 'mac' is also not cleared. This will lead to usage of uninitialised ofputil_phy_port.hw_addr. v1 -> v2: fixed a bug in v1

Re: [ovs-dev] [PATCH] util: Make xmalloc_cacheline() allocate full cachelines.

On Thu, Nov 30, 2017 at 07:17:20PM +, Bodireddy, Bhanuprakash wrote: > >On Wed, Nov 29, 2017 at 08:02:17AM +, Bodireddy, Bhanuprakash wrote: > >> > > >> >On Tue, Nov 28, 2017 at 09:06:09PM +, Bodireddy, Bhanuprakash > >wrote: > >> >> >Until now, xmalloc_cacheline() has provided its

Re: [ovs-dev] [PATCH] netdev: netdev_get_etheraddr is not functioning as advertised.

On Thu, Nov 30, 2017 at 06:32:55AM -0800, Yifeng Sun wrote: > netdev_get_etheraddr claims to clear 'mac' on error, but it fails to do so. > When looking further into both netdev_windows_get_etheraddr() and > netdev_linux_get_etheraddr(), 'mac' is also not cleared. This will lead to > usage of

[ovs-dev] [PATCH] netdev: netdev_get_etheraddr is not functioning as advertised.

netdev_get_etheraddr claims to clear 'mac' on error, but it fails to do so. When looking further into both netdev_windows_get_etheraddr() and netdev_linux_get_etheraddr(), 'mac' is also not cleared. This will lead to usage of uninitialised ofputil_phy_port.hw_addr. Signed-off-by: Yifeng Sun

Re: [ovs-dev] [PATCH] util: Make xmalloc_cacheline() allocate full cachelines.

>On Wed, Nov 29, 2017 at 08:02:17AM +, Bodireddy, Bhanuprakash wrote: >> > >> >On Tue, Nov 28, 2017 at 09:06:09PM +, Bodireddy, Bhanuprakash >wrote: >> >> >Until now, xmalloc_cacheline() has provided its caller memory that >> >> >does not share a cache line, but when posix_memalign() is

[ovs-dev] [PATCH 2/2] ovsschema: Avoid using 'protected' as variable name

In C++, 'protected' is a keyword. This patch renames 'protected' to 'is_protected' in a couple files so that C++ compiler will not get confused. Signed-off-by: Yi-Hung Wei --- ofproto/ofproto-dpif.c | 10 +- ofproto/ofproto.h | 2 +- vswitchd/bridge.c

[ovs-dev] [PATCH 1/2] lib, ovsdb: Adapt headers for C++ usage

This patch adds 'extern "C"' in a couple of header files so that they can be compiled with C++ compilers. Signed-off-by: Yi-Hung Wei --- lib/dirs.h | 8 lib/ovsdb-data.h | 8 lib/ovsdb-idl-provider.h | 8 lib/ovsdb-idl.h

Re: [ovs-dev] [PATCH] odp-execute: Add helpful comment to odp_execute_actions().

Thanks for the review. I applied this to master. On Thu, Nov 30, 2017 at 10:30:02AM -0800, Yifeng Sun wrote: > Thanks for the comments that clarify the usage of this function. > > > Reviewed-by: Yifeng Sun > > On Wed, Nov 29, 2017 at 2:14 PM, Ben Pfaff

Re: [ovs-dev] [PATCH v3] odp-execute: Skip processing actions when batch is emptied

On Thu, Nov 30, 2017 at 05:37:57AM +, Vishal Deep Ajmera wrote: > Today in OVS, when errors are encountered during the execution > of an action the entire batch of packets may be deleted (for e.g. > in processing push_tnl_action, if the port is not found in the > port_cache of PMD). The

[ovs-dev] [PATCH] sflow: Correctly document setup command.

Reported-by: Shivaram Mysore Signed-off-by: Ben Pfaff --- Documentation/howto/sflow.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/howto/sflow.rst b/Documentation/howto/sflow.rst index 1152a7db567a..66f4856b3340

Re: [ovs-dev] [PATCH] odp-execute: Add helpful comment to odp_execute_actions().

Thanks for the comments that clarify the usage of this function. Reviewed-by: Yifeng Sun On Wed, Nov 29, 2017 at 2:14 PM, Ben Pfaff wrote: > It wasn't obvious how ownership transferred to odp_execute_actions() or > to its callback. > > CC: Yifeng Sun

Re: [ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

On Thu, Nov 30, 2017 at 10:03 AM, Ben Pfaff wrote: > On Thu, Nov 30, 2017 at 02:47:34PM +0530, Shashank Ram wrote: >> On Thu, Nov 30, 2017 at 11:45 AM, Ben Pfaff wrote: >> Sai and Shireesh, thanks for the patch. I share the same sentiments as Ben >> regarding >> the

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

On Thu, Nov 30, 2017 at 11:21 PM, Ben Pfaff wrote: > On Thu, Nov 30, 2017 at 11:02:23PM +0530, Numan Siddique wrote: > > On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff wrote: > > > > > On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote: > > > > From:

Re: [ovs-dev] [PATCH v2] ovn-ctl: Add new commands 'run_nb_server' and 'run_sb_server'

On Thu, Nov 30, 2017 at 11:27 PM, Ben Pfaff wrote: > On Thu, Nov 30, 2017 at 04:15:09PM +0530, Numan Siddique wrote: > > On Wed, Nov 29, 2017 at 11:19 PM, Ben Pfaff wrote: > > > > > On Tue, Nov 21, 2017 at 12:35:56PM +0530, nusid...@redhat.com wrote: > > > > From:

Re: [ovs-dev] [PATCH v2] OVN pacemaker: Add the monitor action for Master role

This patch needs so more testing. In one of my deployments I see no master is promoted and all the ovn db resources running in 3 nodes are in slave mode. In my previous testing it worked fine though. I will fix this and submit a v3. Thanks Numan On Thu, Nov 30, 2017 at 4:12 PM,

Re: [ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

On Thu, Nov 30, 2017 at 02:47:34PM +0530, Shashank Ram wrote: > On Thu, Nov 30, 2017 at 11:45 AM, Ben Pfaff wrote: > > > On Wed, Nov 29, 2017 at 05:13:14PM -0800, Sairam Venugopal wrote: > > > Found when compiling the code with C++ binaries. Most of the issues are > > > due to

[ovs-dev] Una asistente capacitada, es una asistente de excelencia

Capacidad y entrega para un máximo rendimiento profesional La asistente Asertiva, Activa y Efectiva 06 de Diciembre - Psi. Dolores Romero Mora - 9am-8pm Detrás de cada ejecutivo hay una asistente ejecutiva que hace que los negocios funcionen. Las asistentes ofrecen ayuda administrativa de alto

Re: [ovs-dev] [PATCH v2] ovn-ctl: Add new commands 'run_nb_server' and 'run_sb_server'

On Thu, Nov 30, 2017 at 04:15:09PM +0530, Numan Siddique wrote: > On Wed, Nov 29, 2017 at 11:19 PM, Ben Pfaff wrote: > > > On Tue, Nov 21, 2017 at 12:35:56PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > Presently if the user wants

Re: [ovs-dev] [PATCH] odp-util: Fix another hang in NSH action parsing.

Thanks. Would you mind reviewing this one also? https://patchwork.ozlabs.org/patch/842248/ On Thu, Nov 30, 2017 at 02:55:53PM +, Jan Scheurich wrote: > Good spot. Thanks for fixing this! > > Acked-by: Jan Scheurich > > > -Original Message- > >

Re: [ovs-dev] [patch v2 0/3] conntrack: Alg improvements.

On Thu, Nov 30, 2017 at 11:09:05AM -0500, Aaron Conole wrote: > Aaron Conole writes: > > > Ben Pfaff writes: > > > >> On Mon, Nov 27, 2017 at 06:11:42PM -0500, Aaron Conole wrote: > >>> Darrell Ball writes: > >>> > >>> > Some refactoring of

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

On Thu, Nov 30, 2017 at 11:02:23PM +0530, Numan Siddique wrote: > On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff wrote: > > > On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > In the case of OVN HA

Re: [ovs-dev] Buffer configuration

On Thu, Nov 30, 2017 at 07:24:58AM +, nurefşan sertbaş wrote: > I’m using ovs vSwitch version 2.3.90 in my SDN environment. Is it > possible to limit the size of receive and transmit buffers of the > switch via configuration? OVS doesn't buffer packets. > Also, is there any document about

Re: [ovs-dev] [PATCH v2] netdev-linux: Do not remove ingress qdisc when policing is never enabled.

On Thu, Nov 30, 2017 at 04:56:16PM +0800, Guoshuai Li wrote: > > > >On Thu, Nov 16, 2017 at 02:18:26PM +0800, Guoshuai Li wrote: > >>rate limiting may be implemented in other ways (such as nova/libvirt), > >>ovs never enable policing. I think ovs need not control qdisc, such as > >>remove >

Re: [ovs-dev] [PATCH] types: New macros ETH_ADDR_C and ETH_ADDR64_C.

OK, I pushed a fix. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] OVS no longer compiles on Centos 7 (gcc 4.8.5)

On Thu, Nov 30, 2017 at 08:18:51AM -0600, Terry Wilson wrote: > As of the ETH_ADDR_C patch > (https://patchwork.ozlabs.org/patch/842364/), ovs won't compile on gcc > 4.8.5 which ships with Centos 7. It works fine on 7.2.1 which ships in > Fedora 27. > > lots of: > >

Re: [ovs-dev] [PATCH] cmap: Use PADDED_MEMBERS macro for cmap_bucket padding.

On Thu, Nov 30, 2017 at 03:55:03PM +0300, Ilya Maximets wrote: > Current implementation of manual padding inside struct cmap_bucket > doesn't work for some cacheline sizes. For example, if CACHE_LINE_SIZE > equals to 128, compiler adds an additional 8 bytes: 4 bytes between > 'hashes' and 'nodes'

Re: [ovs-dev] [PATCH] netdev: Custom statistics.

On Thu, Nov 30, 2017 at 02:39:56PM +, Weglicki, MichalX wrote: > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Wednesday, November 29, 2017 6:35 PM > > To: Weglicki, MichalX > > Cc: d...@openvswitch.org > > Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff wrote: > On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > In the case of OVN HA deployments with openstack, it has been noticed > > that the 5 seconds inactivity

Re: [ovs-dev] [patch v2 0/3] conntrack: Alg improvements.

Aaron Conole writes: > Ben Pfaff writes: > >> On Mon, Nov 27, 2017 at 06:11:42PM -0500, Aaron Conole wrote: >>> Darrell Ball writes: >>> >>> > Some refactoring of alg support is done. >>> > Also algs are disabled by default unless an alg

Re: [ovs-dev] [patch v2 3/3] conntrack: Disable algs by default.

Darrell Ball writes: > There is a bug here in that the control connection should still be created > even though it is likely an unused control connection. > The following incremental fixes it. Good catch. While thinking about it, I was wondering if it would be possible to

Re: [ovs-dev] [PATCH] odp-util: Fix another hang in NSH action parsing.

Good spot. Thanks for fixing this! Acked-by: Jan Scheurich > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Wednesday, 29 November, 2017 17:59 > To: d...@openvswitch.org >

[ovs-dev] [PATCH V3 2/2] netdev-dpdk: vHost IOMMU support

DPDK v17.11 introduces support for the vHost IOMMU feature. This is a security feature, which restricts the vhost memory that a virtio device may access. This feature also enables the vhost REPLY_ACK protocol, the implementation of which is known to work in newer versions of QEMU (i.e. v2.10.0),

[ovs-dev] [PATCH V3 1/2] netdev-dpdk: DPDK v17.11 upgrade

This commit adds support for DPDK v17.11: - minor updates to accomodate DPDK API changes - update references to DPDK version in Documentation - update DPDK version in travis' linux-build script Signed-off-by: Mark Kavanagh Acked-by: Maxime Coquelin

[ovs-dev] [PATCH V3 0/2] DPDK v17.11 Support

This patchset adds support for DPDK v17.11: - the first patch introduces minor code updates to accomodate DPDK API changes, and also updates Documentation and travis scripts. - the second patch adds a new global configuration option, vhost-iommu-support; this is required in order to take

Re: [ovs-dev] [PATCH] netdev: Custom statistics.

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, November 29, 2017 6:35 PM > To: Weglicki, MichalX > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev: Custom statistics. > > On Tue, Nov 28, 2017 at 01:46:05PM

Re: [ovs-dev] [PATCH] openvswitch: use ktime_get_ts64() instead of ktime_get_ts()

From: Arnd Bergmann Date: Mon, 27 Nov 2017 12:41:38 +0100 > timespec is deprecated because of the y2038 overflow, so let's convert > this one to ktime_get_ts64(). The code is already safe even on 32-bit > architectures, since it uses monotonic times. On 64-bit architectures, >

[ovs-dev] OVS no longer compiles on Centos 7 (gcc 4.8.5)

As of the ETH_ADDR_C patch (https://patchwork.ozlabs.org/patch/842364/), ovs won't compile on gcc 4.8.5 which ships with Centos 7. It works fine on 7.2.1 which ships in Fedora 27. lots of: ../include/openvswitch/types.h:186:47: error: initializer element is not constant #define

[ovs-dev] [PATCH] cmap: Use PADDED_MEMBERS macro for cmap_bucket padding.

Current implementation of manual padding inside struct cmap_bucket doesn't work for some cacheline sizes. For example, if CACHE_LINE_SIZE equals to 128, compiler adds an additional 8 bytes: 4 bytes between 'hashes' and 'nodes' and 4 bytes after the manual 'pad'. This leads to build time assertion,

Re: [ovs-dev] [PATCH V2 2/2] netdev-dpdk: vHost IOMMU support

>From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Thursday, November 30, 2017 11:24 AM >To: Kavanagh, Mark B ; d...@openvswitch.org >Cc: ktray...@redhat.com; maxime.coque...@redhat.com; >jan.scheur...@ericsson.com; Mooney, Sean K ;

Re: [ovs-dev] [PATCH V2 2/2] netdev-dpdk: vHost IOMMU support

Thanks for the patches. Comments inline. Best regards, Ilya Maximets. On 30.11.2017 13:03, Mark Kavanagh wrote: > DPDK v17.11 introduces support for the vHost IOMMU feature. > This is a security feature, which restricts the vhost memory > that a virtio device may access. > > This feature also

Re: [ovs-dev] [PATCH] types: New macros ETH_ADDR_C and ETH_ADDR64_C.

I also have this problem in centos. I try it, remove "-std=gnu99" for gcc is worked. [root@vNetCI ~]# gcc lgs.c [root@vNetCI ~]# [root@vNetCI ~]# gcc -std=gnu99 lgs.c lgs.c:9:15: error: initializer element is not constant = (struct eth_addr) { { .ea =  { 0x00, 0x23, 0x20, 0x00, 0x00, 0x01

Re: [ovs-dev] [PATCH v2] ovn-ctl: Add new commands 'run_nb_server' and 'run_sb_server'

On Wed, Nov 29, 2017 at 11:19 PM, Ben Pfaff wrote: > On Tue, Nov 21, 2017 at 12:35:56PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Presently if the user wants to start OVN db servers as separate > containers, 'ovn-ctl' > > script is not

[ovs-dev] [PATCH v2] OVN pacemaker: Add the monitor action for Master role

From: Numan Siddique Pacemaker Resource agent periodically calls the OVN OCF's "monitor" action periodically to check the status. But the OVN OCF script doesn't add the action "monitor" for the role "Master" because of which the pacemaker resource agent do not call the

[ovs-dev] [PATCH V2 2/2] netdev-dpdk: vHost IOMMU support

DPDK v17.11 introduces support for the vHost IOMMU feature. This is a security feature, which restricts the vhost memory that a virtio device may access. This feature also enables the vhost REPLY_ACK protocol, the implementation of which is known to work in newer versions of QEMU (i.e. v2.10.0),

[ovs-dev] [PATCH V2 1/2] netdev-dpdk: DPDK v17.11 upgrade

This commit adds support for DPDK v17.11: - minor updates to accomodate DPDK API changes - update references to DPDK version in Documentation - update DPDK version in travis' linux-build script Signed-off-by: Mark Kavanagh Acked-by: Maxime Coquelin

[ovs-dev] [PATCH V2 0/2] DPDK v17.11 Support

This patchset adds support for DPDK v17.11: - the first patch introduces minor code updates to accomodate DPDK API changes, and also updates Documentation and travis scripts. - the second patch adds a new global configuration option, vhost-iommu-support; this is required in order to take

Re: [ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

On Thu, Nov 30, 2017 at 11:45 AM, Ben Pfaff wrote: > On Wed, Nov 29, 2017 at 05:13:14PM -0800, Sairam Venugopal wrote: > > Found when compiling the code with C++ binaries. Most of the issues are > > due to missing explicit cast. > > > > Signed-off-by: Sairam Venugopal

Re: [ovs-dev] QoS Meters in OVSSwitch

Hello, The port outside the hypervisor， Do you use dpdk-port  ?  such as:     Bridge br-agg     Port bond-agg     Interface "agg-dpdk-1"     type: dpdk     options: {dpdk-devargs=":02:00.0", n_rxq="4"}     Interface "agg-dpdk-2"    

Re: [ovs-dev] [PATCH v2] netdev-linux: Do not remove ingress qdisc when policing is never enabled.

On Thu, Nov 16, 2017 at 02:18:26PM +0800, Guoshuai Li wrote: rate limiting may be implemented in other ways (such as nova/libvirt), ovs never enable policing. I think ovs need not control qdisc, such as remove qdisk added by other. Signed-off-by: Guoshuai Li Signed-off-by: