Re: [ovs-dev] [PATCH v3 3/8] ovsdb-client; Add new "get-schema-cksum" command.

> On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote: > > I don't have a particular use for this but it allows ovsdb-client to do > all the things with schemas that ovsdb-tool can. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH v3 2/8] ovsdb-client: Move ovsdb-client specific tests to new .at file.

> On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote: > > Delete the "tcp socket" version of the test--really there's no point in > trying everything over N different kinds of sockets. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH v2] ovsdb: Improve documentation.

> On Dec 8, 2017, at 7:56 PM, Ben Pfaff wrote: > > diff --git a/Documentation/ref/ovsdb-server.7.rst > b/Documentation/ref/ovsdb-server.7.rst > new file mode 100644 > index ..feb093db22ae > --- /dev/null > +++ b/Documentation/ref/ovsdb-server.7.rst > > +

Re: [ovs-dev] [PATCH] openvswitch: Trim off padding before L3 conntrack processing

On Tue, Dec 12, 2017 at 8:17 AM, Ed Swierk wrote: > A short IPv4 packet may have up to 6 bytes of padding following the IP > payload when received on an Ethernet device. > > In the normal IPv4 receive path, ip_rcv() trims the packet to > ip_hdr->tot_len before invoking

[ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

Found when compiling the code with C++ binaries. Most of the issues are due to missing explicit cast. Changes in PADDED_MEMBERS* is because MSVC does not allow to re-define unnamed structure in union. Thus, this fix defines the struct outside of the anonymous union in order to calculate the

Re: [ovs-dev] [PATCH v2] ovsdb: Improve documentation.

On Fri, Dec 08, 2017 at 07:56:43PM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > v1->v2: Rebase with minor changes. I reposted an expanded series as v3. This patch becomes the first patch of the new version, with no changes:

[ovs-dev] [PATCH v3 7/8] ovsdb-client: Add new "query" command.

This is mostly for symmetry with ovsdb-tool, but it might come in handy from time to time. Signed-off-by: Ben Pfaff --- NEWS| 2 +- ovsdb/ovsdb-client.1.in | 11 ovsdb/ovsdb-client.c| 67 -

[ovs-dev] [PATCH v3 6/8] ovsdb-client: Add new "restore" command.

Signed-off-by: Ben Pfaff --- Documentation/ref/ovsdb.7.rst | 11 +++-- NEWS | 2 +- lib/ovsdb-data.c | 76 - lib/ovsdb-data.h | 5 ++ lib/ovsdb-idl.c | 20 +---

[ovs-dev] [PATCH v3 5/8] ovsdb-client: Add new "backup" command.

Signed-off-by: Ben Pfaff --- Documentation/ref/ovsdb.7.rst | 4 ++ NEWS | 1 + ovsdb/file.c | 22 --- ovsdb/file.h | 2 + ovsdb/ovsdb-client.1.in | 18 ++ ovsdb/ovsdb-client.c | 134

[ovs-dev] [PATCH v3 1/8] ovsdb: Improve documentation.

Signed-off-by: Ben Pfaff --- Documentation/automake.mk| 5 +- Documentation/conf.py| 6 + Documentation/ref/index.rst | 3 + Documentation/ref/ovsdb-server.7.rst | 393 + Documentation/ref/ovsdb.5.rst| 125

[ovs-dev] [PATCH v3 4/8] log: New function ovsdb_log_compose_record().

This will acquire a new user later on. Signed-off-by: Ben Pfaff --- ovsdb/log.c | 55 --- ovsdb/log.h | 4 2 files changed, 36 insertions(+), 23 deletions(-) diff --git a/ovsdb/log.c b/ovsdb/log.c index

[ovs-dev] [PATCH v3 3/8] ovsdb-client; Add new "get-schema-cksum" command.

I don't have a particular use for this but it allows ovsdb-client to do all the things with schemas that ovsdb-tool can. Signed-off-by: Ben Pfaff --- NEWS | 1 + ovsdb/ovsdb-client.c | 13 + tests/ovsdb-client.at | 4 +++- 3 files changed, 17

[ovs-dev] [PATCH v3 2/8] ovsdb-client: Move ovsdb-client specific tests to new .at file.

Delete the "tcp socket" version of the test--really there's no point in trying everything over N different kinds of sockets. Signed-off-by: Ben Pfaff --- tests/automake.mk | 1 + tests/ovsdb-client.at | 11 +++ tests/ovsdb-server.at | 21 -

[ovs-dev] [PATCH v3 0/8] Add new ovsdb commands (and improve docs)

v1->v2: Rebase with minor changes. v2->v3: Add patches 2-8. Ben Pfaff (8): ovsdb: Improve documentation. ovsdb-client: Move ovsdb-client specific tests to new .at file. ovsdb-client; Add new "get-schema-cksum" command. log: New function ovsdb_log_compose_record(). ovsdb-client: Add new

Re: [ovs-dev] sparse issues

That is odd. Have you learned anything that points to the difference? On Wed, Dec 13, 2017 at 02:29:53PM -0800, Guru Shetty wrote: > Usually when devs have told me that sparse does not work for them, I ask > them not to install sparse with 'apt-get install' but rather to compile it > from source

Re: [ovs-dev] [PATCH] datapath: Enforce matching of kernel releases on loading openvswitch.ko

And one more thing I forgot to say. With latest distributions (e.g RHEL7.x or Ubuntu 16.04), they already come with a openvswitch kernel module (from upstream linux). And that kernel module gets placed in /lib/modules/'uname -r`/kernel/net/openvswitch. But that kernel module is tied to the

Re: [ovs-dev] [PATCH] datapath: Enforce matching of kernel releases on loading openvswitch.ko

Hi Guru, Thanks for clarifying it. In this case, this patch is not necessary. Best, Yifeng On Wed, Dec 13, 2017 at 2:24 PM, Guru Shetty wrote: > > > On 12 December 2017 at 07:59, Yifeng Sun wrote: > >> Deployment and upgrade failure is quite often caused

Re: [ovs-dev] [PATCH] datapath: Enforce matching of kernel releases on loading openvswitch.ko

On 12 December 2017 at 07:59, Yifeng Sun wrote: > Deployment and upgrade failure is quite often caused by that > openvswitch.ko was > built upon kernel x.y.z-release-A while it is loaded into a running kernel > of x.y.z-release-B. This patch proposes to enforce the

Re: [ovs-dev] [PATCH] datapath: Enforce matching of kernel releases on loading openvswitch.ko

Thanks for introducing dkms to me, I didn't know about it. If I am not wrong, it seems dkms can rebuild the openvswitch module against the new kernel release. That may solve the issue, but one concern is that the openvswitch.ko is not tested on the new release. When RHEL comes out with a new

Re: [ovs-dev] [PATCH] datapath: Enforce matching of kernel releases on loading openvswitch.ko

Yifeng Sun writes: > Thanks for your review. > > Since CONFIG_MODVERSIONS is default to 'y' in most cases, I'd say this > is to circumvent CONFIG_MODVERSIONS=y. > > This happened when redhat kernel was upgraded from > 3.10.0-514.el7.x86_64 to 3.10.0-693.1.1.el7.x86_64.

Re: [ovs-dev] [PATCH v3] ovsdb-idlc: Replace C/C++ keyword in column name

On Tue, Dec 12, 2017 at 01:17:40PM -0800, Yi-Hung Wei wrote: > With this patch, ovs-idlc appends an underscore to a column name > if it is a C or C++ keyword. Therefore, C and C++ compiler will > not get confused. > > Signed-off-by: Yi-Hung Wei Thanks, applied to master.

Re: [ovs-dev] [PATCH] datapath: Enforce matching of kernel releases on loading openvswitch.ko

Thanks for your review. Since CONFIG_MODVERSIONS is default to 'y' in most cases, I'd say this is to circumvent CONFIG_MODVERSIONS=y. This happened when redhat kernel was upgraded from 3.10.0-514.el7.x86_64 to 3.10.0-693.1.1.el7.x86_64. When 693 uses the openvswitch.ko built for 514, some error

Re: [ovs-dev] NoviFlow Experimenter VXLan encapsulation: Calculate the IP header checksum.

On Wed, Dec 13, 2017 at 02:55:45PM -0500, yann bourdeau wrote: > Hi all, > > I’m currently porting the NoviFlow Experiments OF (match, action, msg). > I’m currently porting the VXLan encapsulation and was wondering, by adding > new layers of ETH, IP, UDP and VXLAN before the existing

[ovs-dev] NoviFlow Experimenter VXLan encapsulation: Calculate the IP header checksum.

Hi all, I’m currently porting the NoviFlow Experiments OF (match, action, msg). I’m currently porting the VXLan encapsulation and was wondering, by adding new layers of ETH, IP, UDP and VXLAN before the existing packet, how to calculate the IP header checksum. I mean, if there is an

Re: [ovs-dev] [PATCH 3/3] ovsdb-parser: New function ovsdb_parser_put_error().

Thank you for the reviews. I made the improvement to patch 1 that you suggested, and pushed these to master. On Wed, Dec 13, 2017 at 11:25:40AM -0800, Yifeng Sun wrote: > Looks good to me. > > Reviewed-by: Yifeng Sun > > On Wed, Dec 13, 2017 at 10:04 AM, Ben Pfaff

Re: [ovs-dev] [PATCH] DNS: Add basic support for asynchronous DNS resolving

Thanks a lot Ben for your review. I will apply your advice in v2. Yifeng On Wed, Dec 13, 2017 at 11:02 AM, Ben Pfaff wrote: > On Mon, Dec 04, 2017 at 06:03:40AM -0800, Yifeng Sun wrote: > > This patch is a simple implementation for the proposal discussed in > >

Re: [ovs-dev] [PATCH 2/3] ovsdb-error: New function ovsdb_error_to_json_free().

Thanks for the change. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Wed, Dec 13, 2017 at 10:04 AM, Ben Pfaff wrote: > This simplifies little bits of code here and there. > > Signed-off-by: Ben Pfaff > --- >

Re: [ovs-dev] [PATCH 1/3] ovsdb-error: New function ovsdb_error_to_string_free().

Thanks for the change. I also find that this new function can be applied in another place: diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 1e0c20486e38..f9e4e529e32e 100644 --- a/ovsdb/ovsdb-server.c +++ b/ovsdb/ovsdb-server.c @@ -517,7 +517,7 @@ open_db(struct server_config

Re: [ovs-dev] [PATCH] DNS: Add basic support for asynchronous DNS resolving

On Mon, Dec 04, 2017 at 06:03:40AM -0800, Yifeng Sun wrote: > This patch is a simple implementation for the proposal discussed in > https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337038.html and > https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/340013.html. > > It enables

[ovs-dev] Evite gastos por demandas

Todo lo que necesita saber para negociar los términos de relaciones laborales Taller práctico de finiquitos y liquidaciones 20 de Diciembre - MCE. Abdón Guzmán - 9am-3pm Cuando no se cuenta con los conocimientos de derecho laboral y fiscal, así como las formas y procedimientos sólidos para

Re: [ovs-dev] [PATCH] datapath: Enforce matching of kernel releases on loading openvswitch.ko

Yifeng Sun writes: > Deployment and upgrade failure is quite often caused by that openvswitch.ko > was > built upon kernel x.y.z-release-A while it is loaded into a running kernel > of x.y.z-release-B. This patch proposes to enforce the matching of the two > kernel

[ovs-dev] sparse issues

There's been some talk about how sparse isn't working properly for you or some others. Let's try to figure that out. A few possibilities come to mind: - Maybe sparse isn't being detected at configure time. If it is detected, then Makefile should contain a nasty mess of a "make" conditional

[ovs-dev] [PATCH 3/3] ovsdb-parser: New function ovsdb_parser_put_error().

This will have its first user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/ovsdb-parser.c | 14 +- lib/ovsdb-parser.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-parser.c b/lib/ovsdb-parser.c index

[ovs-dev] [PATCH 2/3] ovsdb-error: New function ovsdb_error_to_json_free().

This simplifies little bits of code here and there. Signed-off-by: Ben Pfaff --- lib/ovsdb-error.c | 17 + lib/ovsdb-error.h | 1 + ovsdb/execution.c | 4 +--- ovsdb/jsonrpc-server.c | 24 ++-- 4 files changed, 25 insertions(+),

[ovs-dev] [PATCH 1/3] ovsdb-error: New function ovsdb_error_to_string_free().

This allows slight code simplifications across the tree. Signed-off-by: Ben Pfaff --- lib/ovsdb-data.c | 5 ++--- lib/ovsdb-error.c| 29 +++-- lib/ovsdb-error.h| 3 ++- lib/ovsdb-idl.c | 9 +++-- ovsdb/file.c | 7 ++-

Re: [ovs-dev] [PATCH 2/2] travis: Install libnuma dependency for DPDK.

On Tue, Dec 12, 2017 at 02:44:41PM +, Stokes, Ian wrote: > > libnuma is a default dependency for DPDK 17.11 because > > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES and CONFIG_RTE_LIBRTE_VHOST_NUMA are > > enabled by default for most architectures. > > libnuma-dev package installation fixes the DPDK

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

Jan Scheurich writes: > Hi Billy, > > My patches frequently get corrupted by our email system. When I submit > the v4 of the series adapted to the reverted dp_netdev_pmd_thread > struct changes I will try out another method of sending them. > > For now, could you

Re: [ovs-dev] [PATCH] netdev-dpdk: defer MTU set after interface start

"Stokes, Ian" writes: >> > The issue only arises with the qede PMD and 67fe6d635193 >> > ("netdev-dpdk: use rte_eth_dev_set_mtu.") >> >> I had some more time to look at this today but this patch will break >> OVS DPDK for existing supported DPDK ports during testing. >> >>

Re: [ovs-dev] [PATCH 0/3] Fix tunnel neighbor cache population

On 12/13/2017 2:49 AM, Zoltán Balogh wrote: Currenlty, OVS snoops any ARP or ND packets in any bridge and populates the tunnel neighbor cache with the retreived data. For instance, when ARP reply originated by a tenant is received on an overlay bridge, the ARP message is snooped and tunnel

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

Thanks Ben. I have sent V2 version of the patch covering category-3 errors for review. Warm Regards, Vishal -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Saturday, December 09, 2017 12:37 AM To: Vishal Deep Ajmera Cc:

[ovs-dev] [PATCH 3/3] dpif-netdev: Add percentage of pmd/core used by each rxq.

It is based on the length of history that is stored about an rxq (currently 1 min). $ ovs-appctl dpif-netdev/pmd-rxq-show pmd thread numa_id 0 core_id 4: isolated : false port: dpdkphy1 queue-id: 0pmd usage: 70 % port: dpdkvhost0 queue-id: 0pmd

[ovs-dev] [PATCH 2/3] dpif-netdev: Add rxq idle cycle counters.

This commit lays the groundwork for displaying stats about the cpu consumption used by an rxq. Displaying the processing cycles we measure for an rxq is not user friendly, so we will also collect rxq idle polling information. That will later allow us to show the percentage of a pmd/core that an

[ovs-dev] [PATCH 1/3] dpif-netdev: Reset the rxq current cycle counter on reload.

An rxq may have processing cycles counted in the current counter when a reload happens. That could temporarily create a small skew on the stats for an rxq. Reset the counter after reload. Fixes: 4809891b2e01 ("dpif-netdev: Count the rxq processing cycles for an rxq.") Signed-off-by: Kevin Traynor

Re: [ovs-dev] [PATCH] netdev-dpdk: defer MTU set after interface start

> > The issue only arises with the qede PMD and 67fe6d635193 > > ("netdev-dpdk: use rte_eth_dev_set_mtu.") > > I had some more time to look at this today but this patch will break OVS DPDK > for existing supported DPDK ports during testing. > > I tested with an XL710 and the MTU will fail to

Re: [ovs-dev] [PATCH] netdev-dpdk: defer MTU set after interface start

> > The issue only arises with the qede PMD and 67fe6d635193 > > ("netdev-dpdk: use rte_eth_dev_set_mtu.") > > I had some more time to look at this today but this patch will break OVS DPDK > for existing supported DPDK ports during testing. > > I tested with an XL710 and the MTU will fail to

Re: [ovs-dev] [PATCH 0/3] Fix tunnel neighbor cache population

> > Currenlty, OVS snoops any ARP or ND packets in any bridge and populates > > the tunnel neighbor cache with the retreived data. For instance, when > > ARP reply originated by a tenant is received on an overlay bridge, the > > ARP message is snooped and tunnel neighbor cache is filled with

[ovs-dev] [PATCH v2] docs: Fix table view for VM config in dpdk howto.

In current version table contains only one row with all the values together. This is not readable. 'Simple table' format should work for this case. Additionally, some words capitalized to look better and be conform with other tables in the file. CC: Stephen Finucane Fixes:

Re: [ovs-dev] [PATCH] docs: Fix table view for VM config in dpdk howto.

On 13.12.2017 12:27, Stephen Finucane wrote: > On Tue, 2017-12-12 at 16:19 +0300, Ilya Maximets wrote: >> In current version table contains only one row with all the values >> together. This is not readable. 'Simple table' format should work for >> this case. >> >> CC: Stephen Finucane

Re: [ovs-dev] [PATCH] docs: Fix table view for VM config in dpdk howto.

On Tue, 2017-12-12 at 16:19 +0300, Ilya Maximets wrote: > In current version table contains only one row with all the values > together. This is not readable. 'Simple table' format should work for > this case. > > CC: Stephen Finucane > Fixes: 167703d664fc ("doc: Convert

[ovs-dev] (no subject)

Hi Dev http://bit.ly/2C0kDU9 Thanks! Scott ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev