Re: [ovs-dev] packaging

2018-04-18 Thread Raymond Burkholder
On 04/17/2018 06:19 PM, Ben Pfaff wrote: On Sat, Apr 14, 2018 at 12:19:02PM -0300, Raymond Burkholder wrote: On 04/13/2018 02:52 PM, Ben Pfaff wrote: I'm quite sympathetic to that viewpoint--I think that OVS currently has far too much distro-specific stuff in it. In the long run I'd like to d

Re: [ovs-dev] [PATCH v4 0/2] Fix tunnel neighbor cache population

2018-04-18 Thread Ben Pfaff
On Wed, Apr 04, 2018 at 11:57:52PM +0200, Jan Scheurich wrote: > Currently, OVS snoops any ARP or ND packets in any bridge and populates > the tunnel neighbor cache with the retrieved data. For instance, when > ARP reply originated by a tenant is received on an overlay bridge, the > ARP packet is s

Re: [ovs-dev] [PATCH v4] ofproto-dpif-xlate: makes OVS native tunneling honor tunnel-specified source addresses

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 11:03:47AM +0800, we...@ucloud.cn wrote: > From: wenxu > > It makes OVS native tunneling honor tunnel-specified source addresses, > in the same way that Linux kernel tunneling honors them. > > This patch made valid tun_src specified by flow-action can be used for > tunnel

Re: [ovs-dev] [PATCH v2] ovs-ofctl: Fixed the "snoop" command of ovs-ofctl

2018-04-18 Thread Ben Pfaff
On Tue, Apr 17, 2018 at 06:40:46PM -0700, Ashish Varma wrote: > In normal ovs-ofctl commands (e.g. add-flow), ovs-ofctl connects to > ovs-vswitchd process on “/.mgmt” unix socket. > In an output that contains a port or table, port name or table name can be > displayed, instead of their numbers, if

Re: [ovs-dev] [PATCH] Adding cli for displaying LACP counters

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 11:57:43PM +0530, Nitin Katiyar wrote: > Currently OVS does not provide any command to display stats for LACP > without which it is difficult to debug LACP issues. Here we propose > to display various statistics about LACP PDUs and slave state change. > > Sample output: >

Re: [ovs-dev] [PATCH] tutorial: skip passing .db for backup option for ovn_start_ovsdb_server:

2018-04-18 Thread Ben Pfaff
On Wed, Apr 11, 2018 at 05:43:01PM -0700, aginwala wrote: > current params uses two sb1.db which is redundant: > e.g. ovsdb-server --remote=punix:sb1.ovsdb sb1.db sb1.db > expected: > e.g. ovsdb-server --remote=punix:sb1.ovsdb sb1.db > > tested and works as expected: > ovn-sbctl --db=unix:/root/ov

[ovs-dev] [PATCH] tutorial: skip passing .db for backup option for ovn_start_ovsdb_server:

2018-04-18 Thread aginwala
current params uses two sb1.db which is redundant: e.g. ovsdb-server --remote=punix:sb1.ovsdb sb1.db sb1.db expected: e.g. ovsdb-server --remote=punix:sb1.ovsdb sb1.db tested and works as expected: ovn-sbctl --db=unix:/root/ovs/tutorial/sandbox/sb2.ovsdb show Chassis "chassis-1" hostname: sand

Re: [ovs-dev] [PATCH 6/6] python: Tighten the check if we need encoding

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 06:01:15PM +0200, Jakub Sitnicki wrote: > Check if we are dealing with a Unicode string for Python 2 and we need > to encode it before sending it, just as we do already for Python 3. > > Also, do the encoding the same way for Python 2 and 3 and avoid using > negation to mak

Re: [ovs-dev] [PATCH 5/6] python: Fix a double encoding attempt on an Unicode string

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 06:01:14PM +0200, Jakub Sitnicki wrote: > Encoding from 'unicode' to 'str' that has been added to the Stream class > in commit 2254074e3067 ("python: fix python3 encode/decode on Windows") > conflicts with SSLStream which already contains a quirk for pyopenssl > that does th

Re: [ovs-dev] [PATCH 4/6] tests: Extend Python IDL checks to also run with SSL

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 06:01:13PM +0200, Jakub Sitnicki wrote: > Extend the macro for running a Python IDL test against an OVSDB server > that uses SSL so that it can be used for regular IDL tests and for the > notify tests. > > This makes it easy to generate additional Python IDL tests that run

[ovs-dev] [RFC v2 1/2] dpdk: allow init to fail

2018-04-18 Thread Aaron Conole
It's possible for dpdk initialization to fail either due to an internal error or an invalid configuration. When that happens, it's rather impolite to immediately abort without any details. With this change, a failed dpdk initialization attempt will continue to trigger a SIGABRT. However, the fai

[ovs-dev] [RFC v2 2/2] dpdk: reflect status and version in the database

2018-04-18 Thread Aaron Conole
The normal way of retrieving the running DPDK status involves parsing log files and issuing various incantations of ovs-vsctl and ovs-appctl commands to determine whether the rte_eal_init successfully started. This commit adds two new records to reflect the dpdk version, and the dpdk initializatio

[ovs-dev] [RFC v2 0/2] dpdk: minor refactor of the initialization step

2018-04-18 Thread Aaron Conole
Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort in that case. When that occurs, ovs-vswitchd will be restarted by the monitor and immediately abort. This is rather unfriendly to users, who would prefer to possibly correct the issue or at least, not have lots of processes cont

Re: [ovs-dev] [PATCH 3/6] tests: Reuse OVSDB_CHECK_IDL_PYN macro for IDL notify tests

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 06:01:12PM +0200, Jakub Sitnicki wrote: > OVSDB_CHECK_IDL_NOTIFY_PYN macro is the same as OVSDB_CHECK_IDL_PYN > except it doesn't support PRE-IDL-TXN parameter. Reuse the more generic > OVSDB_CHECK_IDL_PYN macro. > > Signed-off-by: Jakub Sitnicki Thanks. This is much nic

Re: [ovs-dev] [PATCH 2/6] tests: Remove useless run-if-fail commands passed to AT_CHECK

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 06:01:11PM +0200, Jakub Sitnicki wrote: > Path to ovsdb-server's pidfile has changed long ago when > ovsdb_start_idltest() helper was introduced in commit 561205007e17 > ("tests: Get rid of overly specific --pidfile and --unixctl options.") > but the run-if-fail commands wer

Re: [ovs-dev] [PATCH 1/6] tests: Complain if key and certs not provided for SSL connection

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 06:01:10PM +0200, Jakub Sitnicki wrote: > Add an argument check to test-ovsdb.py to ensure that the user has > provided the private key, the certificate, and the peer CA certificate > needed to set up an SSL connection. > > Signed-off-by: Jakub Sitnicki Applied to master,

Re: [ovs-dev] [patch v1] netdev: If MTU set fails, issue warn log.

2018-04-18 Thread Ben Pfaff
On Wed, Apr 18, 2018 at 10:52:58AM -0700, Darrell Ball wrote: > Recently, an issue was debugged that was thought to be a bond > failover triggered issue. It turned out to an vlan interface MTU set issue > that had nothing to do with bonding or most other likely possibilities. > Besides the effect

Re: [ovs-dev] [PATCH] python: Fix reporting that test-ovsdb.py command needs more args

2018-04-18 Thread Ben Pfaff
Thanks Jakub and Mark, I applied this to master. On Wed, Apr 18, 2018 at 10:14:48AM -0500, Mark Michelson wrote: > Acked-by: Mark Michelson > > On 04/18/2018 05:35 AM, Jakub Sitnicki wrote: > >In Python OVSDB tester, we are not unpacking a value from n_args tuple > >that holds the accepted range

[ovs-dev] [patch v1] netdev: If MTU set fails, issue warn log.

2018-04-18 Thread Darrell Ball
Recently, an issue was debugged that was thought to be a bond failover triggered issue. It turned out to an vlan interface MTU set issue that had nothing to do with bonding or most other likely possibilities. Besides the effect of not setting the MTU to the desired value, this can result in increa

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-18 Thread Kevin Traynor
On 04/18/2018 03:41 PM, Pablo Cascón wrote: > On 13/04/18 19:45, Kevin Traynor wrote: >> On 04/13/2018 04:20 PM, Stokes, Ian wrote: Currently to RX jumbo packets fails for NICs not supporting scatter. Scatter is not strictly needed for jumbo support on RX. This change fixes the

[ovs-dev] 8 razones para asistir a este webinar

2018-04-18 Thread Excelentes lectores desde la infancia
Cómo preparar excelentes lectores desde la primera infancia Abril 27 - webinar Interactivo Objetivo: En esta capacitación veremos los detalles de una metodología que está revolucionando la manera de enseñar a leer y que está soportada científicamente. Le daremos los detalles para que em

[ovs-dev] [PATCH 6/6] python: Tighten the check if we need encoding

2018-04-18 Thread Jakub Sitnicki
Check if we are dealing with a Unicode string for Python 2 and we need to encode it before sending it, just as we do already for Python 3. Also, do the encoding the same way for Python 2 and 3 and avoid using negation to make the code simpler. Signed-off-by: Jakub Sitnicki --- python/ovs/stream

[ovs-dev] [PATCH 5/6] python: Fix a double encoding attempt on an Unicode string

2018-04-18 Thread Jakub Sitnicki
Encoding from 'unicode' to 'str' that has been added to the Stream class in commit 2254074e3067 ("python: fix python3 encode/decode on Windows") conflicts with SSLStream which already contains a quirk for pyopenssl that does the same thing. This results in a double encoding attempt when SSL is use

[ovs-dev] [PATCH 4/6] tests: Extend Python IDL checks to also run with SSL

2018-04-18 Thread Jakub Sitnicki
Extend the macro for running a Python IDL test against an OVSDB server that uses SSL so that it can be used for regular IDL tests and for the notify tests. This makes it easy to generate additional Python IDL tests that run using SSL, so do it. As it turns out, newly added SSL tests unearth a pre

[ovs-dev] [PATCH 3/6] tests: Reuse OVSDB_CHECK_IDL_PYN macro for IDL notify tests

2018-04-18 Thread Jakub Sitnicki
OVSDB_CHECK_IDL_NOTIFY_PYN macro is the same as OVSDB_CHECK_IDL_PYN except it doesn't support PRE-IDL-TXN parameter. Reuse the more generic OVSDB_CHECK_IDL_PYN macro. Signed-off-by: Jakub Sitnicki --- tests/ovsdb-idl.at | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --gi

[ovs-dev] [PATCH 2/6] tests: Remove useless run-if-fail commands passed to AT_CHECK

2018-04-18 Thread Jakub Sitnicki
Path to ovsdb-server's pidfile has changed long ago when ovsdb_start_idltest() helper was introduced in commit 561205007e17 ("tests: Get rid of overly specific --pidfile and --unixctl options.") but the run-if-fail commands were left behind. Besides, we don't need to kill the ovs-db-server from th

[ovs-dev] [PATCH 1/6] tests: Complain if key and certs not provided for SSL connection

2018-04-18 Thread Jakub Sitnicki
Add an argument check to test-ovsdb.py to ensure that the user has provided the private key, the certificate, and the peer CA certificate needed to set up an SSL connection. Signed-off-by: Jakub Sitnicki --- tests/test-ovsdb.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-

[ovs-dev] [PATCH 0/6] Run Python IDL checks using SSL

2018-04-18 Thread Jakub Sitnicki
This patch set extends the Python IDL checks so that SSL is used and fixes a Unicode encoding issue with SSLStream that the newly added tests expose. The mentioned issue has also been independently reported by Marcin Mirecki (oVirt). Jakub Sitnicki (6): tests: Complain if key and certs not prov

Re: [ovs-dev] [PATCH v2] rhel: user/group openvswitch does not exist

2018-04-18 Thread Aaron Conole
Markos Chandras writes: > Hi Aaron, > > On 18/04/18 15:51, Aaron Conole wrote: >> v2: >> * Removed the requires(post) lines >> * Removed 'exit 0' > > I realize that I was the one suggested to drop 'exit 0', but right at > the bottom of > https://fedoraproject.org/wiki/Packaging:UsersAndGroups#D

Re: [ovs-dev] [PATCH v4] tests: Add system-dpdk-testsuite

2018-04-18 Thread Stokes, Ian
> Hi Ian, > > Appreciate your comments and findings. See my replies inline. > > > > -Original Message- > > From: Stokes, Ian > > Sent: Tuesday, April 17, 2018 8:50 PM > > To: Rybka, MarcinX ; d...@openvswitch.org > > Cc: Rybka, MarcinX > > Subject: RE: [ovs-dev] [PATCH v4] tests: Add sy

Re: [ovs-dev] [PATCH v2 7/9] doc: Move "pdump" guide to its own document

2018-04-18 Thread Stokes, Ian
> -Original Message- > From: Stephen Finucane [mailto:step...@that.guru] > Sent: Monday, April 16, 2018 3:30 PM > To: d...@openvswitch.org > Cc: Stokes, Ian ; Stephen Finucane > > Subject: [PATCH v2 7/9] doc: Move "pdump" guide to its own document > > Yet another section that's far too de

Re: [ovs-dev] [PATCH v2 6/9] doc: Add "bridge" topic document

2018-04-18 Thread Stokes, Ian
> This details configuration steps that apply to the entire bridge, rather > than individual ports. > > Signed-off-by: Stephen Finucane > --- > v2: > - Cross-reference this document from all interface documents > --- > Documentation/howto/dpdk.rst | 60 -- > Document

Re: [ovs-dev] [PATCH v2 5/9] doc: Move "QoS" guide to its own document

2018-04-18 Thread Stokes, Ian
> Again, this stuff is too detailed for a high-level howto. > > Signed-off-by: Stephen Finucane > --- > v2: > - Keep flow control section in 'phy' document > --- > Documentation/howto/dpdk.rst| 42 > Documentation/topics/dpdk/index.rst | 1 + > Documentation/topics/

Re: [ovs-dev] [PATCH v2 9/9] doc: Final cleanup of the DPDK documents

2018-04-18 Thread Stokes, Ian
> This concludes the cleanup by fixing some nits and adding some additional > cross-references. > LGTM. Ian > Signed-off-by: Stephen Finucane > --- > v2: > - Add changes to DPDK topic index doc > --- > Documentation/howto/dpdk.rst| 51 > - > Documen

Re: [ovs-dev] [PATCH v2 4/9] doc: Add "vdev" topic document

2018-04-18 Thread Stokes, Ian
> These are separate things from physical, ring and vhost-user interfaces > and deserve their own documents. A couple of small typos are fixed along > the way. > > Signed-off-by: Stephen Finucane > --- > Documentation/howto/dpdk.rst| 29 -- > Documentation/topics/dpdk/ind

Re: [ovs-dev] [PATCH v2 8/9] doc: Add "jumbo frames" topic document

2018-04-18 Thread Stokes, Ian
> We include refrences from the physical and vhost-user interface guides. Minor type above, 'reference'. > > Signed-off-by: Stephen Finucane > --- > v2: > - Don't split the document into multiple docs > --- > Documentation/howto/dpdk.rst | 52 ++ > Documentati

Re: [ovs-dev] [PATCH v2 3/9] doc: Move additional sections to "physical ports" doc

2018-04-18 Thread Stokes, Ian
> The "hotplugging", "flow control", and "Rx checksum offload" sections only > apply to 'dpdk' ports and are too detailed to include in a high-level > howto. Move them, reworking some aspects of this in the process. > > Signed-off-by: Stephen Finucane > --- > v2: > - Split out vdev into its own d

Re: [ovs-dev] [PATCH v2 2/9] doc: Add "PMD" topic document

2018-04-18 Thread Stokes, Ian
> This continues the breakup of the huge DPDK "howto" into smaller > components. There are a couple of related changes included, such as using > "Rx queue" instead of "rxq" and noting how Tx queues cannot be configured. > > Signed-off-by: Stephen Finucane > --- > v2: > - Add cross-references from

Re: [ovs-dev] [PATCH v2 1/9] doc: Add an overview of the 'dpdk' port

2018-04-18 Thread Stokes, Ian
> These ports are used to allow ingress/egress from the host and are > therefore _reasonably_ important. However, there is no clear overview of > what these ports actually are or why things are done the way they are. > Start closing this gap by providing a standalone example of using these > ports

Re: [ovs-dev] [PATCH v4] tests: Add system-dpdk-testsuite

2018-04-18 Thread Rybka, MarcinX
Hi Ian, Appreciate your comments and findings. See my replies inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday, April 17, 2018 8:50 PM > To: Rybka, MarcinX ; d...@openvswitch.org > Cc: Rybka, MarcinX > Subject: RE: [ovs-dev] [PATCH v4] tests: Add system-dpdk-testsuite >

Re: [ovs-dev] [PATCH] python: Fix reporting that test-ovsdb.py command needs more args

2018-04-18 Thread Mark Michelson
Acked-by: Mark Michelson On 04/18/2018 05:35 AM, Jakub Sitnicki wrote: In Python OVSDB tester, we are not unpacking a value from n_args tuple that holds the accepted range of arguments. This causes an error: $ python tests/test-ovsdb.py idl tests/idltest.schema Traceback (most recent cal

Re: [ovs-dev] [PATCH v2] rhel: user/group openvswitch does not exist

2018-04-18 Thread Markos Chandras
Hi Aaron, On 18/04/18 15:51, Aaron Conole wrote: > v2: > * Removed the requires(post) lines > * Removed 'exit 0' I realize that I was the one suggested to drop 'exit 0', but right at the bottom of https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation it seems that 'exit 0'

[ovs-dev] [PATCH v2] rhel: user/group openvswitch does not exist

2018-04-18 Thread Aaron Conole
From: Alan Pevec Default ownership[1] for config files is failing on an empty system: Running scriptlet: openvswitch-2.9.0-3.fc28.x86_64 warning: user openvswitch does not exist - using root warning: group openvswitch does not exist - using root ... Required user/group need to be created in %p

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-18 Thread Pablo Cascón
On 13/04/18 19:45, Kevin Traynor wrote: On 04/13/2018 04:20 PM, Stokes, Ian wrote: Currently to RX jumbo packets fails for NICs not supporting scatter. Scatter is not strictly needed for jumbo support on RX. This change fixes the issue by only enabling scatter for NICs supporting it. Add a quirk

[ovs-dev] [PATCH] python: Fix reporting that test-ovsdb.py command needs more args

2018-04-18 Thread Jakub Sitnicki
In Python OVSDB tester, we are not unpacking a value from n_args tuple that holds the accepted range of arguments. This causes an error: $ python tests/test-ovsdb.py idl tests/idltest.schema Traceback (most recent call last): File "./tests/test-ovsdb.py", line 869, in main(sys.argv)

[ovs-dev] [PATCH] Adding cli for displaying LACP counters

2018-04-18 Thread Nitin Katiyar
Currently OVS does not provide any command to display stats for LACP without which it is difficult to debug LACP issues. Here we propose to display various statistics about LACP PDUs and slave state change. Sample output: ovs_lacp # ovs-appctl lacp/stats-show bond-prv statistics slave:

Re: [ovs-dev] [PATCH v2 2/3] ofproto-dpif: Improve dp_hash selection method for select groups

2018-04-18 Thread Jan Scheurich
> How about this approach, which should cleanly eliminate the warning? > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index e1a5c097f3aa..362339a4abb4 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -4780,22 +4780,17 @@ group_setup_dp_hash_table(struct