On 15.05.2018 20:18, Ben Pfaff wrote:
> On Tue, May 15, 2018 at 02:23:38PM +0300, Ilya Maximets wrote:
>> Unconditional return may cause packet leak in case of
>> 'may_steal == true'.
>>
>> Additionally, removed redundant checking for depth level and
>> clarified ignoring of the 'false' value of 'm
Unconditional return may cause packet leak in case of
'should_steal == true'.
Additionally, removed redundant checking for depth level.
CC: Sugesh Chandran
Fixes: 7c12dfc527a5 ("tunneling: Avoid datapath-recirc by
combining recirc actions at xlate.")
Signed-off-by: Ilya Max
On 24.05.2018 11:52, Ilya Maximets wrote:
> On 15.05.2018 20:18, Ben Pfaff wrote:
>> On Tue, May 15, 2018 at 02:23:38PM +0300, Ilya Maximets wrote:
>>> Unconditional return may cause packet leak in case of
>>> 'may_steal == true'.
>>>
>>> Additionally, removed redundant checking for depth level and
> On 24.05.2018 11:52, Ilya Maximets wrote:
> > On 15.05.2018 20:18, Ben Pfaff wrote:
> >> On Tue, May 15, 2018 at 02:23:38PM +0300, Ilya Maximets wrote:
> >>> Unconditional return may cause packet leak in case of 'may_steal ==
> >>> true'.
> >>>
> >>> Additionally, removed redundant checking for d
On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote:
> The struct erspan_metadata is updated to replace the 'version'
> placeholder with the erspan base hdr. Also, the erspan
> index is defined explicitly as ovs_16aligned_be32 to mirror
> its encoding.
> Changes to odp_util result from updating t
On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote:
> Flagged by clang.
>
> CC: William Tu
> Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
> Signed-off-by: Darrell Ball
> ---
LGTM, thanks
Acked-by: William Tu
___
dev mailing list
d...
From: venkata anil
When a vm on a vlan tenant network sends traffic to an external network,
it is tunneled from host chassis to gateway chassis. In the earlier
discussion [1], Russel (also in his doc [2]) suggested if we can figure
out a way for OVN to do this redirect to the gateway host over a
When we host-update the DPDK-OVS, we may run at least
two ovs-vswitchd (If kill one, and then spawn anther
one may take more time, such as DPDK memory alloc.).
while multiple ovs-vswitchd running, switch ports of
qemu maybe easy.
This patch aim to support multiple ovs-vswitchd process
and only aff
To: netdev, dev@openvswitch
Cc: Eric Dumazet (author of ff04a771ad), debian bug
Hi,
As follow-up to my bug report at Debian [0], I'm trying to do bug triage
and find out more. I'm not the expert here, but anything could help, and
it's an opportunity to learn things.
I'm observing the attached er
This is the snippet from MSDN:
https://msdn.microsoft.com/en-us/library/windows/desktop/aa366358(v=vs.85).aspx
The SendARP function is used to request the physical hardware address
(sometimes referred to as the MAC address) that corresponds to a specified
destination IPv4 address. If the infor
The current default OpenFlow select group implementation sends every new L4 flow
to the slow path for the balancing decision and installs a 5-tuple "miniflow"
in the datapath to forward subsequent packets of the connection accordingly.
Clearly this has major scalability issues with many parallel L
This commit implements a new dp_hash algorithm OVS_HASH_L4_SYMMETRIC in
the netdev datapath. It will be used as default hash algorithm for the
dp_hash-based select groups in a subsequent commit to maintain
compatibility with the symmetry property of the current default hash
selection method.
A new
The dp_hash selection method for select groups overcomes the scalability
problems of the current default selection method which, due to L2-L4
hashing during xlation and un-wildcarding of the hashed fields,
basically requires an upcall to the slow path to load-balance every
L4 connection. The conseq
The current implementation of the "dp_hash" selection method suffers
from two deficiences: 1. The hash mask and hence the number of dp_hash
values is just large enough to cover the number of group buckets, but
does not consider the case that buckets have different weights. 2. The
xlate-time selecti
On 5/23/2018 7:19 PM, Rohith Basavaraja wrote:
Hi Ben,
Only changes in
datapath/linux/compat/include/linux/openvswitch.h
are related to OvS Kernel module.
The changes in openvswitch.h are not upstreamed yet.
Can you please let me know the procedure for submitting the
Changes for OvS Kernel Mod
Hi Numan,
I'm running it by you before posting because I've kept your sign-off on your
patch but trimmed down to just the tests with mostly cosmetic adjustments.
I'm holding off on sending it out until I get your OK.
Thanks,
Jakub
---
This series has grown out of previously discussed patch - [
From: Numan Siddique
Check the application of conjunctive matching to logical flow match
expressions. In particular cover the case where conjunctive matching is
applied to ACL match expressions that refer to Address Sets.
Mark Michelson who tested a similar patch [1] has found a significant
impr
Appending prerequisites to sub-expressions of OR that are all over one
symbol prevents the expression-to-matches converter from applying
conjunctive matching. This happens during the annotation phase.
input: s1 == { c1, c2 } && s2 == { c3, c4 }
expanded: (s1 == c1 || s1 == c2) && (s2 == c3
On Thu, 24 May 2018 17:45:51 +0200
Jakub Sitnicki wrote:
> Hi Numan,
>
> I'm running it by you before posting because I've kept your sign-off on your
> patch but trimmed down to just the tests with mostly cosmetic adjustments.
>
> I'm holding off on sending it out until I get your OK.
>
> Than
The MSDN entry is really unclear. It says that it sends an ARP request,
if necessary. I cannot find anything in the entry that says whether, if
it sends an ARP request, it waits for a reply.
However, this stackoverflow entry implies that it does wait for a reply:
https://stackoverflow.com/questi
It's more work to selectively flush and no one has implemented that.
On Thu, May 24, 2018 at 02:55:00AM +, Lilijun (Jerry, Cloud Networking)
wrote:
> Are there anybody has some ideas about this question?
> Thanks.
>
> -邮件原件-
> 发件人: Lilijun (Jerry, Cloud Networking)
> 发送时间: 2018年5月18
On Thu, May 24, 2018 at 05:55:00AM -0700, William Tu wrote:
> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote:
> > Flagged by clang.
> >
> > CC: William Tu
> > Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
> > Signed-off-by: Darrell Ball
> > ---
> LGTM, thanks
> Acked-by: Wil
On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote:
> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote:
> > The struct erspan_metadata is updated to replace the 'version'
> > placeholder with the erspan base hdr. Also, the erspan
> > index is defined explicitly as ovs_16aligned_be32 to
Several OVS structs contain embedded named unions, like this:
struct {
...
union {
...
} u;
};
C11 standardized a feature that many compilers already implemented
anyway, where an embedded union may be unnamed, like this:
struct {
...
union {
...
};
};
Thi
We've actually made a lot of improvements.
Signed-off-by: Ben Pfaff
---
ovn/TODO.rst | 26 --
1 file changed, 26 deletions(-)
diff --git a/ovn/TODO.rst b/ovn/TODO.rst
index 34615b9bc7d4..101a127d8054 100644
--- a/ovn/TODO.rst
+++ b/ovn/TODO.rst
@@ -25,17 +25,9 @@
OVN To
On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote:
> On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote:
>> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote:
>> > The struct erspan_metadata is updated to replace the 'version'
>> > placeholder with the erspan base hdr. Also, the erspan
Thanks for pointing this out. It might be better to simply add a static ARP
entry when adding an IPFIX collector. This way we do not trigger this for every
packet.
We are currently documenting this as a workaround for using IPFIX collectors on
the same subnet as the Hyper-V host. This patch w
Whatsapp
Business
Fecha: 14/Junio/2018
Horario: 10:00 a 13:00 y 15:00 a 18:00 horas
"En esta capacitación virtual en vivo podra conocer todo lo que debes saber
sobre cómo vender de manera efectiva con WhatsApp. "
Temario:
Qué es WhatsApp para Empresas.
Beneficios de WhatsApp para Em
Greetings,
Let's work together!
We are a trusted digital marketing agency for more than 10 years, our team
of 200+ marketing gurus has served over 4000 clients. Our unique
"Pay-for-performance" model attracts customers from all geographies of the
world, and we are proud to cater to the need
On Mon, May 21, 2018 at 04:44:13PM +0100, Ciara Loftus wrote:
> The vHost PMD brings vHost User port types ('dpdkvhostuser' and
> 'dpdkvhostuserclient') under control of DPDK's librte_ether API, like
> all other DPDK netdev types ('dpdk' and 'dpdkr'). In doing so, direct
> calls to DPDK's librte_vh
On Thu, May 24, 2018 at 05:45:51PM +0200, Jakub Sitnicki wrote:
> Hi Numan,
>
> I'm running it by you before posting because I've kept your sign-off on your
> patch but trimmed down to just the tests with mostly cosmetic adjustments.
>
> I'm holding off on sending it out until I get your OK.
>
>
On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote:
> On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote:
> > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote:
> >> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote:
> >> > The struct erspan_metadata is updated to replace the 'v
On Thu, May 24, 2018 at 02:19:06AM +, Rohith Basavaraja wrote:
> Only changes in
> datapath/linux/compat/include/linux/openvswitch.h
> are related to OvS Kernel module.
On a second look, I see that the new stuff here is only for the DPDK
datapath. If you don't intend to add this feature t
ovn-controller currently recomputes everything when there are any changes
of input, which leads to high CPU usages and slow in end-to-end flow
enforcement in response to changes. It even wastes CPU to recompute flows
for unrelated inputs such as pinctrl events.
This patch series implements increme
This patch implements the engine which will be used in future patches
for ovn-controller incremental processing.
Signed-off-by: Han Zhou
---
ovn/lib/automake.mk| 4 +-
ovn/lib/inc-proc-eng.c | 141 ++
ovn/lib/inc-proc-eng.h | 202
Track OVSDB changes for future patches of incremental processing
Signed-off-by: Han Zhou
---
ovn/controller/bfd.c| 4 ++--
ovn/controller/binding.c| 16
ovn/controller/encaps.c | 12 ++--
ovn/controller/ovn-controller.c | 22 +
Incremental proccessing engine is used to compute flows. In this
patch we only create 2 engine nodes with simple dependency:
runtime_data -> flow_output
In each iteration everything is still recomputed.
Signed-off-by: Han Zhou
---
ovn/controller/ofctrl.c | 21 +-
ovn/controller/ofc
Create nodes for ovs_idl inputs and add ovs_idl inputs and
SB inputs as dependencies for runtime_data. With this patch
there is no recomputed if there is no change in input. For
example, pinctrl input will not trigger flow recompute any
more.
Signed-off-by: Han Zhou
---
ovn/controller/ovn-contro
This patch expands the incremental processing by spliting SB inputs
from runtime_data and add them as input for flow_output.
Signed-off-by: Han Zhou
---
ovn/controller/ovn-controller.c | 44 -
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/o
Evaluates change for SB port-binding in runtime_data node.
If the port-binding change has no impact for the runtime_data it will
not trigger runtime_data change.
Signed-off-by: Han Zhou
---
ovn/controller/binding.c| 92 +
ovn/controller/binding.h
Signed-off-by: Han Zhou
---
ovn/controller/ovn-controller.c | 13 +
ovn/lib/inc-proc-eng.c | 20
ovn/lib/inc-proc-eng.h | 4
3 files changed, 33 insertions(+), 4 deletions(-)
diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ov
Signed-off-by: Han Zhou
---
ovn/controller/ovn-controller.c | 37 -
ovn/controller/physical.c | 23 +++
ovn/controller/physical.h | 7 ++-
3 files changed, 65 insertions(+), 2 deletions(-)
diff --git a/ovn/controller/ovn-co
This patch implements change handler for port-binding in flow_output
for physical flows computing, so that physical flow computing will
be incremental.
This patch together with previous incremental processing engine
related changes supports incremental processing for lflow changes
and port-binding
Persistents flow-table and implements change handler of flow_output
for SB lflow changes.
Signed-off-by: Han Zhou
---
include/ovn/actions.h | 3 +
ovn/controller/lflow.c | 178 +++--
ovn/controller/lflow.h | 20 +++-
ovn/controller/ofctrl.c
On Wed, May 23, 2018 at 4:00 PM, Ben Pfaff wrote:
>
> On Mon, May 14, 2018 at 07:23:20PM -0700, Han Zhou wrote:
> > This patch implements the engine which will be used in future patches
> > for ovn-controller incremental processing.
> >
> > Signed-off-by: Han Zhou
>
> Thanks a lot for working on
On Thu, May 24, 2018 at 03:15:13PM -0700, Han Zhou wrote:
> (Somehow the cover letter always missing in patchwork...)
Yeah, patchwork only tracks patches.
Cover letters don't get into Git, either, since they don't become part
of commits, so when there's important information in a cover letter it'
Deze email nieuwsbrief werd in grafisch HTML formaat verzonden.
Als u deze tekstversie ziet, verkiest uw email programma "gewone tekst" emails.
U kan de originele nieuwsbrief online bekijken:
https://ymlpsend3.com/z8l
> On May 24, 2018, at 11:00 AM, Ben Pfaff wrote:
>
> We've actually made a lot of improvements.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo
> On May 24, 2018, at 10:32 AM, Ben Pfaff wrote:
>
> Several OVS structs contain embedded named unions, like this:
>
> struct {
>...
>union {
>...
>} u;
> };
>
> C11 standardized a feature that many compilers already implemented
> anyway, where an embedded union may be unna
> On May 23, 2018, at 4:39 PM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On May 23, 2018, at 3:15 PM, Ben Pfaff wrote:
>
> The tests probe whether the host has IPv6 support and, if it doesn't, skip
> the tests that require IPv6. However, until now, when the host lacks
> support, this caused a Python exception to be printed, like this:
>
> Traceback (most recent c
> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote:
>
> This test is supposed to be parameterized, but one of the loops didn't
> honor the parameterization and just had hardcoded values. Also, the
> output comparison didn't work properly for more than 100 client sets
> (n1 > 100), so this adds some
> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote:
>
> Until now the timing in the cluster torture test has been pretty
> inaccurate because it just worked by calling "sleep 1" in a loop that
> did other things. The longer those other things too, the more inaccurate
> it got.
s/too/took
Acked-by
> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote:
>
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index babda21defff..d81fcaeb440d 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> ...
> @@ -123,7 +125,7 @@ _man_pages = [
> ('ovsdb.5',
> u'Open vSwitch
On Thu, May 24, 2018 at 2:16 PM, Ben Pfaff wrote:
> On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote:
>> On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote:
>> > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote:
>> >> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote:
>> >>
> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote:
>
> There's no value in having these testing tools log to syslog. It just
> pollutes the system log.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvsw
> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote:
>
> These utilities logged the command very early, before parsing the options
> or the command. This meant that logging options (like --log-file or
> -vsyslog:off) weren't considered for the purpose of logging the command.
> This fixes the problem
Whatsapp
Business
Fecha: 14/Junio/2018
Horario: 10:00 a 13:00 y 15:00 a 18:00 horas
"En esta capacitación virtual en vivo podra conocer todo lo que debes saber
sobre cómo vender de manera efectiva con WhatsApp. "
Temario:
Qué es WhatsApp para Empresas.
Beneficios de WhatsApp para Em
Hi Ben,
Thanks for your reply very much.
Currently, if we delete a port, ovs only flush the related datapath flows.
So I have an opinions as follows:
When deleting the ovs bridge br-plyXXX, we can flush per br-plyXXX's port
related datapath flows instead of flush all datapath flow
On Thu, May 24, 2018 at 05:22:37PM -0700, William Tu wrote:
> On Thu, May 24, 2018 at 2:16 PM, Ben Pfaff wrote:
> > On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote:
> >> On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote:
> >> > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote
> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On May 18, 2018, at 10:16 AM, Ben Pfaff wrote:
>
> The purpose of including an OpenFlow version in the notes in meta-flow.h
> and ovs-fields.7 is to explain what version of OpenFlow standardized a
> given field. NXOXM_* are not standardized so they should not have an
> OpenFlow version. This
> On May 18, 2018, at 10:16 AM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Ben for the clarification. Yes this new stuff is used only in the
DPDK datapath and it’s not used in the kernel datapath.
Thanks
Rohith
On 25/05/18, 2:52 AM, "Ben Pfaff" wrote:
On Thu, May 24, 2018 at 02:19:06AM +, Rohith Basavaraja wrote:
> Only changes in
> datapath/l
Hi Greg,
Thanks a lot for sharing the info.
Ben clarified that it should be ok if this new stuff is used only in the
DPDK datapath and it’s not used in the kernel datapath.
Thanks
Rohith
On 24/05/18, 9:05 PM, "Gregory Rose" wrote:
On 5/23/2018 7:19 PM, Rohith Basavaraja wrote:
> Hi B
66 matches
Mail list logo