Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Ben Pfaff needs to sign off.
Lines checked: 113, Warnings: 0, Errors: 1
Please
I have been playing with the OFTest framework off and on over the last
few months and I believe it's caught an actual bug with its
DirectVlanPackets test. I'm appending a script that demonstrates it.
To see it, run "make sandbox" then execute the script inside it.
At some level at least, the
Hi,
Thanks for your inputs. I shall leave the signed off field intact in my future
patches.
Regards
Bhargava
On September 28, 2018 8:09:02 PM GMT+02:00, Ben Pfaff wrote:
>Is it the list archive that you're worried about? The archive does
>this
>kind of minor obfuscation of email addresses
Is it the list archive that you're worried about? The archive does this
kind of minor obfuscation of email addresses anyway.
On Fri, Sep 28, 2018 at 07:44:36PM +0200, Bhargava Shastry wrote:
> Hi Aaron,
>
> The mistake is on my part. I am breaking up my email by hand because I
> fear bots on
Bhargava Shastry writes:
> Hi Aaron,
>
> The mistake is on my part. I am breaking up my email by hand because I
> fear bots on the Internet are going to pick up well formatted emails and
> send spam :-)
>
> Is my concern well-founded? Do you have any suggestions for fighting
> auto-scraping of
On 9/28/18, 5:03 AM, "Aaron Conole" wrote:
Darrell Ball writes:
> Below is the recent private commit message I have for the patch:
>
> However, I plan to split out to 3 main patches, with probably a few minor
> cosmetic patches.
>
> 1/ cmap performance and
This reverts commit 90c7afc96cbbd77f44094b5b651261968e97de67.
When the commit was merged, the code used nf_ct_put() to free
the entry, but later on commit 76644232e612 ("openvswitch: Free
tmpl with tmpl_free.") replaced that with nf_ct_tmpl_free which
is a more appropriate. Now the original
Load the respective NAT helper module if the flow uses it.
Signed-off-by: Flavio Leitner
---
net/openvswitch/conntrack.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index 86a75105af1a..7e9a5283e236 100644
---
Hi Aaron,
The mistake is on my part. I am breaking up my email by hand because I
fear bots on the Internet are going to pick up well formatted emails and
send spam :-)
Is my concern well-founded? Do you have any suggestions for fighting
auto-scraping of email addresses?
Regards,
Bhargava
On
Hi Ben,
> 25 seconds would be really long. I think you could reasonably lower
> it to just 1 or 2 seconds.
Somehow, even the 25 second timeout is being exceeded with non-trivial
frequency. I'm afraid that if we lower it to 1-2 seconds, oss-fuzz is
going to file a lot of bugs. I am trying out
On Fri, Sep 28, 2018 at 02:00:39PM +0200, Bhargava Shastry wrote:
> 3. Does it make sense to impose a time out for expr_parse_target? The
> default time out used by oss-fuzz fuzzing engines is 25 seconds i.e., a
> bug is automatically filed for inputs that take longer than 25 seconds
> to be
On Fri, Sep 28, 2018 at 01:39:44PM +0200, Bhargava Shastry wrote:
> 1. Does it make sense to move the fuzzer build script to Openvswitch
> repo in the long run?
If you'd be happy with it there, I'm OK with moving it.
> 2. Does it make sense to impose a size limit on inputs to the
>
On Wed, Sep 26, 2018 at 2:58 AM Stefano Brivio wrote:
>
> Hi Pravin,
>
> On Wed, 15 Aug 2018 00:19:39 -0700
> Pravin Shelar wrote:
>
> > I understand fairness has cost, but we need to find right balance
> > between performance and fairness. Current fairness scheme is a
> > lockless algorithm
Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#40 FILE: lib/dp-packet.c:306:
* XXX: This function is the
The following tests are added to the DPDK testsuite to add some
coverage for the multi-segment mbufs:
- Check that multi-segment mbufs are disabled by default;
- Check that providing `other_config:dpdk-multi-seg-mbufs=true` indeed
enables mbufs;
- Using a DPDK port, send a random packet out and
As it stands, OVS_DPDK_START() won't allow other configs to be set
before starting the ovs-vswitchd daemon. This is a problem since some
configs, such as the "dpdk-multi-seg-mbufs=true" for enabling the
multi-segment mbufs, need to be set prior to start OvS.
To support other options,
In order to create a minimal environment that allows the tests to get
mbufs from an existing mempool, the following approach is taken:
- EAL is initialised (by using the main dpdk_init()) and a (very) small
mempool is instantiated (mimicking the logic in dpdk_mp_create()).
This mempool
From: Mark Kavanagh
Currently, jumbo frame support for OvS-DPDK is implemented by
increasing the size of mbufs within a mempool, such that each mbuf
within the pool is large enough to contain an entire jumbo frame of
a user-defined size. Typically, for each user-defined MTU,
'requested_mtu', a
Previous commits have added support to the dp_packet API to handle
multi-segmented packets, where data is not stored contiguously in
memory. However, in some cases, it is inevitable and data must be
provided contiguously. Examples of such cases are when performing csums
over the entire packet
From: Mark Kavanagh
Currently, packets are only copied to a single segment in the function
dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames,
particularly when multi-segment mbufs are involved.
This patch calculates the number of segments needed by a packet and
copies the
From: Michael Qiu
When doing packet clone, if packet source is from DPDK driver,
multi-segment must be considered, and copy the segment's data one by
one.
Also, lots of DPDK mbuf's info is missed during a copy, like packet
type, ol_flags, etc. That information is very important for DPDK to do
In its current implementation dp_packet_shift() is also unaware of
multi-seg mbufs (that holds data in memory non-contiguously) and assumes
that data exists contiguously in memory, memmove'ing data to perform the
shift.
To add support for multi-seg mbuds a new set of functions was
introduced,
Most helper functions in dp-packet assume that the data held by a
dp_packet is contiguous, and perform operations such as pointer
arithmetic under that assumption. However, with the introduction of
multi-segment mbufs, where data is non-contiguous, such assumptions are
no longer possible. Some
When a dp_packet is from a DPDK source, and it contains multi-segment
mbufs, the data_len is not equal to the packet size, pkt_len. Instead,
the data_len of each mbuf in the chain should be considered while
distributing the new (provided) size.
To account for the above dp_packet_set_size() has
A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise
allocation and free operations by non-pmd threads on a given mempool.
free_dpdk_buf() has been modified to make use of the introduced mutex.
Signed-off-by: Tiago Lam
Acked-by: Eelco Chaudron
---
lib/netdev-dpdk.c | 33
When enabled with DPDK OvS deals with two types of packets, the ones
coming from the mempool and the ones locally created by OvS - which are
copied to mempool mbufs before output. In the latter, the space is
allocated from the system, while in the former the mbufs are allocated
from a mempool,
From: Mark Kavanagh
dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's
possible the the resultant mbuf portion of the dp_packet contains
random data. For some mbuf fields, specifically those related to
multi-segment mbufs and/or offload features, random values may cause
From: Mark Kavanagh
There are numerous factors that must be considered when calculating
the size of an mbuf:
- the data portion of the mbuf must be sized in accordance With Rx
buffer alignment (typically 1024B). So, for example, in order to
successfully receive and capture a 1500B packet,
Overview
This patchset introduces support for multi-segment mbufs to OvS-DPDK.
Multi-segment mbufs are typically used when the size of an mbuf is
insufficient to contain the entirety of a packet's data. Instead, the
data is split across numerous mbufs, each carrying a portion, or
bshas...@sect.tu-berlin.de writes:
> From: Bhargava Shastry
>
> oss-fuzz options file must begin with a [libfuzzer] header.
> This was missing in the expr_parse_target.options file which this patch
> fixes.
>
> Signed-off-by: Bhargava Shastry
> ---
Just wanted to let you know that the bot is
Bleep bloop. Greetings Bhargava Shastry, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Bhargava Shastry needs to sign off.
WARNING: Unexpected sign-offs from
Darrell Ball writes:
> Below is the recent private commit message I have for the patch:
>
> However, I plan to split out to 3 main patches, with probably a few minor
> cosmetic patches.
>
> 1/ cmap performance and code simplification.
> 2/ Eliminating exporting private datastructures to outside
Sorry, I overlooked a third question (addendum to the previous two):
3. Does it make sense to impose a time out for expr_parse_target? The
default time out used by oss-fuzz fuzzing engines is 25 seconds i.e., a
bug is automatically filed for inputs that take longer than 25 seconds
to be processed
Hi Ben,
Please ignore my comment regarding build (under the heading === 1. Build
===). There was a bug in my earlier patch which I fixed in my latest
patch. Please don't rename anything in OvS repo or in the
ovs-fuzzing-corpus repo. Local tests show everything works as expected.
However, two
From: Bhargava Shastry
oss-fuzz options file must begin with a [libfuzzer] header.
This was missing in the expr_parse_target.options file which this patch
fixes.
Signed-off-by: Bhargava Shastry
---
tests/oss-fuzz/config/expr_parse_target.options | 1 +
1 file changed, 1 insertion(+)
diff
Printing of the SMC hits missed in the 'dpif-netdev/pmd-perf-show'
appctl command.
CC: Yipeng Wang
Fixes: 60d8ccae135f ("dpif-netdev: Add SMC cache after EMC cache")
Signed-off-by: Ilya Maximets
Acked-by: Yipeng Wang
---
lib/dpif-netdev-perf.c | 3 +++
lib/dpif-netdev-perf.h | 2 +-
In the review process of the original patch 'masked hits' stat
was renamed to 'megaflow hits', but the man page wasn't updated.
Fixes: 6553d06bd179 ("dpif-netdev: Add dpif-netdev/pmd-stats-*
appctl commands.")
Signed-off-by: Ilya Maximets
---
lib/dpif-netdev-unixctl.man |
Version 2:
* Fixed typo: 'smc hists' --> 'smc hits'.
Ilya Maximets (2):
dpif-netdev-unixctl: Change 'masked' to 'megaflow'.
dpif-netdev-perf: Print SMC statistics.
lib/dpif-netdev-perf.c | 3 +++
lib/dpif-netdev-perf.h | 2 +-
lib/dpif-netdev-unixctl.man | 3 ++-
3 files
Hi Ben,
Thanks for taking a close look applying the (edited) patch. I have a
couple of comments:
=== 1. Build ===
Currently, all fuzzer test harnesses in OvS are built by this bash
script located at Google oss-fuzz repo [1]. The peculiar thing about
Google's fuzz infrastructure is that it
On 27.09.2018 19:25, Wang, Yipeng1 wrote:
> Thank you Ilya for adding this!
>
> Besides the small comment, otherwise
>
> Acked-by: Yipeng Wang
>
>> -Original Message-
>> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>> Sent: Wednesday, September 26, 2018 10:19 AM
>> To:
Add a symmetric_l3 hash method that uses both network destination
address and network source address.
VMware-BZ: #2112940
Signed-off-by: Martin Xu
CC: Ben Pfaff
---
v1->v2: add eth_type as part of the hash fields;
added unit tests in multipath, bundle, oss-fuzz, ovs-ofctl
Ltd.___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
42 matches
Mail list logo
