Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

On Thu, Nov 1, 2018, 5:18 AM Ben Pfaff Thanks! > > On Wed, Oct 31, 2018 at 04:28:00PM -0700, Yifeng Sun wrote: > > For the second question, if there is error reading /etc/resolv.conf, > > currently we print a warning and continue trying to resolve names. > > As you said, I will create a patch to

Re: [ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

On Thu, Nov 1, 2018 at 5:32 AM Flavio Leitner wrote: > > > Hi Sriharsha, > > Do you mind to send this again but directly to > d...@openvswitch.org > instead of > ovs-dev@openvswitch.org ? > > I received spam with the same issue but only when sent to > ovs-dev@ > > Thanks, > fbl Hi Flavio,

Re: [ovs-dev] ovn-controller: function ofctrl_inject_pkt() with wrong parameter

Bleep bloop. Greetings xurong00037997, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author xurong00037997 needs to sign off. Lines checked: 26, Warnings: 0, Errors: 1

Re: [ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

On Thu, Nov 1, 2018 at 2:01 AM Ben Pfaff wrote: > > On Wed, Oct 31, 2018 at 01:11:58PM -0700, Ben Pfaff wrote: > > On Thu, Nov 01, 2018 at 12:51:41AM +0530, Sriharsha Basavapatna via dev > > wrote: > > > A few lines with form feed characters (ASCII: ^L) were accidentally > > > deleted by a

[ovs-dev] [PATCH] ovn-controller: function ofctrl_inject_pkt() with wrong parameter

--- ovn/controller/ovn-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 2b2779a..dd481b6 100644 --- a/ovn/controller/ovn-controller.c +++ b/ovn/controller/ovn-controller.c @@ -792,7 +792,7 @@

Re: [ovs-dev] ovn-controller: function ofctrl_inject_pkt() with wrong parameter

Bleep bloop. Greetings xurong00037997, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author xurong00037997 needs to sign off. Lines checked: 26, Warnings: 0, Errors: 1

[ovs-dev] [PATCH] ovn-controller: function ofctrl_inject_pkt() with wrong parameter

--- ovn/controller/ovn-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 2b2779a..dd481b6 100644 --- a/ovn/controller/ovn-controller.c +++ b/ovn/controller/ovn-controller.c @@ -792,7 +792,7 @@

[ovs-dev] How to create vxlan gpe tunnels on the same underlay with different end-points ?

I dont know if this the right mailing list for vxlan gpe related queries but since I saw several posts pertaining to vxlan-gpe in the archives, so hoping that someone can help: I am trying to create multiple vxlan-gpe tunnel interfaces (with different vnis) over the same underlay endpoints.  I

Re: [ovs-dev] [PATCH] dpif-netdev: End the quiescent state for flow offloading thread.

On Wed, Oct 31, 2018 at 06:44:09PM +0300, Ilya Maximets wrote: > Flow offloading thread uses concurrent hash maps which are > based on rcu protected variables. It must use them while in > active state. Working in a quiescent state could cause > segmentation faults because of possible cmap internal

Re: [ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

Hi Sriharsha, Do you mind to send this again but directly to d...@openvswitch.org instead of ovs-dev@openvswitch.org ? I received spam with the same issue but only when sent to ovs-dev@ Thanks, fbl On Thu, Nov 01, 2018 at 12:51:41AM +0530, Sriharsha Basavapatna via dev wrote: > A few lines

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

Thanks! On Wed, Oct 31, 2018 at 04:28:00PM -0700, Yifeng Sun wrote: > For the second question, if there is error reading /etc/resolv.conf, > currently we print a warning and continue trying to resolve names. > As you said, I will create a patch to let dns resolving fail for this case. > >

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

For the second question, if there is error reading /etc/resolv.conf, currently we print a warning and continue trying to resolve names. As you said, I will create a patch to let dns resolving fail for this case. Thanks, Yifeng On Wed, Oct 31, 2018 at 3:59 PM Ben Pfaff wrote: > OK, that answers

Re: [ovs-dev] [PATCH 3/6] connmgr: Improve interface for setting controllers.

Thanks, I applied this to master. On Wed, Oct 31, 2018 at 02:49:28PM -0700, Yifeng Sun wrote: > Thanks for the improvement. > > Tested-by: Yifeng Sun > Reviewed-by: Yifeng Sun > > On Mon, Oct 29, 2018 at 3:59 PM Ben Pfaff wrote: > > > Using an shash instead of an array simplifies the code

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

OK, that answers the first question. What about if no DNS servers are available; what does the resolver do in that case? On Wed, Oct 31, 2018 at 03:24:13PM -0700, Yifeng Sun wrote: > Hi Ben, > > The dns resolving depends on libunbound's ub_resolve, which, from > Numan's experience as well as my

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

Hi Ben, The dns resolving depends on libunbound's ub_resolve, which, from Numan's experience as well as my reading on its documentation, doesn't support timeout. I agree there is a bug and we should fix it. Thanks, Yifeng On Wed, Oct 31, 2018 at 1:59 PM Ben Pfaff wrote: > On Thu, Oct 25, 2018

Re: [ovs-dev] [PATCH 3/6] connmgr: Improve interface for setting controllers.

Thanks for the improvement. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Mon, Oct 29, 2018 at 3:59 PM Ben Pfaff wrote: > Using an shash instead of an array simplifies the code for both the caller > and the callee. Putting the set of allowed OpenFlow versions into the >

Re: [ovs-dev] [PATCH 2/6] rconn: New function rconn_is_reliable().

Yes, I am reviewing 3. Please ask someone else to review 4+. Thanks. Yifeng On Wed, Oct 31, 2018 at 1:47 PM Ben Pfaff wrote: > On Wed, Oct 31, 2018 at 01:40:59PM -0700, Ben Pfaff wrote: > > Thanks for the reviews, I applied patches 1 and 2. > > > > Do you plan to review further patches? I

Re: [ovs-dev] [branch 2.9][PATCH] ovn: Fix IPv6 DAD failure for container ports

On Tue, 23 Oct 2018 at 03:22, wrote: > From: Numan Siddique > > When a container port is created inside a VM, the below kernel message > is seen and IPv6 doesn't work on that interface. > > [ 138.000753] IPv6: vlan4: IPv6 duplicate address detected! > > When a container port sends a ethernet

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

On Thu, Oct 25, 2018 at 03:27:41PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > When 'make check' is called by the mock rpm build (which disables networking), > the test "ovn-nbctl: LBs - daemon" fails when it runs the command > "ovn-nbctl lb-add lb0 30.0.0.1a

Re: [ovs-dev] [PATCH 2/6] rconn: New function rconn_is_reliable().

On Wed, Oct 31, 2018 at 01:40:59PM -0700, Ben Pfaff wrote: > Thanks for the reviews, I applied patches 1 and 2. > > Do you plan to review further patches? I understand that patch 3 is > more ambitious, so I'd be happy to ask someone else, if you do not want > to invest the time. Well, actually

Re: [ovs-dev] [PATCH 2/6] rconn: New function rconn_is_reliable().

Thanks for the reviews, I applied patches 1 and 2. Do you plan to review further patches? I understand that patch 3 is more ambitious, so I'd be happy to ask someone else, if you do not want to invest the time. On Tue, Oct 30, 2018 at 02:35:55PM -0700, Yifeng Sun wrote: > Looks good, thanks! >

Re: [ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

On Wed, Oct 31, 2018 at 01:11:58PM -0700, Ben Pfaff wrote: > On Thu, Nov 01, 2018 at 12:51:41AM +0530, Sriharsha Basavapatna via dev wrote: > > A few lines with form feed characters (ASCII: ^L) were accidentally > > deleted by a recent commit to support rebalancing of offloaded flows. > > This

Re: [ovs-dev] [PATCH] contributing: Signed-off-by tags should come last.

On Wed, Oct 31, 2018 at 03:30:59PM -0300, Flavio Leitner wrote: > On Wed, Oct 31, 2018 at 11:02:08AM -0700, Ben Pfaff wrote: > > Suggested-by: Gregory Rose > > Signed-off-by: Ben Pfaff > > --- > > Documentation/internals/contributing/submitting-patches.rst | 6 ++ > > 1 file changed, 6

Re: [ovs-dev] [PATCH] submitting-patches: Advise not to wrap tags across multiple lines.

On Wed, Oct 31, 2018 at 03:32:07PM -0300, Flavio Leitner wrote: > On Wed, Oct 31, 2018 at 11:06:50AM -0700, Ben Pfaff wrote: > > It makes parsing them more difficult. > > It does, indeed. > Acked-by: Flavio Leitner Thanks Flavio and Greg, I applied this to master.

[ovs-dev] FedEx Shipment 987411053**** Tendered to FedEx

___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

On Thu, Nov 01, 2018 at 12:51:41AM +0530, Sriharsha Basavapatna via dev wrote: > A few lines with form feed characters (ASCII: ^L) were accidentally > deleted by a recent commit to support rebalancing of offloaded flows. > This patch reverts those lines. > > Fixes: 57924fc91c ("revalidator:

[ovs-dev] From Mrs Susan

I’m Mrs Susan Armstrong, an aging widow suffering from the cancer disease for a long period of time and my only son (Kevin) later died in a motor accident. I have ($4.800.000.00 usd) I want to donate for humanitarian aid. If you will be able to use these funds please reply to me.Remain

Re: [ovs-dev] dpif: Restore a few lines with form feed characters

Bleep bloop. Greetings Sriharsha Basavapatna via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Sriharsha Basavapatna via dev needs to sign off. WARNING:

[ovs-dev] Elaboración de manuales de políticas y procedimientos

¡Aún estamos a tiempo! La elaboración de manuales precisos en sus indicaciones y claros ayuda en gran medida a garantizar la calidad en los procesos, productos y servicios, por otra parte, optimiza el trabajo eliminando el desperdicio organizacional e incrementa el nivel de

[ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

A few lines with form feed characters (ASCII: ^L) were accidentally deleted by a recent commit to support rebalancing of offloaded flows. This patch reverts those lines. Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") Signed-off-by: Sriharsha Basavapatna --- lib/dpif.c

Re: [ovs-dev] [PATCH] submitting-patches: Advise not to wrap tags across multiple lines.

On Wed, Oct 31, 2018 at 11:06:50AM -0700, Ben Pfaff wrote: > It makes parsing them more difficult. It does, indeed. Acked-by: Flavio Leitner > > Signed-off-by: Ben Pfaff > --- > Documentation/internals/contributing/submitting-patches.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [ovs-dev] [PATCH] contributing: Signed-off-by tags should come last.

On Wed, Oct 31, 2018 at 11:02:08AM -0700, Ben Pfaff wrote: > Suggested-by: Gregory Rose > Signed-off-by: Ben Pfaff > --- > Documentation/internals/contributing/submitting-patches.rst | 6 ++ > 1 file changed, 6 insertions(+) LGTM Acked-by: Flavio Leitner > diff --git

Re: [ovs-dev] [PATCH v1] Docs: Remove HWOL DPDK limitation.

On Thu, Oct 25, 2018 at 05:50:44PM +0100, Ian Stokes wrote: > Partial offload support was added to OVS DPDK in OVS 2.10. As such > remove the limitation that OVS DPDK does not support HWOL from the > DPDK install documentation. > > Signed-off-by: Ian Stokes The Flow HWOF is documented as

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

On Wed, Oct 31, 2018 at 11:18 PM Yifeng Sun wrote: > What I actually meant to say is to add a default timeout to present > dns_resolve__, say 15 seconds. > Then other parts of code won't need be changed. If you think this is good, > I will create a patch. > Sounds good to me. Please note that

Re: [ovs-dev] [PATCH] contributing: Signed-off-by tags should come last.

On 10/31/2018 11:02 AM, Ben Pfaff wrote: Suggested-by: Gregory Rose Signed-off-by: Ben Pfaff --- Documentation/internals/contributing/submitting-patches.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/internals/contributing/submitting-patches.rst

Re: [ovs-dev] [PATCH] submitting-patches: Advise not to wrap tags across multiple lines.

On 10/31/2018 11:06 AM, Ben Pfaff wrote: It makes parsing them more difficult. Signed-off-by: Ben Pfaff --- Documentation/internals/contributing/submitting-patches.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/internals/contributing/submitting-patches.rst

[ovs-dev] [PATCH] submitting-patches: Advise not to wrap tags across multiple lines.

It makes parsing them more difficult. Signed-off-by: Ben Pfaff --- Documentation/internals/contributing/submitting-patches.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/internals/contributing/submitting-patches.rst

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On Wed, Oct 31, 2018 at 10:40:36AM -0700, Gregory Rose wrote: > On 10/31/2018 10:32 AM, Ben Pfaff wrote: > >On Wed, Oct 31, 2018 at 08:35:13AM -0700, Gregory Rose wrote: > >>The order of tags should be: > >>Reported-at: > >>Fixes: > >>Signed-off-by: > >I agree that's the most common order but do

[ovs-dev] [PATCH] contributing: Signed-off-by tags should come last.

Suggested-by: Gregory Rose Signed-off-by: Ben Pfaff --- Documentation/internals/contributing/submitting-patches.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/internals/contributing/submitting-patches.rst

Re: [ovs-dev] [PATCH v1 2/2] netdev-dpdk: Add link speed to get_status().

On Tue, Oct 30, 2018 at 01:10:51PM +, Stokes, Ian wrote: > > > Report the link speed of the device in netdev_dpdk_get_status() > > > function. > > > > > > Link speed is already reported as part of the netdev_get_features() > > > function. However only link speeds defined in the OpenFlow specs

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

First go at it https://www.spinics.net/lists/netdev/msg531328.html Changed the commit message to something a bit more verbose. BR Jaime. -Original Message- From: Gregory Rose To: Yi-Hung Wei Cc: ovs dev , jcaam...@suse.de Subject: Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop

Re: [ovs-dev] [PATCH v2 3/3] ovn-northd: Fix memory leak in free_chassis_queueid().

On Wed, Oct 31, 2018 at 11:00:15PM +0530, Numan Siddique wrote: > On Wed, Oct 31, 2018 at 3:36 AM Ben Pfaff wrote: > > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Numan Siddique Thanks for the reviews. I applied both patches to master and backported patch 3.

Re: [ovs-dev] [PATCH] ovn-northd: Use structure assignment instead of memcpy().

On Wed, Oct 31, 2018 at 11:17:34PM +0530, Numan Siddique wrote: > On Wed, Oct 31, 2018 at 3:21 AM Ben Pfaff wrote: > > > Makes the code easier to read. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Numan Siddique Thanks, applied to master. ___

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

What I actually meant to say is to add a default timeout to present dns_resolve__, say 15 seconds. Then other parts of code won't need be changed. If you think this is good, I will create a patch. Thanks, Yifeng On Tue, Oct 30, 2018 at 9:34 PM Numan Siddique wrote: > > > On Tue, Oct 30, 2018

Re: [ovs-dev] [PATCH] ovn-northd: Use structure assignment instead of memcpy().

On Wed, Oct 31, 2018 at 3:21 AM Ben Pfaff wrote: > Makes the code easier to read. > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique > --- > ovn/northd/ovn-northd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/northd/ovn-northd.c

Re: [ovs-dev] [PATCH] ovs-lib.in: Remove unnecessary conntrack flush

On Tue, Oct 30, 2018 at 03:03:26PM -0700, Gregory Rose wrote: > On 10/30/2018 1:47 PM, Yi-Hung Wei wrote: > >We introduced flush-conntrack in force-reload-kmod script by commit > >8bea39b186ca ("datapath: Prevent panic") to prevent kernel panic. > >It turns out that the kernel panic is actually

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On 10/31/2018 10:32 AM, Ben Pfaff wrote: On Wed, Oct 31, 2018 at 08:35:13AM -0700, Gregory Rose wrote: The order of tags should be: Reported-at: Fixes: Signed-off-by: I agree that's the most common order but do we have anything that says so? (Should we?) Uh - good point.  I don't know of

Re: [ovs-dev] [PATCH v2 2/3] ovn-northd: Improve hashing for chassis queues.

On Wed, Oct 31, 2018 at 3:35 AM Ben Pfaff wrote: > The key for a "struct ovn_chassis_qdisc_queues" is a Chassis UUID and a > queue_id, but only the UUID was being hashed, so if there was more than one > per chassis then they'd all end up in the same hash bucket, which is > needlessly

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On Wed, Oct 31, 2018 at 08:35:13AM -0700, Gregory Rose wrote: > The order of tags should be: > Reported-at: > Fixes: > Signed-off-by: I agree that's the most common order but do we have anything that says so? (Should we?) ___ dev mailing list

Re: [ovs-dev] [PATCH v2 3/3] ovn-northd: Fix memory leak in free_chassis_queueid().

On Wed, Oct 31, 2018 at 3:36 AM Ben Pfaff wrote: > Found by inspection. > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique > --- > ovn/northd/ovn-northd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c > index

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

Honestly the best thing to do is probably to propose a design or, if it's simple enough, to send a patch. That will probably be more effective at sparking a discussion. On Wed, Oct 31, 2018 at 03:33:48PM +, venugopal iyer wrote: > Hi: > Just wanted to check if folks had any thoughts on the

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Dump flow patterns only if debug enabled.

> No need to waste time for fields checking in case DBG disabled. > Additionally sequence of prints replaced with single print to avoid output > interrupting by other log messages. > I think these changes make sense, I don't have the HW to test however so I might wait for someone to test this

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Drop offload API for vhost ports.

Hi, It is a good idea to remove the macro from the h file. Please find more comments inline > -Original Message- > From: Lam, Tiago [mailto:tiago@intel.com] > Sent: Wednesday, October 31, 2018 2:41 PM > To: Stokes, Ian ; Ilya Maximets > ; ovs-dev@openvswitch.org; Ophir Munk > > Cc:

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions")

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Print port name in offload API messages.

> This is useful for understanding which flows offloaded to which ports. > > Code refactored a bit to reduce number of casts. > > Signed-off-by: Ilya Maximets Thanks for this Ilya, weirdly this patch didn't apply (the only one in the series). I've applied manually and tested, LGTM. Will be

Re: [ovs-dev] [PATCH V2] erspan: fix error handling for erspan tunnel

This one has been sitting around for about 40 days now. William, can you please review? Thanks, - Greg On 9/21/2018 7:54 AM, Greg Rose wrote: From: Haishuang Yan Upstream commit: commit 51dc63e3911fbb1f0a7a32da2fe56253e2040ea4 Author: Haishuang Yan Date: Mon Sep 10

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On Wed, Oct 31, 2018 at 9:44 AM Gregory Rose wrote: > > On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote: > > When validating push/pop ethernet actions, mac_proto is not being reset > > correctly. > > > > Reported-at: > > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On 10/31/2018 9:56 AM, Yi-Hung Wei wrote: On Wed, Oct 31, 2018 at 9:44 AM Gregory Rose wrote: On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Reported-at:

Re: [ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

On Wed, Oct 31, 2018 at 04:56:07PM +0530, Sriharsha Basavapatna wrote: > On Wed, Oct 31, 2018 at 10:02 AM Ben Pfaff wrote: > > > > On Wed, Oct 31, 2018 at 09:01:59AM +0530, Sriharsha Basavapatna wrote: > > > On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff wrote: > > > > > > > > On Mon, Oct 29, 2018 at

Re: [ovs-dev] [RFC PATCH v2] datapath-windows: Remove IP neighbor entries when internal adapter is down.

Also applied on branch-2.10. — Alin. > On 24 Oct 2018, at 21:24, aserd...@ovn.org wrote: > > Thanks for the patch Anand! Applied on master. > > Alin > >>> >>> Remove the IP neighboring entries when adapter is down, so that when >>> 'OVS_IPHELPER_INSTANCE' is deleted, no stale entries are

Re: [ovs-dev] [PATCH] datapath-windows: Move OVS_IPHELPER_INSTANCE to IpHelper.h

Also applied on branch-2.10. — Alin. > On 2 Oct 2018, at 20:07, Alin Gabriel Serdean wrote: > > Applied on master! > >> On 2 Oct 2018, at 16:16, Alin Gabriel Serdean wrote: >> >> >> >>> On 30 Sep 2018, at 14:53, Alin Gabriel Serdean >> > wrote: >>>

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

When validating push/pop ethernet actions, mac_proto is not being reset correctly. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions") Signed-off-by: Jaime Caamaño Ruiz ---

Re: [ovs-dev] [PATCH] treewide: Fix spelling of "receive".

Also applied on branch-2.10. — Alin. > On 27 Sep 2018, at 20:22, Ben Pfaff wrote: > > On Wed, Sep 26, 2018 at 11:03:26PM -0700, Justin Pettit wrote: >> >>> On Sep 26, 2018, at 4:12 PM, Ben Pfaff wrote: >>> >>> Signed-off-by: Ben Pfaff >> >> Ha. >> >> Acked-by: Justin Pettit > > Thanks,

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

Hi: Just wanted to check if folks had any thoughts on the use case Girish outlined below. We do have a real use case for this and are interested in looking at options for supporting more than one VTEP IP.It is currently a limitation for us, wanted to know if there are similar use cases folks

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On 10/31/2018 8:30 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add

[ovs-dev] [PATCH] dpif-netdev: End the quiescent state for flow offloading thread.

Flow offloading thread uses concurrent hash maps which are based on rcu protected variables. It must use them while in active state. Working in a quiescent state could cause segmentation faults because of possible cmap internal structure changes. Fixes: 02bb2824e51d ("dpif-netdev: do hw flow

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions") ---

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

On 10/31/2018 5:35 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz The patch looks good Jaime, I also suggest the following tags: Reported-at:

[ovs-dev] R Keith Beal (N1ZT)'s invitation is awaiting your response

Hi , R Keith would like to connect on LinkedIn. How would you like to respond? Accept:

Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Fix cmap node use after free on flow disassociation.

> Data pointed by cmap node must not be freed while iterating. > ovsrcu_postpone should be used instead. > LGTM, I'll include this is this weeks pull request. Ian > CC: Finn Christensen > Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") > Signed-off-by: Ilya Maximets

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Drop offload API for vhost ports.

On 31/10/2018 11:40, Stokes, Ian wrote: >> On 31.10.2018 13:42, Stokes, Ian wrote: vhost ports are not DPDK eth ports and has no rte_flow API. Stop calling this API with DPDK_ETH_PORT_ID_INVALID to avoid time wasting and errors in log. Additionally, DPDK_FLOW_OFFLOAD_API

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz --- datapath/flow_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index c3f1baa05..ee0c18422

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Drop offload API for vhost ports.

> On 31.10.2018 13:42, Stokes, Ian wrote: > >> vhost ports are not DPDK eth ports and has no rte_flow API. > >> Stop calling this API with DPDK_ETH_PORT_ID_INVALID to avoid time > >> wasting and errors in log. > >> > >> Additionally, DPDK_FLOW_OFFLOAD_API definition moved to .c file, > >> because

Re: [ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

On Wed, Oct 31, 2018 at 10:02 AM Ben Pfaff wrote: > > On Wed, Oct 31, 2018 at 09:01:59AM +0530, Sriharsha Basavapatna wrote: > > On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff wrote: > > > > > > On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev > > > wrote: > > > > A few lines

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Drop offload API for vhost ports.

On 31.10.2018 13:42, Stokes, Ian wrote: >> vhost ports are not DPDK eth ports and has no rte_flow API. >> Stop calling this API with DPDK_ETH_PORT_ID_INVALID to avoid time wasting >> and errors in log. >> >> Additionally, DPDK_FLOW_OFFLOAD_API definition moved to .c file, because >> there is no

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Secure flow offload API.

> rte API is not thread safe. We have to get netdev mutex before uing it and > also before using fields of netdev structure. > > This is important because offload API used from the separate thread and > could be used at the same time with other netdev functions called from the > main thread.

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Drop offload API for vhost ports.

> vhost ports are not DPDK eth ports and has no rte_flow API. > Stop calling this API with DPDK_ETH_PORT_ID_INVALID to avoid time wasting > and errors in log. > > Additionally, DPDK_FLOW_OFFLOAD_API definition moved to .c file, because > there is no need to expose it in header. Adding Ophir and