Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-22 Thread Anju Thomas
Thanks Ben. Regards Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Wednesday, January 23, 2019 5:24 AM To: Anju Thomas Cc: Stokes, Ian ; Lam, Tiago ; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action OK. I applied

Re: [ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-22 Thread Ben Pfaff
On Tue, Jan 22, 2019 at 05:14:05PM -0800, Gregory Rose wrote: > > On 1/22/2019 5:09 PM, Ben Pfaff wrote: > > On Tue, Jan 22, 2019 at 05:08:38PM -0800, Ben Pfaff wrote: > > > On Tue, Jan 22, 2019 at 04:38:24PM -0800, Yi-Hung Wei wrote: > > > > On Thu, Jan 10, 2019 at 2:09 PM Greg Rose wrote: > >

Re: [ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-22 Thread Gregory Rose
On 1/22/2019 5:22 PM, Ben Pfaff wrote: On Tue, Jan 22, 2019 at 05:14:05PM -0800, Gregory Rose wrote: On 1/22/2019 5:09 PM, Ben Pfaff wrote: On Tue, Jan 22, 2019 at 05:08:38PM -0800, Ben Pfaff wrote: On Tue, Jan 22, 2019 at 04:38:24PM -0800, Yi-Hung Wei wrote: On Thu, Jan 10, 2019 at 2:09 PM

Re: [ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-22 Thread Gregory Rose
On 1/22/2019 5:09 PM, Ben Pfaff wrote: On Tue, Jan 22, 2019 at 05:08:38PM -0800, Ben Pfaff wrote: On Tue, Jan 22, 2019 at 04:38:24PM -0800, Yi-Hung Wei wrote: On Thu, Jan 10, 2019 at 2:09 PM Greg Rose wrote: Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed how ipv6

Re: [ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-22 Thread Ben Pfaff
On Tue, Jan 22, 2019 at 05:08:38PM -0800, Ben Pfaff wrote: > On Tue, Jan 22, 2019 at 04:38:24PM -0800, Yi-Hung Wei wrote: > > On Thu, Jan 10, 2019 at 2:09 PM Greg Rose wrote: > > > > > > Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed > > > how ipv6 fragmentation is

Re: [ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-22 Thread Ben Pfaff
On Tue, Jan 22, 2019 at 04:38:24PM -0800, Yi-Hung Wei wrote: > On Thu, Jan 10, 2019 at 2:09 PM Greg Rose wrote: > > > > Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed > > how ipv6 fragmentation is implemented. This patch was backported to > > the upstream stable 4.9.x

Re: [ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-22 Thread Gregory Rose
On 1/22/2019 4:38 PM, Yi-Hung Wei wrote: On Thu, Jan 10, 2019 at 2:09 PM Greg Rose wrote: Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed how ipv6 fragmentation is implemented. This patch was backported to the upstream stable 4.9.x kernel starting at 4.9.135. This

Re: [ovs-dev] ovn: Add pkg-config support via libovn.pc.

2019-01-22 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author 竹內宏輝 Hiroki Takeuchi needs to sign off. WARNING: Unexpected sign-offs from

[ovs-dev] good evening!

2019-01-22 Thread SHIQ
Dear, write me from your private email address here {(shqin...@gmail.com)} for future communication and details. Regards, Shiq ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

2019-01-22 Thread Yi-Hung Wei
On Thu, Jan 10, 2019 at 2:09 PM Greg Rose wrote: > > Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed > how ipv6 fragmentation is implemented. This patch was backported to > the upstream stable 4.9.x kernel starting at 4.9.135. > > This patch creates the compatibility

[ovs-dev] [PATCH] ovn: Add pkg-config support via libovn.pc.

2019-01-22 Thread Ben Pfaff
From: 竹內宏輝 Hiroki Takeuchi Submitted-at: https://github.com/openvswitch/ovs/pull/270 Signed-off-by: Hiroki Takeuchi --- I'm sending this patch as a squashed version of what was submitted at Github. I know that pkg-config is somewhat controversial, so I'd like to hear what the denizens of

Re: [ovs-dev] [PATCH v6] Improved Packet Drop Statistics in OVS

2019-01-22 Thread Ben Pfaff
On Mon, Jan 21, 2019 at 07:01:33AM +, Anju Thomas wrote: > On Thu, Jan 17, 2019 at 04:49:20AM +, Anju Thomas wrote: > > Currently OVS maintains explicit packet drop/error counters only on port > > level. Packets that are dropped as part of normal OpenFlow processing > > are > >

Re: [ovs-dev] [PATCH V2 0/2] Do not rewrite fields with the same values as

2019-01-22 Thread Ben Pfaff
On Fri, Jan 11, 2019 at 08:28:57AM +0200, Eli Britstein wrote: > Hi > > This patch set avoids unnecessary rewrite actions to fields with the > same values as matched on. > > Patch 1 is a pre-step by defining ovs key structs using macros > > Patch 2 avoids the unnecessary rewrites and adapts the

Re: [ovs-dev] [patch v4 1/2] conntrack: fix ftp ipv4 address substitution.

2019-01-22 Thread Darrell Ball via dev
I would like to wait for David to return, so please hold off for now. On 1/22/19, 3:58 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: It looks like you have some changes to both patches, will you post a v5? Is this series otherwise ready to go (do you have

Re: [ovs-dev] [PATCH V2] rhel: bug fix upgrade path in kmod fedora spec file

2019-01-22 Thread Ben Pfaff
Flavio, can you give an opinion on this? Thanks, Ben. On Tue, Jan 22, 2019 at 03:02:30PM -0800, Greg Rose wrote: > From: Martin Xu > > This patch removes the "Conflicts" tag and adds "Obsoletes" tag. > > With the conflicts tag, when a user attempts to install or upgrade with > the same

Re: [ovs-dev] rhel: bug fix upgrade path in kmod fedora spec file

2019-01-22 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

Re: [ovs-dev] [branch-2.9 1/3] conntrack: fix tcp seq adjustments when mangling commands.

2019-01-22 Thread Ben Pfaff
Thanks for the backport. I applied this series to branch-2.9. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch v4 1/2] conntrack: fix ftp ipv4 address substitution.

2019-01-22 Thread Ben Pfaff
It looks like you have some changes to both patches, will you post a v5? Is this series otherwise ready to go (do you have buy-in from David for the revisions)? ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-22 Thread Ben Pfaff
OK. I applied the first part to all relevant branches. On Mon, Jan 21, 2019 at 04:06:26AM +, Anju Thomas wrote: > Hi Ben/Ian, > I understand that the second part of the patch needs more review. But do you > think we can atleast merge the first part of this viz >

[ovs-dev] [PATCH] datapath: return -EEXIST if inet6_add_protocol fails

2019-01-22 Thread Greg Rose
Our code to determine whether receive functionality will work with ip6 gre depends on the return of -EEXIST but inet6_add_protocol() returns a -1 on failure to grab the pointer via a cmpxchg op. Just set the error return to -EEXIST to help out the vport init function. Reported-at:

Re: [ovs-dev] [PATCH 0/2] travis: misc. improvements

2019-01-22 Thread Ben Pfaff
On Mon, Jan 21, 2019 at 01:05:24PM -0500, Aaron Conole wrote: > Following are some quick changes to improve the travis testing. Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH V2] rhel: bug fix upgrade path in kmod fedora spec file

2019-01-22 Thread Greg Rose
From: Martin Xu This patch removes the "Conflicts" tag and adds "Obsoletes" tag. With the conflicts tag, when a user attempts to install or upgrade with the same version as already installed, the conflict kicks in. Otherwise, such is allowed with --replacepkgs. Obsoletes is needed for the

Re: [ovs-dev] seq: Correct example in comment.

2019-01-22 Thread Ben Pfaff
On Tue, Jan 22, 2019 at 12:52:56PM +0300, Ilya Maximets wrote: > On 22.01.2019 4:14, Ben Pfaff wrote: > > It was deceptive for the example to imply that a seq can be declared > > directly, because the API only allows for creating a new one on the heap. > > > > Signed-off-by: Ben Pfaff > >

Re: [ovs-dev] [PATCH v1] rhel: retain OVS_CTL_OPTS for systemd service files

2019-01-22 Thread Gregory Rose
Aaron, This patch seems to have fallen through the cracks.  Would you mind giving this a review?  Martin is no longer with VMware so I will be following up on this patch. Thanks, - Greg On 9/14/2018 12:49 PM, Martin Xu wrote: OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in

Re: [ovs-dev] [patch v4 2/2] conntrack: Fix max size for inet_ntop() call.

2019-01-22 Thread Darrell Ball
On Mon, Jan 21, 2019 at 9:27 PM Darrell Ball wrote: > The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle > the maximum possible V6 address size for v4 mapping case. > > Found by inspection. > > Should have a fixes tag: Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and

Re: [ovs-dev] [patch v4 1/2] conntrack: fix ftp ipv4 address substitution.

2019-01-22 Thread Darrell Ball
On Mon, Jan 21, 2019 at 9:27 PM Darrell Ball wrote: > When replacing the ipv4 address in repl_ftp_v4_addr(), the remaining size > was incorrectly calculated which could lead to the wrong replacement > adjustment. > > This goes unnoticed most of the time, unless you choose carefully your >

Re: [ovs-dev] [PATCH] datapath-windows: Add support for 'OVS_KEY_ATTR_ENCAP' key attribute.

2019-01-22 Thread aserdean
> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Friday, January 11, 2019 2:45 AM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH] datapath-windows: Add support for > 'OVS_KEY_ATTR_ENCAP' key attribute. > > Add

[ovs-dev] WhatsApp cómo poderosa herramienta

2019-01-22 Thread ultimos lugares
Cursos TOP - Webinar Interactivo – Miércoles 30 de Enero whatsapp 3.0 Las ventas se logran el 90% con una estrategia comunicacional y el 10% con tecnología. En nuestro webinar podrás conocer todo lo que debes saber sobre WhatsApp, esta poderosa herramienta que todos utilizamos de manera

Re: [ovs-dev] dpdk: Limit DPDK memory usage.

2019-01-22 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 dpdk: Limit DPDK memory usage. The copy of

Re: [ovs-dev] [PATCH v4 0/4] dpcls subtable miniflow optimizations

2019-01-22 Thread Van Haaren, Harry
> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Monday, January 21, 2019 4:55 PM > To: Ilya Maximets > Cc: Van Haaren, Harry ; ovs-dev@openvswitch.org; > Stokes, Ian > Subject: Re: [ovs-dev] [PATCH v4 0/4] dpcls subtable miniflow optimizations > > Ilya

[ovs-dev] [PATCH] dpdk: Limit DPDK memory usage.

2019-01-22 Thread Ilya Maximets
Since 18.05 release, DPDK moved to dynamic memory model in which hugepages could be allocated on demand. At the same time '--socket-mem' option was re-defined as a size of pre-allocated memory, i.e. memory that should be allocated at startup and could not be freed. So, DPDK with a new memory model

[ovs-dev] Indicadores de compras

2019-01-22 Thread Costos bajos y ofrecer precios accesibles
Cursos TOP - Webinar Interactivo – Martes 29 de Enero Indicadores de compras para una aministración óptima Medir los indicadores es una tarea fundamental en la administración de un departamento y más si desea hacerse de manera óptima. Además, puede resultar la diferencia para conseguir costos

Re: [ovs-dev] [PATCH 0/2] Use existing data structures while dpdk args construction.

2019-01-22 Thread Aaron Conole
Ilya Maximets writes: > Ilya Maximets (2): > dpdk: Use svec instead of re-inventing. > dpdk: Use dynamic string for socket-mem construction. > > lib/dpdk.c | 230 + > 1 file changed, 71 insertions(+), 159 deletions(-) For the series,

[ovs-dev] [PATCH 2/2] dpdk: Use dynamic string for socket-mem construction.

2019-01-22 Thread Ilya Maximets
No need to allocate memory and use 'strcat' direcly. 'dynamic-string' could do this for us. Signed-off-by: Ilya Maximets --- lib/dpdk.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/dpdk.c b/lib/dpdk.c index d70884aad..855bcf013 100644 --- a/lib/dpdk.c

[ovs-dev] [PATCH 1/2] dpdk: Use svec instead of re-inventing.

2019-01-22 Thread Ilya Maximets
No need to implement dynamic vector to store arguments. 'svec' perfectly covers all the needed functionality. Signed-off-by: Ilya Maximets --- lib/dpdk.c | 217 - 1 file changed, 66 insertions(+), 151 deletions(-) diff --git a/lib/dpdk.c

[ovs-dev] [PATCH 0/2] Use existing data structures while dpdk args construction.

2019-01-22 Thread Ilya Maximets
Ilya Maximets (2): dpdk: Use svec instead of re-inventing. dpdk: Use dynamic string for socket-mem construction. lib/dpdk.c | 230 + 1 file changed, 71 insertions(+), 159 deletions(-) -- 2.17.1

Re: [ovs-dev] seq: Correct example in comment.

2019-01-22 Thread Ilya Maximets
On 22.01.2019 4:14, Ben Pfaff wrote: > It was deceptive for the example to imply that a seq can be declared > directly, because the API only allows for creating a new one on the heap. > > Signed-off-by: Ben Pfaff > --- > lib/seq.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >