Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs

2019-02-18 Thread Matthias May via dev
On 14/02/2019 16:51, Ben Pfaff wrote: > On Thu, Feb 14, 2019 at 03:14:26PM +0100, Matthias May wrote: >> On 14/02/2019 14:34, Flavio Leitner wrote: >>> >>> Hi Ben, >>> >>> This is another patch with From: field altered to be >>> ovs-dev@openvswitch.org. >>> >>> [...] >>> From: Matthias May via de

Re: [ovs-dev] Updated Quotation

2019-02-18 Thread Marie Bernard
Good Morning. Kindly send us an updated quotation. If the attached still valid, please let us know. Thanks. Cordialement, Best Regards ___ Marie GERBAUD BERNARD Assistante Export Tel : +33 1 64 86 27 86 Fax : +33 1 69 10 65 49 E-mail : marie.bern...@htds.fr

Re: [ovs-dev] [PATCH] rstp: add ability to receive VLAN-tagged BPDUs

2019-02-18 Thread Matthias May via dev
On 15/02/2019 01:28, Ben Pfaff wrote: > On Fri, Feb 15, 2019 at 12:27:11AM +0100, Matthias May wrote: >> On 14/02/2019 20:17, Ben Pfaff wrote: >>> On Thu, Feb 14, 2019 at 10:58:48AM +0100, Matthias May via dev wrote: There are switches which allow to transmit their BPDUs VLAN-tagged. With

Re: [ovs-dev] [PATCH v4 3/9] dp-packet: Refactor offloading API.

2019-02-18 Thread Ilya Maximets
On 15.02.2019 21:48, Flavio Leitner wrote: > On Fri, Feb 15, 2019 at 04:07:02PM +0300, Ilya Maximets wrote: >> 1. No reason to have mbuf related APIs in a generic code. >> 2. Not only RSS/checksums should be invalidated in case of tunnel >>decapsulation or sending to 'ring' ports. >> >> In orde

Re: [ovs-dev] [PATCH v4 3/9] dp-packet: Refactor offloading API.

2019-02-18 Thread Ilya Maximets
On 17.02.2019 16:37, Asaf Penso wrote: > > > Regards, > Asaf Penso > >> -Original Message- >> From: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> On Behalf Of Ilya Maximets >> Sent: Friday, February 15, 2019 3:07 PM >> To: ovs-dev@openvswitch.org; Ian Stokes >> Cc: Roni Bar

Re: [ovs-dev] [PATCH v4 3/9] dp-packet: Refactor offloading API.

2019-02-18 Thread Ilya Maximets
On 17.02.2019 20:00, Ophir Munk wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, February 15, 2019 3:07 PM >> To: ovs-dev@openvswitch.org; Ian Stokes >> Cc: Flavio Leitner ; Ophir Munk >> ; Kevin Traynor ; Roni Bar >> Yanai ; Finn Christensen ; Ilya >> Maximets

Re: [ovs-dev] [PATCH v4 4/9] dp-packet: Add flow_mark support for non-DPDK case.

2019-02-18 Thread Ilya Maximets
On 17.02.2019 16:44, Asaf Penso wrote: > > > Regards, > Asaf Penso > >> -Original Message- >> From: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> On Behalf Of Flavio Leitner >> Sent: Friday, February 15, 2019 8:59 PM >> To: Ilya Maximets >> Cc: ovs-dev@openvswitch.org; Roni

Re: [ovs-dev] [PATCH V4 1/3] acinclude: Include libverbs and libmlx5 when needed

2019-02-18 Thread Flavio Leitner
On Mon, Feb 11, 2019 at 01:32:33PM +0200, Eli Britstein wrote: > DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled. > > This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is > enabled on DPDK. > > Signed-off-by: Eli Britstein > Reviewed-by: Shahaf Shuler > Reviewed-

[ovs-dev] OVN/OVS code split: POC

2019-02-18 Thread Mark Michelson
Hi everyone, I have completed a *rough* POC of an OVN/OVS code split. You can find it at https://github.com/putnopvut/ovn.git Please take a look at the README file since that highlights how the split was done, as well as some known issues. My attitude towards this repo is that it is a throw

[ovs-dev] [PATCH] checkpatch: Escape range operators inside regex.

2019-02-18 Thread Ilya Maximets
' -(' matches a single character in the range between ' ' (index 32) and '(' (index 40). This leads to the false positive: WARNING: Line lacks whitespace around operator #445 FILE: ovsdb/monitor.c:573: if (--mcs->n_refs == 0) { Need to escape '-' to have a right behaviour. This patch ad

Re: [ovs-dev] [PATCH V4 0/3] Include libverbs and libmlx4/5 when needed

2019-02-18 Thread Ilya Maximets
I didn't try to build with mlx libs because I have no right environment. But the code looks good to me. For the series: Acked-by: Ilya Maximets On 11.02.2019 14:31, Eli Britstein wrote: > This patch set automatically links with the necessary libraries for > MLX4/5 DPDK PMDs. > > Patch 1 automat

[ovs-dev] [PATCH v5 0/9] dpif-netdev: Partial HWOL fixes/refactoring/unit-tests.

2019-02-18 Thread Ilya Maximets
Few more fixes + dummy implementation to enable unit testing of this feature. One more patch with refactoring: * https://patchwork.ozlabs.org/patch/996328/ Version 5: * 'dp_packet_mbuf_init' --> generic 'dp_packet_init_special' * 'dp_packet_offload_invalidate' --> 'dp_pack

[ovs-dev] [PATCH v5 2/9] dp-packet: Constantify offloading APIs.

2019-02-18 Thread Ilya Maximets
Getters should have const arguments. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/dp-packet.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 5b13329da..c6672f6be 100644 --- a/lib/dp-packet.h +++ b/lib/dp-

[ovs-dev] [PATCH v5 1/9] dpif-netdev: Reduce log level for not found mark id.

2019-02-18 Thread Ilya Maximets
It's a normal case for 'find' function, especially because this happens for every first packet of flow that was not offloaded yet. Should not warn about this. Dropped to DBG to avoid log trashing in case of big number of new flows. CC: Yuanhan Liu Fixes: 241bad15d99a ("dpif-netdev: associate flow

[ovs-dev] [PATCH v5 3/9] dp-packet: Refactor offloading API.

2019-02-18 Thread Ilya Maximets
1. No reason to have mbuf related APIs in a generic code. 2. Not only RSS/checksums should be invalidated in case of tunnel decapsulation or sending to 'ring' ports. In order to fix two above issues, new function 'dp_packet_reset_offload' introduced. In order to clean up/unify the code and simp

[ovs-dev] [PATCH v5 4/9] dp-packet: Add flow_mark support for non-DPDK case.

2019-02-18 Thread Ilya Maximets
Additionally, new API call 'dp_packet_set_flow_mark' is needed for packet clone. Mostly for dummy HWOL implementation. Signed-off-by: Ilya Maximets --- lib/dp-packet.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h i

[ovs-dev] [PATCH v5 5/9] dp-packet: Copy flow mark on packet clone.

2019-02-18 Thread Ilya Maximets
Dummy interfaces clones dp-packet while 'receive' appctl processing. In general, we should do this anyway to avoid any possible issues in the future with real interfaces. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/dp-packet.c | 4 1 file changed, 4 insertions(+) diff --

[ovs-dev] [PATCH v5 6/9] netdev-dummy: Implement dummy put/del flow offload API.

2019-02-18 Thread Ilya Maximets
Basic partial HWOL API for dummy interfaces. Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 106 +++-- 1 file changed, 103 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 72b4f7adc..6ee3cbca8 100644 --- a/li

[ovs-dev] [PATCH v5 7/9] netdev-dummy: Set flow mark for offloaded flows.

2019-02-18 Thread Ilya Maximets
Match packets received on dummy interfaces with offloaded flows and set up corresponding marks in dp-packet. Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/lib/netdev-dummy.c b/lib

[ovs-dev] [PATCH v5 8/9] netdev-dummy: Add flow offloading related logs.

2019-02-18 Thread Ilya Maximets
Add debug logging for partial HWOL for dummy interfaces for the future using in tests. Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 66 +++--- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c i

[ovs-dev] [PATCH v5 9/9] dpif-netdev.at: Add basic test for partial HW offloading.

2019-02-18 Thread Ilya Maximets
Simple test for basic partial HWOL functionality. Signed-off-by: Ilya Maximets --- tests/dpif-netdev.at | 74 1 file changed, 74 insertions(+) diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index 6915d43ba..8b30a9573 100644 --- a/tests/dpif

Re: [ovs-dev] [PATCH v5 0/9] dpif-netdev: Partial HWOL fixes/refactoring/unit-tests.

2019-02-18 Thread Ilya Maximets
On 18.02.2019 19:00, Ilya Maximets wrote: > Few more fixes + dummy implementation to enable unit testing > of this feature. > > One more patch with refactoring: > * https://patchwork.ozlabs.org/patch/996328/ > > Version 5: > * 'dp_packet_mbuf_init' --> generic 'dp_packet_init_special'

Re: [ovs-dev] [PATCH v4 3/9] dp-packet: Refactor offloading API.

2019-02-18 Thread Asaf Penso
Regards, Asaf Penso > -Original Message- > From: Ilya Maximets > Sent: Monday, February 18, 2019 2:10 PM > To: Asaf Penso ; ovs-dev@openvswitch.org; Ian > Stokes > Cc: Roni Bar Yanai ; Flavio Leitner > > Subject: Re: [ovs-dev] [PATCH v4 3/9] dp-packet: Refactor offloading API. > > O

[ovs-dev] Negociación táctica y estratégica

2019-02-18 Thread Comunicación verbal y no verbal
Cursos escenciales - Webinar Interactivo – Martes 26 de Febrero Habilidades de negociación táctica y estratégica para profesionales Aprenderás a estructurar la negociación como un proceso creativo hacia el acuerdo, a buscar la satisfacción de los intereses de ambas partes (ganar- ganar) y a sup

Re: [ovs-dev] [PATCH V4 0/3] Include libverbs and libmlx4/5 when needed

2019-02-18 Thread Ian Stokes
On 2/18/2019 3:41 PM, Ilya Maximets wrote: I didn't try to build with mlx libs because I have no right environment. But the code looks good to me. For the series: Acked-by: Ilya Maximets Thanks for series, pushed to master and 2.11. Ian ___ dev ma

[ovs-dev] [PATCH v1 0/3] Move offloading-code into a new file

2019-02-18 Thread Ophir Munk
Hardware offloading-code is moved to a new file called netdev-rte-offloads.c. The original offloading-code is copied as is from the netdev-dpdk.c file to the new file where future offloading-code should be added as well. This series is essential for offloading-code development for the following re

[ovs-dev] [PATCH v1 3/3] netdev-rte-offloads: Rename netdev_dpdk_* functions

2019-02-18 Thread Ophir Munk
Rename all the netdev_dpdk_* functions names (originated from the file netdev-dpdk.c) into the netdev_rte_offloads_* functions names. Signed-off-by: Ophir Munk --- lib/netdev-rte-offloads.c | 39 --- lib/netdev-rte-offloads.h | 17 + 2 files ch

[ovs-dev] [PATCH v1 2/3] netdev-dpdk: Move offloading-code to a new file

2019-02-18 Thread Ophir Munk
From: Roni Bar Yanai Hardware offloading-code is moved to a new file called netdev-rte-offloads.c. The original offloading-code is copied as is from the netdev-dpdk.c file into the new file where future offloading-code should be added as well. The netdev-dpdk.c file will remain unchanged as new o

[ovs-dev] [PATCH v1 1/3] netdev-dpdk: Expose flow creation/destruction calls

2019-02-18 Thread Ophir Munk
From: Roni Bar Yanai Before offloading-code was added to the netdev-dpdk.c file (MARK and RSS actions) the only DPDK RTE calls in use were rte_flow_create() and rte_flow_destroy(). In preparation for splitting the offloading-code from the netdev-dpdk.c file to a separate file, it is required to e

Re: [ovs-dev] [PATCH] checkpatch: Escape range operators inside regex.

2019-02-18 Thread Aaron Conole
Ilya Maximets writes: > ' -(' matches a single character in the range between ' ' (index 32) > and '(' (index 40). This leads to the false positive: > > WARNING: Line lacks whitespace around operator > #445 FILE: ovsdb/monitor.c:573: > if (--mcs->n_refs == 0) { > > Need to escape '-' to

Re: [ovs-dev] netdev-dpdk: Expose flow creation/destruction calls

2019-02-18 Thread 0-day Robot
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: O

Re: [ovs-dev] netdev-dpdk: Move offloading-code to a new file

2019-02-18 Thread 0-day Robot
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: O

Re: [ovs-dev] [PATCH v3] doc: Add "Representors" topic document

2019-02-18 Thread Ian Stokes
On 2/17/2019 5:37 PM, Ophir Munk wrote: This details how to configure representors ports. Signed-off-by: Ophir Munk --- v1: First version v2: Following patch reviews. https://patchwork.ozlabs.org/patch/1039515/ Mainly add how to create representors with Intel and Mellanox NICs. v3: Fix Checkpat

[ovs-dev] Ultimos 4 Lugares

2019-02-18 Thread Balanced Scorecard
Cursos esenciales - Webinar Interactivo – Miércoles 27 de Febrero Balanced Scorecard El Balanced Scorecard (Cuadro de Mando Integral) es una herramienta que permite enlazar estrategias y objetivos clave con desempeño y resultados a través de cuatro áreas críticas en cualquier empresa: desempeñ

[ovs-dev] [PATCH 0/5] ovn: Add HA chassis group and 'external' port support

2019-02-18 Thread nusiddiq
From: Numan Siddique This patch series adds a generic HA chassis group support in OVN deprecating the existing Gateway chassis support. The final patch of the series adds the 'external' port support in OVN. The 'external' port patch addresses the review comments from Han Zhou which he provided wh

[ovs-dev] [PATCH 1/5] ovn-northd: Reuse the hmaps - datapaths and ports in ovnsb_db_run()

2019-02-18 Thread nusiddiq
From: Numan Siddique We can reuse the datapaths and ports built during ovnnb_db_run() in ovnsb_db_run(). This way we avoid creating the logical ports hash nodes during the ovnsb_db_run(). An upcoming patch will make further use of these hashmaps during ovnsb_db_run(). This patch refactors the c

[ovs-dev] [PATCH 2/5] ovn: Add generic HA chassis group

2019-02-18 Thread nusiddiq
From: Numan Siddique This patch adds the tables - 'HA_Chassis_Group' and 'HA_Chassis' in both OVN Northbound and Southbound DBs to support generic HA Chassis groups in OVN. CMS can create a group of HA chassis with the priorities assigned to each chassis in the group. An HA chassis group can be a

[ovs-dev] [PATCH 3/5] ovn-controller: Make use of ha_chassis_group table to bind the chassisredirect ports

2019-02-18 Thread nusiddiq
From: Numan Siddique This patch uses the newly added ha_chassis_group table in Southbound DB - to bind the chassisredirect ports. - to establish BFD sessions with the required chassis. The previous patch in this series sets the list of chassis which references a ha chassis group in the

[ovs-dev] [PATCH 4/5] ovn-northd: Delete the references to gateway_chasss in SB DB

2019-02-18 Thread nusiddiq
From: Numan Siddique Previous patch in the series added the support in ovn-controller to use ha_chassis_group table in SB DB to support HA chassis and establishing BFD tunnels instead of the gateway_chassis table. There is no need for ovn-northd to create any gateway_chassis rows in SB DB. This p

[ovs-dev] [PATCH 5/5] ovn: Support a new Logical_Switch_Port.type - 'external'

2019-02-18 Thread nusiddiq
From: Numan Siddique In the case of OpenStack + OVN, when the VMs are booted on hypervisors supporting SR-IOV nics, there are no OVS ports for these VMs. When these VMs sends DHCPv4, DHPCv6 or IPv6 Router Solicitation requests, the local ovn-controller cannot reply to these packets. OpenStack Neu

Re: [ovs-dev] ovn: Add generic HA chassis group

2019-02-18 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #935 FILE: ovn/utilities/ovn-nbctl.c:693: ha

Re: [ovs-dev] [PATCH] ovn-controller: Provide the option to set the datapath-type of br-int

2019-02-18 Thread Mark Michelson
Looks good to me. Acked-by: Mark Michelson Out of curiosity, can you think of any other bridge configuration items that might need the same treatment? On 2/17/19 11:42 PM, nusid...@redhat.com wrote: From: Numan Siddique If the integration bridge is deleted, ovn-controller recreates it but

[ovs-dev] Your fund is confirm

2019-02-18 Thread office nna
SUPREME COURT OF JUSTICE NIGERIA The Supreme Court Secretariat C/ 45 - 47 Rue De Ganhi ,Lagoa, Republic Of Nigeria 01 BP.3045 Ministry Zone E-mail: courtjustic...@peoplepc.com Date: February Th18,2019. >From the Desk of; Hon. Justice Mardochée Vignon Mukouro, GCOB Chief Justice of >Nigeria. Th

[ovs-dev] [PATCH] netdev-vport: Use the vxlan dst_port in netdev name

2019-02-18 Thread Chris Mi
If vxlan dst_port is not default 4789, "ovs-dpctl dump-flows" will fail. The error message is: netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789 device failed: No such device That's because when calling netdev_vport_construct() for netdev vxlan_sys_, the default dst_port is used. Actua

[ovs-dev] [PATCH 0/2] acinclude: User/reader-friendly checking for DPDK dependencies.

2019-02-18 Thread Ilya Maximets
Ilya Maximets (2): acinclude: Transparent checking for DPDK dependencies. acinclude: Use AC_SEARCH_LIBS for linking with dl. acinclude.m4 | 170 ++- 1 file changed, 60 insertions(+), 110 deletions(-) -- 2.17.1

[ovs-dev] [PATCH 1/2] acinclude: Transparent checking for DPDK dependencies.

2019-02-18 Thread Ilya Maximets
'AC_CHECK_DECL' makes almost same thing as 'AC_COMPILE_IFELSE', but looks more pretty. Additionally it prints checking results in a user-visible way making it easy to understand which configs checked and why we need one or another dependency. For exmaple, with this patch, configure log may look li

[ovs-dev] [PATCH 2/2] acinclude: Use AC_SEARCH_LIBS for linking with dl.

2019-02-18 Thread Ilya Maximets
DPDK uses dlopen to load plugins and we need to search for library containing this function. But we should not do this in a loop because 'AC_SEARCH_LIBS' could do this for us. Also, 'AC_SEARCH_LIBS' prints user-visible messages that are useful for debuging. Also added the new 'checking' message and