Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Hi Greg, Please see one comment below Thanks Numan On Thu, Feb 14, 2019 at 6:42 AM Numan Siddique wrote: > > > On Thu, Feb 14, 2019, 2:58 AM Gregory Rose wrote: > >> Norman, >> >> I couldn't find your original email to reply to so I just copied in your >> patch below. My comments are precee

[ovs-dev] Meson integration for DPDK library

Hi, as describe on pr https://github.com/openvswitch/ovs/pull/271 i prepared a minor fix for compile ovs with support to DPDK library compiled with meson. Can anyone check if this doesn't introduce any regression and if could be fine apply the same fix to 2.11 branch. Thanks in advance -- geaaru _

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Use single struct/union for flow offload items.

Looks good, I would consider adding a default case for the switch with an appropriate message. Regards, Asaf Penso > -Original Message- > From: Ilya Maximets > Sent: Wednesday, February 6, 2019 5:41 PM > To: ovs-dev@openvswitch.org; Ian Stokes > Cc: Asaf Penso ; Roni Bar Yanai > ; Ophi

Re: [ovs-dev] Meson integration for DPDK library

On 2/19/2019 10:34 AM, Daniele Rondina wrote: Hi, as describe on pr https://github.com/openvswitch/ovs/pull/271 i prepared a minor fix for compile ovs with support to DPDK library compiled with meson. Can anyone check if this doesn't introduce any regression and if could be fine apply the same f

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Use single struct/union for flow offload items.

On 19.02.2019 13:45, Asaf Penso wrote: > Looks good, I would consider adding a default case for the switch with an > appropriate message. There is an 'if' statement a few lines above the 'switch' that checks for unsupported protocols. And we should not print any warnings in case of unsupported pr

Re: [ovs-dev] Meson integration for DPDK library

On Tue, 2019-02-19 at 10:46 +, Ian Stokes wrote: > On 2/19/2019 10:34 AM, Daniele Rondina wrote: > > Hi, as describe on pr https://github.com/openvswitch/ovs/pull/271 i > > prepared a minor fix for compile ovs with support to DPDK library > > compiled with meson. > > > > Can anyone check if th

Re: [ovs-dev] Meson integration for DPDK library

Currently, acinclude.m4 doesn't include a way to define a custom DPDK library path where it's been used meson for compile. It adds statically a linking rule "-ldpdk" that is wrong if you have used meson because libdpdk.so will not be available. In general, if you have a standard installation with D

Re: [ovs-dev] Meson integration for DPDK library

Yes - but as I mentioned, there is no need to hard-code such a check in the autoconf files. Just call: ./configure PKG_CONFIG_PATH=path/to/wherever On Tue, 2019-02-19 at 12:16 +0100, Daniele Rondina wrote: > Currently, acinclude.m4 doesn't include a way to define a custom DPDK > library path whe

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Use single struct/union for flow offload items.

I see that now, thanks. I agree with you and I'm fine with this v2. Regards, Asaf Penso > -Original Message- > From: Ilya Maximets > Sent: Tuesday, February 19, 2019 12:54 PM > To: Asaf Penso ; ovs-dev@openvswitch.org; Ian > Stokes > Cc: Roni Bar Yanai ; Ophir Munk > > Subject: Re: [PA

Re: [ovs-dev] Meson integration for DPDK library

Hi. Thanks for the patch. I faced this issue few weeks ago trying to build OVS with DPDK built by meson. However, your patch doesn't fix my case. You're exporting "PKG_CONFIG_PATH=$with_dpdk/build/meson-private/" assuming that '$with_dpdk/build' is a meson build directory. But it's not true in mo

[ovs-dev] [PATCHv8] Improved Packet Drop Statistics in OVS

Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the con

Re: [ovs-dev] Meson integration for DPDK library

Yeah, currently I presume that it's used build directory and this doesn't cover all cases. Ok. So better solution remains that supplied by Luca: ./configure PKG_CONFIG_PATH=path/of/dpdk I proceed to close my pr. Thanks for support. Good work at all. On Tue, 2019-02-19 at 14:29 +0300, Ilya Maxi

Re: [ovs-dev] Improved Packet Drop Statistics in OVS

Bleep bloop. Greetings Anju Thomas, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv -f ofproto/.deps/ofproto_libofproto_la-ofproto-dpif-monitor.Tpo ofproto/.deps/ofproto_libofproto_

Re: [ovs-dev] [PATCH] ovn-controller: Provide the option to set the datapath-type of br-int

On Tue, Feb 19, 2019 at 2:32 AM Mark Michelson wrote: > Looks good to me. > > Acked-by: Mark Michelson > > Out of curiosity, can you think of any other bridge configuration items > that might need the same treatment? > > Thanks for the review. I checked and I don't think we need anything extra

[ovs-dev] Contact me immediately 2019-02-18

Attn: Sir/Madam, Note: If you receive this message in your spam/bulk folder, it’s because of the restrictions imposed by your mail/internet service provider and I urge to treat this message genuine. My name is adv. Modise Khoza, trustee and executor to late Mrs. Aurel Yvonne Mitchley testament

[ovs-dev] [PATCH RFC 0/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

netdev-dpdk: Add new DPDK RFC 4115 egress policer This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a color-blind marking of the traffic at the queue level, followed by a color-aware marking a

[ovs-dev] [PATCH RFC 1/2] netdev-dpdk: Add support for multi-queue QoS to the DPDK datapath

This patch adds support for multi-queue QoS to the DPDK datapath. Most of the code is based on an earlier patch from a patchset sent out by zhaozhanxu. The patch was titled "[ovs-dev, v2, 1/4] netdev-dpdk.c: Support the multi-queue QoS configuration for dpdk datapath" Signed-off-by: Eelco Chaudron

[ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a color-blind marking of the traffic at the queue level, followed by a color-aware marking at the port level. At the end traffic marked as Gree

Re: [ovs-dev] [PATCH] netdev-dpdk: Flow validation refactoring.

On 2/13/2019 6:25 PM, Flavio Leitner wrote: On Mon, Nov 12, 2018 at 12:28:39PM +0300, Ilya Maximets wrote: * Dropped 'is_all_zero' function, which is equal to 'is_all_zeros' from util.h . * util.h added to includes. Includes re-sorted within their blocks. (it's hard to figure out where to

Re: [ovs-dev] [PATCH] ovs-tcpdump: Fix an undefined variable

> On Mon, Feb 04, 2019 at 11:50:22AM -0500, Aaron Conole wrote: >> Hyong Youb Kim via dev writes: >> >> > From: Hyong Youb Kim >> > >> > Run ovs-tcpdump without --span, and it throws the following >> > exception. Define mirror_select_all to avoid the error. >> > >> > Traceback (most recent call

Re: [ovs-dev] netdev-dpdk: Move offloading-code to a new file

Hi Aaron, 1. I am the committer of this patch. 2. When running latest checkpatch in my environment I do not get such warning indication. Can you please explain about what the Robot is complaining? Regards, Ophir > -Original Message- > From: 0-day Robot > Sent: Monday, February 18, 201

Re: [ovs-dev] netdev-dpdk: Move offloading-code to a new file

Hmmm, it's simple: I am the committer in my local tree. But when I send the patch to patchwork I am no longer the committer and therefore cannot sign-off. Ian - can you please update: Signed-off-by: Ophir Munk <...> To: Reviewed-by: Ophir Munk <...> Regards, OPhir > -Original Message- >

Re: [ovs-dev] netdev-dpdk: Expose flow creation/destruction calls

Ian, Can you please update: Signed-off-by: Ophir Munk <...> To: Reviewed-by: Ophir Munk <...> Regards, Ophir > -Original Message- > From: 0-day Robot > Sent: Monday, February 18, 2019 7:38 PM > To: Ophir Munk > Cc: d...@openvswitch.org > Subject: Re: netdev-dpdk: Expose flow creation/de

Re: [ovs-dev] [PATCH v3] doc: Add "Representors" topic document

On Mon, Feb 18, 2019 at 06:05:54PM +, Ian Stokes wrote: > On 2/17/2019 5:37 PM, Ophir Munk wrote: > > This details how to configure representors ports. > > > > Signed-off-by: Ophir Munk > > --- > > v1: > > First version > > v2: > > Following patch reviews. > > https://patchwork.ozlabs.org/pat

Re: [ovs-dev] netdev-dpdk: Expose flow creation/destruction calls

> > Ian, > Can you please update: > Signed-off-by: Ophir Munk <...> > To: > Reviewed-by: Ophir Munk <...> Sure we can do this upon commit. Ian > > Regards, > Ophir > > > -Original Message- > > From: 0-day Robot > > Sent: Monday, February 18, 2019 7:38 PM > > To: Ophir Munk > > Cc: d.

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On 2/19/2019 1:15 AM, Numan Siddique wrote: Hi Greg, Please see one comment below Thanks Numan On Thu, Feb 14, 2019 at 6:42 AM Numan Siddique > wrote: On Thu, Feb 14, 2019, 2:58 AM Gregory Rose mailto:gvrose8...@gmail.com>> wrote: Norman,

[ovs-dev] [PATCHv2] netlink: added check to prevent netlink attribute overflow

If enough large input is passed to odp_actions_from_string it can cause netlink attribute to overflow. ovs_assert was added just before the problematic code so it could be debugged faster in similar cases if they would arise. Check for buffer size was added to prevent entering this function and ret

[ovs-dev] [PATCHv3] netlink: added check to prevent netlink attribute overflow

If enough large input is passed to odp_actions_from_string it can cause netlink attribute to overflow. Check for buffer size was added to prevent entering this function and returning appropriate error code. Basic manual testing was performed. Reported-by: https://bugs.chromium.org/p/oss-fuzz/issu

Re: [ovs-dev] netdev-dpdk: Move offloading-code to a new file

Ophir Munk writes: > Hmmm, it's simple: I am the committer in my local tree. But when I > send the patch to patchwork I am no longer the committer and therefore > cannot sign-off. > > Ian - can you please update: > Signed-off-by: Ophir Munk <...> > To: > Reviewed-by: Ophir Munk <...> This doesn'

Re: [ovs-dev] netdev-dpdk: Move offloading-code to a new file

Ophir Munk writes: > Hi Aaron, > 1. I am the committer of this patch. There is a corner case that isn't currently handled (because it isn't common). Developer A authors a change. Signed-off-by is needed. Sends to Developer B Developer B takes that change, with no intervention. Developer B n

Re: [ovs-dev] [PATCH v5 3/9] dp-packet: Refactor offloading API.

On Mon, Feb 18, 2019 at 07:00:19PM +0300, Ilya Maximets wrote: > 1. No reason to have mbuf related APIs in a generic code. > 2. Not only RSS/checksums should be invalidated in case of tunnel >decapsulation or sending to 'ring' ports. > > In order to fix two above issues, new function > 'dp_pac

Re: [ovs-dev] [PATCH v5 4/9] dp-packet: Add flow_mark support for non-DPDK case.

On Mon, Feb 18, 2019 at 07:00:20PM +0300, Ilya Maximets wrote: > Additionally, new API call 'dp_packet_set_flow_mark' is needed > for packet clone. Mostly for dummy HWOL implementation. > > Signed-off-by: Ilya Maximets > --- Acked-by: Flavio Leitner ___

Re: [ovs-dev] [PATCH v5 7/9] netdev-dummy: Set flow mark for offloaded flows.

On Mon, Feb 18, 2019 at 07:00:23PM +0300, Ilya Maximets wrote: > Match packets received on dummy interfaces with offloaded flows and > set up corresponding marks in dp-packet. > > Signed-off-by: Ilya Maximets > --- Acked-by: Flavio Leitner ___ dev m

Re: [ovs-dev] [PATCH v5 6/9] netdev-dummy: Implement dummy put/del flow offload API.

On Mon, Feb 18, 2019 at 07:00:22PM +0300, Ilya Maximets wrote: > Basic partial HWOL API for dummy interfaces. On a real hardware, if the flow exists, the flow_put would destroy existing flow, validate the new flow according with HW capabilities and then push the new flow. This patch simply updat

Re: [ovs-dev] [PATCH v5 8/9] netdev-dummy: Add flow offloading related logs.

On Mon, Feb 18, 2019 at 07:00:24PM +0300, Ilya Maximets wrote: > Add debug logging for partial HWOL for dummy interfaces for > the future using in tests. > > Signed-off-by: Ilya Maximets > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openv

Re: [ovs-dev] [PATCH v5 9/9] dpif-netdev.at: Add basic test for partial HW offloading.

On Mon, Feb 18, 2019 at 07:00:25PM +0300, Ilya Maximets wrote: > Simple test for basic partial HWOL functionality. > > Signed-off-by: Ilya Maximets > --- > tests/dpif-netdev.at | 74 > 1 file changed, 74 insertions(+) > > diff --git a/tests/dpif-netd

Re: [ovs-dev] [PATCH] odp-util: Prevent oversized encap action

On 1/17/2019 4:33 PM, Yifeng Sun wrote: nla_len in struct nlattr is of type uint16_t. This patch prevents nla_len from be truncated if the size of encapped actions is too large. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12255 Signed-off-by: Yifeng Sun --- lib/odp-uti

Re: [ovs-dev] [PATCHv3] netlink: added check to prevent netlink attribute overflow

On 2/19/2019 10:55 AM, Toms Atteka wrote: If enough large input is passed to odp_actions_from_string it can cause netlink attribute to overflow. Check for buffer size was added to prevent entering this function and returning appropriate error code. Basic manual testing was performed. Reported-

[ovs-dev] Why continued silence 2

Did you receive my previous email regarding your family inheritance?Reply strictly through: rubenco...@gmail.com Best Regards,Ruben CONVY ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [branch-2.11 1/2] Set release dates for 2.11.0.

Signed-off-by: Justin Pettit --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ebbd3b7434af..a48de60f94ab 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -v2.11.0 - xx xxx +v2.11.0 - 19 Feb 2019 --

[ovs-dev] [branch-2.11 2/2] Prepare for 2.11.1.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a48de60f94ab..23d9d94097a1 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.11.1 - xx xxx +--

[ovs-dev] [patch v2 1/6] ipf: Misc Cleanup.

Signed-off-by: Darrell Ball --- lib/ipf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/ipf.c b/lib/ipf.c index df5196f..125a815 100644 --- a/lib/ipf.c +++ b/lib/ipf.c @@ -456,7 +456,7 @@ ipf_reassemble_v6_frags(struct ipf_list *ipf_list) int rest_len = frag_l

[ovs-dev] [patch v2 2/6] ipf: Do not preallocate more than needed.

ipf_reassemble_v4_frags() and ipf_reassemble_v6_frags() are preallocating more than needed for the reassembled packet. Signed-off-by: Darrell Ball --- lib/ipf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/ipf.c b/lib/ipf.c index 125a815..a4608af 100644 --- a/

[ovs-dev] [patch v2 4/6] tests: Fix udp checksums for some tests.

Signed-off-by: Darrell Ball --- 1/ This patch will fail to merge because it gets corrupted in e-mail because of the long lines, but is submitted for completeness. 2/ Associated 4 system tests will fail until patches 5 and 6 of the series; tests could otherwise be disabled in this patch the

[ovs-dev] [patch v2 3/6] ipf: Check minimum fragment against L3 size.

Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") Signed-off-by: Darrell Ball --- lib/ipf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ipf.c b/lib/ipf.c index a4608af..acddc02 100644 --- a/lib/ipf.c +++ b/lib/ipf.c @@ -613,7 +613,7 @@ ipf_is_

[ovs-dev] [patch v2 5/6] ipf: Handle non-zero L2 padding for first fragments.

Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") Signed-off-by: Darrell Ball --- Following system tests will fail until patch 6 of the series; tests could otherwise be disabled in patch 4 then re-enabled in patch 6. conntrack - IPv6 fragmentation, multiple extension heade

[ovs-dev] [patch v2 6/6] conntrack: Fix L4 csum for V6 extension hdr pkts.

It is a day one issue that got copied to the FTP handling code. Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") CC: Daniele Di Proietto Signed-off-by: Darrell Ball --- lib/conntrack.c | 25 +++---