Re: [ovs-dev] Set release date for 2.10.2.

> On Feb 20, 2019, at 10:13 PM, Darrell Ball wrote: > > > On Wed, Feb 20, 2019 at 7:44 PM Darrell Ball wrote: > I was able to see it with the address sanitizer as a false positive > > You can backport > > faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d > > as far back as 2.8 > > hmm, after

Re: [ovs-dev] Set release date for 2.10.2.

On Wed, Feb 20, 2019 at 7:44 PM Darrell Ball wrote: > I was able to see it with the address sanitizer as a false positive > > You can backport > > faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d > > as far back as 2.8 > hmm, after rebase, I can see this pretty consistently with '-O2' with various gcc

Re: [ovs-dev] [PATCH 0/5] ovn: Add HA chassis group and 'external' port support

Thanks for the review and comments. Please see below for few comments. Thanks Numan On Thu, Feb 21, 2019 at 3:29 AM Mark Michelson wrote: > Hi Numan, > > This is quite a large patchset, but I believe I understand it. It > essentially does two things: > > 1) Deprecates Gateway_Chassis in

Re: [ovs-dev] Set release date for 2.10.2.

I was able to see it with the address sanitizer as a false positive You can backport faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d as far back as 2.8 On Wed, Feb 20, 2019 at 6:17 PM Justin Pettit wrote: > Hi, Darrell. You've handled most of the userspace conntrack work lately. > Are you able to

[ovs-dev] Fwd: Set release date for 2.10.2.

Hi, Darrell. You've handled most of the userspace conntrack work lately. Are you able to reproduce this issue? My compiler build it without any problem. Thanks, --Justin > Begin forwarded message: > > From: 0-day Robot > Subject: Re: Set release date for 2.10.2. > Date: February 20, 2019

Re: [ovs-dev] Set release date for 2.10.2.

Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include

[ovs-dev] [branch-2.5 2/2] Prepare for 2.5.8.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index af4b58789943..4d3fee0d0418 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.5.8 - xx xxx

[ovs-dev] [branch-2.5 1/2] Set release date for 2.5.7.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 448db42d7161..af4b58789943 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.5.7 - xx xxx +v2.5.7 - 20 Feb 2019

[ovs-dev] [branch-2.6 2/2] Prepare for 2.6.6.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 7b1eb1293067..639adb7aff42 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.6.6 - xx xxx

[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.9.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index ac5946870215..53beadea41e7 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.7.9 - xx xxx

[ovs-dev] [branch-2.6 1/2] Set release date for 2.6.5.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a202e7b5b84f..7b1eb1293067 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.6.5 - xx xxx +v2.6.5 - 20 Feb 2019

[ovs-dev] [branch-2.8 2/2] Prepare for 2.8.7.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f9f25dc259c6..fd27fee35d83 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.8.7 - xx xxx

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.8.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 4cf7ad6a43c0..ac5946870215 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.7.8 - xx xxx +v2.7.8 - 20 Feb 2019

[ovs-dev] [branch-2.9 2/2] Prepare for 2.9.5.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index be65f16e90f4..b7883b941d6b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.9.5 - xx xxx

[ovs-dev] [branch-2.8 1/2] Set release date for 2.8.6.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 631e1deaf577..f9f25dc259c6 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.8.6 - xx xxx +v2.8.6 - 20 Feb 2019

[ovs-dev] [branch-2.9 1/2] Set release date for 2.9.4.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index e633d762fc5a..be65f16e90f4 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.9.4 - xx xxx +v2.9.4 - 20 Feb 2019

[ovs-dev] [branch-2.10 2/2] Prepare for 2.10.3.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e1ea8278016b..6f6c4378ef74 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.10.3 - xx xxx

[ovs-dev] [branch-2.10 1/2] Set release date for 2.10.2.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 35aafc037398..e1ea8278016b 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.10.2 - xx xxx +v2.10.2 - 20 Feb 2019

Re: [ovs-dev] [branch-2.11 2/2] Prepare for 2.11.1.

> On Feb 20, 2019, at 8:08 AM, Flavio Leitner wrote: > > On Tue, Feb 19, 2019 at 09:47:10PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- > > Acked-by: Flavio Leitner Thanks. I pushed the series to branch-2.11, and the 2.11.0 date setting to master. --Justin

Re: [ovs-dev] [PATCHv3] netlink: added check to prevent netlink attribute overflow

On 2/20/2019 1:53 PM, Cpp Code wrote: On 20 Feb 2019, at 02:27, Gregory Rose > wrote: On 2/19/2019 10:55 AM, Toms Atteka wrote: If enough large input is passed to odp_actions_from_string it can cause netlink attribute to overflow. Check for buffer size was

[ovs-dev] [RFC PATCH v1 6/6] L3 N-S support in ovn, avoid chassis redirection as default for vlan backed networks

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [RFC PATCH v1 5/6] L3 N-S support in ovn, do not replace router port mac on gateway chassis

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [RFC PATCH v1 4/6] L3 N-S support in ovn, advertise router port mac from gateway chassis

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn, northd changes to read logical switch network type.

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [RFC PATCH v1 1/6] Vlan Support in ovn, add network type in northbound schema

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [RFC PATCH v1 0/6] OVN: Distributed Virtual Router for Vlan Backed Networks

This series is about enhancing the logical router functionality in OVN to work with vlan backed logical switches. Intial proposal was discused here: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2]

Re: [ovs-dev] [PATCH v1 0/3] Move offloading-code into a new file

If we wanted to switch to a multi-threaded offload model today- we could have done it in two steps: 1. Implement a multi-threaded model on current master branch. 2. Do the split. The two steps seem independent. The split is rather technical and there are ways to share/pass locks between two

Re: [ovs-dev] [PATCH] OVN: select a random mac_prefix if not provided

Looks good to me. The only potential issue here is that this constitutes a change in behavior with no configuration change. Is there a good place to note this so that it is clear to people who upgrade? Perhaps a NEWS entry? On 2/20/19 10:53 AM, Lorenzo Bianconi wrote: Select a random IPAM

Re: [ovs-dev] [PATCH 0/5] ovn: Add HA chassis group and 'external' port support

Hi Numan, This is quite a large patchset, but I believe I understand it. It essentially does two things: 1) Deprecates Gateway_Chassis in favor of HA_Chassis_Groups and HA_Chassis. The benefit of HA_Chassis_Groups is that it allows for automatic failover of chassis using BFD. 2) Adds

Re: [ovs-dev] [PATCHv3] netlink: added check to prevent netlink attribute overflow

> On 20 Feb 2019, at 02:27, Gregory Rose wrote: > > > On 2/19/2019 10:55 AM, Toms Atteka wrote: >> If enough large input is passed to odp_actions_from_string it can >> cause netlink attribute to overflow. >> Check for buffer size was added to prevent entering this function >> and returning

Re: [ovs-dev] [PATCH v1 0/3] Move offloading-code into a new file

Ilya, this is what I think. I think there are two points here. First is the atomicity of offloading flows and the second is concurrency in offloading on dpif. Regarding the first point, at this point flows are logically atomic, so if for example you are offloading with two threads the lock Is

[ovs-dev] Plan de vida y carrera

Cursos TOP - Webinar Interactivo – Miércoles 06 de Marzo Planes de carrera y sucesión Desarrollaremos planes de carrera y sucesión que aseguren el funcionamiento óptimo de una empresa. Ejes Temáticos: • Competencias organizacionales complejas. • Desarrollo de plan de vida y carrera. •

[ovs-dev] [RFC] OVN: add the possibility to configure a static IPv4 addr/IPv6 prefix and dynamic MAC

Add the possibility to configure a static IPv4 address and IPv6 prefix and get MAC address dynamically allocated. This can be done using the following commands: $ovn-nbctl ls-add sw0 $ovn-nbctl set Logical-Switch sw0 other_config:subnet=192.168.0.0/24 $ovn-nbctl set Logical-switch sw0

Re: [ovs-dev] [PATCH v1 0/3] Move offloading-code into a new file

One general concern to think about: This code split introduces few helper functions that resides in netdev-dpdk and calls dpdk API by the requests of other modules (netdev-rte-offloads). This strategy will not allow us to lock the device for performing several operations atomically because all

[ovs-dev] [patch v3 6/6] conntrack: Fix L4 csum for V6 extension hdr pkts.

It is a day one issue that got copied to the FTP handling code. Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") CC: Daniele Di Proietto Signed-off-by: Darrell Ball --- v3: New patch. lib/conntrack.c | 25

[ovs-dev] [patch v3 5/6] ipf: Handle non-zero L2 padding for first fragments.

Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") Signed-off-by: Darrell Ball --- Following system tests will fail until patch 6 of the series; tests could otherwise be disabled in patch 4 then re-enabled in patch 6. conntrack - IPv6 fragmentation, multiple extension

[ovs-dev] [patch v3 4/6] tests: Fix udp checksums for some tests.

Also, enable the kernel side tests since these will pass now. Signed-off-by: Darrell Ball --- v3: Enable tests for kernel Associated 4 system tests will fail until patches 5 and 6 of the series; tests could otherwise be disabled in this patch then re-enabled in patch 6.

[ovs-dev] [patch v3 3/6] ipf: Check minimum fragment against L3 size.

Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") Signed-off-by: Darrell Ball --- v3: Update documentation. lib/dpctl.man | 2 +- lib/ipf.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/dpctl.man b/lib/dpctl.man index f22029f..1ff3511

[ovs-dev] [patch v3 2/6] ipf: Do not preallocate more than needed.

ipf_reassemble_v4_frags() and ipf_reassemble_v6_frags() are preallocating more than needed for the reassembled packet. Signed-off-by: Darrell Ball --- v3: Add minor optimization. lib/ipf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/ipf.c b/lib/ipf.c index

[ovs-dev] [patch v3 1/6] ipf: Misc Cleanup.

Signed-off-by: Darrell Ball --- lib/ipf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/ipf.c b/lib/ipf.c index df5196f..125a815 100644 --- a/lib/ipf.c +++ b/lib/ipf.c @@ -456,7 +456,7 @@ ipf_reassemble_v6_frags(struct ipf_list *ipf_list) int rest_len =

[ovs-dev] [PATCH] OVN: select a random mac_prefix if not provided

Select a random IPAM mac_prefix if it has not been provided by the user. With this patch the admin can avoid to configure mac_prefix in order to avoid L2 address collisions if multiple OVN deployments share the same broadcast domain. Remove MAC_ADDR_PREFIX definitions/occurrences since now

Re: [ovs-dev] [branch-2.11 2/2] Prepare for 2.11.1.

On Tue, Feb 19, 2019 at 09:47:10PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.11 1/2] Set release dates for 2.11.0.

On Tue, Feb 19, 2019 at 09:47:09PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] netdev-vport: Use the vxlan dst_port in netdev name

On Tue, Feb 19, 2019 at 10:51:40AM +0900, Chris Mi wrote: > If vxlan dst_port is not default 4789, "ovs-dpctl dump-flows" > will fail. The error message is: > > netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789 device failed: No > such device > > That's because when calling

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Hi Ben and Greg, Please see one comment below inline Thanks Numan On Tue, Feb 12, 2019 at 7:57 AM Ben Pfaff wrote: > Greg, I recommend that you take a look at this one. > > (More commentary below.) > > On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com wrote: > > From: Numan

Re: [ovs-dev] [PATCH v1 2/3] netdev-dpdk: Move offloading-code to a new file

On Mon, Feb 18, 2019 at 04:16:02PM +, Ophir Munk wrote: > From: Roni Bar Yanai > > Hardware offloading-code is moved to a new file called > netdev-rte-offloads.c. The original offloading-code is copied as is > from the netdev-dpdk.c file into the new file where future > offloading-code

Re: [ovs-dev] [PATCH v6 9/9] dpif-netdev.at: Add basic test for partial HW offloading.

On Wed, Feb 20, 2019 at 03:47:37PM +0300, Ilya Maximets wrote: > Simple test for basic partial HWOL functionality. Works for me, thanks! Acked-by: Flavio Leitner > Signed-off-by: Ilya Maximets > --- > tests/dpif-netdev.at | 74 > 1 file changed,

[ovs-dev] [PATCH v6 8/9] netdev-dummy: Add flow offloading related logs.

Add debug logging for partial HWOL for dummy interfaces for the future using in tests. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 66 +++--- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH v6 9/9] dpif-netdev.at: Add basic test for partial HW offloading.

Simple test for basic partial HWOL functionality. Signed-off-by: Ilya Maximets --- tests/dpif-netdev.at | 74 1 file changed, 74 insertions(+) diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index 6915d43ba..8b30a9573 100644 ---

[ovs-dev] [PATCH v6 7/9] netdev-dummy: Set flow mark for offloaded flows.

Match packets received on dummy interfaces with offloaded flows and set up corresponding marks in dp-packet. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git

[ovs-dev] [PATCH v6 6/9] netdev-dummy: Implement dummy put/del flow offload API.

Basic partial HWOL API for dummy interfaces. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 106 +++-- 1 file changed, 103 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index

[ovs-dev] [PATCH v6 5/9] dp-packet: Copy flow mark on packet clone.

Dummy interfaces clones dp-packet while 'receive' appctl processing. In general, we should do this anyway to avoid any possible issues in the future with real interfaces. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/dp-packet.c | 4 1 file changed, 4 insertions(+) diff

[ovs-dev] [PATCH v6 3/9] dp-packet: Refactor offloading API.

1. No reason to have mbuf related APIs in a generic code. 2. Not only RSS/checksums should be invalidated in case of tunnel decapsulation or sending to 'ring' ports. In order to fix two above issues, new function 'dp_packet_reset_offload' introduced. In order to clean up/unify the code and

[ovs-dev] [PATCH v6 4/9] dp-packet: Add flow_mark support for non-DPDK case.

Additionally, new API call 'dp_packet_set_flow_mark' is needed for packet clone. Mostly for dummy HWOL implementation. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/dp-packet.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH v6 2/9] dp-packet: Constantify offloading APIs.

Getters should have const arguments. Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets --- lib/dp-packet.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 5b13329da..c6672f6be 100644 --- a/lib/dp-packet.h +++

[ovs-dev] [PATCH v6 1/9] dpif-netdev: Reduce log level for not found mark id.

It's a normal case for 'find' function, especially because this happens for every first packet of flow that was not offloaded yet. Should not warn about this. Dropped to DBG to avoid log trashing in case of big number of new flows. CC: Yuanhan Liu Fixes: 241bad15d99a ("dpif-netdev: associate

[ovs-dev] [PATCH v6 0/9] dpif-netdev: Partial HWOL fixes/refactoring/unit-tests.

Few more fixes + dummy implementation to enable unit testing of this feature. Version 6: * More specific log parsing in test. * Added Acks from Flavio to corresponding patches. Version 5: * 'dp_packet_mbuf_init' --> generic 'dp_packet_init_special' *

Re: [ovs-dev] [PATCH v5 9/9] dpif-netdev.at: Add basic test for partial HW offloading.

On 20.02.2019 0:03, Flavio Leitner wrote: > On Mon, Feb 18, 2019 at 07:00:25PM +0300, Ilya Maximets wrote: >> Simple test for basic partial HWOL functionality. >> >> Signed-off-by: Ilya Maximets >> --- >> tests/dpif-netdev.at | 74 >> 1 file changed,