After two days of running OVS through valgrind again I suspect that for some
reason (probably how Valgrind works) the leak is not happening while running
through Valgrind.
Please find attached two sets of valgrind logs in case they can help but I
really doubt it.
As soon as I run OVS alone aga
On Fri, Mar 15, 2019 at 01:12:09PM +0300, Ilya Maximets wrote:
> On 15.03.2019 12:39, Simon Horman wrote:
> > On Fri, Mar 15, 2019 at 12:28:03PM +0300, Ilya Maximets wrote:
> >> On 15.03.2019 11:50, Simon Horman wrote:
> >>> On Thu, Mar 14, 2019 at 01:14:05PM +0300, Ilya Maximets wrote:
> On 1
Hi. I'm try to modify/write/improve golang ovn binding. And i'm stuck
at dhcpv4_options in logical_switch_port.
As i see its is weak reference, i think that it is string, but as i
see in returned results via libovsdb it is OvsSet type (array of
strings). Does it right?
--
Vasiliy Tolstov,
e-mail:
On 18.03.2019 11:03, Simon Horman wrote:
> On Fri, Mar 15, 2019 at 01:12:09PM +0300, Ilya Maximets wrote:
>> On 15.03.2019 12:39, Simon Horman wrote:
>>> On Fri, Mar 15, 2019 at 12:28:03PM +0300, Ilya Maximets wrote:
On 15.03.2019 11:50, Simon Horman wrote:
> On Thu, Mar 14, 2019 at 01:14:
On Sun, Mar 17, 2019 at 02:29:45PM +, Roi Dayan wrote:
>
>
> On 01/03/2019 02:26, Gregory Rose wrote:
> >
> >
> > On 2/28/2019 11:29 AM, Moshe Levi wrote:
> >> Signed-off-by: Moshe Levi
> >> ---
> >> lib/netdev-tc-offloads.c | 4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletion
On Sun, Mar 17, 2019 at 05:58:47AM +, Roi Dayan wrote:
>
>
> On 14/03/2019 10:50, Simon Horman wrote:
> > On Tue, Mar 12, 2019 at 04:05:16PM +0100, Simon Horman wrote:
> >> On Mon, Mar 11, 2019 at 03:25:09PM +, John Hurley wrote:
> >>> On Mon, Mar 11, 2019 at 2:34 PM Roi Dayan wrote:
> >
On 16.03.2019 0:05, Ben Pfaff wrote:
> Doesn't seem particularly useful to me, I suggest that we remove it
> entirely instead.
OK. I thought about removing too.
I'll send v2.
>
> On Fri, Mar 15, 2019 at 06:21:40PM +0300, Ilya Maximets wrote:
>> s/dubug/debug/
>>
>> On 15.03.2019 17:06, Ilya Maxi
On Mon, Mar 18, 2019 at 1:45 PM Vasiliy Tolstov wrote:
> Hi. I'm try to modify/write/improve golang ovn binding. And i'm stuck
> at dhcpv4_options in logical_switch_port.
> As i see its is weak reference, i think that it is string, but as i
> see in returned results via libovsdb it is OvsSet type
This information is not that useful.
Anyway, no need to print it each time to the logs.
CC: Ben Pfaff
Fixes: d1fd1ea91242 ("ovs-dpctl: New --names option to use port names in flow
dumps.")
Signed-off-by: Ilya Maximets
---
Version 2:
* Logs removed instead of changing to DBG.
lib/dpctl.c
пн, 18 мар. 2019 г. в 13:30, Numan Siddique :
>
>
>
> On Mon, Mar 18, 2019 at 1:45 PM Vasiliy Tolstov wrote:
>>
>> Hi. I'm try to modify/write/improve golang ovn binding. And i'm stuck
>> at dhcpv4_options in logical_switch_port.
>> As i see its is weak reference, i think that it is string, but as
On Mon, Mar 18, 2019 at 7:35 AM taoyunupt wrote:
> Dear all,
>As far as I know , ovn/networking-ovn(support) dose not support
> fwaas and vpnaas.So, does have any plan or blueprint to support fwaas
> and vpnaas in ovn/networking-ovn(openstack)?
>
>
I think openstack ML is more a
Real values of 'packets per batch' and 'cycles per upcall' already
added to histograms in 'dpif-netdev' on receive. Adding the averages
makes statistics wrong. We should not add to histograms values that
never really appeared.
For exmaple, in current code following situation is possible:
pmd th
Hi Ilya,
Thanks for spotting this. I believe your fix is correct.
BR, Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, 18 March, 2019 14:01
> To: ovs-dev@openvswitch.org; Ian Stokes
> Cc: Kevin Traynor ; Ilya Maximets
> ; Jan Scheurich
> Subject: [PATCH] dpif-netdev-perf
On Mon, Mar 18, 2019 at 09:39:00AM +0100, Simon Horman wrote:
> On Sun, Mar 17, 2019 at 02:29:45PM +, Roi Dayan wrote:
> >
> >
> > On 01/03/2019 02:26, Gregory Rose wrote:
> > >
> > >
> > > On 2/28/2019 11:29 AM, Moshe Levi wrote:
> > >> Signed-off-by: Moshe Levi
> > >> ---
> > >> lib/ne
On Mon, Mar 18, 2019 at 02:59:19PM +0100, Simon Horman wrote:
> On Mon, Mar 18, 2019 at 09:39:00AM +0100, Simon Horman wrote:
> > On Sun, Mar 17, 2019 at 02:29:45PM +, Roi Dayan wrote:
> > >
> > >
> > > On 01/03/2019 02:26, Gregory Rose wrote:
> > > >
> > > >
> > > > On 2/28/2019 11:29 AM,
On Sun, Mar 17, 2019 at 04:13:25PM +0200, Or Gerlitz wrote:
> Currnetly, when a tc flow is installed on a bond port using shared blocks,
> we get these failures from the validator threads:
>
> 2019-03-17T10:02:58.919Z|13369|dpif(revalidator93)|WARN|system@ovs-system:
> failed to flow_del \
>
> On Thu, Dec 21, 2017 at 04:30:05PM -0800, Justin Pettit wrote:
>>
>>
>> > On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote:
>> >
>> > The 'mask' buffer in parse_odp_action() is supposed to always be big
>> > enough:
>> >/* 'mask' is big enough to hold any key. */
>> >
>> > Geneve options
On Mon, Mar 18, 2019 at 07:13:27PM +0300, Ilya Maximets wrote:
> > On Thu, Dec 21, 2017 at 04:30:05PM -0800, Justin Pettit wrote:
> >>
> >>
> >> > On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote:
> >> >
> >> > The 'mask' buffer in parse_odp_action() is supposed to always be big
> >> > enough:
> >>
Thanks Darrell for the review. Will do.
Yifeng
On Sat, Mar 16, 2019 at 11:43 AM Darrell Ball wrote:
> Hi Yifeng
>
> Thanks for the patch.
>
> Your patch is corrupted; if this is due to transmit via e-mail, you can
> post a pull request.
> Other comments inline
>
>
> On Fri, Mar 15, 2019 at 7:20
Hi Numan,
Thanks a lot for comment.
Sure, I am ok either ways, i.e whether we want to read
“ovn-chassis-mac-mappings” from OVSDB on each chassis or from OVN northbound DB.
Just wanted to make sure that we follow only ONE approach.
From OVN as a platform perspective, ovn-chassis-mac-mappings look
If NULL value was provided for odp_flow_from_string errorp argument
segmentation fault error occurred.
This patch fixes it by ignoring error formatting if error pointer
is not provided.
Reported-at:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12972
Signed-off-by: Toms Atteka
---
lib/o
On Mon, Mar 18, 2019 at 07:13:27PM +0300, Ilya Maximets wrote:
> > On Thu, Dec 21, 2017 at 04:30:05PM -0800, Justin Pettit wrote:
> >>
> >>
> >> > On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote:
> >> >
> >> > The 'mask' buffer in parse_odp_action() is supposed to always be big
> >> > enough:
> >>
On Mon, Mar 18, 2019 at 11:31:32AM +0300, Ilya Maximets wrote:
> On 18.03.2019 11:03, Simon Horman wrote:
> > On Fri, Mar 15, 2019 at 01:12:09PM +0300, Ilya Maximets wrote:
> >> On 15.03.2019 12:39, Simon Horman wrote:
> >>> On Fri, Mar 15, 2019 at 12:28:03PM +0300, Ilya Maximets wrote:
> On 1
I guess that Simon should look at it.
On Mon, Mar 11, 2019 at 09:26:03AM +0800, wenxu wrote:
>
> Hi,
> Are there any idear for this patch？
>
> BR
> wenxu
>
>
> 在 2019-03-06 12:35:58，we...@ucloud.cn 写道：
>
> > From: wenxu
> >
> > The hw do/t support USERSPACE action, it will lead many err
> >
On Thu, Mar 07, 2019 at 11:37:57PM -0800, Han Zhou wrote:
> On Thu, Mar 7, 2019 at 7:45 PM Han Zhou wrote:
> >
> > On Tue, Mar 5, 2019 at 6:17 PM Han Zhou wrote:
> > >
> > > From: Han Zhou
> > >
> > > When a row is deleted, if it is referenced by another row, the
> > > function ovsdb_idl_row_rep
On Mon, Mar 18, 2019 at 12:11:48PM -0700, Toms Atteka wrote:
> If NULL value was provided for odp_flow_from_string errorp argument
> segmentation fault error occurred.
>
> This patch fixes it by ignoring error formatting if error pointer
> is not provided.
>
> Reported-at:
> https://bugs.chromium
On Mon, Mar 18, 2019 at 02:02:30PM +0300, Ilya Maximets wrote:
> This information is not that useful.
> Anyway, no need to print it each time to the logs.
>
> CC: Ben Pfaff
> Fixes: d1fd1ea91242 ("ovs-dpctl: New --names option to use port names in flow
> dumps.")
> Signed-off-by: Ilya Maximets
Did you try compiling with Address Sanitizer yet? It is just as
effective as valgrind at finding leaks, but it slows the process much
less than valgrind does, so it is less likely to change behavior due to
timing issues.
On Mon, Mar 18, 2019 at 07:36:06AM +, Fernando Casas Schössow wrote:
> A
On Fri, Mar 15, 2019 at 03:37:20PM -0700, Han Zhou wrote:
> On Fri, Mar 15, 2019 at 3:30 PM Ben Pfaff wrote:
> >
> > On Thu, Mar 14, 2019 at 10:13:56AM -0700, Han Zhou wrote:
> > > From: Han Zhou
> > >
> > > When update is requested from follower, the leader sends AppendRequest
> > > to all follo
On Fri, Mar 15, 2019 at 04:17:35PM -0700, Han Zhou wrote:
> From: Han Zhou
>
> When update is requested from follower, the leader sends AppendRequest
> to all followers and wait until AppendReply received from majority, and
> then it will update commit index - the new entry is regarded as committ
On Sun, Mar 10, 2019 at 05:31:31AM +, Eli Britstein wrote:
> Generate datapath ovs key fields offset and size array macros as a
> pre-step for bit-wise comparing fields, with no functional change.
>
> Signed-off-by: Eli Britstein
> Reviewed-by: Roi Dayan
Thanks!
This introduces a script th
Using python `sys.exit(-1)` on Windows produces mixed results.
Let's take the following results from different shells:
CMD
>python -c "import sys; sys.exit(-1)" & echo %errorlevel%
1
MSYS
$ python -c "import sys; sys.exit(-1)" && echo $?
0
WSL
$ python -c "import sys; sys.exit(-1)"; echo $?
255
th
From: Han Zhou
When update is requested from follower, the leader sends AppendRequest
to all followers and wait until AppendReply received from majority, and
then it will update commit index - the new entry is regarded as committed
in raft log. However, this commit will not be notified to followe
On Mon, Mar 18, 2019 at 2:49 PM Ben Pfaff wrote:
>
> On Fri, Mar 15, 2019 at 04:17:35PM -0700, Han Zhou wrote:
> > From: Han Zhou
> >
> > When update is requested from follower, the leader sends AppendRequest
> > to all followers and wait until AppendReply received from majority, and
> > then it
From: Han Zhou
Add option --leader-timeout to ovsdb-server.
Signed-off-by: Han Zhou
---
Notes:
This patch is on top of:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-March/357339.html
ovsdb/ovsdb-server.1.in | 12
ovsdb/ovsdb-server.c| 23 +++---
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 ovsdb raft: Configurable leader timeout.
The copy o
On 18/03/2019 23:58, Ben Pfaff wrote:
> On Sun, Mar 10, 2019 at 05:31:31AM +, Eli Britstein wrote:
>> Generate datapath ovs key fields offset and size array macros as a
>> pre-step for bit-wise comparing fields, with no functional change.
>>
>> Signed-off-by: Eli Britstein
>> Reviewed-by: R
37 matches
Mail list logo
