Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Print netdev name for txq mapping.

On 3/5/2019 4:28 PM, Ilya Maximets wrote: In case of reconfiguration while 'vhost_id' is not set yet, there will be the meaningless message like: |netdev_dpdk|DBG|TX queue mapping for |netdev_dpdk|DBG| 0 --> 0 It's better to print the name of the netdev which is always set. Addition

Re: [ovs-dev] [PATCH] dpif-netdev-perf: Fix millisecond stats precision with slower TSC.

On 3/19/2019 1:01 PM, Jan Scheurich wrote: Hi Ilya, OK with me! BR, Jan -Original Message- From: Ilya Maximets Sent: Tuesday, 19 March, 2019 12:08 To: ovs-dev@openvswitch.org; Ian Stokes Cc: Kevin Traynor ; Ilya Maximets ; Jan Scheurich Subject: [PATCH] dpif-netdev-perf: Fix millis

Re: [ovs-dev] [PATCH 2/2] ovn-ctl: Make sure OVN_RUNDIR is created for central nodes.

On Thu, Mar 21, 2019 at 04:06:31PM -0700, Han Zhou wrote: > From: Han Zhou > > When ovn-ctl tries to start ovsdb, it didn't ensure the rundir > (e.g. /var/run/openvswitch) exist, because it is not calling > start_daemon(). Usually, if OVS is started by ovs-ctl before > on the same node, the folde

Re: [ovs-dev] [PATCH] rhel: Fix sphinx BuildRequires on Fedora Rawhide

On Fri, Mar 22, 2019 at 07:45:46PM +0100, Timothy Redaelli wrote: > On Fedora Rawhide only python3-sphinx is available, but currently > python2-sphinx is used. > > This commit changes the BuildRequires for sphinx to use > /usr/bin/sphinx-build directly instead of python2-sphinx in order to make >

Re: [ovs-dev] [PATCH] ovs-vsctl: Add datapath_type column to show command.

On Thu, Mar 21, 2019 at 01:56:47PM +0300, Ilya Maximets wrote: > Sometimes it's unclear which datapath type is in use by particular > bridge. For example, if all the interfaces supported by both system > and netdev datapaths it needs a DB query or log analysis to find out > which 'datapath_type' is

Re: [ovs-dev] [PATCH v2] reconnect.c: Don't transition back to ACTIVE when forced to RECONNECT.

On Fri, Mar 22, 2019 at 01:41:05PM -0700, Han Zhou wrote: > From: Han Zhou > > Currently, whenever there is activity on the session, the FSM is > transitioned to ACTIVE. However, this causes reconnect_force_reconnect() > failed to work once there are traffic received from remote after > transitio

Re: [ovs-dev] [PATCH 2/2] ovs: tests：Adjust the test cases about group stats

On Fri, Mar 22, 2019 at 06:26:33PM +0800, solomon wrote: > The bucket id field is added to the ofp11_bucket_counter structure. > So, adjust the corresponding testcases. > > > Signed-off-by: solomon See, you even broke OVS itself. These tests are designed to make sure that doesn't happen. _

Re: [ovs-dev] [PATCH 1/2] ovs: dump bucket id when doing dump-group-stats

On Fri, Mar 22, 2019 at 06:26:01PM +0800, solomon wrote: > --- a/include/openflow/openflow-1.1.h > +++ b/include/openflow/openflow-1.1.h > @@ -531,10 +531,12 @@ OFP_ASSERT(sizeof(struct ofp11_group_stats_request) == > 8); > > /* Used in group stats replies. */ > struct ofp11_bucket_counter { >

[ovs-dev] [PATCH v2] reconnect.c: Don't transition back to ACTIVE when forced to RECONNECT.

From: Han Zhou Currently, whenever there is activity on the session, the FSM is transitioned to ACTIVE. However, this causes reconnect_force_reconnect() failed to work once there are traffic received from remote after transition to RECONNECT, it will skip the reconnection phase and directly go ba

Re: [ovs-dev] [PATCH] reconnect.c: Don't transition back to ACTIVE when forced to RECONNECT.

On Fri, Mar 22, 2019 at 1:29 PM Ben Pfaff wrote: > > On Thu, Mar 21, 2019 at 09:55:15AM -0700, Han Zhou wrote: > > From: Han Zhou > > > > Currently, whenever there is activity on the session, the FSM is > > transitioned to ACTIVE. However, this causes reconnect_force_reconnect() > > failed to wor

Re: [ovs-dev] [PATCH] reconnect.c: Don't transition back to ACTIVE when forced to RECONNECT.

On Thu, Mar 21, 2019 at 09:55:15AM -0700, Han Zhou wrote: > From: Han Zhou > > Currently, whenever there is activity on the session, the FSM is > transitioned to ACTIVE. However, this causes reconnect_force_reconnect() > failed to work once there are traffic received from remote after > transitio

Re: [ovs-dev] [PATCH v5] Monitor Database table to manage lifecycle of IDL client.

On Thu, Mar 21, 2019 at 12:25:23PM +0530, Numan Siddique wrote: > On Sat, Jan 26, 2019 at 12:41 AM Ted Elhourani > wrote: > > > The Python IDL implementation supports ovsdb cluster connections. > > This patch is a follow up to commit 31e434fc98, it adds the option of > > connecting to the leader

[ovs-dev] [PATCH] rhel: Fix sphinx BuildRequires on Fedora Rawhide

On Fedora Rawhide only python3-sphinx is available, but currently python2-sphinx is used. This commit changes the BuildRequires for sphinx to use /usr/bin/sphinx-build directly instead of python2-sphinx in order to make it work on current Fedora Rawhide too. Signed-off-by: Timothy Redaelli ---

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

Hi Numan, Sure, sounds good to me. I am adding Mark and Han to the thread as well. I will be happy to make the change either ways. Meanwhile, if possible can you please take a look at other patches as well (v2). Appreciate your help. Regards, Ankur From: Numan Siddique Sent: Friday, March 22

Re: [ovs-dev] [RFC v4 1/1] datapath: Add a new action check_pkt_len

On 3/22/2019 2:58 AM, Numan Siddique wrote: On Fri, Mar 22, 2019 at 6:16 AM Gregory Rose > wrote: On 3/21/2019 5:38 PM, Gregory Rose wrote: > > > On 3/21/2019 10:37 AM, Numan Siddique wrote: >> This is the datapath patch - https://patchw

Re: [ovs-dev] [PATCH v2] python: Fix package requirements with old setuptools

Thanks for the patch, applied on master! -Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of aserd...@ovn.org Sent: Friday, March 22, 2019 4:26 PM To: 'Timothy Redaelli' ; d...@openvswitch.org Cc: Lucian Petrut Subject: Re: [ovs-dev] [PATCH v2] python: Fix package requi

Re: [ovs-dev] [PATCH v2] python: Fix package requirements with old setuptools

Acked-by: Alin Gabriel Serdean -Original Message- From: Timothy Redaelli Sent: Friday, March 22, 2019 4:02 PM To: d...@openvswitch.org Cc: Alin Serdean ; Lucian Petrut Subject: [PATCH v2] python: Fix package requirements with old setuptools Commit 00fcc832d598 ("Update Python package

[ovs-dev] [PATCH v2] python: Fix package requirements with old setuptools

Commit 00fcc832d598 ("Update Python package requirements") added a PEP 508 environment marker to install pywin32 on Windows systems. This requires a new setuptools version (>= 20.5), but (at least) RHEL/CentOS7 and Debian Jessie are using an older version of setuptools and so python extension fail

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

On Tue, Mar 19, 2019 at 12:33 AM Ankur Sharma wrote: > Hi Numan, > > Thanks a lot for comment. > Sure, I am ok either ways, i.e whether we want to read > “ovn-chassis-mac-mappings” from OVSDB on each chassis or from OVN > northbound DB. > Just wanted to make sure that we follow only ONE approach.

[ovs-dev] [PATCH] python: Fix package requirements with old setuptools

Commit 00fcc832d598 ("Update Python package requirements") added a PEP 508 environment marker to install pywin32 on Windows systems. This requires a new setuptools version (>= 20.5), but (at least) RHEL/CentOS7 and Debian Jessie are using an older version of setuptools and so python extension fail

Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup function

On 22.03.2019 16:08, Van Haaren, Harry wrote: > Hey Eelco, > >> -Original Message- >> From: Eelco Chaudron [mailto:echau...@redhat.com] >> Sent: Friday, March 22, 2019 12:29 PM >> To: Van Haaren, Harry >> Cc: ovs-dev@openvswitch.org; i.maxim...@samsung.com >> Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH v3] dpif-netdev: dfc_process optimization by prefetching EMC entry.

On 3/22/2019 8:44 AM, Yanqin Wei (Arm Technology China) wrote: Hi , OVS Maintainers, Could you help to have a look at this patch? Thanks a lot. Hi Wei, I'll have some time this afternoon to look at this. Thanks Ian Best Regards, Wei Yanqin -Original Message- From: Yanqin Wei Sent:

Re: [ovs-dev] [PATCH v3] dpif-netdev: dfc_process optimization by prefetching EMC entry.

On 22.03.2019 11:44, Yanqin Wei (Arm Technology China) wrote: > Hi , OVS Maintainers, > > Could you help to have a look at this patch? Thanks a lot. Hi. Thanks for improving performance and sorry for delay. Review process here in OVS is a bit slow due to lack of reviewers. I have a plan to test

Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup function

Hey Eelco, > -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Friday, March 22, 2019 12:29 PM > To: Van Haaren, Harry > Cc: ovs-dev@openvswitch.org; i.maxim...@samsung.com > Subject: Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup > functio

[ovs-dev] [PATCH] bridge: Propagate patch port pairing errors to db.

Virtual ports like 'patch' ports that almost fully implemented on 'ofproto' layer could have internal to 'ofproto' statuses that could not be retrieved from 'netdev' or other layers. For example, in current implementation there is no way to get the patch port pairing status (i.e. if it has usable p

Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup function

On 25 Feb 2019, at 17:18, Harry van Haaren wrote: This commit splits the generic hash-lookup-verify function to its own file. In doing so, we must move some MACRO definitions to dpif-netdev.h Changes look good, but want to wait for some performance numbers before ack’ing the series. Did y

Re: [ovs-dev] [PATCH v5 2/3] dpif-netdev: move dpcls lookup structures to .h

On 25 Feb 2019, at 17:18, Harry van Haaren wrote: This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c S

Re: [ovs-dev] [PATCH v5 1/3] dpif-netdev: implement function pointers/subtable

On 25 Feb 2019, at 17:18, Harry van Haaren wrote: This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. See two small style comments below, the rest looks fi

[ovs-dev] [PATCH 2/2] ovs: tests：Adjust the test cases about group stats

The bucket id field is added to the ofp11_bucket_counter structure. So, adjust the corresponding testcases. Signed-off-by: solomon --- tests/ofp-print.at | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tests/ofp-print.at b/t

[ovs-dev] [PATCH 1/2] ovs: dump bucket id when doing dump-group-stats

The number of the buckets that are dumped start from 0 and is incremented. If the bucket in the group is adjusted, such as delete or added, the order will be disrupted. Then we can't know which bucket the output value corresponds to. So, also dump the bucket id when doing dump-group-stats comma

Re: [ovs-dev] [RFC v4 1/1] datapath: Add a new action check_pkt_len

On Fri, Mar 22, 2019 at 6:16 AM Gregory Rose wrote: > > > On 3/21/2019 5:38 PM, Gregory Rose wrote: > > > > > > On 3/21/2019 10:37 AM, Numan Siddique wrote: > >> This is the datapath patch - > https://patchwork.ozlabs.org/patch/1046370/ > >> and this is the corresponding ovs-vswitchd patch - > >>

Re: [ovs-dev] [PATCH v3] dpif-netdev: dfc_process optimization by prefetching EMC entry.

Hi , OVS Maintainers, Could you help to have a look at this patch? Thanks a lot. Best Regards, Wei Yanqin -Original Message- From: Yanqin Wei Sent: Wednesday, March 13, 2019 1:28 PM To: d...@openvswitch.org Cc: nd ; Gavin Hu (Arm Technology China) ; Yanqin Wei (Arm Technology China)

[ovs-dev] Respond Asap

I am sorry for contacting you lately prior to this notice, I am Eric Sero the UN fiduciary lawyer and have been appointed to represent ECOWAS States on financial matters. I would like you to know that the United Nation has signed a payment regulation of 850,000 USD as compensation to you due to