Re: [ovs-dev] [PATCH 3/3] OVN: use send_event action to report 'empty_lb_rule' events

2019-07-05 Thread Ben Pfaff
On Fri, Jun 14, 2019 at 05:53:23PM +0200, Lorenzo Bianconi wrote: > Add northd logical flows in order to reports that the controller > received an IP packet for LB rule witn no backends. > This configuration is used by OpenShift to spin up a idle POD > > Signed-off-by: Mark Michelson >

Re: [ovs-dev] [PATCH 2/3] OVN: introduce send_event() action

2019-07-05 Thread Ben Pfaff
On Fri, Jun 14, 2019 at 05:53:22PM +0200, Lorenzo Bianconi wrote: > Add send_event() ovn action in order to allow ovs-vswitchd to report > CMS related events. > This commit introduces a new event, empty_lb_backends. This event is > raised if a received packet is destined for a load balancer VIP

Re: [ovs-dev] [PATCH 1/3] OVN: introduce Controller_Event table

2019-07-05 Thread Ben Pfaff
On Fri, Jun 14, 2019 at 05:53:21PM +0200, Lorenzo Bianconi wrote: > Add Controller_Event table to OVN SBDB in order to > report CMS related event. > Introduce event_table hashmap array and controller_event related > structures to ovn-controller in order to track pending events > forwarded by

Re: [ovs-dev] [PATCH 0/3] OVN: add Controller Events

2019-07-05 Thread Ben Pfaff
On Fri, Jun 14, 2019 at 05:53:20PM +0200, Lorenzo Bianconi wrote: > The series here introduces a new table, Controller_Event, for this > purpose. Traffic into OVS can raise a controller() event that results in > a Controller_Event being written to the southbound database. The > intention is for a

Re: [ovs-dev] [PATCH 0/3] ovn-controller: Fix and refactor chassis ovn-sbdb record init

2019-07-05 Thread Ben Pfaff
On Wed, Jun 12, 2019 at 12:37:57PM +0200, Dumitru Ceara wrote: > The chassis_run code didn't take into account the scenario when the > system-id was changed in the Open_vSwitch table. Due to this the code > was trying to insert a new Chassis record in the OVN_Southbound DB with > the same Encaps

Re: [ovs-dev] [PATCH v2] OVN: do not distribute traffic for local FIP

2019-07-05 Thread Ben Pfaff
On Thu, Jun 13, 2019 at 07:47:59PM +0200, Lorenzo Bianconi wrote: > Do not send traffic for local FIP through the overlay tunnels but > manage it in the local hypervisor > > Signed-off-by: Lorenzo Bianconi Thanks, applied to master. ___ dev mailing

Re: [ovs-dev] [PATCH v4] ovn: Add a new logical switch port type - 'virtual'

2019-07-05 Thread Ben Pfaff
On Fri, Jun 14, 2019 at 10:22:31PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This new type is added for the following reasons: > > - When a load balancer is created in an OpenStack deployment with Octavia > service, it creates a logical port 'VIP' for the virtual ip.

Re: [ovs-dev] [PATCH] ovn-northd: Add the option to pause and resume

2019-07-05 Thread Ben Pfaff
On Mon, Jun 17, 2019 at 11:10:04AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds 3 unixctl socket comments - pause, resume and is-paused. > > Usage: ovs-appctl -t ovn-northd pause/resume/is-paused > > This feature will be useful if the CMS wants to > - deploy

Re: [ovs-dev] [PATCH v2] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-07-05 Thread Ben Pfaff
On Thu, Jun 20, 2019 at 11:11:23AM -0400, Vasu Dasari wrote: > Say an ARP entry is learnt on a OVS port and when such a port is deleted, > learnt entry should be removed from the port. It would have be aged out after > ARP ageout time. This code will clean up immediately. > > Added test

Re: [ovs-dev] [PATCH v2] OVN: run local logical flows first in S_ROUTER_OUT_SNAT table

2019-07-05 Thread Ben Pfaff
On Wed, Jun 19, 2019 at 02:45:34PM +0200, Lorenzo Bianconi wrote: > Run local logical flows first if the gw router port is scheduled > on the local chassis in order to properly manage snat traffic > > Tested-by: Eran Kuris > Signed-off-by: Lorenzo Bianconi > --- > Changes since v1: > - add

Re: [ovs-dev] [PATCH branch-2.11 1/1] dpdk: Use DPDK 18.11.2 release.

2019-07-05 Thread Ben Pfaff
On Thu, Jun 20, 2019 at 02:00:48PM +0100, Ian Stokes wrote: > Modify travis linux build script to use the latest DPDK stable release > 18.11.2. Update docs for latest DPDK stable releases. > > Note: due to commit [1] in DPDK 18.11.2, the behaviour of the vhost > destroy callback has changed. DPDK

Re: [ovs-dev] [PATCH V2] Documentation: Clarify connection tracking tutorial

2019-07-05 Thread Ben Pfaff
On Wed, Jun 19, 2019 at 02:56:54PM -0700, Greg Rose wrote: > The current documentation states that "all packets entering OVS for > the first time are "untracked"". However there is a minor exception > to this in the case where a packet (re)enters the same datapath and > the namespace has not

Re: [ovs-dev] [PATCH v2] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-07-05 Thread Ben Pfaff
On Tue, Jun 25, 2019 at 09:28:32AM +, Vishal Deep Ajmera wrote: > Problem: > > In OVS-DPDK, flows with output over a bond interface of type "balance-tcp" > (using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into > "HASH" and "RECIRC" datapath actions. After

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-07-05 Thread Ben Pfaff
On Thu, Jun 27, 2019 at 09:10:06AM -0700, Gregory Rose wrote: > > > On 6/27/2019 7:51 AM, Ben Pfaff wrote: > > On Wed, Jun 26, 2019 at 03:21:49PM -0700, Gregory Rose wrote: > > > On 6/26/2019 11:59 AM, Ben Pfaff wrote: > > > > On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: > > > > >

Re: [ovs-dev] [PATCH v2 2/3] rconn: Remove write-only struct members.

2019-07-05 Thread Ben Pfaff
On Fri, Jun 28, 2019 at 02:51:41PM +0300, Ilya Maximets wrote: > On 11.06.2019 19:55, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > lib/rconn.c | 16 > > 1 file changed, 16 deletions(-) > > Acked-by: Ilya Maximets > > BTW, I'm curious if these members was ever

Re: [ovs-dev] [RFE] Event mechanism for a pro-active packet drop detection and recovery

2019-07-05 Thread Ben Pfaff
Wow. There's a lot here. Some of my reactions: - It's good to increase visibility. - I don't know much about the importance of different kinds of visibility or what kinds of tools will consume them downstream. I don't know the ultimate goals. - OVS doesn't currently implement d-bus. I

Re: [ovs-dev] [PATCH v4] ovn-controller: Omit tracking external_ids columns

2019-07-05 Thread Numan Siddique
On Fri, Jul 5, 2019 at 11:55 PM Ben Pfaff wrote: > On Fri, Jun 28, 2019 at 04:14:04PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Running the command "ovn-nbctl set logical_switch_port foo > external_ids:foo=bar" > > results in the incremetal processing engine to

[ovs-dev] ovn-controller taking lot of time to process logical flows

2019-07-05 Thread Numan Siddique
Hello, Daniel and Lucas were doing some scale testing with OpenShift deployed on top of OpenStack with OVN (OVS/OVN 2.9) in last couple of weeks. They noticed very high CPU usage during the test runs. Below are some of the observations we found - ovn-controller is taking a lot of time in

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove unused macro MAX_QUEUE_LENGTH.

2019-07-05 Thread Ben Pfaff
On Wed, Jun 19, 2019 at 12:22:45PM +0800, Yunjian Wang wrote: > Signed-off-by: Yunjian Wang Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4] ovn-controller: Omit tracking external_ids columns

2019-07-05 Thread Ben Pfaff
On Fri, Jun 28, 2019 at 04:14:04PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Running the command "ovn-nbctl set logical_switch_port foo > external_ids:foo=bar" > results in the incremetal processing engine to recompute the flows on the > chassis where the logical port 'foo'

Re: [ovs-dev] [PATCH v12] OVN: Enable E-W Traffic, Vlan backed DVR

2019-07-05 Thread Ben Pfaff
On Thu, Jun 20, 2019 at 01:36:46AM +, Ankur Sharma wrote: > Background: > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html > [2] > https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing > > Key difference between an overlay

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-05 Thread Ilya Maximets
Few more comments inline. On 01.07.2019 19:08, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable >

Re: [ovs-dev] [PATCH v2] ovn-controller: Provide the option to configure inactivity probe interval for OpenFlow conn

2019-07-05 Thread Ben Pfaff
On Mon, Jul 01, 2019 at 01:12:08PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > If the ovn-controller main loop takes more than 5 seconds (if there are lots > of logical > flows) before it calls poll_block(), it causes the poll_block to wake up > immediately, > since rconn

Re: [ovs-dev] [PATCH 1/1] db-ctl-base: fix memory leak in cmd-get() function

2019-07-05 Thread Ben Pfaff
On Fri, Jul 05, 2019 at 01:38:47PM +0200, Damijan Skvarc wrote: > Memory leak occured in case specified key was not found in table > record. > > Signed-off-by: Damijan Skvarc Thanks! Applied to master. ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-05 Thread Taehee Yoo
When a vport is deleted, the maximum headroom size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is equal to the old headroom size, updating routine is unnecessary. Signed-off-by: Taehee Yoo ---

[ovs-dev] [PATCH net-next] net: openvswitch: use netif_ovs_is_port() instead of opencode

2019-07-05 Thread Taehee Yoo
Use netif_ovs_is_port() function instead of open code. This patch doesn't change logic. Signed-off-by: Taehee Yoo --- net/openvswitch/dp_notify.c| 2 +- net/openvswitch/vport-netdev.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/openvswitch/dp_notify.c

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-05 Thread Ilya Maximets
On 01.07.2019 19:08, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK but cooperate

[ovs-dev] [PATCH 1/1] db-ctl-base: fix memory leak in cmd-get() function

2019-07-05 Thread Damijan Skvarc
Memory leak occured in case specified key was not found in table record. Signed-off-by: Damijan Skvarc --- lib/db-ctl-base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index fc09293..3bd9f00 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@