Re: [ovs-dev] [PATCH] datapath: Print friendly error message when conntrack fails to init

2019-07-19 Thread Yifeng Sun
Ok, I will do that. Thanks for reviewing. Yifeng On Fri, Jul 19, 2019 at 9:10 AM Gregory Rose wrote: > > On 7/18/2019 6:43 PM, Yifeng Sun wrote: > > On 4.14 kernels, if kernel isn't configured with CONFIG_NF_CONNTRACK_IPV4 > > and CONFIG_NF_CONNTRACK_IPV6, openvswitch module will fail to load.

Re: [ovs-dev] [PATCH v3] OVN: run local logical flows first in S_ROUTER_OUT_SNAT table

2019-07-19 Thread Darrell Ball
The following tests consistently fail for kernel and userspace datapaths 136: ovn -- DNAT and SNAT on distributed router - N/S FAILED ( system-ovn.at:1337) 137: ovn -- DNAT and SNAT on distributed router - E/W FAILED ( system-ovn.at:1510) after this commit commit

Re: [ovs-dev] Update on DDlog port of ovn-northd

2019-07-19 Thread Leonid Ryzhyk
Hi Mark, Many thanks for reporting this experiment! The latency plot is very insightful. The DDlog implementation is far from being optimized yet, so having multiple scale tests to use as performance targets is great. As one example of a low-hanging fruit, here are the top two lines from

Re: [ovs-dev] [PATCH] datapath: Print friendly error message when conntrack fails to init

2019-07-19 Thread Gregory Rose
On 7/18/2019 6:43 PM, Yifeng Sun wrote: On 4.14 kernels, if kernel isn't configured with CONFIG_NF_CONNTRACK_IPV4 and CONFIG_NF_CONNTRACK_IPV6, openvswitch module will fail to load. The error message is "openvswitch: failed to init nf_conncount -91". This patch prints helpful error message for

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-19 Thread William Tu
On Fri, Jul 19, 2019 at 05:54:54PM +0300, Ilya Maximets wrote: > On 18.07.2019 23:11, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built upon the eBPF and XDP

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-19 Thread Ilya Maximets
On 18.07.2019 23:11, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK but cooperate

[ovs-dev] [PATCHv2] system-traffic: Make nsh test more robust.

2019-07-19 Thread William Tu
The patch adds '-n' to tcpdump to avoid address coverting. Add '-l' for rhel8 to avoid buffering. Since '-U' is used to output to stdout, simply use 'cat' to search result. Use OVS_WAIT_UNTIL instead of sleep, and also remove/add some newlines. Finally, move tcpdump captured interface into the

Re: [ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

2019-07-19 Thread Ilya Maximets
On 18.07.2019 21:03, Ben Pfaff wrote: > On Wed, Jul 17, 2019 at 01:23:33PM -0700, William Tu wrote: >> --- a/include/openvswitch/thread.h >> +++ b/include/openvswitch/thread.h >> @@ -17,6 +17,8 @@ >> #ifndef OPENVSWITCH_THREAD_H >> #define OPENVSWITCH_THREAD_H 1 >> >> +#include > > That

Re: [ovs-dev] [PATCH] system-traffic.at: Make nsh test more robust.

2019-07-19 Thread William Tu
On Thu, Jul 18, 2019 at 04:26:30PM +0300, Ilya Maximets wrote: > On 18.07.2019 0:21, William Tu wrote: > > The patch adds '-n' to tcpdump to avoid address coverting. Since '-U' is > > used to output to stdout, simply use 'cat' to search result. > > Use OVS_WAIT_UNTIL instead of sleep ,and also

[ovs-dev] UMSCHREIBEN IHRER FONDSZAHLUNGSDATEIEN / AUSFÜHRUNG

2019-07-19 Thread Stewart Gosby
Sehr geehrter Herr / Frau, UMSCHREIBEN IHRER FONDSZAHLUNGSDATEIEN / AUSFÜHRUNG Ich habe Ihre E-Mail erhalten und verstehe, Sie meinen, ich sollte versuchen, Nummer 51 Tiriot Street 13127 Berlin zu finden, oder? Im Moment bin ich auf dem Flughafen und werde angehalten, um vom deutschen Zolldienst

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Ian Stokes
On 7/19/2019 12:14 PM, Stokes, Ian wrote: -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Friday, July 19, 2019 11:57 AM To: Stokes, Ian ; Van Haaren, Harry ; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations On

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Stokes, Ian
> >> -Original Message- > >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] > >> Sent: Friday, July 19, 2019 11:57 AM > >> To: Stokes, Ian ; Van Haaren, Harry > >> ; d...@openvswitch.org > >> Subject: Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations > >> > >> On

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Ilya Maximets
On 19.07.2019 14:00, Stokes, Ian wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Friday, July 19, 2019 11:57 AM >> To: Stokes, Ian ; Van Haaren, Harry >> ; d...@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs &

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Stokes, Ian
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, July 19, 2019 11:57 AM > To: Stokes, Ian ; Van Haaren, Harry > ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations > > On 19.07.2019 11:27, Ian Stokes

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Ilya Maximets
On 19.07.2019 11:27, Ian Stokes wrote: > On 7/19/2019 9:08 AM, Ilya Maximets wrote: >> On 19.07.2019 9:58, Ian Stokes wrote: >>> On 7/18/2019 3:30 PM, Ian Stokes wrote: On 7/18/2019 2:03 PM, Harry van Haaren wrote: > Hey Folks, > > Here a v14 of the DPCLS Function Pointer

Re: [ovs-dev] [PATCH v14 5/5] dpif-netdev: Add specialized generic scalar functions

2019-07-19 Thread Stokes, Ian
> On 18.07.2019 16:03, Harry van Haaren wrote: > > This commit adds a number of specialized functions, that handle > > common miniflow fingerprints. This enables compiler optimization, > > resulting in higher performance. Below a quick description of > > how this optimization actually works; > > >

Re: [ovs-dev] [PATCH v14 5/5] dpif-netdev: Add specialized generic scalar functions

2019-07-19 Thread Ilya Maximets
On 18.07.2019 16:03, Harry van Haaren wrote: > This commit adds a number of specialized functions, that handle > common miniflow fingerprints. This enables compiler optimization, > resulting in higher performance. Below a quick description of > how this optimization actually works; > >

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Ian Stokes
On 7/19/2019 9:08 AM, Ilya Maximets wrote: On 19.07.2019 9:58, Ian Stokes wrote: On 7/18/2019 3:30 PM, Ian Stokes wrote: On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on

Re: [ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__

2019-07-19 Thread Dumitru Ceara
Hi Damijan, Ben, Damijan, sorry, I didn't realize you had already reported and fixed the problem in your pending pull request. I wouldn't have sent my patch otherwise. Regarding a single parsed field instead of parsed bits per column I had the impression that it's ok if unparsing is done for all

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Ilya Maximets
On 19.07.2019 9:58, Ian Stokes wrote: > On 7/18/2019 3:30 PM, Ian Stokes wrote: >> On 7/18/2019 2:03 PM, Harry van Haaren wrote: >>> Hey Folks, >>> >>> Here a v14 of the DPCLS Function Pointer patchset, as has been >>> presented at OVS Conf in Nov '18, and discussed on the ML since then. >>> I'm

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-19 Thread Ian Stokes
On 7/18/2019 3:30 PM, Ian Stokes wrote: On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has