Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

Hi Alin, Will update the patch and change it according to the comments. Thanks very much. BR/Amber On 1/22/20, 12:43, "Alin Serdean" wrote: Hi Amber, The patch fails to apply: "error: corrupt patch at line 198" Please rebase on master. Trimming the patch a

Re: [ovs-dev] [PATCH] Grant Access Privilege of Named Pipe to Creator

Hi, Sorry I missed the email. The direction sounds ok with me. It will surely help with unit tests, since right now they require elevated permissions. Adding also Anand in the loop. Anand do you like the idea? Please also add a few lines to the documentation so users are aware of the change.

[ovs-dev] Powerful Electr0nic M0squito Lamp ⚔️⚔️⚔️⚔️⚔️⚔️⚔️.........................................

/ ___ dev

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

Hi Amber, The patch fails to apply: "error: corrupt patch at line 198" Please rebase on master. Trimming the patch a bit and comments inlined. > -Original Message- > From: Amber Hu > Sent: Tuesday, January 14, 2020 7:50 AM > To: d...@openvswitch.org; Alin Serdean > Cc: Qiong Wang ;

[ovs-dev] About your ATM shipment

Dear Friend, I am Anina Lylund, the newly parcel delivery officer with the DHL Courier Services Nigeria. During my personal audit yesterday, I came across an abandoned registered ATM Visa Card bearing your name and address as the recipient. After studying the shipment papers carefully, I

Re: [ovs-dev] [PATCH] ofproto: Fix for frequent invalidation of flows due to mismatch in mask bits

On Thu, Jan 16, 2020 at 09:47:23PM +0530, Vishal Deep Ajmera via dev wrote: > The wildcard bits in the installed megaflow entry could be different from > the bits originally generated by the ofproto layer. Datapath implementation > wildcards those match fields which are not present in the incoming

Re: [ovs-dev] [PATCH ovn] ovn-northd: Set stage-hint for all applicable flows.

Hi Dumitru, It appears that some of the stage hints correspond to DHCPv4_Options and DHCPv6_Options, but these are not handled in ovn-detrace. On 1/17/20 10:44 AM, Dumitru Ceara wrote: Until now the 'stage-hint' external-id was set only for logical flows installed for ACLs. In order to

Re: [ovs-dev] [PATCH v5] userspace: Add TCP Segmentation Offload support

On Sat, Jan 18, 2020 at 12:08:06AM +0100, Ilya Maximets wrote: > On 18.01.2020 00:03, Stokes, Ian wrote: > > Thanks all for review/testing, pushed to master. > > OK, thanks Ian. > > @Ben, even though this patch already merged, I'd ask you to take a look > at the code in case you'll spot some

Re: [ovs-dev] [PATCH v2 1/2] Prepare for 2.13.0.

Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Prepare for 2.13.0. The copy of the patch that

Re: [ovs-dev] [PATCH] Prepare for 2.13.0.

Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Prepare for 2.13.0. The copy of the patch that

Re: [ovs-dev] [PATCH v2 2/2] Prepare for post-2.13.0 (2.13.90).

On Tue, Jan 21, 2020 at 12:55:17PM -0800, Guru Shetty wrote: > On Tue, 21 Jan 2020 at 12:46, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > > For both: > Acked-by: Gurucharan Shetty Thank you! We are now branched for the 2.13 release. ___ dev

Re: [ovs-dev] [PATCH v10 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

On Mon, Jan 20, 2020 at 05:09:05PM +0100, Ilya Maximets wrote: > > +static struct tx_bond * > > +tx_bond_lookup(const struct hmap *hmap, uint32_t bond_id) > > +{ > > +struct tx_bond *tx; > > + > > +HMAP_FOR_EACH_IN_BUCKET (tx, node, hash_bond_id(bond_id), hmap) { > > Why not

Re: [ovs-dev] [PATCH v2 2/2] Prepare for post-2.13.0 (2.13.90).

On Tue, 21 Jan 2020 at 12:46, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > For both: Acked-by: Gurucharan Shetty > --- > NEWS | 4 > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS >

[ovs-dev] [PATCH v2 0/2] Branch for 2.13.0

v2 since I forgot the second patch the first time (thanks Guru!). Ben Pfaff (2): Prepare for 2.13.0. Prepare for post-2.13.0 (2.13.90). NEWS | 6 +- configure.ac | 2 +- debian/changelog | 10 -- 3 files changed, 14 insertions(+), 4 deletions(-) -- 2.23.0

Re: [ovs-dev] [PATCH] Prepare for 2.13.0.

On Tue, Jan 21, 2020 at 12:42:55PM -0800, Guru Shetty wrote: > On Tue, 21 Jan 2020 at 12:27, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > > > Usually I see one more "Prepare for post-" patch. But I guess, you intend > to do it later. Oh, you're right. Usually I rely on Justin to do

[ovs-dev] [PATCH v2 1/2] Prepare for 2.13.0.

Signed-off-by: Ben Pfaff --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index c6d3b6053f8d..89b53bfae039 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -Post-v2.12.0 +v2.13.0 - xx xxx

[ovs-dev] [PATCH v2 2/2] Prepare for post-2.13.0 (2.13.90).

Signed-off-by: Ben Pfaff --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 89b53bfae039..100cb22d568d 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +Post-v2.13.0

Re: [ovs-dev] [PATCH ovn v2 0/2] Caching logical flow expr tree for each lflow

I have pushed the series to master. On 1/21/20 3:05 PM, Han Zhou wrote: On Tue, Jan 21, 2020 at 6:40 AM wrote: From: Numan Siddique This patch series tries to improve the time taken to proceess logical flows by caching the expr tree. For large scale deployments with lots of logical flows,

Re: [ovs-dev] [PATCH] Prepare for 2.13.0.

On Tue, 21 Jan 2020 at 12:27, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Usually I see one more "Prepare for post-" patch. But I guess, you intend to do it later. Acked-by: Guru Shetty > --- > NEWS | 2 +- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

Sure. I will review it tonight. Thanks, Alin. -Original Message- From: Ben Pfaff Sent: Tuesday, January 21, 2020 7:59 PM To: Amber Hu Cc: d...@openvswitch.org; Alin Serdean ; Qiong Wang Subject: Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct

[ovs-dev] [PATCH] Prepare for 2.13.0.

Signed-off-by: Ben Pfaff --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index c6d3b6053f8d..89b53bfae039 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -Post-v2.12.0 +v2.13.0 - xx xxx

Re: [ovs-dev] [PATCH ovn v2 0/2] Caching logical flow expr tree for each lflow

On Tue, Jan 21, 2020 at 6:40 AM wrote: > > From: Numan Siddique > > This patch series tries to improve the time taken to proceess logical > flows by caching the expr tree. For large scale deployments with lots > of logical flows, the logical flow processing to OpenFlow rules > takes a lot of

Re: [ovs-dev] [PATCH ovn v2 2/2] ovn-controller: Cache logical flow expr tree for each lflow.

On Tue, Jan 21, 2020 at 6:41 AM wrote: > > From: Numan Siddique > > This patch caches the logical flow expr tree for each logical flow. This > cache is stored as an hashmap in the output_flow engine data. When a logical > flow is deleted, the expr tree for that lflow is deleted in the >

Re: [ovs-dev] [PATCH] Use TPACKET_V1/V2/V3 to accelerate veth for DPDK datapath

On Tue, Jan 21, 2020 at 02:49:47AM -0500, yang_y...@163.com wrote: > From: Yi Yang > > We can avoid high system call overhead by using TPACKET_V1/V2/V3 > and use DPDK-like poll to receive and send packets (Note: send > still needs to call sendto to trigger final packet transmission). > > I can

Re: [ovs-dev] [PATCHv6] userspace: Add GTP-U support.

Hi William, Two comments, please inline. >-Original Message- >From: William Tu >Sent: Thursday, January 16, 2020 9:45 PM >To: d...@openvswitch.org >Cc: Roni Bar Yanai ; acon...@redhat.com; >yangy...@inspur.com; fhal...@redhat.com; ashishvarma@gmail.com; >b...@ovn.org >Subject:

Re: [ovs-dev] [PATCH] docs: Add header install command for afxdp.

On Tue, Jan 21, 2020 at 09:48:28AM -0800, William Tu wrote: > The 'XDP_RING_NEED_WAKEUP' and related flags are defined if_xdp.h, so after > installing newer kernel, users have to update the kernel's header files, > by doing: > $ make headers_install INSTALL_HDR_PATH=/usr > > Otherwise the

Re: [ovs-dev] [PATCHv6] userspace: Add GTP-U support.

On Fri, Jan 17, 2020 at 04:24:42PM -0800, William Tu wrote: > On Fri, Jan 17, 2020 at 02:14:27PM -0800, Ben Pfaff wrote: > > On Thu, Jan 16, 2020 at 11:45:20AM -0800, William Tu wrote: > > > GTP, GPRS Tunneling Protocol, is a group of IP-based communications > > > protocols used to carry general

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

On Thu, Jan 16, 2020 at 9:01 AM Flavio Leitner wrote: > > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > the network stack to delegate the TCP segmentation to the NIC reducing > the per packet CPU overhead. > > A guest using vhost-user interface with TSO enabled can

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

I expect that, of the OVS maintainers, Alin is most qualified to review it. Alin, are you planning to take a look at it? On Tue, Jan 21, 2020 at 02:52:54AM +, Amber Hu via dev wrote: > Hi, > > May I ask the process of reviewing for the below patch >

[ovs-dev] [PATCH] docs: Add header install command for afxdp.

The 'XDP_RING_NEED_WAKEUP' and related flags are defined if_xdp.h, so after installing newer kernel, users have to update the kernel's header files, by doing: $ make headers_install INSTALL_HDR_PATH=/usr Otherwise the following error shows: /usr/local/include/bpf/xsk.h: In function

[ovs-dev] [PATCHv8] userspace: Add GTP-U support.

GTP, GPRS Tunneling Protocol, is a group of IP-based communications protocols used to carry general packet radio service (GPRS) within GSM, UMTS and LTE networks. GTP protocol has two parts: Signalling (GTP-Control, GTP-C) and User data (GTP-User, GTP-U). GTP-C is used for setting up GTP-U

[ovs-dev] Es momento de darle un giro a tu empresa

Miércoles 12 de Febrero | Horario de 10:00 a 14:00 hrs. | (hora del centro de México) - ¿Cómo aumentar tus ventas con Whatsapp Business? - ¿De qué hablaremos? Aprende a vender por la aplicación más usada del mundo utilizando herramientas digitales que aumentarán tu conversión actual de

Re: [ovs-dev] [PATCH v3] Documentation: add notes for TSO & i40e

On 1/20/2020 2:45 PM, Flavio Leitner wrote: ACK, thanks! fbl Thanks All, pushed to master. Regards Ian On Mon, Jan 20, 2020 at 01:09:36PM +, Ciara Loftus wrote: When using TSO in OVS-DPDK with an i40e device, the following patch is required for DPDK, which fixes an issue on the

Re: [ovs-dev] [PATCHv7] userspace: Add GTP-U support.

On Fri, Jan 17, 2020 at 7:00 PM 0-day Robot wrote: > > Bleep bloop. Greetings William Tu, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: C99 style comment >

Re: [ovs-dev] [PATCH v2] tc: handle packet mark of zero

On Thu, Jan 16, 2020 at 09:23:11AM -0500, Aaron Conole wrote: > Simon Horman writes: > > > On Thu, Jan 16, 2020 at 04:59:54AM -0500, 0-day Robot wrote: > >> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out > >> your patch. > >> Thanks for your contribution. > >> > >> I

[ovs-dev] [PATCH ovn v2 1/2] expr: Evaluate the condition expression in a separate step.

From: Numan Siddique A new function is added - expr_evaluate_condition() which evaluates the condition expression - is_chassis_resident. expr_simply() will no longer evaluates this condition. An upcoming commit needs this in order to cache the logical flow expressions so that every lflow_*()

[ovs-dev] [PATCH ovn v2 2/2] ovn-controller: Cache logical flow expr tree for each lflow.

From: Numan Siddique This patch caches the logical flow expr tree for each logical flow. This cache is stored as an hashmap in the output_flow engine data. When a logical flow is deleted, the expr tree for that lflow is deleted in the flow_output_sb_logical_flow_handler(). Below are the details

[ovs-dev] [PATCH ovn v2 0/2] Caching logical flow expr tree for each lflow

From: Numan Siddique This patch series tries to improve the time taken to proceess logical flows by caching the expr tree. For large scale deployments with lots of logical flows, the logical flow processing to OpenFlow rules takes a lot of time as it is CPU intensive. This patch series tries to

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Cache logical flow expr tree for each lflow.

On Tue, Jan 21, 2020 at 2:03 PM Han Zhou wrote: > > On Thu, Jan 9, 2020 at 9:37 AM wrote: > > > > From: Numan Siddique > > > > This patch caches the logical flow expr tree for each logical flow. This > > cache is stored as an hashmap in the output_flow engine data. When a > logical > > flow is

Re: [ovs-dev] OVN Soft Freeze

On Tue, Jan 21, 2020 at 12:09 PM Mark Michelson wrote: > > Hi all, > > OVN has entered its "soft freeze" state. That means that any new > features that should be added prior to the next release need to have > reviews posted already. > > At this point, if anyone has any specific new features they

[ovs-dev] OVN Soft Freeze

Hi all, OVN has entered its "soft freeze" state. That means that any new features that should be added prior to the next release need to have reviews posted already. At this point, if anyone has any specific new features they want reviewed prior to the release, please reply on this thread.

[ovs-dev] Mein liebster Schatz

Mein liebster Schatz Wie geht es dir heute? Ich hoffe, dir geht es gut. Ich bin Fräulein Caroline Richard. Bitte ich möchte, dass Sie mir bei der Investition eines Gesamtbetrags von (5,7 Millionen Euro) helfen, den ich von meinen verstorbenen Eltern geerbt habe. Ich bitte um Ihre

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Cache logical flow expr tree for each lflow.

On Thu, Jan 9, 2020 at 9:37 AM wrote: > > From: Numan Siddique > > This patch caches the logical flow expr tree for each logical flow. This > cache is stored as an hashmap in the output_flow engine data. When a logical > flow is deleted, the expr tree for that lflow is deleted in the >

Re: [ovs-dev] [PATCH ovn 1/2] expr: Evaluate the condition expression in a separate step.

On Thu, Jan 9, 2020 at 9:37 AM wrote: > > From: Numan Siddique > > A new function is added - expr_evaluate_condition() which evaluates > the condition expression - is_chassis_resident. expr_simply() will > no longer evaluates this condition. > > An upcoming commit needs this in order to cache