Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread Han Zhou
On Tue, Feb 18, 2020 at 11:56 AM Numan Siddique wrote: > > On Tue, Feb 18, 2020 at 11:50 PM Han Zhou wrote: > > > > On Tue, Feb 18, 2020 at 9:27 AM Numan Siddique wrote: > > > > > On Tue, Feb 18, 2020 at 10:34 PM Han Zhou wrote: > > > > > > > > On Tue, Feb 18, 2020 at 7:32 AM wrote: > > > > >

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread Han Zhou
On Tue, Feb 18, 2020 at 11:54 AM wrote: > > From: Numan Siddique > > After the patch [1], which added caching of lflow expr, the lflow_resource_ref > is not rebuilt properly when lflow_run() is called. If a lflow is already cached > in lflow expr cache, then the lflow_resource_ref is not updated.

[ovs-dev] 答复: 答复: [PATCH v3] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-02-18 Thread 杨燚
Hi, William I pushed fix patch into my github repo, travis showed all the builds passed, https://travis-ci.org/yyang13/ovs (my ovs repo: https://github.com/yyang13/ovs) I'll include this in next version, I'll send out it after I get more comments and work out a way which can make sure tpacket_v

[ovs-dev] 答复: 答复: [PATCH v3] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-02-18 Thread 杨燚
Thanks William, I forked ovs to my github account, travis worked, I'll fix those build issues. -邮件原件- 发件人: William Tu [mailto:u9012...@gmail.com] 发送时间: 2020年2月18日 23:32 收件人: Yi Yang (杨燚)-云服务集团 抄送: yang_y...@126.com; ovs-dev@openvswitch.org; yang_y...@163.com 主题: Re: [ovs-dev] 答复: [PATCH

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread Numan Siddique
On Wed, Feb 19, 2020, 3:01 AM Mark Michelson wrote: > Hi, Numan. Would it be possible to add a test case that exercises the fix? > Hi Mark, The modified test case in this patch fails without the fix. Numan > On 2/18/20 2:53 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > After th

[ovs-dev] [PATCH ovn] ovn-controller.c: Avoid adding neighbour flows for non-local datapaths.

2020-02-18 Thread Han Zhou
This is usefule when external_ids:ovn-monitor-all is set to true. Signed-off-by: Han Zhou --- controller/lflow.c | 15 +++ controller/lflow.h | 1 + controller/ovn-controller.c | 6 +- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/controller/

Re: [ovs-dev] [PATCH] conntrack: Fix TCP conntrack state

2020-02-18 Thread William Tu
On Tue, Feb 11, 2020 at 04:07:53PM +0100, Dumitru Ceara wrote: > On 2/7/20 11:55 PM, Yi-Hung Wei wrote: > > If a TCP connection is in SYN_SENT state, receiving another SYN packet > > would just renew the timeout of that conntrack entry rather than create > > a new one. Thus, tcp_conn_update() shou

[ovs-dev] [PATCH ovn] ovn-controller: Avoid creating patch port for non-local datapaths.

2020-02-18 Thread Han Zhou
When external-ids:ovn-monitor-all is set to true, patch ports for non-local datapaths may be created, which is unnecessary and confusing. This patch avoids that by checking if a localnet port belongs to local datapaths before creating the patch port. It also moves patch_run() in mainloop after en

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread Mark Michelson
Hi, Numan. Would it be possible to add a test case that exercises the fix? On 2/18/20 2:53 PM, num...@ovn.org wrote: From: Numan Siddique After the patch [1], which added caching of lflow expr, the lflow_resource_ref is not rebuilt properly when lflow_run() is called. If a lflow is already cac

Re: [ovs-dev] OVS GPU

2020-02-18 Thread William Tu
On Sun, Feb 16, 2020 at 8:30 AM Akilesh K wrote: > > Hi, > I read a white paper on boosting OpenVswitch performance using integrated > GPU. > > https://www.researchgate.net/publication/319050396_Accelerating_Open_vSwitch_with_Integrated_GPU > > Is there an official project among OpenVswitch develo

Re: [ovs-dev] [PATCH 3/4] datapath.c: Use built-in RCU list checking

2020-02-18 Thread David Miller
From: madhuparnabhowmi...@gmail.com Date: Wed, 19 Feb 2020 01:28:02 +0530 > From: Madhuparna Bhowmik > > hlist_for_each_entry_rcu() has built-in RCU and lock checking. > > Pass cond argument to list_for_each_entry_rcu() to silence > false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled >

Re: [ovs-dev] [PATCH 1/4] meter.c: Use built-in RCU list checking

2020-02-18 Thread David Miller
From: madhuparnabhowmi...@gmail.com Date: Wed, 19 Feb 2020 01:24:25 +0530 > From: Madhuparna Bhowmik > > hlist_for_each_entry_rcu() has built-in RCU and lock checking. > > Pass cond argument to list_for_each_entry_rcu() to silence > false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled >

Re: [ovs-dev] [PATCH 4/4] flow_table.c: Use built-in RCU list checking

2020-02-18 Thread David Miller
From: madhuparnabhowmi...@gmail.com Date: Wed, 19 Feb 2020 01:28:20 +0530 > From: Madhuparna Bhowmik > > hlist_for_each_entry_rcu() has built-in RCU and lock checking. > > Pass cond argument to list_for_each_entry_rcu() to silence > false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled >

Re: [ovs-dev] [PATCH 2/4] vport.c: Use built-in RCU list checking

2020-02-18 Thread David Miller
From: madhuparnabhowmi...@gmail.com Date: Wed, 19 Feb 2020 01:27:42 +0530 > From: Madhuparna Bhowmik > > hlist_for_each_entry_rcu() has built-in RCU and lock checking. > > Pass cond argument to list_for_each_entry_rcu() to silence > false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled >

[ovs-dev] [PATCH 4/4] flow_table.c: Use built-in RCU list checking

2020-02-18 Thread madhuparnabhowmik10
From: Madhuparna Bhowmik hlist_for_each_entry_rcu() has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu() to silence false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled by default. Signed-off-by: Madhuparna Bhowmik --- net/openvswitch/flow_table.c | 6 +++

[ovs-dev] [PATCH 3/4] datapath.c: Use built-in RCU list checking

2020-02-18 Thread madhuparnabhowmik10
From: Madhuparna Bhowmik hlist_for_each_entry_rcu() has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu() to silence false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled by default. Signed-off-by: Madhuparna Bhowmik --- net/openvswitch/datapath.c | 9 +

[ovs-dev] [PATCH 2/4] vport.c: Use built-in RCU list checking

2020-02-18 Thread madhuparnabhowmik10
From: Madhuparna Bhowmik hlist_for_each_entry_rcu() has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu() to silence false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled by default. Signed-off-by: Madhuparna Bhowmik --- net/openvswitch/vport.c | 3 ++- 1 f

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread Numan Siddique
On Tue, Feb 18, 2020 at 11:50 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 9:27 AM Numan Siddique wrote: > > > On Tue, Feb 18, 2020 at 10:34 PM Han Zhou wrote: > > > > > > On Tue, Feb 18, 2020 at 7:32 AM wrote: > > > > > > > > From: Numan Siddique > > > > > > > > After the patch [1], which a

[ovs-dev] [PATCH 1/4] meter.c: Use built-in RCU list checking

2020-02-18 Thread madhuparnabhowmik10
From: Madhuparna Bhowmik hlist_for_each_entry_rcu() has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu() to silence false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled by default. Signed-off-by: Madhuparna Bhowmik --- net/openvswitch/meter.c | 3 ++- 1 f

[ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-18 Thread numans
From: Numan Siddique After the patch [1], which added caching of lflow expr, the lflow_resource_ref is not rebuilt properly when lflow_run() is called. If a lflow is already cached in lflow expr cache, then the lflow_resource_ref is not updated. But flow_output_run() clears the lflow_resource_ref

Re: [ovs-dev] [PATCH ovn] ovn-nbctl.8.xml: Daemon mode document minor fix.

2020-02-18 Thread Han Zhou
On Mon, Feb 17, 2020 at 11:19 PM Numan Siddique wrote: > > On Tue, Feb 18, 2020 at 10:32 AM Han Zhou wrote: > > > > Signed-off-by: Han Zhou > > Acked-by: Numan Siddique > > Thanks > Numan > Thanks. I applied to master. > > --- > > utilities/ovn-nbctl.8.xml | 2 +- > > 1 file changed, 1 inser

Re: [ovs-dev] [PATCH ovn] automake.mk: Use PYTHON3 to generate the ovn-ic-{n, sb} pics

2020-02-18 Thread 0-day Robot
Bleep bloop. Greetings Timothy Redaelli, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 121 characters long (recommended limit is 79) #36 FILE: utilities/ovn-ctl:

Re: [ovs-dev] [PATCH ovn] automake.mk: Use PYTHON3 to generate the ovn-ic-{n, sb} pics

2020-02-18 Thread Mark Michelson
Hi Timothy, It looks like some wires got crossed here. commit ff39e6c5 from James Page fixed this in master, but the fix was not backported to the 20.03 branch. I'm going to backport the existing commit to 20.03. On 2/18/20 12:53 PM, Timothy Redaelli wrote: Currently $(PYTHON) is used in ord

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread Han Zhou
On Tue, Feb 18, 2020 at 9:27 AM Numan Siddique wrote: > On Tue, Feb 18, 2020 at 10:34 PM Han Zhou wrote: > > > > On Tue, Feb 18, 2020 at 7:32 AM wrote: > > > > > > From: Numan Siddique > > > > > > After the patch [1], which added caching of lflow expr, the > > lflow_resource_ref > > > is not r

[ovs-dev] [PATCH ovn] automake.mk: Use PYTHON3 to generate the ovn-ic-{n, sb} pics

2020-02-18 Thread Timothy Redaelli
Currently $(PYTHON) is used in order to launch dot2pic script to generate the diagram, but this is wrong since PYTHON variable is NOT defined by the build system and so it fails when "python" binary doesn't exists (like on RHEL8). This commit fixes this by using the correct PYTHON3 variable that i

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread Numan Siddique
On Tue, Feb 18, 2020 at 10:34 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 7:32 AM wrote: > > > > From: Numan Siddique > > > > After the patch [1], which added caching of lflow expr, the > lflow_resource_ref > > is not rebuilt properly when lflow_run() is called. If a lflow is already > cached

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread Han Zhou
On Tue, Feb 18, 2020 at 7:32 AM wrote: > > From: Numan Siddique > > After the patch [1], which added caching of lflow expr, the lflow_resource_ref > is not rebuilt properly when lflow_run() is called. If a lflow is already cached > in lflow expr cache, then the lflow_resource_ref is not updated.

Re: [ovs-dev] 答复: [PATCH v4] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-02-18 Thread William Tu
On Mon, Feb 17, 2020 at 6:10 AM Yi Yang (杨燚)-云服务集团 wrote: > > Ilya, thank you so much for your comments, I'll fix them in next version. > > For TSO support, this patch can work from functionality, but I checked > tpacket_v3 kernel code, I don't think tpacket_v3 kernel part can support it, > my tes

[ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-18 Thread numans
From: Numan Siddique After the patch [1], which added caching of lflow expr, the lflow_resource_ref is not rebuilt properly when lflow_run() is called. If a lflow is already cached in lflow expr cache, then the lflow_resource_ref is not updated. But flow_output_run() clears the lflow_resource_ref

Re: [ovs-dev] 答复: [PATCH v3] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-02-18 Thread William Tu
On Fri, Feb 14, 2020 at 8:10 PM Yi Yang (杨燚)-云服务集团 wrote: > > William, I don't know why I can't receive your comments in my outlook, > https://mail.openvswitch.org/pipermail/ovs-dev/2020-February/367860.html > Are you able to use github? if OK, then travis can directly links to you github repo. So

[ovs-dev] [PATCH V2 1/1] dpif-netdev.at: VLAN id modification test for ARP partial HW offloading

2020-02-18 Thread Eli Britstein
Follow up to commit eb540c0f5fc8 ("flow: Fix parsing l3_ofs with partial offloading") that fixed the issue, add a unit-test for it. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- tests/dpif-netdev.at | 77 1 file changed, 77 insertio

Re: [ovs-dev] [PATCH v2 1/1] docs: Add flow control on i40e issue

2020-02-18 Thread Konieczny, TomaszX
>-Original Message- >From: Flavio Leitner >Sent: 17 February 2020 19:07 >To: Konieczny, TomaszX >Cc: d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCH v2 1/1] docs: Add flow control on i40e issue > >On Mon, Feb 17, 2020 at 12:37:36PM +0100, Tomasz Konieczny wrote: >> There is an issu

[ovs-dev] (no subject)

2020-02-18 Thread OOO TD ALTAYNEFT via dev
We introduce to you “OOO TD "ALTAYNEFT" a mandate company that is bond in law and authorized to represent a reputable end seller company involved in the selling of various petroleum products: JP54, Jet fuel A1, LPG, LNG, Mazut, D2, D6. We also have reliable Storage Tanks (Tank Farm) availabl

Re: [ovs-dev] [PATCH 00/25] netdev datapath vxlan offload

2020-02-18 Thread Eli Britstein
On 2/10/2020 11:16 PM, Hemal Shah wrote: Eli, There are some fundamental architecture issues (multi HW tables vs. single HW table, use of rte_flow JUMP action for mapping ovs sw tnl_pop action, etc.) that we need to discuss before we can get into the details of the patchset. I'm inlining my

Re: [ovs-dev] [PATCH v2] db-ctl-base: add uuid specified method for create cmd

2020-02-18 Thread taoyunxi...@cmss.chinamobile.com
Hi,Ben,            Thanks for your reply.  Below is is my commet . -- taoyunxi...@cmss.chinamobile.com >On Thu, Feb 06, 2020 at 05:17:33PM +0800, Tao YunXiang wrote: >> Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the >> UUID for inserted rows) solves ovsdb-client sp

Re: [ovs-dev] [PATCH v3] db-ctl-base: add uuid specified method for create cmd

2020-02-18 Thread 0-day Robot
Bleep bloop. Greetings Tao YunXiang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 198 characters long (recommended limit is 79) #97 FILE: lib/db-ctl-base.xml:29