[ovs-dev] netdev-dpdk: Fix to set attached flag if valid DPDK port was found

2020-04-06 Thread Somnath Kotur via dev
The 'attached' flag for a netdev_dpdk device is set only when it is attached via rte_dev_probe(). However, when the DPDK port probe was successfully done as part of vswitchd bring up (if the device was bound to igb_uio/vfio-pci prior to bring up), then this flag is not set. When netdev_dpdk_process

Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-04-06 Thread Vishal Deep Ajmera via dev
> > Hi Matteo, > > > > Thanks for the patch. But I fail to understand why there is a memory leak. > > In fact when I tested in my setup, the test ran without any leak. > > The main part is: > '_REFILL_' loop removes packets from the original batch and > dp_execute_output_action() > doesn't free the

[ovs-dev] [PATCH] dpif-netdev: includes microsecond delta in meter bucket calculation

2020-04-06 Thread 姜立东 via dev
>From 077ab5387ca2b1dbe64389ef2d2aa8f3956f7c57 Mon Sep 17 00:00:00 2001 From: Jiang Lidong Date: Tue, 7 Apr 2020 10:33:14 +0800 Subject: [PATCH] dpif-netdev: includes microsecond delta in meter bucket calculation When dp-netdev meter rate is higher than 200Mbps, observe more than 10% bias from c

Re: [ovs-dev] [PATCH 1/2] tun_metadata: Fix coredump caused by use-after-free bug

2020-04-06 Thread William Tu
On Mon, Apr 6, 2020 at 8:47 AM William Tu wrote: > > On Thu, Mar 26, 2020 at 12:58:21PM -0700, Yifeng Sun wrote: > > Tun_metadata can be referened by flow and frozen_state at the same > > time. When ovs-vswitchd handles TLV table mod message, the involved > > tun_metadata gets freed. The call trac

[ovs-dev] Alcance y las ventajas del plan

2020-04-06 Thread Tabulador de sueldos y compensaciones
Miércoles 24 de Abril | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) - Elaboración de un tabulador de sueldos y compensaciones. - Curso en Línea Al inscribirte en cualquiera de nuestros cursos obtén tres accesos o conexiones al precio de uno para un mismo un curso. ¿De qué hab

[ovs-dev] [PATCHv2] ovs-vswitchd: Fix icmp reply timeout description.

2020-04-06 Thread William Tu
Currently the userspace datapath implements conntrack ICMP reply state as when ICMP packets have been seen on both directions. However, the description is defined as timeout of the connection after an ICMP error is replied in response to an ICMP packet. Fixes: 61a5264d60d0c ("ovs-vswitchd: Add Da

Re: [ovs-dev] [PATCH] netdev-linux.c: Fix coverity unreachable code warning

2020-04-06 Thread William Tu
On Wed, Apr 1, 2020 at 3:33 PM wrote: > > From: Usman Ansari > > Coverity reports unreachable code in "?" statement > Fixed by removing code segment and unused variables & defines > > Signed-off-by: Usman Ansari > --- Applied to master, thanks ___ dev

[ovs-dev] [PATCH] ovs-vswitchd: Fix icmp reply timeout description.

2020-04-06 Thread William Tu
The timeout value of icmp_reply is defined as timeout of the connection after an ICMP error is replied in response to an ICMP packet. Currently this is not implemented. Fixes: 61a5264d60d0c ("ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.") Signed-off-by: William Tu --- vswitc

Re: [ovs-dev] [PATCH] netdev-linux.c: Fix coverity unreachable code warning

2020-04-06 Thread Usman S. Ansari
Reminding about this On Wed, Apr 1, 2020 at 3:33 PM wrote: > From: Usman Ansari > > Coverity reports unreachable code in "?" statement > Fixed by removing code segment and unused variables & defines > > Signed-off-by: Usman Ansari > --- > lib/netdev-linux.c | 12 +++- > 1 file changed

Re: [ovs-dev] [PATCH 2/2] system-traffic: Check frozen state handling with TLV map change

2020-04-06 Thread William Tu
On Mon, Apr 6, 2020 at 8:29 AM William Tu wrote: > > Hi Yifeng, > > Thanks for the patch, I can reproduce the issue using > $ make check-system-userspace TESTSUITEFLAGS='-k resume' > ASAN reports > ==127707==ERROR: AddressSanitizer: heap-use-after-free on address > 0x61f20690 at pc 0x0089c

Re: [ovs-dev] [PATCH 1/2] tun_metadata: Fix coredump caused by use-after-free bug

2020-04-06 Thread William Tu
On Thu, Mar 26, 2020 at 12:58:21PM -0700, Yifeng Sun wrote: > Tun_metadata can be referened by flow and frozen_state at the same > time. When ovs-vswitchd handles TLV table mod message, the involved > tun_metadata gets freed. The call trace to free tun_metadata is > shown as below: > > ofproto_run

Re: [ovs-dev] [PATCH 2/2] system-traffic: Check frozen state handling with TLV map change

2020-04-06 Thread William Tu
Hi Yifeng, Thanks for the patch, I can reproduce the issue using $ make check-system-userspace TESTSUITEFLAGS='-k resume' ASAN reports ==127707==ERROR: AddressSanitizer: heap-use-after-free on address 0x61f20690 at pc 0x0089cecf bp 0x7fff38f95690 sp 0x7fff38f95688 READ of size 4 at 0x61f00

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: do not unwildcard source address if not needed

2020-04-06 Thread William Tu
Hi Hepeng, Thanks for your reply. Can you re-send a separate v3 patch email? I can't apply your patch to master. Also some comment below On Thu, Mar 26, 2020 at 7:21 PM 贺鹏 wrote: > > Hi, I rebase the patch on the latest master branch. > > > From 07f10707699a39e3a6de68012dd6c0453120c543 Mon Sep

[ovs-dev] Open Positions

2020-04-06 Thread Curran, Able
This is Able Curran from Talent Logic. Can I help you with your hiring needs? I understand the status quo with COVID-19 is unprecedented and we are maneuvering uncharted territories. I trust that you, your staff and families are safe and healthy. Regards, Able Curran |Recruiting/Talent

Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-04-06 Thread Vishal Deep Ajmera via dev
Hi Matteo, Thanks for the patch. But I fail to understand why there is a memory leak. In fact when I tested in my setup, the test ran without any leak. The functions dp_execute_lb_output_action and dp_execute_output_action, both return 'false' if current batch is non-empty. case OVS_ACTION_AT

Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-04-06 Thread Ilya Maximets
On 4/6/20 3:03 PM, Vishal Deep Ajmera wrote: > Hi Matteo, > > Thanks for the patch. But I fail to understand why there is a memory leak. > In fact when I tested in my setup, the test ran without any leak. The main part is: '_REFILL_' loop removes packets from the original batch and dp_execute_o

[ovs-dev] PO 001077 - CS#000310

2020-04-06 Thread David Matthew via dev
Fyi Best Regards, David Matthew PT. Infotech Digital System Address : Ruko Harco Mangga Dua Blok E No. 10 | Jl. Arteri Mangga Dua | Jakarta Pusat Office : +6221 - 6220 3147 | Fax : +6221 - 601 9938 Mobile : +62 859-5944-1144 Email : da...@infotechdigital.co.id www.infotechdigital.

Re: [ovs-dev] [PATCH v4 1/2 ovn] NAT: Provide port range in input

2020-04-06 Thread Numan Siddique
On Fri, Apr 3, 2020 at 12:39 AM Ankur Sharma wrote: > > From: Ankur Sharma > > This patch enhances the NB OVSSCHEMA to > add an additional comuln in NAT table. > > external_port_range: Specifies the range of port numbers > to translate source port to. > > Changes also add cor

Re: [ovs-dev] [PATCH v9 ovn 0/2] Add IPv6 Prefix delegation (RFC3633)

2020-04-06 Thread Numan Siddique
On Wed, Apr 1, 2020 at 10:08 PM Lorenzo Bianconi wrote: > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > https://tools.ietf.org/html/rfc3633. > Add handle_dhcpv6_reply controller action to parse advertise/reply from > IPv6 delegation server. > Introduce logical flows in o

Re: [ovs-dev] cherry-pick commit 0c489cc54a6cac72daea2314cc6464f629356c50

2020-04-06 Thread Numan Siddique
On Wed, Apr 1, 2020 at 9:20 PM Lorenzo Bianconi wrote: > > Hi all, > > I guess it would be helpful to cherry-pick the following commit in ovn as well Thanks. The patch applied cleanly to the ovn repo and all the tests passed. I applied this patch to master. Thanks Numan > > Regards, > Lorenzo >