We can delete qos by specify ls and more parameters.
If CMS want to delete it exactly, it must specify detailed "match" field.
It's not an easy way, also maybe deleted by mistake.
This change adds a way to specify ls and uuid, which is optional.
You can still use the previous method to delete.
usa
Hi Numan,
I have add a test, and summit v6, please help to review it.
Thanks,
Yun
--
taoyunxi...@cmss.chinamobile.com
>On Thu, Mar 19, 2020 at 11:23 AM Tao YunXiang
> wrote:
>>
>> We can delete qos by specify ls and more parameters.
>> If CMS want to delete it exactly, it must specify
On Sat, May 9, 2020 at 12:57 PM Tao YunXiang <
taoyunxi...@cmss.chinamobile.com> wrote:
> We can delete qos by specify ls and more parameters.
> If CMS want to delete it exactly, it must specify detailed "match" field.
> It's not an easy way, also maybe deleted by mistake.
> This change adds a way
Bleep bloop. Greetings taoyunxi...@cmss.chinamobile.com, I am a robot and I
have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#89 FILE: utilities/ovn-nbct
It is a must to set the column of the "addresses" to "unknown".
It will add a priority 0 entry in "ls_in_l2_lkup" stage.
If not, the traffic can't go to physical network. I think
it is better to explain in this doc, so the player of OVN
can be easier to use VTEP gateway.
Author: Tao YunXiang
Sig
usage:
ovn-nbctl qos-del ls0 [UUID0]
Author: Tao YunXiang
Co-authored-by: Liu Chang
Co-authored-by: Rong Yin
Signed-off-by: Tao YunXiang
Signed-off-by: Liu Chang
Signed-off-by: Rong Yin
---
v6: ovn-nbctl.c: Add an optional way to delete QoS by uuid
v5: ovn-nbctl.c: Add an optional way to de
Yes, you are right. I have summited v7. Thanks for your review.
Thanks,
Yun
--
taoyunxi...@cmss.chinamobile.com
>On Sat, May 9, 2020 at 12:57 PM Tao YunXiang <
>taoyunxi...@cmss.chinamobile.com> wrote:
>
>> We can delete qos by specify ls and more parameters.
>> If CMS want to delete
Bleep bloop. Greetings taoyunxi...@cmss.chinamobile.com, I am a robot and I
have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#83 FILE: utilities/ovn-nbct
From: wenxu
When restart the vswitchd with flow-restore-wait. The Vswitch doesn't
connect to the controller util the flow-restore-wait finished.
Because when bridge_configure_remotes() calls bridge_get_controllers(),
it first checks if flow-restore-wait has been set, and if so,
it ignores any co
On Sat, May 09, 2020 at 08:46:56AM +0800, Tonghao Zhang wrote:
> On Sat, May 9, 2020 at 7:12 AM William Tu wrote:
> >
> > On Thu, Apr 30, 2020 at 07:00:38PM +0800, xiangxia.m@gmail.com wrote:
> > > From: Tonghao Zhang
> > >
> > > When setting the meter rate to 4+Gbps, there is an overflow, th
On Sat, May 09, 2020 at 09:54:10AM +0800, Tonghao Zhang wrote:
> On Sat, May 9, 2020 at 7:23 AM William Tu wrote:
> >
> > On Thu, Apr 30, 2020 at 07:00:37PM +0800, xiangxia.m@gmail.com wrote:
> > > From: Tonghao Zhang
> > >
> > > For now, the meter of the userspace datapath, don't include
> >
On Thu, Apr 30, 2020 at 07:00:36PM +0800, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> For now, ovs-vswitchd use the array of the dp_meter struct
> to store meter's data, and at most, there are only 65536
> (defined by MAX_METERS) meters that can be used. But in some
> case, for exam
Looks good to me, thanks.
Reviewed-by: Yifeng Sun
On Sat, May 2, 2020 at 10:29 AM William Tu wrote:
> An exmplae pattern shown below:
> void
> ovsrec_ct_zone_index_set_external_ids(const struct ovsrec_ct_zone...
> {
> // 1. alloc_fn: Storage is returned from allocation function xmalloc.
> //
Thanks William, this patch looks good to me.
Maybe code will be a little neater with the fixes below:
@@ -1017,6 +1017,9 @@ static void
free_data(enum ovsdb_atomic_type type,
union ovsdb_atom *atoms, size_t n_atoms)
{
+if (!atoms) {
+return;
+}
if (ovsdb_atom_need
Looks good to me, thanks.
Reviewed-by: Yifeng Sun
On Sat, May 2, 2020 at 10:29 AM William Tu wrote:
> Coverity shows the following memory leak in this code pattern:
>
> void
> ovsrec_ipfix_index_set_obs_domain_id(
> {
> struct ovsdb_datum datum;
> // 1. alloc_fn: Storage is returned from
On 2020-05-07 6:54 PM, Aaron Conole wrote:
> In some cases, when processing a netlink change event, it's possible for
> an alternate part of OvS (like the IPv6 endpoint processing) to hold an
> active netdev interface. This creates a race-condition, where sometimes
> the OvS change processing w
On 2020-05-07 6:54 PM, Aaron Conole wrote:
> It's possible that port ordering could cause the block ID to change
> after enabling / detecting TC Flower support. Therefore, fetch the
> block_id again after probing.
Maybe be more specific and add that block ID could change after probe
for block
17 matches
Mail list logo
