[ovs-dev] [[RFC] [PATCH]] ofproto-dpif.at: add testcase for nd_reserved and nd_options_type fields

2020-09-28 Thread fankaixi . li
From: fankaixi Add testcase for setting ipv6 nd "nd_reserved" and "nd_options_type" fields. Signed-off-by: fankaixi.li CC: Flavio Leitner Fixes: d0d571493cf8 ("ofproto-dpif: Allow IPv6 ND Extensions only if supported") --- tests/ofproto-dpif.at | 18 ++ 1 file changed, 18 inse

[ovs-dev] Re:❕[papiengu...@yahoo.com] (9)

2020-09-28 Thread papienguyen
⭐ Es ist schon ein paar Tage her. Geht es dir gut? https://teranihar1952.blogspot.com papiengu...@yahoo.com 9/28/2020 4:23:21 PM ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V3 03/24] datapath: do not update max_headroom if new headroom is equal to old headroom

2020-09-28 Thread Yi-Hung Wei
On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote: > > From: Taehee Yoo > > Upstream commit: > commit 6b660c4177aaebdc73df7a3378f0e8b110aa4b51 > Author: Taehee Yoo > Date: Sat Jul 6 01:08:09 2019 +0900 > > net: openvswitch: do not update max_headroom if new headroom is equal to

Re: [ovs-dev] [PATCH V3 01/24] datapath: return an error instead of doing BUG_ON()

2020-09-28 Thread Yi-Hung Wei
On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote: > > From: Eelco Chaudron > > Upstream commit: > commit a734d1f4c2fc962ef4daa179e216df84a8ec5f84 > Author: Eelco Chaudron > Date: Thu May 2 16:12:38 2019 -0400 > > net: openvswitch: return an error instead of doing BUG_ON() > >

Re: [ovs-dev] [PATCH V3 02/24] datapath: drop unneeded likely() call around IS_ERR()

2020-09-28 Thread Yi-Hung Wei
On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote: > > From: Enrico Weigelt > > Upstream commit: > commit b90f5aa4d6268e81dd1fd51e5ef89d2892bf040d > Author: Enrico Weigelt > Date: Wed Jun 5 23:06:40 2019 +0200 > > net: openvswitch: drop unneeded likely() call around IS_ERR() > >

Re: [ovs-dev] [PATCH V3 05/24] datapath: Set OvS recirc_id from tc chain index

2020-09-28 Thread Yi-Hung Wei
On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote: > > From: Paul Blakey > > Upstream commit: > commit 95a7233c452a58a4c2310c456c73997853b2ec46 > Author: Paul Blakey > Date: Wed Sep 4 16:56:37 2019 +0300 > > net: openvswitch: Set OvS recirc_id from tc chain index > > Offload

Re: [ovs-dev] [PATCH V3 04/24] datapath: Print error when ovs_execute_actions() fails

2020-09-28 Thread Yi-Hung Wei
On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote: > > From: Yifeng Sun > > Upstream commit: > commit aa733660dbd8d9192b8c528ae0f4b84f3fef74e4 > Author: Yifeng Sun > Date: Sun Aug 4 19:56:11 2019 -0700 > > openvswitch: Print error when ovs_execute_actions() fails > > Current

Re: [ovs-dev] [PATCH ovn v3 1/1] controller: Check for tunnel change in multi-vtep case is incorrect

2020-09-28 Thread venugopal iyer via dev
Thanks, Numan! -venu On Monday, September 28, 2020, 3:34:20 AM PDT, Numan Siddique wrote: On Fri, Sep 25, 2020 at 11:44 PM wrote: > > From: venu iyer > > Prior to multi-vtep, there was one tunnel for each type, since > there was only one encap-ip. So, the check in > chassis_tunnels_c

Re: [ovs-dev] [PATCH v1 1/1] dns-resolve: Allow unbound's config file to be set through an env var.

2020-09-28 Thread Yifeng Sun
Looks good to me, thanks. Reviewed-by: Yifeng Sun On Mon, Sep 28, 2020 at 11:54 AM Ted Elhourani wrote: > When an unbound context is created, check whether OVS_UNBOUND_CONF has been > set. If a valid config file is supplied then use it to configure the > context. The procedure returns if the

[ovs-dev] [PATCH v1 1/1] dns-resolve: Allow unbound's config file to be set through an env var.

2020-09-28 Thread Ted Elhourani
When an unbound context is created, check whether OVS_UNBOUND_CONF has been set. If a valid config file is supplied then use it to configure the context. The procedure returns if the config file is invalid. If no config file is found then the default unbound config is used. Signed-off-by: Ted Elho

[ovs-dev] [PATCH v1 0/1] dns-resolve: Allow unbound's config file to be set through an env var.

2020-09-28 Thread Ted Elhourani
It is often necessary to fine-tune parameters of the unbound DNS resolver. The TTL of entries in the DNS servers cache is one example. Unbound's config may be conveniently defined in the form of a configuration file. This patch provides the means for specifying the location of a configuration file

Re: [ovs-dev] [PATCH ovn] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-09-28 Thread Numan Siddique
On Mon, Sep 28, 2020 at 11:13 PM Han Zhou wrote: > > On Mon, Sep 28, 2020 at 10:03 AM Numan Siddique wrote: > > > > On Mon, Sep 28, 2020 at 9:41 PM Han Zhou wrote: > > > > > > On Mon, Sep 28, 2020 at 2:21 AM Numan Siddique wrote: > > > > > > > > On Mon, Sep 28, 2020 at 2:14 PM Numan Siddique w

Re: [ovs-dev] [PATCH v1 1/1] dns-resolve: Allow unbound's config file to be set through an env var.

2020-09-28 Thread Yifeng Sun
Hi Ted, There seems some indent issue with the next to last '}', can you take a look? Thanks, Yifeng On Tue, Sep 8, 2020 at 8:33 PM Ted Elhourani wrote: > When an unbound context is created, check whether OVS_UNBOUND_CONF has been > set. If a valid config file is supplied then use it to config

Re: [ovs-dev] [PATCH ovn] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-09-28 Thread Han Zhou
On Mon, Sep 28, 2020 at 10:03 AM Numan Siddique wrote: > > On Mon, Sep 28, 2020 at 9:41 PM Han Zhou wrote: > > > > On Mon, Sep 28, 2020 at 2:21 AM Numan Siddique wrote: > > > > > > On Mon, Sep 28, 2020 at 2:14 PM Numan Siddique wrote: > > > > > > > > On Mon, Sep 28, 2020 at 5:57 AM Han Zhou wr

Re: [ovs-dev] [PATCH ovn] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-09-28 Thread Numan Siddique
On Mon, Sep 28, 2020 at 9:41 PM Han Zhou wrote: > > On Mon, Sep 28, 2020 at 2:21 AM Numan Siddique wrote: > > > > On Mon, Sep 28, 2020 at 2:14 PM Numan Siddique wrote: > > > > > > On Mon, Sep 28, 2020 at 5:57 AM Han Zhou wrote: > > > > > > > > Thanks Numan. I have some comments on the solution.

Re: [ovs-dev] [PATCH ovn branch-20.09 2/3] branch 20.09: Set release date for 20.09.0

2020-09-28 Thread Numan Siddique
On Mon, Sep 28, 2020 at 9:15 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 2 +- > debian/changelog | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 542bdf99b..0f4252347 1006

Re: [ovs-dev] [PATCH ovn branch-20.09 3/3] branch 20.09: Prepare for 20.09.1

2020-09-28 Thread Numan Siddique
On Mon, Sep 28, 2020 at 9:15 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn] Set release date for 20.09.0.

2020-09-28 Thread Numan Siddique
On Mon, Sep 28, 2020 at 9:15 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 2 +- > debian/changelog | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/NEWS b/NEWS > index ee5c2c393..eaacf7340 10

Re: [ovs-dev] [PATCH ovn] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-09-28 Thread Han Zhou
On Mon, Sep 28, 2020 at 2:21 AM Numan Siddique wrote: > > On Mon, Sep 28, 2020 at 2:14 PM Numan Siddique wrote: > > > > On Mon, Sep 28, 2020 at 5:57 AM Han Zhou wrote: > > > > > > Thanks Numan. I have some comments on the solution. > > > > > > On Thu, Sep 24, 2020 at 9:50 AM wrote: > > > > > >

Re: [ovs-dev] [PATCH ovn] Set release date for 20.09.0.

2020-09-28 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

[ovs-dev] [PATCH ovn branch-20.09 3/3] branch 20.09: Prepare for 20.09.1

2020-09-28 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 0f4252347..696807fac 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v20.09.1 - xx xxx +---

[ovs-dev] [PATCH ovn branch-20.09 2/3] branch 20.09: Set release date for 20.09.0

2020-09-28 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 542bdf99b..0f4252347 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -OVN v20.09.0 - xx xxx +OVN v20.09.0 - 28 Sep 2020 -

[ovs-dev] [PATCH ovn] Set release date for 20.09.0.

2020-09-28 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index ee5c2c393..eaacf7340 100644 --- a/NEWS +++ b/NEWS @@ -2,7 +2,7 @@ Post-v20.09.0 - -OVN v20.09.0 - xx xxx

Re: [ovs-dev] [PATCH] ofproto-dpif: remove checking setting nd_ext field

2020-09-28 Thread Aaron Conole
fankaixi...@bytedance.com writes: > From: "fankaixi.li" > > In order to support openflow rule which setting nd_ext fields in openflow > tables, > we should remove setting nd_ext fields when constructing rule. The ofproto > would > translate it into userspace actions when handling upcalls. > > W

Re: [ovs-dev] [PATCH] compat: Replace the HAVE_L4_RXHASH define with HAVE_L4_HASH

2020-09-28 Thread Gregory Rose
On 9/24/2020 6:05 AM, Flavio Leitner wrote: On Tue, Sep 22, 2020 at 12:45:03PM +0200, Ilya Maximets wrote: On 9/17/20 9:59 PM, Greg Rose wrote: The skb now uses l4_hash and it is easier to check for it. Also fixes a compile error for RHEL 7.7. Signed-off-by: Greg Rose --- acinclude.m4

Re: [ovs-dev] [PATCH 3/3] vxlan: Make vxlan tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-28 Thread Gregory Rose
On 9/23/2020 6:32 AM, Ilya Maximets wrote: On 9/17/20 7:14 PM, Greg Rose wrote: From: wenxu There is currently no support for the multicast/broadcast aspects of VXLAN in ovs. In the datapath flow the tun_dst must specific. But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specifi

[ovs-dev] [PATCH] ofproto-dpif: remove checking setting nd_ext field

2020-09-28 Thread fankaixi . li
From: "fankaixi.li" In order to support openflow rule which setting nd_ext fields in openflow tables, we should remove setting nd_ext fields when constructing rule. The ofproto would translate it into userspace actions when handling upcalls. When trying to add the following flows to ovs with ke

[ovs-dev] From Miss Nidal Aoussa.

2020-09-28 Thread Miss Nidal Aoussa via dev
Hello Dear, I am very sorry that my letter may come as a surprise to you since we have never met each other before. I am Miss Nidal Aoussa. I am the only daughter of Cheikh Ag Aoussa, the President of (HCUA) in Mali who was assasinated on the octobre 2016. https://www.jeuneafrique.com/36543

[ovs-dev] Querido Amado.

2020-09-28 Thread Ms Nessa .k.roland
-- *Querido Amado.* *Soy Nessa Douglas, unos 21 años en poder en la guerra País Côte d 'Ivoire (Costa de Marfil) Estoy en contacto con usted porque necesito tu ayuda urgente para asegurar el dinero que mi difunto padre me dejó antes de morir. Este dinero es de USD 6,7 millones y el dinero se depo

Re: [ovs-dev] [PATCH ovn v3 1/1] controller: Check for tunnel change in multi-vtep case is incorrect

2020-09-28 Thread Numan Siddique
On Fri, Sep 25, 2020 at 11:44 PM wrote: > > From: venu iyer > > Prior to multi-vtep, there was one tunnel for each type, since > there was only one encap-ip. So, the check in > chassis_tunnels_changed(): > > sset_count(encap_type_set) != encap_type_count > > worked. However, with multiple IPs

[ovs-dev] [PATCH v4 ovn 1/2] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-28 Thread Dumitru Ceara
Avoid reparsing the *_force_snat_ip addresses. Acked-by: Han Zhou Signed-off-by: Dumitru Ceara --- lib/ovn-util.c |6 lib/ovn-util.h |2 + northd/ovn-northd.c | 69 --- tests/ovn-northd.at | 19 ++ 4 files ch

[ovs-dev] [PATCH v4 ovn 2/2] ovn-northd: Refactor processing of SNAT IPs.

2020-09-28 Thread Dumitru Ceara
Instead of building string sets every time we need to generate logical flows for unique SNAT IPs we now prebuild the set of unique SNAT IPs and store the list of NAT entries that refer it. Acked-by: Han Zhou Signed-off-by: Dumitru Ceara --- northd/ovn-northd.c | 322 +++

[ovs-dev] [PATCH v4 ovn 0/2] Drop packets destined to own IPs and refactor SNAT processing.

2020-09-28 Thread Dumitru Ceara
The series refactors logical flow processing for SNAT trying to make it a bit more efficient while reducing code duplication. CC: Numan Siddique CC: Han Zhou Signed-off-by: Dumitru Ceara Dumitru Ceara (2): ovn-northd: Refactor parsing of *_force_snat_ip. ovn-northd: Refactor proces

Re: [ovs-dev] [PATCH v3] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-28 Thread 0-day Robot
Bleep bloop. Greetings Tonghao Zhang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 175 characters long (recommended limit is 79) #96 FILE: lib/dpctl.man:107: .D

Re: [ovs-dev] [PATCH 1/3] dpif-netlink: Generate ufids for installing TC flowers

2020-09-28 Thread Eelco Chaudron
On 14 Sep 2020, at 14:23, Eelco Chaudron wrote: On 14 Sep 2020, at 7:54, Tonghao Zhang wrote: On Fri, Sep 11, 2020 at 5:46 PM Eelco Chaudron wrote: Hi Tonghao, at al. This patch is breaking basic flow adding/deletion with ovs-dpctl. I did not look at the root cause yet, maybe you can t

Re: [ovs-dev] [PATCH] dpctl: add add-flows command to dpctl

2020-09-28 Thread Eelco Chaudron
On 22 Sep 2020, at 15:21, Aaron Conole wrote: Eelco Chaudron writes: When you would like to add, modify, or delete a lot of flows in the datapath, for example when you want to measure performance, adding one flow at the time won't scale. This as it takes a decent amount of time to set up t

Re: [ovs-dev] [PATCH ovn] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-09-28 Thread Numan Siddique
On Mon, Sep 28, 2020 at 2:14 PM Numan Siddique wrote: > > On Mon, Sep 28, 2020 at 5:57 AM Han Zhou wrote: > > > > Thanks Numan. I have some comments on the solution. > > > > On Thu, Sep 24, 2020 at 9:50 AM wrote: > > > > > > From: Numan Siddique > > > > > > ovn-northd adds below lflows for a re

[ovs-dev] [PATCH v3] dpctl-netdev: Add the option "pmd" for dump-flows

2020-09-28 Thread xiangxia . m . yue
From: Tonghao Zhang "ovs-appctl dpctl/dump-flows" added the option "pmd" which allow user to dump pmd specified. That option is useful to dump rules from pmd when we have a large number of rules in dp. Signed-off-by: Tonghao Zhang --- v3: * remove unnecessary check * as filter to reduce the si

Re: [ovs-dev] [PATCH ovn] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-09-28 Thread Numan Siddique
On Mon, Sep 28, 2020 at 5:57 AM Han Zhou wrote: > > Thanks Numan. I have some comments on the solution. > > On Thu, Sep 24, 2020 at 9:50 AM wrote: > > > > From: Numan Siddique > > > > ovn-northd adds below lflows for a reject ACL with a match - M > > > > match = (ip4 && tcp && 'M') action = tcp_

Re: [ovs-dev] [PATCH v3 ovn 1/4] ovn-northd: Drop IP packets destined to router owned IPs (after NAT).

2020-09-28 Thread Dumitru Ceara
On 9/22/20 8:17 AM, Numan Siddique wrote: > > > On Mon, Sep 21, 2020 at 12:08 PM Han Zhou > wrote: > > On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara > wrote: > > > > OVN was dropping IP packets destined to IPs owned by logical >

Re: [ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-28 Thread Dumitru Ceara
On 9/21/20 9:01 AM, Han Zhou wrote: > > > On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara > wrote: >> >> Avoid reparsing the *_force_snat_ip addresses for every logical router > port. >> These addresses are defined once for the whole router. >> > > The commit message is

Re: [ovs-dev] [PATCH v3 ovn 3/4] ovn-northd: Refactor parsing of *_force_snat_ip.

2020-09-28 Thread Dumitru Ceara
On 9/22/20 8:11 AM, Numan Siddique wrote: > > > On Mon, Sep 21, 2020 at 12:32 PM Han Zhou > wrote: > > On Thu, Sep 17, 2020 at 5:51 AM Dumitru Ceara > wrote: > > > > Avoid reparsing the *_force_snat_ip addresses for every logical