Re: [ovs-dev] [PATCH 1/7] ovsdb: Add support for transaction forwarding to the replication mode.

2021-04-30 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #707 FILE: ovsdb/replication.c:1029:

[ovs-dev] [PATCH 7/7] python: idl: Allow retry even when using a single remote.

2021-04-30 Thread Ilya Maximets
As described in commit [1], it's possible that remote IP is backed by a load-balancer and re-connection to this same IP will lead to connection to a different server. This case is supported for C version of IDL and should be supported in a same way for python implementation. [1] ca367fa5f8bb

[ovs-dev] [PATCH 6/7] ovsdb: Report connection state for replication server.

2021-04-30 Thread Ilya Maximets
Clients may want to know if current replica actually has an active connection with the replication source. For example, if one of the replicas lost connection, clients may want to re-connect to another replica in order to receive all the up-to-date database content. Signed-off-by: Ilya Maximets

[ovs-dev] [PATCH 3/7] replication: Allow replication of _Server database.

2021-04-30 Thread Ilya Maximets
If replication server is connected to a cluster member, clients would like to know the state of the cluster from that server. This will allow them to make a decision about re-connection. Marking 'Database' table with a 'copyForReplication' flag to have a new '_synced_Database' table where records

[ovs-dev] [PATCH 5/7] python: idl: Monitor _synced_Database table.

2021-04-30 Thread Ilya Maximets
The same change as for ovsdb-cs module. Monitoring data from '_synced_Database' table to check the state of clustered databases from which this replica receives updates. Not allowing 'leader-only' connection to the replication server as this type of connections typically used for database

[ovs-dev] [PATCH 4/7] ovsdb-cs: Monitor _synced_Database table.

2021-04-30 Thread Ilya Maximets
Monitoring data from '_synced_Database' table to check the state of clustered databases from which this replica receives updates. Not allowing 'leader-only' connection to the replication server as this type of connections typically used for database locking. Otherwise making decision about

[ovs-dev] [PATCH 2/7] ovsdb: Add extra internal tables to databases for replication purposes.

2021-04-30 Thread Ilya Maximets
New flag for ovsdb table schema 'copyForReplication'. It's needed to enable replication of a _Server database in later commits. With this option ovsdb-server will create a new _synced_ table where it will store data received from the replication source while keeping the original table for data

[ovs-dev] [PATCH 1/7] ovsdb: Add support for transaction forwarding to the replication mode.

2021-04-30 Thread Ilya Maximets
Current version of ovsdb replication allows to scale out read-only access to the primary database. However, many clients are not read-only but read-mostly. For example, ovn-controller. In order to scale out database access for this case ovsdb-server need to process transactions that are not

[ovs-dev] [PATCH 0/7] OVSDB 2-Tier deployment.

2021-04-30 Thread Ilya Maximets
Replication can be used to scale out read-only access to the database. But there are clients that are not read-only, but read-mostly. One of the main examples is ovn-controller that mostly monitors updates from the Southbound DB, but needs to claim ports by sending transactions that changes some

Re: [ovs-dev] [PATCH ovn v6 0/5] ARP and Floating IP Fixes

2021-04-30 Thread Mark Michelson
On 4/27/21 3:40 PM, Numan Siddique wrote: On Fri, Apr 23, 2021 at 3:17 PM Mark Michelson wrote: This patch series aims to fix issues seen in OpenStack deployments when floating IPs were assigned to routers, and those floating IPs were not part of any subnet configured on that router.

Re: [ovs-dev] [PATCH v3 14/28] seq-pool: Module for faster ID generation

2021-04-30 Thread Ilya Maximets
On 4/25/21 1:55 PM, Gaetan Rivet wrote: > The current id-pool module is slow to allocate the > next valid ID, and can be optimized when restricting > some properties of the pool. > > Those restrictions are: > > * No ability to add a random ID to the pool. > > * A new ID is no more the

[ovs-dev] [PATCH v2] conntrack: add coverage counters for L3 bad checksum

2021-04-30 Thread Paolo Valerio
similarly to what already exists for L4, add conntrack_l3csum_err and ipf_l3csum_err for L3. Received packets with L3 bad checksum will increase respectively ipf_l3csum_err if they are fragments and conntrack_l3csum_err otherwise. Although the patch basically covers IPv4, the names are kept

Re: [ovs-dev] [RFC ovn 0/5] respin CoPP series

2021-04-30 Thread Mark Gray
On 30/04/2021 09:23, Dumitru Ceara wrote: > On 4/29/21 6:31 PM, Mark Gray wrote: >> On 28/04/2021 10:44, Dumitru Ceara wrote: >>> On 4/28/21 10:21 AM, Mark Gray wrote: On 24/04/2021 11:39, Lorenzo Bianconi wrote: > This series respin CoPP support introduced here [0] by Dumitru rebasing

Re: [ovs-dev] [RFC 0/3] dpif-netlink: Introduce per-cpu upcall dispatching

2021-04-30 Thread Mark Gray
On 30/04/2021 16:31, Mark Gray wrote: > This series proposes a new method of distributing upcalls > to user space threads attempting to resolve a number of > issues with the current method. > > Mark Gray (3): > ofproto: change type of n_handlers and n_revalidators > dpif-netlink: fix

Re: [ovs-dev] [PATCH v10] dpif-netlink: distribute polling to discreet handlers

2021-04-30 Thread Mark Gray
On 29/10/2020 21:15, Flavio Leitner wrote: > On Wed, Oct 28, 2020 at 02:17:06PM -0400, Mark Gray wrote: >> From: Aaron Conole >> >> Currently, the channel handlers are polled globally. On some >> systems, this causes a thundering herd issue where multiple >> handler threads become active, only

Re: [ovs-dev] [RFC 0/3] dpif-netlink: Introduce per-cpu upcall dispatching

2021-04-30 Thread Mark Gray
On 30/04/2021 16:31, Mark Gray wrote: > This series proposes a new method of distributing upcalls > to user space threads attempting to resolve a number of > issues with the current method. > > Mark Gray (3): > ofproto: change type of n_handlers and n_revalidators > dpif-netlink: fix

[ovs-dev] [RFC net-next] openvswitch: Introduce per-cpu upcall dispatch

2021-04-30 Thread Mark Gray
The Open vSwitch kernel module uses the upcall mechanism to send packets from kernel space to user space when it misses in the kernel space flow table. The upcall sends packets via a Netlink socket. Currently, a Netlink socket is created for every vport. In this way, there is a 1:1 mapping between

[ovs-dev] [RFC 3/3] dpif-netlink: Introduce per-cpu upcall dispatch

2021-04-30 Thread Mark Gray
The Open vSwitch kernel module uses the upcall mechanism to send packets from kernel space to user space when it misses in the kernel space flow table. The upcall sends packets via a Netlink socket. Currently, a Netlink socket is created for every vport. In this way, there is a 1:1 mapping between

[ovs-dev] [RFC 2/3] dpif-netlink: fix report_loss() message

2021-04-30 Thread Mark Gray
Signed-off-by: Mark Gray --- lib/dpif-netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 50520f8c0687..2ded5fdd01b3 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -4662,7 +4662,7 @@ report_loss(struct

[ovs-dev] [RFC 1/3] ofproto: change type of n_handlers and n_revalidators

2021-04-30 Thread Mark Gray
'n_handlers' and 'n_revalidators' are declared as type 'size_t'. However, dpif_handlers_set() requires parameter 'n_handlers' as type 'uint32_t'. This patch fixes this type mismatch. Signed-off-by: Mark Gray --- ofproto/ofproto-dpif-upcall.c | 24

[ovs-dev] [RFC 0/3] dpif-netlink: Introduce per-cpu upcall dispatching

2021-04-30 Thread Mark Gray
This series proposes a new method of distributing upcalls to user space threads attempting to resolve a number of issues with the current method. Mark Gray (3): ofproto: change type of n_handlers and n_revalidators dpif-netlink: fix report_loss() message dpif-netlink: Introduce per-cpu

Re: [ovs-dev] [PATCH v3 12/28] mpsc-queue: Module for lock-free message passing

2021-04-30 Thread Ilya Maximets
On 4/25/21 1:55 PM, Gaetan Rivet wrote: > Add a lockless multi-producer/single-consumer (MPSC), linked-list based, > intrusive, unbounded queue that does not require deferred memory > management. > > The queue is an implementation of the structure described by Dmitri > Vyukov[1]. It adds a

Re: [ovs-dev] [PATCH ovn v6 0/5] ARP and Floating IP Fixes

2021-04-30 Thread Mark Michelson
On 4/27/21 3:40 PM, Numan Siddique wrote: On Fri, Apr 23, 2021 at 3:17 PM Mark Michelson wrote: This patch series aims to fix issues seen in OpenStack deployments when floating IPs were assigned to routers, and those floating IPs were not part of any subnet configured on that router.

Re: [ovs-dev] [PATCH 2/2] dpdk: Add debug appctl to get malloc statistics.

2021-04-30 Thread Eelco Chaudron
On 25 Apr 2021, at 18:28, Eli Britstein wrote: New appctl 'dpdk/get-malloc-stats' implemented to get result of 'rte_malloc_dump_stats()' function. rte_malloc_dump_stats() calls malloc_heap_get_stats(), so I would call this command dpdk/get-heap-stats to also avoid collision with the other

[ovs-dev] [PATCH ovn v7] ovn-controller: Split logical flow and phsyical flow processing.

2021-04-30 Thread numans
From: Numan Siddique Presently, the 'flow_output' engine node recomputes physical flows by calling physical_run() in the 'physical_flow_changes' handler in some scenarios. Because of this, an engine run can do a full recompute of physical flows but not full recompute of logical flows. Although

Re: [ovs-dev] [PATCH 1/2] dpdk: Add debug appctl to get socket statistics.

2021-04-30 Thread Eelco Chaudron
On 30 Apr 2021, at 14:51, Eelco Chaudron wrote: On 25 Apr 2021, at 18:28, Eli Britstein wrote: New appctl 'dpdk/get-socket-stats' implemented to get result of 'rte_malloc_get_socket_stats()' function for socket passed as an argument. If no arguments passed, get the results for all available

Re: [ovs-dev] [PATCH 1/2] dpdk: Add debug appctl to get socket statistics.

2021-04-30 Thread Eelco Chaudron
On 25 Apr 2021, at 18:28, Eli Britstein wrote: New appctl 'dpdk/get-socket-stats' implemented to get result of 'rte_malloc_get_socket_stats()' function for socket passed as an argument. If no arguments passed, get the results for all available sockets. The information is malloc() stats per

Re: [ovs-dev] [PATCH] dpif-netdev: Remove meter rate from the bucket size calculation.

2021-04-30 Thread Eelco Chaudron
On 21 Apr 2021, at 15:48, Ilya Maximets wrote: > Implementation of meters supposed to be a classic token bucket with 2 > typical parameters: rate and burst size. > > Burst size in this schema is the maximum number of bytes/packets that > could pass without being rate limited. > > Recent

Re: [ovs-dev] [PATCH ovn] github: Fix permissions for system test artifacts.

2021-04-30 Thread Numan Siddique
On Fri, Apr 30, 2021 at 3:26 AM Dumitru Ceara wrote: > > On 4/29/21 7:45 PM, Han Zhou wrote: > > On Thu, Apr 29, 2021 at 5:11 AM Ilya Maximets wrote: > >> > >> System test logs are not saved due to insufficient access rights: > >> > >> cp: cannot open

Re: [ovs-dev] [PATCH] conntrack: add coverage counters for L3 bad checksum

2021-04-30 Thread Paolo Valerio
"Eelco Chaudron" writes: > On 30 Apr 2021, at 9:25, Eelco Chaudron wrote: > >> On 29 Apr 2021, at 21:40, Paolo Valerio wrote: >> >>> similarly to what we already have for L4, add conntrack_l3csum_err >>> for the received packets with L3 bad checksum. >>> >>> Although, it basically covers IPv4,

Re: [ovs-dev] [RFC ovn 0/5] respin CoPP series

2021-04-30 Thread Dumitru Ceara
On 4/29/21 6:31 PM, Mark Gray wrote: > On 28/04/2021 10:44, Dumitru Ceara wrote: >> On 4/28/21 10:21 AM, Mark Gray wrote: >>> On 24/04/2021 11:39, Lorenzo Bianconi wrote: This series respin CoPP support introduced here [0] by Dumitru rebasing on top of ovn master branch and adding

Re: [ovs-dev] [PATCH] conntrack: add coverage counters for L3 bad checksum

2021-04-30 Thread Eelco Chaudron
On 30 Apr 2021, at 9:25, Eelco Chaudron wrote: On 29 Apr 2021, at 21:40, Paolo Valerio wrote: similarly to what we already have for L4, add conntrack_l3csum_err for the received packets with L3 bad checksum. Although, it basically covers IPv4, let's keep the name generic. Signed-off-by:

Re: [ovs-dev] [PATCH ovn] github: Fix permissions for system test artifacts.

2021-04-30 Thread Dumitru Ceara
On 4/29/21 7:45 PM, Han Zhou wrote: > On Thu, Apr 29, 2021 at 5:11 AM Ilya Maximets wrote: >> >> System test logs are not saved due to insufficient access rights: >> >> cp: cannot open './tests/system-kmod-testsuite.dir/001/ovs-vswitchd.log' >> for reading: Permission denied >> cp:

Re: [ovs-dev] [PATCH] conntrack: add coverage counters for L3 bad checksum

2021-04-30 Thread Eelco Chaudron
On 29 Apr 2021, at 21:40, Paolo Valerio wrote: similarly to what we already have for L4, add conntrack_l3csum_err for the received packets with L3 bad checksum. Although, it basically covers IPv4, let's keep the name generic. Signed-off-by: Paolo Valerio --- lib/conntrack.c |3 +++ 1