Re: [ovs-dev] [PATCH ovn v3 2/7] northd-ddlog: Handle Port_Binding:plugged_by.

2021-08-25 Thread Han Zhou
On Thu, Aug 19, 2021 at 4:09 AM Frode Nordahl wrote: > > This patch brings northd-ddlog up to speed with the same feature > added to the C version of northd. > Maybe not something critical, but we usually request the ddlog changes being added in the same patch with the northd.c change - which

Re: [ovs-dev] [PATCH ovn v3 1/7] ovn-sb: Add plugged_by column to Port_Binding.

2021-08-25 Thread Han Zhou
On Thu, Aug 19, 2021 at 4:09 AM Frode Nordahl wrote: > > To allow for use of optional plugging support we add a new > plugged_by column with weakRef to the Chassis table. The > ovn-controller can monitor this column and only process events > for its chassis UUID. > > ovn-northd will fill this

Re: [ovs-dev] [PATCH] jsonrpc: Turn sorting of json objects off in messages

2021-08-25 Thread Anton Ivanov
On 25/08/2021 22:12, Ilya Maximets wrote: On 8/25/21 5:17 PM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov A JSON object sort order is by definition arbitrary. OVS parser(s) do not care about object order - the result is loaded into a SHASH losing any order on the wire. Having

Re: [ovs-dev] [PATCH] json: Optimize string serialization.

2021-08-25 Thread Numan Siddique
On Tue, Aug 24, 2021 at 5:07 PM Ilya Maximets wrote: > > Current string serialization code puts all characters one by one. > This is slow because dynamic string needs to perform length checks > on every ds_put_char() and it's also doesn't allow compiler to use > better memory copy operations,

[ovs-dev] [PATCH v5 2/2] ovsdb-idl: Exclude missing tables and columns in the transaction.

2021-08-25 Thread numans
From: Numan Siddique In the cases where the C idl client is compiled with a newer schema and the ovsdb-server is running with older schema, the IDL clients can included tables or columns in the transaction which are missing in the server schema. ovsdb-server will reject the transaction, but the

[ovs-dev] [PATCH v5 1/2] ovsdb-idl : Add APIs to query if a table and a column is present or not.

2021-08-25 Thread numans
From: Numan Siddique This patch adds 2 new APIs in the ovsdb-idl client library - ovsdb_idl_has_table() and ovsdb_idl_has_column_in_table() to query if a table and a column is present in the IDL or not. This is required for scenarios where the server schema is old and missing a table or column

[ovs-dev] [PATCH v5 0/2] ovsdb-idl: Address missing table and column issues.

2021-08-25 Thread numans
From: Numan Siddique This patch series addresses the transaction issues seen when the C IDL client is running compiled with newer schema and ovsdb-server is still running with older schema. Patch 1: Adds the API to query for table and column names. Patch 2: Addresses the transaction issues. v4

Re: [ovs-dev] [PATCH v4 1/2] ovsdb-idl : Add APIs to query if a table and a column is present or not.

2021-08-25 Thread Numan Siddique
' On Wed, Aug 25, 2021 at 6:06 PM Ilya Maximets wrote: > > On 8/25/21 5:12 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch adds 2 new APIs in the ovsdb-idl client library > > - ovsdb_idl_has_table() and ovsdb_idl_has_column_in_table() to > > query if a table and a column

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-08-25 Thread Gregory Rose
On 8/25/2021 11:42 AM, Yifeng Sun wrote: LGTM, thanks Greg. Reviewed-by: Yifeng Sun Thanks Yifeng! - Greg On Mon, Aug 23, 2021 at 9:33 AM Greg Rose wrote: RHEL 8.4 is the first of the RHEL 8.x kernels that has broken ABI so it requires the same sort of fix as we did for several

Re: [ovs-dev] [PATCH v4 1/2] ovsdb-idl : Add APIs to query if a table and a column is present or not.

2021-08-25 Thread Ilya Maximets
On 8/25/21 5:12 AM, num...@ovn.org wrote: > From: Numan Siddique > > This patch adds 2 new APIs in the ovsdb-idl client library > - ovsdb_idl_has_table() and ovsdb_idl_has_column_in_table() to > query if a table and a column is present in the IDL or not. This > is required for scenarios where

Re: [ovs-dev] how ovn supports vlan

2021-08-25 Thread Numan Siddique
On Wed, Aug 25, 2021 at 11:20 AM longguang.yue wrote: > > Hi,all > is there a document to detail how vlan is supported and basic theory? or if > you please tell me, and patches. In order for you to use vlan networks, you need to create a localnet port for the logical switch. Lets say you have

Re: [ovs-dev] [PATCH] jsonrpc: Turn sorting of json objects off in messages

2021-08-25 Thread Ilya Maximets
On 8/25/21 5:17 PM, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > A JSON object sort order is by definition arbitrary. OVS > parser(s) do not care about object order - the result is > loaded into a SHASH losing any order on the wire. > > Having the objects sorted is a

Re: [ovs-dev] [PATCH v2 ovn 1/2] northd: refactor unreachable IPs lb flows

2021-08-25 Thread Mark Michelson
Hi Lorenzo, I discovered some bugs I missed in my first pass-through. Sorry for missing them the first time around. See below. On 8/25/21 7:58 AM, Lorenzo Bianconi wrote: Refactor unreachable IPs for vip load-balancers inverting the logic used during the lb flow creation in order to visit lb

Re: [ovs-dev] [PATCH ovn] controller: add datapath meter capability check

2021-08-25 Thread Lorenzo Bianconi
> On 18/08/2021 09:32, Lorenzo Bianconi wrote: > > Dump datapath meter capabilities before configuring meters in > > ovn-controller > > > > Signed-off-by: Lorenzo Bianconi > > --- > > controller/lflow.c | 10 +- > > controller/lflow.h | 3 +++ > > controller/pinctrl.c | 10

Re: [ovs-dev] [PATCH ovn v1] Add a northbound interface to program MAC_Binding table

2021-08-25 Thread 0-day Robot
References: <20210825185229.195890-1-svc.eng.git-m...@nutanix.com> Bleep bloop. Greetings svc.eng.git-mail, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 89

[ovs-dev] [PATCH ovn v1] Add a northbound interface to program MAC_Binding table

2021-08-25 Thread svc . eng . git-mail
From: Karthik Chandrashekar Add a new NB MAC_Binding table. This allows programming of static mac_bindings for a logical_router. OVN northd is responsible for propagating these static entries to the existing SB MAC_Binding table. Signed-off-by: Karthik Chandrashekar --- lib/automake.mk

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-08-25 Thread Yifeng Sun
LGTM, thanks Greg. Reviewed-by: Yifeng Sun On Mon, Aug 23, 2021 at 9:33 AM Greg Rose wrote: > RHEL 8.4 is the first of the RHEL 8.x kernels that has broken ABI so > it requires the same sort of fix as we did for several RHEL 7.x kernel > that needed two kernel rpms to work for all minor

[ovs-dev] [PATCH v2] pmd.at: Add test-cases for set and get commands for DPCLS and DPIF

2021-08-25 Thread Kumar Amber
Added 2 separate test-cases for DPCLS and DPIF commands: 1018: PMD - DPCLS Configuration 1017: PMD - DPIF Configuration Signed-off-by: Kumar Amber --- v2: - Moved the test-cases to pmd.at from dpdk suit. - Removed avx512 specific set commands as per discussion. --- tests/pmd.at | 36

Re: [ovs-dev] [PATCH ovn v2] northd: Add VIP port to established flows in DNAT table for Load Balancers

2021-08-25 Thread Mark Gray
On 24/08/2021 16:58, Numan Siddique wrote: > On Tue, Aug 24, 2021 at 11:21 AM Mark Gray wrote: >> >> On 24/08/2021 16:15, Mark Michelson wrote: >>> Excellent, thanks for the updated patch! >>> >>> Acked-by: Mark Michelson >> >> Thanks, and thanks for the review! > > Thanks. I applied this

Re: [ovs-dev] [PATCH v1] system-dpdk: Add test-cases for set and get commands for DPCLS and DPIF

2021-08-25 Thread Amber, Kumar
Hi Ilya, Thanks for the Reviews . Replies are Inline. > -Original Message- > From: Ilya Maximets > Sent: Wednesday, August 25, 2021 8:02 PM > To: Amber, Kumar ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH v1] system-dpdk: Add test-cases for set and

Re: [ovs-dev] [PATCH v9] ovsdb: provide raft and command interfaces with priority

2021-08-25 Thread Ilya Maximets
On 8/25/21 3:37 PM, Anton Ivanov wrote: > > On 25/08/2021 13:08, Ilya Maximets wrote: >> On 8/20/21 11:16 AM, anton.iva...@cambridgegreys.com wrote: >>> From: Anton Ivanov >>> >>> Set a soft time limit of "raft election timer"/2 on ovsdb >>> processing. >>> >>> This improves behaviour in large

[ovs-dev] how ovn supports vlan

2021-08-25 Thread longguang.yue
Hi,all is there a document to detail how vlan is supported and basic theory? or if you please tell me, and patches. thanks very much. -- 发自我的网易邮箱手机智能版 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] jsonrpc: Turn sorting of json objects off in messages

2021-08-25 Thread anton . ivanov
From: Anton Ivanov A JSON object sort order is by definition arbitrary. OVS parser(s) do not care about object order - the result is loaded into a SHASH losing any order on the wire. Having the objects sorted is a performance penalty, especially for large objects like f.e. lflow state. That is

Re: [ovs-dev] [PATCH v1] system-dpdk: Add test-cases for set and get commands for DPCLS and DPIF

2021-08-25 Thread Ilya Maximets
On 8/23/21 10:55 AM, Kumar Amber wrote: > Added 2 separate test-cases for DPCLS and DPIF commands: > > OVS-DPDK unit-tests: > > 9: OVS-DPDK - DPIF Configuration > 10: OVS-DPDK - DPCLS Configuration > > Also updated the validation docs for the same. Hi. Thanks for working on these tests!

Re: [ovs-dev] [OVN Patch 2/2] northd: Alter initial hash sizing for dp_groups+parallel

2021-08-25 Thread Anton Ivanov
On 25/08/2021 08:35, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov When running with dp_groups and parallelization enabled we have a possible worse case scenario where northd connects for the first time to a pre-populated database. If we do not size the hash to a sufficiently

Re: [ovs-dev] [PATCH v9] ovsdb: provide raft and command interfaces with priority

2021-08-25 Thread Anton Ivanov
On 25/08/2021 13:08, Ilya Maximets wrote: On 8/20/21 11:16 AM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Set a soft time limit of "raft election timer"/2 on ovsdb processing. This improves behaviour in large heavily loaded clusters. While it cannot fully eliminate spurious

Re: [ovs-dev] [PATCH v9] ovsdb: provide raft and command interfaces with priority

2021-08-25 Thread Ilya Maximets
On 8/20/21 11:16 AM, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > Set a soft time limit of "raft election timer"/2 on ovsdb > processing. > > This improves behaviour in large heavily loaded clusters. > While it cannot fully eliminate spurious raft elections > under heavy

[ovs-dev] [PATCH v2 ovn 1/2] northd: refactor unreachable IPs lb flows

2021-08-25 Thread Lorenzo Bianconi
Refactor unreachable IPs for vip load-balancers inverting the logic used during the lb flow creation in order to visit lb first and then related datapath/ovn_ports. This is a preliminary patch to avoid recomputing flow hash and lflow lookup when not necessary. Signed-off-by: Lorenzo Bianconi ---

[ovs-dev] [PATCH v2 ovn 2/2] northd: improve unreachable_ips flows processing for dp_groups

2021-08-25 Thread Lorenzo Bianconi
Improve code efficiency of load-balancer unreachable_ips flows processing when datapath_groups are enabled. We can avoid to perform a flow lookup for each ovn_port in build_lflows_for_unreachable_vips() since lflows only depends on vips (match and action filters). Using this approach (with

[ovs-dev] [PATCH v2 ovn 0/2] improve code efficiency for ovn-northd lb-unreachable ips

2021-08-25 Thread Lorenzo Bianconi
ovn-master: -- tatistics for 'ovnnb_db_run' Total samples: 97 Maximum: 12596 msec Minimum: 12324 msec 95th percentile: 12549.921348 msec Short term average: 12438.001085 msec Long term average: 12407.350781 msec Statistics for 'ovn-northd-loop' Total samples: 185 Maximum:

Re: [ovs-dev] [PATCH ovn 1/2] northd: refactor unreachable IPs lb flows

2021-08-25 Thread Lorenzo Bianconi
> Hi Lorenzo, > > I have some minor findings below. Hi Mark, thx for the fast review :) > [...] > > s/,od/, od/ ack, I will fix it > > > + io_port, ctrl_meter, stage_hint, where, > > hash); > > } > > /* Adds a row with the specified contents to the

[ovs-dev] [PATCH v2 2/2] stream-ssl: Update default protocols, enable TLSv1.3

2021-08-25 Thread Frode Nordahl
RFC 8996 [0] deprecates the use of TLSv1 and TLSv1.1 for security reasons. Update our default list of protcols to be in compliance. Also add TLSv1.3 to the default list of supported protocols. 0: https://datatracker.ietf.org/doc/html/rfc8996 Signed-off-by: Frode Nordahl --- NEWS

[ovs-dev] [PATCH v2 1/2] stream-ssl: Fix handling of default ciphers/protocols

2021-08-25 Thread Frode Nordahl
Contrary to what is stated in the documentation, when SSL ciphers or protocols options are omitted the default values will not be set. The SSL library default settings will be used instead. Fix handling of default ciphers and protocols so that we actually enforce what is listed as defaults.

Re: [ovs-dev] [PATCH] json: Optimize string serialization.

2021-08-25 Thread Ilya Maximets
On 8/24/21 11:07 PM, Ilya Maximets wrote: > Current string serialization code puts all characters one by one. > This is slow because dynamic string needs to perform length checks > on every ds_put_char() and it's also doesn't allow compiler to use > better memory copy operations, i.e. doesn't

Re: [ovs-dev] [PATCH 2/2] stream-ssl: Update default protocols, enable TLSv1.3

2021-08-25 Thread 0-day Robot
Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include

[ovs-dev] [PATCH 2/2] stream-ssl: Update default protocols, enable TLSv1.3

2021-08-25 Thread Frode Nordahl
RFC 8996 [0] deprecates the use of TLSv1 and TLSv1.1 for security reasons. Update our default list of protcols to be in compliance. Also add TLSv1.3 to the default list of supported protocols. 0: https://datatracker.ietf.org/doc/html/rfc8996 Signed-off-by: Frode Nordahl --- NEWS

[ovs-dev] [PATCH 1/2] stream-ssl: Fix handling of default ciphers/protocols

2021-08-25 Thread Frode Nordahl
Contrary to what is stated in the documentation, when SSL ciphers or protocols options are omitted the default values will not be set. The SSL library default settings will be used instead. Fix handling of default ciphers and protocols so that we actually enforce what is listed as defaults.

[ovs-dev] [OVN Patch 1/2] northd: Resize the hash to correct parameters after build

2021-08-25 Thread anton . ivanov
From: Anton Ivanov Parallel builds may result in suboptimal hash bucket sizing. In the absense of dp-groups this does not matter as the hash is purely storage and not used for lookups during the build. Such a hash needs to be resized to a correct size at the end of the build to ensure that any

[ovs-dev] [OVN Patch 2/2] northd: Alter initial hash sizing for dp_groups+parallel

2021-08-25 Thread anton . ivanov
From: Anton Ivanov When running with dp_groups and parallelization enabled we have a possible worse case scenario where northd connects for the first time to a pre-populated database. If we do not size the hash to a sufficiently big size to accommodate for this, we end up with severe lock

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix extremely inefficient usage of lflow hash map.

2021-08-25 Thread Anton Ivanov
On 24/08/2021 22:49, Ilya Maximets wrote: On 8/24/21 10:07 PM, Anton Ivanov wrote: On 23/08/2021 22:36, Ilya Maximets wrote: On 8/23/21 10:37 PM, Anton Ivanov wrote: On 23/08/2021 21:26, Ilya Maximets wrote: On 8/23/21 10:20 PM, Anton Ivanov wrote: Should not be the case. The map is