[ovs-dev] [PATCH v3] tests: Fix endianness in netlink policy test fixtures.

2021-12-06 Thread Frode Nordahl
The netlink policy unit test contains test fixture data that is subject to endianness and currently fails on big endian systems. Store the fixture data in a struct to ensure proper byte order for the header data. Also fix improper style for sizeof with expressions. Fixes: bfee9f6c0115

Re: [ovs-dev] [PATCH v4 0/3] bug fix: avoid install bad dp flow

2021-12-06 Thread lic121
>On 11/21/21 16:19, lic121 wrote: >> Version 4: >>   - Cover case where tcp_hdrlen > tcp_pkt_size >>   - Other small adjustments >> >> ovs may install bad datapath flow when meet malformed pkts. As a >> result, it may allows some unwanted pkts pass. This could be a point >> of attack. >> >>

Re: [ovs-dev] [PATCH v3] dpif-netdev: Call cpuid for x86 isa availability.

2021-12-06 Thread Ilya Maximets
On 12/3/21 16:24, Van Haaren, Harry wrote: >> -Original Message- >> From: David Marchand >> Sent: Thursday, December 2, 2021 4:05 PM >> To: Van Haaren, Harry >> Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian >> ; Amber, Kumar >> Subject: Re: [PATCH v3] dpif-netdev: Call cpuid

Re: [ovs-dev] [PATCH net-next v8] net: openvswitch: IPv6: Add IPv6 extension header support

2021-12-06 Thread Cpp Code
On Thu, Dec 2, 2021 at 9:28 PM Pravin Shelar wrote: > > On Thu, Dec 2, 2021 at 12:20 PM Cpp Code wrote: > > > > On Wed, Dec 1, 2021 at 11:34 PM Pravin Shelar wrote: > > > > > > On Wed, Nov 24, 2021 at 11:33 AM Toms Atteka > > > wrote: > > > > > > > > This change adds a new OpenFlow field

Re: [ovs-dev] [PATCH v3 2/4] system-dpdk: Use dummy-pmd port for packet injection.

2021-12-06 Thread Ilya Maximets
On 11/30/21 16:00, David Marchand wrote: > net_pcap is not always available in DPDK (like, in a dev > environment when you forgot to install the libpcap-devel). > On the other hand, OVS already has its own way to inject packets into a > bridge. Let's make use of it. > > This solution is slower

Re: [ovs-dev] [PATCH v3] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info logs.

2021-12-06 Thread Mike Pattrick
On Wed, 2021-11-24 at 13:32 +, lin huang wrote: > From: linhuang > > Userspace tunnel doesn't have a valid device in the kernel. So > get_ifindex() function (ioctl) always get error during > adding a port, deleting a port or updating a port status. > > The info log is >

Re: [ovs-dev] [PATCH v3] Revert "odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP."

2021-12-06 Thread Mike Pattrick
On Wed, 2021-12-01 at 14:46 +0100, Eelco Chaudron wrote: > > On 29 Nov 2021, at 22:02, Aaron Conole wrote: > > > This reverts commit c645550bb249 ("odp-util: Always report > > ODP_FIT_TOO_LITTLE for IGMP.") > > > > Always forcing a slow path action can result in some over-broad > > flows which

Re: [ovs-dev] [PATCH] datapath: fix crash when ipv6 fragment pkt recalculate L4 checksum

2021-12-06 Thread Gregory Rose
On 11/30/2021 10:16 PM, zhounan (E) via dev wrote: From: Zhou Nan When we set ipv6 addr, we need to recalculate checksum of L4 header. In our testcase, after send ipv6 fragment package, KASAN detect "use after free" when calling function update_ipv6_checksum, and crash occurred after a

Re: [ovs-dev] [PATCH] compat: handle NF_REPEAT error on nf_conntrack_in

2021-12-06 Thread Gregory Rose
On 11/26/2021 12:59 PM, Vladislav Odintsov wrote: In patch [1] rpl_nf_conntrack_in was backported as static inline function without do..while loop handling NF_REPEAT error. In patch [2] rpl_nf_conntrack_in backported function was removed from compat/include/net/netfilter/nf_conntrack_core.h

Re: [ovs-dev] [PATCH 2/2] alb.at: Increase time/warp.

2021-12-06 Thread David Marchand
On Tue, Nov 23, 2021 at 3:01 PM Kevin Traynor wrote: > > It seems that on slow system with high concurrency and cpu contention > time/warp is not accurate enough for the ALB unit tests with the minimum > time/warp that was used to hit an amount of events. This results in some > intermittent test

Re: [ovs-dev] [PATCH] dpdk: Use --in-memory by default.

2021-12-06 Thread Dmitry Kozlyuk
2021-12-06 17:34 (UTC+0100), David Marchand: [...] > > Are there plans in DPDK to deprecate the legacy memory model someday? > > Hard to remove this mode in DPDK atm: FreeBSD does not implement the new mode. > And the DPDK memory allocator beast has very few contributors, so I > can't promise

[ovs-dev] [PATCH] ofp-flow: skip flow reply if it exceeds the maximum message size

2021-12-06 Thread Eelco Chaudron
Currently, if a flow reply results in a message which exceeds the maximum reply size, it will assert OVS. This would happen when OVN uses OpenFlow15 to add large flows, and they get read using OpenFlow10 with ovs-ofctl. This patch prevents this and adds a test case to make sure the code behaves

Re: [ovs-dev] [PATCH v3 2/4] system-dpdk: Use dummy-pmd port for packet injection.

2021-12-06 Thread Ilya Maximets
On 12/6/21 17:54, Ilya Maximets wrote: > On 12/3/21 17:47, Van Haaren, Harry wrote: >>> -Original Message- >>> From: David Marchand >>> Sent: Thursday, December 2, 2021 3:18 PM >>> To: Van Haaren, Harry >>> Cc: Amber, Kumar ; d...@openvswitch.org; >>> i.maxim...@ovn.org;

Re: [ovs-dev] [PATCH v3 2/4] system-dpdk: Use dummy-pmd port for packet injection.

2021-12-06 Thread Ilya Maximets
On 12/3/21 17:47, Van Haaren, Harry wrote: >> -Original Message- >> From: David Marchand >> Sent: Thursday, December 2, 2021 3:18 PM >> To: Van Haaren, Harry >> Cc: Amber, Kumar ; d...@openvswitch.org; >> i.maxim...@ovn.org; f...@sysclose.org; maxime.coque...@redhat.com >> Subject: Re:

Re: [ovs-dev] [PATCH v2] tests: Handle endianness in netlink policy test

2021-12-06 Thread Frode Nordahl
On Fri, Dec 3, 2021 at 3:53 PM Ilya Maximets wrote: > > On 11/25/21 19:49, Mike Pattrick wrote: > > Hello Frode, > > > > This patch does appear to fix the test case on big-endian systems. > > > > On Fri, 2021-11-19 at 06:08 +0100, Frode Nordahl wrote: > >> The netlink policy unit test contains

Re: [ovs-dev] [PATCH] dpdk: Use --in-memory by default.

2021-12-06 Thread David Marchand
On Sat, Dec 4, 2021 at 2:22 AM Ilya Maximets wrote: > > On 9/9/21 14:49, David Marchand wrote: > > On Fri, Aug 6, 2021 at 2:44 PM Rosemarie O'Riorden > > wrote: > >> > >> If anonymous memory mapping is supported by the kernel, it's better > >> to run OVS entirely in memory rather than creating

Re: [ovs-dev] [PATCH 1/2] alb.at: Check for log from correct line number.

2021-12-06 Thread David Marchand
On Tue, Nov 23, 2021 at 3:01 PM Kevin Traynor wrote: > > The next log line number should be updated to ensure that the > anticipated log has occurred again after more time has passed. > > Fixes: a83a406096e9 ("dpif-netdev: Sync PMD ALB state with user commands.") > Signed-off-by: Kevin Traynor

Re: [ovs-dev] [PATCH v4 0/4] netdev datapath hardware offload support for GRE flows

2021-12-06 Thread Finn, Emma
-Original Message- From: Ilya Maximets Sent: Monday 29 November 2021 18:00 To: Nir Anteby ; d...@openvswitch.org; Stokes, Ian ; Finn, Emma Cc: el...@nvidia.com; i.maxim...@ovn.org; Maxime Coquelin ; Sriharsha Basavapatna Subject: Re: [ovs-dev] [PATCH v4 0/4] netdev datapath

[ovs-dev] OvS+OVN Fall '21 Conference - IMPORTANT (start time, etc.)

2021-12-06 Thread Aaron Conole
Thanks everyone for your interest in the OvS+OVN Fall '21 Conference, which is taking place on Dec. 7th & 8th, 2021. There is just about 24 hours left until the conference start time, so here are a few reminders and important announcements. Please make sure you are registered using the Event

Re: [ovs-dev] [PATCH ovn v3] controller/pinctrl: improve packet-in debuggability

2021-12-06 Thread Ilya Maximets
On 12/6/21 15:01, Ilya Maximets wrote: > On 12/6/21 14:35, Ilya Maximets wrote: >> On 12/6/21 10:09, Mohammad Heib wrote: >>> Improve packet-in debuggability within pinctrl module >>> by printing basic details about each received packet-in >>> message, those messages will be printed to the logs

Re: [ovs-dev] [PATCH ovn v3] controller/pinctrl: improve packet-in debuggability

2021-12-06 Thread Ilya Maximets
On 12/6/21 14:35, Ilya Maximets wrote: > On 12/6/21 10:09, Mohammad Heib wrote: >> Improve packet-in debuggability within pinctrl module >> by printing basic details about each received packet-in >> message, those messages will be printed to the logs only >> when DBG log level is enabled. >> >>

Re: [ovs-dev] [PATCH ovn v3] controller/pinctrl: improve packet-in debuggability

2021-12-06 Thread Ilya Maximets
On 12/6/21 10:09, Mohammad Heib wrote: > Improve packet-in debuggability within pinctrl module > by printing basic details about each received packet-in > message, those messages will be printed to the logs only > when DBG log level is enabled. > > Also, add two coverage counters that will

Re: [ovs-dev] [PATCH v1] dpdk: Use --in-memory by default.

2021-12-06 Thread Ilya Maximets
On 12/6/21 02:49, Mike Pattrick wrote: > On Fri, Dec 3, 2021 at 8:15 PM Ilya Maximets wrote: >> >> On 11/30/21 22:31, Mike Pattrick wrote: >>> If anonymous memory mapping is supported by the kernel, it's better >>> to run OVS entirely in memory rather than creating shared data >>> structures. OVS

Re: [ovs-dev] [PATCH v1] acinclude: Provide error info when linking fails with DPDK.

2021-12-06 Thread Pai G, Sunil
Hi Ilya, > Hi, Sunil. > > I don't think that printing parts of a config.log is a good thing to do. > Primarily > because if ./configure failed, users need to look at config.log anyway. > That's > a normal thing for all automake based build systems. > > One thing that we can improve is the

[ovs-dev] [PATCH ovn v3] controller/pinctrl: improve packet-in debuggability

2021-12-06 Thread Mohammad Heib
Improve packet-in debuggability within pinctrl module by printing basic details about each received packet-in message, those messages will be printed to the logs only when DBG log level is enabled. Also, add two coverage counters that will indicate the total packet-in messages that were received

Re: [ovs-dev] [PATCH v18 3/8] dpif-offload-provider: Introduce dpif-offload-provider layer

2021-12-06 Thread Chris Mi via dev
Hi Ilya, On 11/30/2021 3:58 PM, Eelco Chaudron wrote: On 29 Nov 2021, at 8:38, Chris Mi wrote: On 11/25/2021 4:52 PM, Eelco Chaudron wrote: On 15 Nov 2021, at 3:53, Chris Mi wrote: Some offload actions require functionality that is not netdev based, but dpif. For example, sFlow action

Re: [ovs-dev] [PATCH] dpif-netlink: Improve feature negotiation for older kernels.

2021-12-06 Thread Chris Mi via dev
On 12/4/2021 2:18 AM, Ilya Maximets wrote: On 12/3/21 16:57, Paolo Valerio wrote: Ilya Maximets writes: On 11/11/21 19:06, Paolo Valerio wrote: Hi Chris, Chris Mi via dev writes: OVS_DP_F_UNALIGNED is already set, no need to set again. If restarting ovs, dp is already created. So