On Thu, 2022-04-28 at 14:00 +0200, Ilya Maximets wrote:
> On 4/28/22 13:49, Ilya Maximets wrote:
> > On 4/28/22 11:06, Jianbo Liu wrote:
> > > On Wed, 2022-04-27 at 13:37 +0200, Ilya Maximets wrote:
> > > > On 4/27/22 04:41, Jianbo Liu wrote:
> > > > > On Wed, 2022-04-27 at 01:58 +0200, Ilya
On Wed, Apr 27, 2022 at 01:36:48PM +0200, Adrian Moreno wrote:
>
>
> On 4/7/22 15:53, lic121 wrote:
> >During the revalidation, mirror could be removed. Instead of crash
> >the process, we can simply skip the deleted mirror.
> >
> >Fixes: ec7ceaed4f3e ("ofproto-dpif: Modularize mirror code.")
>
Bleep bloop. Greetings Alin-Gabriel Serdean, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#26 FILE:
I am no longer actively working on OVN, so it's appropriate to move myself
to emeritus status.
Signed-off-by: Ben Pfaff
---
MAINTAINERS.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index 0d19bd622..fff2cd977 100644
---
Signed-off-by: Alin-Gabriel Serdean
---
Documentation/howto/qos.rst | 8
.../internals/contributing/documentation-style.rst| 2 +-
Documentation/topics/testing.rst | 2 +-
Documentation/topics/windows.rst
This patch removes the newly added NEWS entry and adds it as a leaf
under post 2.17.
Add OVS version instead of specifying that the feature is supported
for IPv6 connection tracking and Genenve IPv6 tunnels.
Signed-off-by: Alin-Gabriel Serdean
---
Documentation/faq/releases.rst | 6 +++---
On Thu, 28 Apr 2022 10:09:17 -0400 Benjamin Coddington wrote:
> > Noob reply: wish I knew. (I somewhat hoped _you_ would've been able to
> > tell me.)
> >
> > Thing is, the only method I could think of for fd passing is the POSIX fd
> > passing via unix_attach_fds()/unix_detach_fds(). But that's
On 4/27/22 17:33, Aaron Conole wrote:
> Vasu Dasari writes:
>
>> Extended OpenFlow monitoring support
>> * OpenFlow 1.3 with ONF extensions
>> * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+.
>>
>> ONF extensions are similar to Nicira extensions except for
>>
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#1050 FILE: utilities/ovn-nbctl.c:275:
Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller.
While Mirror creation just creates the mirror, the lsp-attach-mirror
triggers the sequence to create Mirror in OVS DB on compute node.
OVS already supports Port Mirroring.
Example commands are as below:
Mirror creation
On 4/28/22 18:07, Ilya Maximets wrote:
> On 4/26/22 12:37, Dumitru Ceara wrote:
>> At a first glance, change tracking should never be allowed for
>> write-only columns. However, some clients (e.g., ovn-northd) that are
>> mostly exclusive writers of a database, use change tracking to avoid
>>
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo controller-vtep/gateway.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
This uses the newly added ovsdb_idl_set_write_changed_only_all() to
explicitly disable atomicity checks for read/write columns and to enable
optimizing the process of building the SB transaction.
Bump OVS submodule to pick up d94cd0d3eec3 ("ovsdb-idl: Support
write-only-changed IDL monitor
Hi Kevin,
> I don't see this issue locally. Not sure what I am missing.
>
> # /root/ovs/utilities/ovs-vsctl --no-wait set open_vSwitch .
> other_config:pmd-auto-lb-rebal-interval="-0"
>
> # 2022-04-28T14:01:07Z|00359|dpif_netdev|INFO|PMD auto load balance
> interval set to 1 mins
>
> However,
On 4/26/22 12:37, Dumitru Ceara wrote:
> At a first glance, change tracking should never be allowed for
> write-only columns. However, some clients (e.g., ovn-northd) that are
> mostly exclusive writers of a database, use change tracking to avoid
> duplicating the IDL row records into a local
This allows CMS to tweak the way logical routers reply to ARP/ND packets
targeting load balancer VIPs. By default a router only replies for VIPs
that are reachable locally (they're part of a subnet configured on the
router). There are cases though when it's desirable for routers to
reply for all
Hi, sorry for the slow reply, I was out on PTO.
On 08/04/2022 15:34, Wan Junjie wrote:
On Sat, Apr 2, 2022 at 12:25 AM Kevin Traynor wrote:
On 29/03/2022 04:26, Wan Junjie wrote:
Hi Kevin,
Thanks for your comments.
On Fri, Mar 25, 2022 at 8:17 PM Kevin Traynor wrote:
Hi Wan Junjie,
From: Seamus Ryan
This adds 4 new unit tests to the 'check-dpdk' subsystem that will
test rate limiting functionality.
Signed-off-by: Seamus Ryan
Signed-off-by: Michael Phelan
Co-authored-by: Michael Phelan
---
v2:
- Fixed dn1 typo & spacing issues.
- Added check for removing burst and
On 4/28/22 15:44, Eelco Chaudron wrote:
> Hi All,
>
> I just got the following feedback from the robot, but it does not look like
> any of the code this patchset is touching:
>
> ==17733==ERROR: AddressSanitizer: heap-use-after-free on address
> 0x61400c50 at pc 0x00536627 bp
On 4/26/22 13:42, Ales Musil wrote:
> It can happen that MAC binding physical flow is not created
> on when new datapath is added to chassis.
>
> Consider following scenario:
> Chassis are set with "ovn-monitor-all=true".
>
> T0 - The CH0 have only DP0
> T1 - MAC binding table gets new update
Hi Lin,
On 20/04/2022 13:55, 林晃(研发部 福州) wrote:
When we set a special value "-0" to pmd-auto-lb-rebal-interval, its
value is 0 not 1.
e.g.
ovs-vsctl set open_vswitch .
other_config:pmd-auto-lb-rebal-interval="-0"
2022-04-20T11:31:44.987Z|00526|dpif_netdev|INFO|PMD auto load balance
interval
Dumitru Ceara writes:
> Some openflow actions can be misaligned, e.g., actions whithin OF 1.0
> replies to statistics reply messages which have a header of 12 bytes
> and no additional padding.
>
> Also, buggy controllers might incorrectly encode actions.
>
> When decoding multiple actions in
Dumitru Ceara writes:
> This is undefined behavior and was reported by UB Sanitizer:
> lib/meta-flow.c:3445:16: runtime error: member access within null pointer
> of type 'struct vl_mf_field'
> #0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445
> #1 0x6d96d7 in mf_from_oxm_header
On 22 Mar 2022, at 10:35, Eelco Chaudron wrote:
> The parse_key_and_mask_to_match() is a function to translate
> a netlink formatted key/mask to match structure. And should
> not consider any configuration setting when translating.
>
> In addition we also enforce the encap_eth_type[0] mask as
>
lic121 writes:
> On Mon, Apr 25, 2022 at 08:47:32AM -0400, Aaron Conole wrote:
>> lic121 writes:
>>
>> > Max allowed conntrack entries is configurable with
>> > 'ovs-appctl dpctl/ct-set-maxconns' command. In real scenarios,
>> > this configuration is expected to survive from host reboot.
>> >
On Thu, Apr 28, 2022 at 02:59:37PM +0200, Ilya Maximets wrote:
> On 4/27/22 22:34, Bruce Richardson wrote:
> > On Mon, Apr 25, 2022 at 11:46:01PM +0200, Ilya Maximets wrote:
> >> On 4/20/22 18:41, Mcnamara, John wrote:
> -Original Message-
> From: Ilya Maximets
> Sent:
Hi All,
I just got the following feedback from the robot, but it does not look like any
of the code this patchset is touching:
==17733==ERROR: AddressSanitizer: heap-use-after-free on address 0x61400c50
at pc 0x00536627 bp 0x7f96d7ffd990 sp 0x7f96d7ffd988
READ of size 8 at
Now ovs-tcpdump will check for an OVS_RUNDIR environment variable and
if present, use it instead of the default RUNDIR. This is useful when
used in conjunction with OVS_PAUSE_TEST while running the test suite.
Signed-off-by: Mike Pattrick
---
utilities/ovs-tcpdump.in | 5 -
1 file changed,
From: Flavio Leitner
From: Flavio Leitner
This patch split out the common code between vhost and
dpdk transmit paths to shared functions to simplify the
code and fix an issue.
The issue is that the packet coming from non-DPDK device
and egressing on a DPDK device currently skips the hwol
On 28 Apr 2022, at 15:15, Mike Pattrick wrote:
> On Thu, Apr 28, 2022 at 5:15 AM Eelco Chaudron wrote:
>>
>> Signed-off-by: Eelco Chaudron
>
> Looks great!
>
> Acked-by: Mike Pattrick
Thanks Mike for taking the time to review all of this!
//Eelco
On Thu, Apr 28, 2022 at 5:15 AM Eelco Chaudron wrote:
>
> Signed-off-by: Eelco Chaudron
Looks great!
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Apr 28, 2022 at 5:14 AM Eelco Chaudron wrote:
>
> This patch will properly initialize offload, as it requires the
> setting to be enabled before starting ovs-vswitchd (or do a
> restart once configured).
>
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
On 4/27/22 22:34, Bruce Richardson wrote:
> On Mon, Apr 25, 2022 at 11:46:01PM +0200, Ilya Maximets wrote:
>> On 4/20/22 18:41, Mcnamara, John wrote:
-Original Message-
From: Ilya Maximets
Sent: Friday, April 8, 2022 10:58 AM
To: Hu, Jiayu ; Maxime Coquelin
; Van
> > > > From: Seamus Ryan
> > > >
> > > > This adds 4 new unit tests to the 'check-dpdk' subsystem that will
> > > > test rate limiting functionality.
> > > >
> > >
> > > Thanks for the patch Michael, a few comments below.
> > >
> > > I'm still conducting some testing so may have some follow up
On 4/28/22 13:49, Ilya Maximets wrote:
> On 4/28/22 11:06, Jianbo Liu wrote:
>> On Wed, 2022-04-27 at 13:37 +0200, Ilya Maximets wrote:
>>> On 4/27/22 04:41, Jianbo Liu wrote:
On Wed, 2022-04-27 at 01:58 +0200, Ilya Maximets wrote:
> On 4/26/22 09:14, Simon Horman wrote:
>> On Tue,
On 4/28/22 11:06, Jianbo Liu wrote:
> On Wed, 2022-04-27 at 13:37 +0200, Ilya Maximets wrote:
>> On 4/27/22 04:41, Jianbo Liu wrote:
>>> On Wed, 2022-04-27 at 01:58 +0200, Ilya Maximets wrote:
On 4/26/22 09:14, Simon Horman wrote:
> On Tue, Apr 19, 2022 at 01:38:33AM +, Jianbo Liu via
> -Original Message-
> From: Stokes, Ian
> Sent: Wednesday 27 April 2022 16:16
> To: Phelan, Michael ; d...@openvswitch.org
> Cc: acon...@redhat.com; david.march...@redhat.com;
> maxime.coque...@redhat.com; Ryan, Seamus
> Subject: RE: [PATCH] tests: Add ovs-dpdk rate limiting unit
Hi Flavio, Mike,
> From: Flavio Leitner
>
> This patch split out the common code between vhost and dpdk transmit paths
> to shared functions to simplify the code and fix an issue.
>
> The issue is that the packet coming from non-DPDK device and egressing on
> a DPDK device currently skips the
On 28 Apr 2022, at 10:16, Eelco Chaudron wrote:
> On 25 Apr 2022, at 14:45, Mike Pattrick wrote:
>
>> On Mon, Mar 28, 2022 at 7:12 AM Eelco Chaudron wrote:
>>>
>>> This patch will properly initialize offload, as it requires the
>>> setting to be enabled before starting ovs-vswitchd (or do a
Signed-off-by: Eelco Chaudron
---
v2:
- Added section in the NEWS document
NEWS |2
tests/system-offloads-traffic.at | 413 ++
2 files changed, 414 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index
This patch will properly initialize offload, as it requires the
setting to be enabled before starting ovs-vswitchd (or do a
restart once configured).
Signed-off-by: Eelco Chaudron
---
v2:
- Unified all the OVS_TRAFFIC_VSWITCHD_START macro's
tests/ofproto-macros.at |6 +-
This change implements support for the check_pkt_len
action using the TC police action, which supports MTU
checking.
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
lib/netdev-offload-tc.c | 171 +-
lib/tc.c| 455
Move handling of the individual actions in the parse_tc_flower_to_match()
function to a separate function that will make recursive action handling
easier.
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
lib/netdev-offload-tc.c | 422 +--
1
Move handling of the individual actions in the netdev_tc_flow_put()
function to a separate function that will make recursive action handling
easier.
Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
---
lib/netdev-offload-tc.c | 255 +--
1 file
This series adds support for the datapath action check_pkt_len for TC offload.
It also includes some offload self-tests.
v2:
- Add ACKs
- Unified all the OVS_TRAFFIC_VSWITCHD_START macro's
- Added section in the NEWS document
Eelco Chaudron (5):
netdev-offload-tc: Move flow_put
On Wed, 2022-04-27 at 13:37 +0200, Ilya Maximets wrote:
> On 4/27/22 04:41, Jianbo Liu wrote:
> > On Wed, 2022-04-27 at 01:58 +0200, Ilya Maximets wrote:
> > > On 4/26/22 09:14, Simon Horman wrote:
> > > > On Tue, Apr 19, 2022 at 01:38:33AM +, Jianbo Liu via dev
> > > > wrote:
> > > > > On
On 25 Apr 2022, at 14:45, Mike Pattrick wrote:
> On Mon, Mar 28, 2022 at 7:12 AM Eelco Chaudron wrote:
>>
>> This patch will properly initialize offload, as it requires the
>> setting to be enabled before starting ovs-vswitchd (or do a
>> restart once configured).
>>
>> Signed-off-by: Eelco
47 matches
Mail list logo
