[ovs-dev] [PATCH] man: Fix various typos across manual pages

As reported by Debian lintian. Signed-off-by: Frode Nordahl --- lib/db-ctl-base.man | 2 +- lib/dpctl.man| 2 +- ovsdb/ovsdb-tool.1.in| 6 +++--- utilities/ovs-ofctl.8.in | 6 +++--- utilities/ovs-vsctl.8.in | 2 +- vswitchd/vswitch.xml | 4 ++-- 6 files changed, 11 inse

[ovs-dev] [PATCH] Fix spelling error exposed in binaries.

As reported by Debian lintinan. Signed-off-by: Frode Nordahl --- lib/daemon-unix.c| 4 ++-- lib/ovsdb-idl.c | 2 +- lib/perf-counter.c | 2 +- ofproto/ofproto-dpif-sflow.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/daemon-unix.c

[ovs-dev] [PATCH] utilities/bashcomp: Fix incorrect file mode

The bash completion scripts shipped with Open vSwitch currently have the executable bit set. This is problematic because the files do not start with a shebang and as such a user may end up executing them using the wrong shell. When installed in a system the bash shell will source these files and

[ovs-dev] [PATCH ovn] fix typo

I looked at https://github.com/ovn-org/ovn/commit/23e203a3f30bd57ef8d0def7ee2698e588782d0c Found fixed typo: "webserer" => "webserver" I decided to grep "webserer" and found another such word. >From b1d7d16289ffa28f76c4a7803e369a5e287ffdc5 Mon Sep 17 00:00:00 2001 From: Igor Zhukov Date: Fri, 8

Re: [ovs-dev] [v7 9/9] doc: Add meter offload topic document

Bleep bloop. Greetings Jianbo Liu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #98 FILE: Documentation/howto/tc-of

[ovs-dev] [v7 9/9] doc: Add meter offload topic document

Fow now, add introduction and the limitation of meter offload. Signed-off-by: Jianbo Liu --- Documentation/automake.mk | 1 + Documentation/howto/index.rst | 1 + Documentation/howto/tc-offload.rst | 114 + 3 files changed, 116 insertions(+) create

[ovs-dev] [v7 7/9] netdev-offload-tc: Offloading rules with police actions

When offloading rule, tc should be filled with police index, instead of meter id. As meter is mapped to police action, and the mapping is inserted into meter_id_to_police_idx hmap, this hmap is used to find the police index. Besides, the reverse mapping between meter id and police index is also add

[ovs-dev] [v7 8/9] dpif-netlink: Offloading meter to tc police action

OVS meters are created in advance and openflow rules refer to them by their unique ID. New tc_police API is used to offload them. By calling the API, police actions are created and meters are mapped to them. These actions then can be used in tc filter rules by the index. Signed-off-by: Jianbo Liu

[ovs-dev] [v7 6/9] netdev-offload-tc: Cleanup police actions with reserved indexes on startup

As the police actions with indexes of 0x1000-0x1fff are reserved for meter offload, to provide a clean environment for OVS, these reserved police actions should be deleted on startup. So dump all the police actions, delete those actions with indexes in this range. Signed-off-by: Jianbo Liu

[ovs-dev] [v7 5/9] netdev-offload-tc: Implement meter offload API for tc

For dpif-netlink, meters are mapped by tc to police actions with one-to-one relationship. Implement meter offload API to set/get/del the police action, and a hmap is used to save the mappings. An id-pool is used to manage all the available police indexes, which are 0x1000-0x1fff, reserved o

[ovs-dev] [v7 4/9] netdev-linux: Add functions to manipulate tc police action

Add helpers to add, delete and get stats of police action with the specified index. Signed-off-by: Jianbo Liu --- lib/netdev-linux.c | 147 + lib/netdev-linux.h | 6 ++ lib/tc.c | 118 +--- lib/tc.h

[ovs-dev] [v7 2/9] tc: Add support parsing tc police action

Add function to parse police action from netlink message. Signed-off-by: Jianbo Liu Acked-by: Eelco Chaudron --- lib/netdev-offload-tc.c | 4 +++ lib/tc.c| 54 + lib/tc.h| 5 3 files changed, 63 insertions(+) diff -

[ovs-dev] [v7 3/9] netdev-linux: Refactor put police action netlink message

To reuse the code for manipulating police action, move the common initialization code to a function, and change PPS parameters as meter pktps is in unit of packet per second. null_police is redundant because either BPS or PPS, not both, can be configured in one message. So the police passed in to

[ovs-dev] [v7 1/9] netdev-offload: Add meter offload API

Add API to offload meter to HW, and the corresponding functions to call the meter callbacks from all the registered flow API providers. The interfaces are like those related to meter in dpif_class, in order to pass necessary info to HW. Signed-off-by: Jianbo Liu Acked-by: Eelco Chaudron --- lib

[ovs-dev] [v7 0/9] Add support for ovs metering with tc offload

This series is to add support for tc offloading of ovs metering, and enhance OVS to use new kernel feature which offload tc police action to hardware. To do the offloading, new APIs for meter are added in netdev-offload, and OVS meters are mapped to tc police actions with one-to-one relationship fo

Re: [ovs-dev] [v6 4/9] netdev-linux: Add functions to manipulate tc police action

On Fri, 2022-07-08 at 09:38 +0800, Jianbo Liu wrote: > On Thu, 2022-07-07 at 14:02 +0200, Ilya Maximets wrote: > > On 7/7/22 13:51, Eelco Chaudron wrote: > > > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > > +static int > > > > +tc_update_policer_action_stats(struct ofpbuf *msg, > > > > +

Re: [ovs-dev] [v6 0/9] Add support for ovs metering with tc offload

On Thu, 2022-07-07 at 13:54 +0200, Eelco Chaudron wrote: > > > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > This series is to add support for tc offloading of ovs metering, > > and > > enhance OVS to use new kernel feature which offload tc police > > action to > > hardware. > > To do the offl

Re: [ovs-dev] [v6 9/9] doc: Add meter offload topic document

On Thu, 2022-07-07 at 13:53 +0200, Eelco Chaudron wrote: > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > Fow now, add introduction and the limitation of meter offload. > > > > Signed-off-by: Jianbo Liu > > --- > >  Documentation/automake.mk  |  1 + > >  Documentation/howto/index.rst   

Re: [ovs-dev] [v6 8/9] dpif-netlink: Offloading meter to tc police action

On Thu, 2022-07-07 at 13:53 +0200, Eelco Chaudron wrote: > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > OVS meters are created in advance and openflow rules refer to them > > by > > their unique ID. New tc_police API is used to offload them. By > > calling > > the API, police actions are create

Re: [ovs-dev] [v6 4/9] netdev-linux: Add functions to manipulate tc police action

On Thu, 2022-07-07 at 13:51 +0200, Eelco Chaudron wrote: > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > > +    tca = ofpbuf_at_assert(msg, NLMSG_HDRLEN, sizeof *tca); > > +    act = nl_attr_find(msg, NLMSG_HDRLEN + sizeof *tca, > > TCA_ACT_TAB); > > +    if (!act) { > > +    VLOG_ERR_RL(&r

Re: [ovs-dev] [v6 4/9] netdev-linux: Add functions to manipulate tc police action

On Thu, 2022-07-07 at 14:02 +0200, Ilya Maximets wrote: > On 7/7/22 13:51, Eelco Chaudron wrote: > > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > > > +static int > > > +tc_update_policer_action_stats(struct ofpbuf *msg, > > > +   struct ofputil_meter_stats > > > *stats) >

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On 7/7/2022 4:53 AM, David Marchand wrote: On Wed, Jul 6, 2022 at 6:57 PM Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux openvswitch kernel driver in it's place [1]. There are many Linux specific source modules in the data

Re: [ovs-dev] [PATCH v2 ovn] Always funnel multichassis port traffic through tunnels

On Fri, Jul 1, 2022 at 1:52 PM Mark Michelson wrote: > > Looks good to me. Thanks, Ihar. > > Acked-by: Mark Michelson > > On 6/24/22 18:35, Ihar Hrachyshka wrote: > > Before the patch, for switches with a localnet port, > > > > - traffic to a multichassis port was funneled through tunnels; but >

[ovs-dev] [PATCH ovn branch-21.12] northd: Add feature to log reply and related ACL traffic.

It can be desirable for replies to stateful ACLs to be logged. And in some cases, it can actually be a bit confusing why they aren't logged. Consider a situation where a port group called "port_group" exists and logical switch ports swp1 and swp2 belong to it. We create the following ACL, where log

Re: [ovs-dev] [PATCH 3/6] rhel: Remove RHEL 6 kernel module spec

On 7/7/2022 4:34 AM, David Marchand wrote: On Wed, Jul 6, 2022 at 7:05 PM Greg Rose wrote: Remove the RHEL 6 kernel driver module specification. Signed-off-by: Greg Rose --- rhel/automake.mk| 5 -- rhel/kmod-openvswitch-rhel6.spec.in | 123

[ovs-dev] onv: fix typo

I looked at https://github.com/ovn-org/ovn/commit/23e203a3f30bd57ef8d0def7ee2698e588782d0c Found fixed typo: "webserer" => "webserver" I decided to grep "webserer" and found another such word. >From b1d7d16289ffa28f76c4a7803e369a5e287ffdc5 Mon Sep 17 00:00:00 2001 From: Igor Zhukov Date: Fri, 8

[ovs-dev] [PATCH v3 1/8] debian: Archive debian packaging source.

The packaging source in the OVS repository has drifted away from what is currently in Debian and Ubuntu. This state is problematic because from time to time someone tries to build packages from the upstream OVS debian package source and then expect that package to work with up-/down-grades from-/t

[ovs-dev] [PATCH v3 8/8] docs: Update package references in debian/ubuntu related docs.

On the back of changing the debian/ubuntu packaging, update the docs to refer to existing packages. Signed-off-by: Frode Nordahl --- Documentation/intro/install/distributions.rst | 22 --- Documentation/tutorials/ipsec.rst | 19 +++- 2 files changed, 12 in

[ovs-dev] [PATCH v3 7/8] debian: Fix generation of copyright file.

The recipe for inserting authors from AUTHORS.rst is wrong. Fixes: 3deca69b08f2 ("doc: Convert AUTHORS to rST") Signed-off-by: Frode Nordahl --- debian/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/automake.mk b/debian/automake.mk index afba5b0e4..89c

[ovs-dev] [PATCH v3 6/8] debian: Fix build of python json C extension.

Signed-off-by: Frode Nordahl --- debian/control | 2 +- debian/rules | 13 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/debian/control b/debian/control index 7a79d1ff0..1fb504482 100644 --- a/debian/control +++ b/debian/control @@ -279,7 +279,7 @@ Description:

[ovs-dev] [PATCH v3 5/8] python: Allow building json C extension with static OVS library.

Allow caller of setup.py to pass in libopenvswitch.a as an object for linking through the use of LDFLAGS environment variable when not building a shared openvswitch library. To accomplish this set the `enable_shared` environment variable to 'no'. Example: LDFLAGS=lib/libopenvswitch.a enable_s

[ovs-dev] [PATCH v3 4/8] ci: Separate job for debs, ensure built pkg is tested.

Use a separate GitHub Actions job for deb test so that we can control base image for package test. The CI deb package test code currently attempts to use `apt` to install local packages. That may not produce the expected result. Explicitly install the local packages with `dpkg` after installing

[ovs-dev] [PATCH v3 2/8] checkpatch: Ignore line length and leading whitespace for debian/*.

Signed-off-by: Frode Nordahl --- utilities/checkpatch.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 8c02ac3ce..de2420e1f 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -194,12 +194,12 @@ sk

Re: [ovs-dev] [PATCH 3/6] rhel: Remove RHEL 6 kernel module spec

On 7/7/2022 4:34 AM, David Marchand wrote: On Wed, Jul 6, 2022 at 7:05 PM Greg Rose wrote: Remove the RHEL 6 kernel driver module specification. Signed-off-by: Greg Rose --- rhel/automake.mk| 5 -- rhel/kmod-openvswitch-rhel6.spec.in | 123

Re: [ovs-dev] [PATCH ovn 1/3] Don't save original dst IP and Port to avoid megaflow unwildcarding.

On 7/7/22 18:21, Han Zhou wrote: > On Thu, Jul 7, 2022 at 8:55 AM Dumitru Ceara wrote: >> >> On 7/7/22 13:45, Dumitru Ceara wrote: >>> On 7/7/22 00:08, Han Zhou wrote: On Wed, Jul 6, 2022 at 8:45 AM Dumitru Ceara wrote: > > Hi Han, > > On 7/6/22 00:41, Han Zhou wrote: >>

Re: [ovs-dev] [PATCH ovn] northd: set svc_mon status to offline if port_binding released

Thanks Numan. Regards, Vladislav Odintsov > On 7 Jul 2022, at 19:57, Numan Siddique wrote: > > On Tue, Jul 5, 2022 at 1:54 PM Vladislav Odintsov > wrote: >> >> This patch fixes situation where a Load Balancer >> has corresponding Load_Balancer_Health_Check and >> cur

Re: [ovs-dev] [PATCH ovn] northd: set svc_mon status to offline if port_binding released

On Tue, Jul 5, 2022 at 1:54 PM Vladislav Odintsov wrote: > > This patch fixes situation where a Load Balancer > has corresponding Load_Balancer_Health_Check and > current checks are successful. This means > Service_Monitor record in SBDB has status == "online". > > In case VM (or container) stops

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Refactor simple match lookup functions.

> -Original Message- > From: Ferriter, Cian > Sent: Thursday, July 7, 2022 6:35 PM > To: ovs-dev@openvswitch.org > Cc: Van Haaren, Harry ; Pai G, Sunil > ; Ferriter, Cian > Subject: [PATCH v2 1/2] dpif-netdev: Refactor simple match lookup > functions. > > Make the simple match functio

Re: [ovs-dev] [PATCH v2 2/2] dpif-avx512: Add support for simple match lookup.

> -Original Message- > From: Ferriter, Cian > Sent: Thursday, July 7, 2022 6:35 PM > To: ovs-dev@openvswitch.org > Cc: Van Haaren, Harry ; Pai G, Sunil > ; Ferriter, Cian > Subject: [PATCH v2 2/2] dpif-avx512: Add support for simple match lookup. > > Perform scalar simple match lookup

Re: [ovs-dev] [PATCH ovn 1/3] Don't save original dst IP and Port to avoid megaflow unwildcarding.

On Thu, Jul 7, 2022 at 8:55 AM Dumitru Ceara wrote: > > On 7/7/22 13:45, Dumitru Ceara wrote: > > On 7/7/22 00:08, Han Zhou wrote: > >> On Wed, Jul 6, 2022 at 8:45 AM Dumitru Ceara wrote: > >>> > >>> Hi Han, > >>> > >>> On 7/6/22 00:41, Han Zhou wrote: > The ls_in_pre_stateful priority 120 f

Re: [ovs-dev] [v8 10/10] odp-execute: Add ISA implementation of set_masked IPv4 action

Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please ema

Re: [ovs-dev] [v8 09/10] odp-execute: Add ISA implementation of set_masked ETH

Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please ema

Re: [ovs-dev] [v8 08/10] odp-execute: Add ISA implementation of push_vlan action.

Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please ema

Re: [ovs-dev] [v8 07/10] odp-execute: Add ISA implementation of pop_vlan action.

Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please ema

Re: [ovs-dev] [v8 06/10] odp-execute: Add ISA implementation of actions.

Bleep bloop. Greetings Emma Finn, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv -f $depbase.Tpo $depbase.Plo libtool: compile: g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I ./include -I

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On 7/7/2022 2:30 AM, Ilya Maximets wrote: On 7/7/22 10:27, David Marchand wrote: Hi Greg, On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose wrote: On 7/6/2022 9:57 AM, Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux openvswitch

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On 7/7/2022 1:27 AM, David Marchand wrote: Hi Greg, On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose wrote: On 7/6/2022 9:57 AM, Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux openvswitch kernel driver in it's place [1]. Ther

Re: [ovs-dev] [PATCH ovn 1/3] Don't save original dst IP and Port to avoid megaflow unwildcarding.

On 7/7/22 13:45, Dumitru Ceara wrote: > On 7/7/22 00:08, Han Zhou wrote: >> On Wed, Jul 6, 2022 at 8:45 AM Dumitru Ceara wrote: >>> >>> Hi Han, >>> >>> On 7/6/22 00:41, Han Zhou wrote: The ls_in_pre_stateful priority 120 flow that saves dst IP and Port to registers is causing a critical

[ovs-dev] [v8 10/10] odp-execute: Add ISA implementation of set_masked IPv4 action

This commit adds support for the AVX512 implementation of the ipv4_set_addrs action as well as an AVX512 implementation of updating the checksums. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 208 +++ 1 file changed, 208 insertions(+) diff --git a/

[ovs-dev] [v8 09/10] odp-execute: Add ISA implementation of set_masked ETH

This commit includes infrastructure changes for enabling set_masked_X actions and also adds support for the AVX512 implementation of the eth_set_addrs action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 90 +++ lib/odp-execute-private.c | 14 +

[ovs-dev] [v8 08/10] odp-execute: Add ISA implementation of push_vlan action.

This commit adds the AVX512 implementation of the push_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 55 lib/odp-execute.c| 22 +--- 2 files changed, 68 insertions(+), 9 deletions(-) diff --git a/lib/odp-execute

[ovs-dev] [v8 07/10] odp-execute: Add ISA implementation of pop_vlan action.

This commit adds the AVX512 implementation of the pop_vlan action. Signed-off-by: Emma Finn --- lib/odp-execute-avx512.c | 153 +- lib/odp-execute-private.h | 2 +- 2 files changed, 153 insertions(+), 2 deletions(-) diff --git a/lib/odp-execute-avx512.c b/

[ovs-dev] [v8 06/10] odp-execute: Add ISA implementation of actions.

This commit adds the AVX512 implementation of the action functionality. Usage: $ ovs-appctl odp-execute/action-impl-set avx512 Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- Documentation/ref/ovs-actions.7.rst | 26 + Documentation/topics/testing.rst| 24

[ovs-dev] [v8 04/10] odp-execute: Add command to switch action implementation.

This commit adds a new command to allow the user to switch the active action implementation at runtime. Usage: $ ovs-appctl odp-execute/action-impl-set scalar This commit also adds a new command to retrieve the list of available action implementations. This can be used by to check what implemen

[ovs-dev] [v8 00/10] Actions Infrastructure + Optimizations

This patchset introduces actions infrastructure changes which allows the user to choose between different action implementations based on CPU ISA by using different commands. The infrastructure also provides a way to check the correctness of the ISA optimized action version against the scalar

[ovs-dev] [v8 05/10] dpif-netdev: Add configure option to enable actions autovalidator at build time.

From: Kumar Amber This commit adds a new command to allow the user to enable the actions autovalidator by default at build time thus allowing for running unit test by default. $ ./configure --enable-actions-default-autovalidator Signed-off-by: Kumar Amber Acked-by: Harry van Haaren --- NEWS

[ovs-dev] [v8 03/10] odp-execute: Add auto validation function for actions.

This commit introduced the auto-validation function which allows users to compare the batch of packets obtained from different action implementations against the linear action implementation. The autovalidator function can be triggered at runtime using the following command: $ ovs-appctl odp-exec

[ovs-dev] [v8 02/10] odp-execute: Add function pointer for pop_vlan action.

This commit removes the pop_vlan action from the large switch and creates a separate function for batched processing. A function pointer is also added to call the new batched function for the pop_vlan action. Signed-off-by: Emma Finn Acked-by: Harry van Haaren --- lib/odp-execute-private.c | 16

[ovs-dev] [v8 01/10] odp-execute: Add function pointers to odp-execute for different action implementations.

This commit introduces the initial infrastructure required to allow different implementations for OvS actions. The patch introduces action function pointers which allows user to switch between different action implementations available. This will allow for more performance and flexibility so the us

Re: [ovs-dev] [PATCH v7 02/11] odp-execute: Add function pointers to odp-execute for different action implementations.

On 7 Jul 2022, at 16:20, Finn, Emma wrote: >> -Original Message- >> From: Eelco Chaudron >> Sent: Thursday 7 July 2022 14:54 >> To: Finn, Emma >> Cc: Ilya Maximets ; Van Haaren, Harry >> ; d...@openvswitch.org; Stokes, Ian >> ; Flavio Leitner ; Mcnamara, John >> >> Subject: Re: [ovs-d

Re: [ovs-dev] [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

On Thu, Jul 07, 2022 at 10:08:33AM +0200, Greg KH wrote: [ ... ] > > > > Unverified Error/Warning (likely false positive, please contact us if > > interested): > > > > arch/x86/events/core.c:2114 init_hw_perf_events() warn: missing error code > > 'err' > > drivers/android/binder.c:1481:19-23:

Re: [ovs-dev] [PATCH v2] dpif-netdev: Simplify AVX512 build time checks to enhance readability.

> -Original Message- > From: Pai G, Sunil > Sent: Monday 4 July 2022 13:27 > To: d...@openvswitch.org > Cc: echau...@redhat.com; Finn, Emma ; Van Haaren, Harry > ; Ferriter, Cian > Subject: [PATCH v2] dpif-netdev: Simplify AVX512 build time checks to enhance > readability. > > The pr

Re: [ovs-dev] [PATCH v7 02/11] odp-execute: Add function pointers to odp-execute for different action implementations.

> -Original Message- > From: Eelco Chaudron > Sent: Thursday 7 July 2022 14:54 > To: Finn, Emma > Cc: Ilya Maximets ; Van Haaren, Harry > ; d...@openvswitch.org; Stokes, Ian > ; Flavio Leitner ; Mcnamara, John > > Subject: Re: [ovs-dev] [PATCH v7 02/11] odp-execute: Add function pointe

Re: [ovs-dev] [PATCH v7 02/11] odp-execute: Add function pointers to odp-execute for different action implementations.

On 7 Jul 2022, at 15:31, Finn, Emma wrote: > > Hi Eelco/Ilya, > > Thanks for the reviews. > > I have reworked this series based on all your feedback and I have a V8 ready > to > push. > > Checksum handling has been reworked to update checksum and not recalculate > And now follows the same met

Re: [ovs-dev] [PATCH v4 1/1] netdev-dpdk: Delay vhost mempool creation.

> Currently mempools for vhost are being assigned before the vhost device > is added. In some cases this may be just reusing an existing mempool but > in others it can require creation of a mempool. > > For multi-NUMA, the NUMA info of the vhost port is not known until a > device is added to the

Re: [ovs-dev] [PATCH v7 02/11] odp-execute: Add function pointers to odp-execute for different action implementations.

> -Original Message- > From: Ilya Maximets > Sent: Friday 1 July 2022 13:35 > To: Eelco Chaudron ; Van Haaren, Harry > ; Finn, Emma > Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian > ; Flavio Leitner ; Mcnamara, John > > Subject: Re: [ovs-dev] [PATCH v7 02/11] odp-execute: A

Re: [ovs-dev] [PATCH] python-c-ext: fix a couple of build warnings

On 6/30/22 12:32, Timothy Redaelli wrote: > ovs/_json.c:67:20: warning: assignment discards ‘const’ qualifier from pointer > target type [-Wdiscarded-qualifiers] > > ovs/_json.c:132:27: warning: comparison of integer expressions of different > signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int

Re: [ovs-dev] [PATCH v4 13/14] userspace: Add Generic Segmentation Offloading.

On Thu, Jul 7, 2022 at 7:03 AM David Marchand wrote: > > Hello Mike, > > > I did not review carefully yet. > Just two quick comments. > > > On Fri, Jul 1, 2022 at 5:58 AM Mike Pattrick wrote: > > > > From: Flavio Leitner > > > > This provides a software implementation in the case > > the egress

Re: [ovs-dev] [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

On 7/7/2022 4:08 PM, Greg KH wrote: On Thu, Jul 07, 2022 at 02:56:34PM +0800, kernel test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 088b9c375534d905a4d337c78db3b3bfbb52c4a0 Add linux-next specific files for 20220706 E

Re: [ovs-dev] [PATCH v2 3/6] debian: Update packaging source from Debian/Ubuntu.

On Thu, Jul 7, 2022 at 2:02 PM Frode Nordahl wrote: > > On Thu, Jul 7, 2022 at 1:00 PM Ilya Maximets wrote: [ snip ] > > And this one here: > > > > +Package: openvswitch-pki > > +Architecture: all > > +Depends: > > + openvswitch-common (<< ${source:Version}.1~), > > + openvswitch-common (>= ${s

[ovs-dev] [PATCH v2 2/2] dpif-avx512: Add support for simple match lookup.

Perform scalar simple match lookup in AVX512 DPIF by reusing the simple match lookup functions. The simple match lookup is placed in a separate per packet loop before the batch miniflow extract call since miniflow extract can be skipped when simple match is being used. Unsuccessful lookup during s

[ovs-dev] [PATCH v2 0/2] Add simple match lookup to the AVX512 DPIF.

Perform scalar simple match lookup in AVX512 DPIF by reusing the simple match lookup functions that are used in the scalar DPIF. This allows feature parity with the scalar DPIF and better lookup performance in the AVX512 DPIF for supported flows over existing lookup methods (6% faster than EMC for

[ovs-dev] [PATCH v2 1/2] dpif-netdev: Refactor simple match lookup functions.

Make the simple match functions used during lookup non-static to allow reuse of these functions in the AVX512 DPIF. Signed-off-by: Cian Ferriter Tested-by: Harry van Haaren --- v2: * Make the 3 simple match lookup function definitions non-static rather than moving the defitions to the lib/dpi

Re: [ovs-dev] [PATCH v4] ofproto/bond: Add knob "all_members_active"

Bleep bloop. Greetings Christophe Fontaine, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #43 FILE: ofproto/bond.c:129:

[ovs-dev] [PATCH v4] ofproto/bond: Add knob "all_members_active"

This config param allows the delivery of broadcast and multicast packets to the secondary interface of non-lacp bonds, equivalent to the option "all_slaves_active" for Linux kernel bonds. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1720935 Signed-off-by: Christophe Fontaine --- NEWS

[ovs-dev] [PATCH v4] ofproto/bond: Add knob "all_members_active"

Changes in v4: - Update the patch to address Ilya comments - removed test/bond.at and moved the added test to dpif-netdev.at - updated doc based on Eelco and Ilya comments Christophe ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.or

Re: [ovs-dev] [PATCH v2 3/6] debian: Update packaging source from Debian/Ubuntu.

On 7/7/22 14:02, Frode Nordahl wrote: > On Thu, Jul 7, 2022 at 1:00 PM Ilya Maximets wrote: >> One last thing is that we'll need to squash patches #1 and #3 in the >> end, otherwise build fails if only patch #1 is applied. Alternatively, >> automake can be adjusted to not try to evaluate debian/

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On Thu, Jul 7, 2022 at 11:31 AM Ilya Maximets wrote: > > On 7/7/22 10:27, David Marchand wrote: > > Hi Greg, > > > > On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose wrote: > >> On 7/6/2022 9:57 AM, Greg Rose wrote: > >>> It is time to remove support for the OVS kernel driver and push > >>> towards u

Re: [ovs-dev] [PATCH v2 3/6] debian: Update packaging source from Debian/Ubuntu.

On Thu, Jul 7, 2022 at 1:00 PM Ilya Maximets wrote: > > On 7/7/22 12:27, Frode Nordahl wrote: > > On Fri, Jul 1, 2022 at 4:09 PM Ilya Maximets wrote: > >> > >> On 6/29/22 15:52, Frode Nordahl wrote: > >>> * Update upstream OVS debian packaging to be on par with package > >>> source in Debian/Ub

Re: [ovs-dev] [v6 4/9] netdev-linux: Add functions to manipulate tc police action

On 7/7/22 13:51, Eelco Chaudron wrote: > On 2 Jul 2022, at 5:18, Jianbo Liu wrote: >> +static int >> +tc_update_policer_action_stats(struct ofpbuf *msg, >> + struct ofputil_meter_stats *stats) >> +{ >> +struct ovs_flow_stats stats_dropped = {0}; >> +struct ovs_

Re: [ovs-dev] [v6 0/9] Add support for ovs metering with tc offload

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > This series is to add support for tc offloading of ovs metering, and > enhance OVS to use new kernel feature which offload tc police action to > hardware. > To do the offloading, new APIs for meter are added in netdev-offload, > and OVS meters are mapp

Re: [ovs-dev] [v6 9/9] doc: Add meter offload topic document

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > Fow now, add introduction and the limitation of meter offload. > > Signed-off-by: Jianbo Liu > --- > Documentation/automake.mk | 1 + > Documentation/howto/index.rst | 1 + > Documentation/howto/tc-offload.rst | 75 +

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

On Wed, Jul 6, 2022 at 6:57 PM Greg Rose wrote: > > It is time to remove support for the OVS kernel driver and push > towards use of the upstream Linux openvswitch kernel driver > in it's place [1]. > > There are many Linux specific source modules in the datapath that > will need eventual removal

Re: [ovs-dev] [v6 8/9] dpif-netlink: Offloading meter to tc police action

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > OVS meters are created in advance and openflow rules refer to them by > their unique ID. New tc_police API is used to offload them. By calling > the API, police actions are created and meters are mapped to them. > These actions then can be used in tc fil

Re: [ovs-dev] [PATCH 1/6] acinclude.m4: Remove support for building the OVS kernel module

On Wed, Jul 6, 2022 at 7:02 PM Greg Rose wrote: > > Since the openvswitch project inception it has had support for building > a Linux kernel module to support the OVS kernel datapath. Since Linux > kernel release 5.8 support for newer kernels has been deprecated. Now > is the time to fully disco

Re: [ovs-dev] [v6 7/9] netdev-offload-tc: Offloading rules with police actions

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > When offloading rule, tc should be filled with police index, instead > of meter id. As meter is mapped to police action, and the mapping is > inserted into meter_id_to_police_idx hmap, this hmap is used to find > the police index. Besides, the reverse ma

Re: [ovs-dev] [v6 6/9] netdev-offload-tc: Cleanup police actions with reserved indexes on startup

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > As the police actions with indexes of 0x1000-0x1fff are > reserved for meter offload, to provide a clean environment for OVS, > these reserved police actions should be deleted on startup. So dump > all the police actions, delete those actions wit

Re: [ovs-dev] [v6 5/9] netdev-offload-tc: Implement meter offload API for tc

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > For dpif-netlink, meters are mapped by tc to police actions with > one-to-one relationship. Implement meter offload API to set/get/del > the police action, and a hmap is used to save the mappings. > An id-pool is used to manage all the available police i

Re: [ovs-dev] [PATCH v2 1/6] debian: Archive debian packaging source.

On Thu, Jul 7, 2022 at 1:22 PM David Marchand wrote: > > On Wed, Jun 29, 2022 at 3:53 PM Frode Nordahl > wrote: > > > > The packaging source in the OVS repository has drifted away from > > what is currently in Debian and Ubuntu. This state is problematic > > because from time to time someone tri

Re: [ovs-dev] [v6 4/9] netdev-linux: Add functions to manipulate tc police action

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > Add helpers to add, delete and get stats of police action with > the specified index. > > Signed-off-by: Jianbo Liu Two some small comments below... > --- > lib/netdev-linux.c | 144 + > lib/netdev-linux.h

Re: [ovs-dev] [v6 3/9] netdev-linux: Refactor put police action netlink message

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > To reuse the code for manipulating police action, move the common > initialization code to a function, and change PPS parameters as meter > pktps is in unit of packet per second. > > null_police is redundant because either BPS or PPS, not both, can be >

Re: [ovs-dev] [v6 2/9] tc: Add support parsing tc police action

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > Add function to parse police action from netlink message. > > Signed-off-by: Jianbo Liu > Acked-by: Eelco Chaudron No changes in this version, just explicitly ACKing it again. Acked-by: Eelco Chaudron

Re: [ovs-dev] [v6 1/9] netdev-offload: Add meter offload API

On 2 Jul 2022, at 5:18, Jianbo Liu wrote: > Add API to offload meter to HW, and the corresponding functions to call > the meter callbacks from all the registered flow API providers. > The interfaces are like those related to meter in dpif_class, in order > to pass necessary info to HW. > > Signed-

Re: [ovs-dev] [PATCH 2/6] rhel: Remove kernel mode spec

On Wed, Jul 6, 2022 at 7:05 PM Greg Rose wrote: > > Remove the kernel driver specification for RHEL 7.x, 8.x and Fedora. > > Signed-off-by: Greg Rose This leaves references to this specfile behind, see: Vagrantfile poc/playbook-fedora-builder.yml rhel/.gitignore Besides, rhel/openvswitch-dkms.s

Re: [ovs-dev] [PATCH ovn 1/3] Don't save original dst IP and Port to avoid megaflow unwildcarding.

On 7/7/22 00:08, Han Zhou wrote: > On Wed, Jul 6, 2022 at 8:45 AM Dumitru Ceara wrote: >> >> Hi Han, >> >> On 7/6/22 00:41, Han Zhou wrote: >>> The ls_in_pre_stateful priority 120 flow that saves dst IP and Port to >>> registers is causing a critical dataplane performance impact to >>> short-lived

Re: [ovs-dev] [PATCH 3/6] rhel: Remove RHEL 6 kernel module spec

On Wed, Jul 6, 2022 at 7:05 PM Greg Rose wrote: > > Remove the RHEL 6 kernel driver module specification. > > Signed-off-by: Greg Rose > --- > rhel/automake.mk| 5 -- > rhel/kmod-openvswitch-rhel6.spec.in | 123 > 2 files changed, 128 deletions(

Re: [ovs-dev] [PATCH ovn 4/4] multicast: Properly flood IGMP queries and reports.

On Thu, Jul 7, 2022 at 12:24 PM Lucas Alvares Gomes wrote: > > Hi, > > I tested this series of patches with OpenStack upstream [0] since we > have some automated tests for IGMP and it seems good: > > test_multicast_between_vms_on_same_network[id-113486fc-24c9-4be4-8361-03b1c9892867] > pass (link:

Re: [ovs-dev] [PATCH ovn 4/4] multicast: Properly flood IGMP queries and reports.

Hi, I tested this series of patches with OpenStack upstream [0] since we have some automated tests for IGMP and it seems good: test_multicast_between_vms_on_same_network[id-113486fc-24c9-4be4-8361-03b1c9892867] pass (link: https://98794ab76263ee253bc7-6b6bf6aa2495d781bdba3c8c61916451.ssl.cf1.rac

Re: [ovs-dev] [PATCH v2 1/6] debian: Archive debian packaging source.

On Wed, Jun 29, 2022 at 3:53 PM Frode Nordahl wrote: > > The packaging source in the OVS repository has drifted away from > what is currently in Debian and Ubuntu. This state is problematic > because from time to time someone tries to build packages from the > upstream OVS debian package source a

Re: [ovs-dev] [PATCH v2 5/6] python: Allow building json C extension with static OVS library.

On 7/7/22 12:28, Frode Nordahl wrote: > On Fri, Jul 1, 2022 at 4:56 PM Ilya Maximets wrote: >> >> On 6/29/22 15:52, Frode Nordahl wrote: >>> Allow caller of setup.py to pass in libopenvswitch.a as an object >>> for linking through the use of LDFLAGS environment variable when >>> not building a sha

  1   2   >