On Wed, Aug 17, 2022 at 6:54 PM Han Zhou wrote:
>
>
> On Mon, Aug 15, 2022 at 11:29 PM Ales Musil wrote:
> >
> >
> >
> > On Mon, Aug 15, 2022 at 6:51 PM Han Zhou wrote:
> >>
> >>
> >>
> >> On Thu, Aug 11, 2022 at 7:20 AM Ales Musil wrote:
> >> >
> >> > Add configuration option into NB global
On Thu, Aug 18, 2022 at 1:16 PM Wentao Jia wrote:
>
>
> Hi, Numan
>
> It is not difficult to reproduce，this is about snat/dnat rules
> create router and create different type of nat rules of this router
> no other issues to be considered。
>
Right. I now see the issue locally. I do see that the
Hi, Numan
It is not difficult to reproduce，this is about snat/dnat rules
create router and create different type of nat rules of this router
no other issues to be considered。
BR
Wentao Jia
-Original Message-
From: Numan Siddique
Sent: Thursday, August 18, 2022 10:30 AM
To: Wentao Jia
On Thu, Aug 18, 2022 at 12:16 PM Wentao Jia wrote:
>
>
> Hi, Numan
>
> This is snat rule bug，when a snat rule set，this issue is reproduced
> you can find the different between snat rule and dnat_and_snat rule
> Logical flow, ovs openflow and ovs datapath flow are all different
>
> network
On Thu, Aug 18, 2022 at 3:47 AM Lorenzo Bianconi
wrote:
>
> Introduce system test for the following fix:
> 'd9f69b2d7 ("controller: physical: fix regression for container ports")'
Thanks for the follow up patch to add the test case. I applied this
to the main branch.
Numan
>
> Signed-off-by:
Thanks for your review, It is indeed similar to the patch, I will testing and
reviewing the change.
yangch...@chinatelecom.cn
From: Ilya Maximets
Date: 2022-08-17 20:15
To: yangchang; dev
CC: i.maximets; Michael Pattrick
Subject: Re: [ovs-dev] [PATCH] bond: modify bond_link_status_update log
On Wed, Aug 17, 2022 at 6:01 PM Ales Musil wrote:
>
> On Tue, Aug 16, 2022 at 4:47 PM Dumitru Ceara wrote:
>
> > Reported by UndefinedBehaviorSanitizer when running in a sandbox:
> > controller/ovn-controller.c:374:21: runtime error: null pointer passed
> > as argument 2, which is declared to
On Thu, Aug 18, 2022 at 5:55 AM Mark Michelson wrote:
>
> Thanks for finding and fixing this!
>
> Acked-by: Mark Michelson
Thanks. I applied this patch to the main branch,
Numan
>
> On 8/15/22 03:16, wangchuanlei wrote:
> > In master branch, pointer ofpacts_p is modified or
> > cleared in
Hi, Numan
This is snat rule bug，when a snat rule set，this issue is reproduced
you can find the different between snat rule and dnat_and_snat rule
Logical flow, ovs openflow and ovs datapath flow are all different
network topology and nat rules in last mail is not enough to reproduce this?
The
bond link status change comes from carrier and LACP may_enable ,when
carrier does not change and LACP change, prompt of LACP will be more accurate.
Signed-off-by: yangchang
---
ofproto/bond.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/ofproto/bond.c
On Thu, Aug 11, 2022 at 4:57 PM Wentao Jia wrote:
>
> Hi, Numan
>
> Thanks for you reply.
>
> The network topology as follows:
>
> vm1 -> logical switch 1
> (192.168.200.165) \
>---> router -> extenel-net
> /
Bleep bloop. Greetings yangchang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#24 FILE: ofproto/bond.c:1896:
if (up ==
bond link status change comes from carrier and LACP may_enable ,when
carrier does not change and LACP change, prompt of LACP will be more accurate.
Signed-off-by: yangchang
---
ofproto/bond.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/ofproto/bond.c
On 8/18/22 01:15, Ilya Maximets wrote:
On 8/17/22 22:35, Andrey Zhadchenko wrote:
On 8/17/22 21:19, Ilya Maximets wrote:
On 8/17/22 14:49, Andrey Zhadchenko via dev wrote:
Hi!
CRIU currently do not support checkpoint/restore of OVS configurations, but
there was several requests for it.
On 8/17/22 22:35, Andrey Zhadchenko wrote:
>
>
> On 8/17/22 21:19, Ilya Maximets wrote:
>> On 8/17/22 14:49, Andrey Zhadchenko via dev wrote:
>>> Hi!
>>>
>>> CRIU currently do not support checkpoint/restore of OVS configurations, but
>>> there was several requests for it. For example,
>>>
On 8/17/22 21:19, Ilya Maximets wrote:
On 8/17/22 14:49, Andrey Zhadchenko via dev wrote:
Hi!
CRIU currently do not support checkpoint/restore of OVS configurations, but
there was several requests for it. For example,
https://github.com/lxc/lxc/issues/2909
The main problem is ifindexes of
Thanks Olaf and Ales, I have merged this to main, branch-22.06, and
branch-22.03.
On 8/17/22 03:59, Ales Musil wrote:
On Wed, Aug 17, 2022 at 9:59 AM Olaf Seibert via dev <
ovs-dev@openvswitch.org> wrote:
Commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 cloned the external_ids
to ids, then
Thanks Ihar, I pushed both patches to branch-22.03.
On 8/17/22 13:25, Ihar Hrachyshka wrote:
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Conflicts:
controller/binding.c
Signed-off-by: Ihar Hrachyshka
Acked-by: Mark Michelson
Thanks Ihar, I pushed both patches to branch-22.06
On 8/17/22 13:25, Ihar Hrachyshka wrote:
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Signed-off-by: Ihar Hrachyshka
Acked-by: Mark Michelson
Signed-off-by: Numan Siddique
(cherry
Thanks for finding and fixing this!
Acked-by: Mark Michelson
On 8/15/22 03:16, wangchuanlei wrote:
In master branch, pointer ofpacts_p is modified or
cleared in setup_activation_strategy will lead the
following codes to unexpected exceptions.
Signed-off-by: wangchuanlei
---
Thanks Ales and everyone that helped review this series.
Because this lost a merge race to Ilya's
https://patchwork.ozlabs.org/project/ovn/patch/20220803144349.3868591-1-i.maxim...@ovn.org/
, I updated the schema version in patch 1 to 20.25.0 and updated the
cksum so it would compile.
I
Thanks Ilya and Ales.
I removed the paragraph about ovn-northd from the commit message and
replaced it with the suggested bullet point.
I then pushed the change to the main branch.
On 8/9/22 04:31, Ales Musil wrote:
On Wed, Aug 3, 2022 at 4:44 PM Ilya Maximets wrote:
Some CMSes, like
On 8/17/22 14:49, Andrey Zhadchenko via dev wrote:
> Hi!
>
> CRIU currently do not support checkpoint/restore of OVS configurations, but
> there was several requests for it. For example,
> https://github.com/lxc/lxc/issues/2909
>
> The main problem is ifindexes of newly created interfaces. We
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Introduce system test for the following fix:
'd9f69b2d7 ("controller: physical: fix regression for container ports")'
Signed-off-by: Lorenzo Bianconi
---
tests/system-ovn.at | 63 +
1 file changed, 63 insertions(+)
diff --git a/tests/system-ovn.at
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Thanks for bringing this up to Mark and Han. I just posted 22.06 and
22.03 branch backport series in case they are ok'ed to go.
Ihar
On Sun, Aug 14, 2022 at 8:53 PM Numan Siddique wrote:
>
> On Thu, Aug 11, 2022 at 4:07 AM Ihar Hrachyshka wrote:
> >
> > Numan, thank you!
> >
> > Is it backport
When multiple chassis are fighting for the same port (requested-chassis
is not set, e.g. for gateway ports), they may produce an unreasonable
number of chassis field updates in a very short time frame (hundreds of
updates in several seconds). This puts unnecessary load on OVN as well
as any db
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Conflicts:
controller/binding.c
Signed-off-by: Ihar Hrachyshka
Acked-by: Mark Michelson
Signed-off-by: Numan Siddique
(cherry picked from commit
When multiple chassis are fighting for the same port (requested-chassis
is not set, e.g. for gateway ports), they may produce an unreasonable
number of chassis field updates in a very short time frame (hundreds of
updates in several seconds). This puts unnecessary load on OVN as well
as any db
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Signed-off-by: Ihar Hrachyshka
Acked-by: Mark Michelson
Signed-off-by: Numan Siddique
(cherry picked from commit 3103487e087b27b1b3577afba016403fd1ac3093)
---
controller/binding.c | 246
On Wed, Aug 17, 2022 at 7:41 AM Dumitru Ceara wrote:
> On 8/17/22 09:18, Ales Musil wrote:
> > It can happen that northd and SB DB are updated before ovn-controller
> > in that case the new MAC binding would be added with timestamp=0.
> > In combination with enabled MAC binding aging, the
On Mon, Aug 15, 2022 at 11:29 PM Ales Musil wrote:
>
>
>
> On Mon, Aug 15, 2022 at 6:51 PM Han Zhou wrote:
>>
>>
>>
>> On Thu, Aug 11, 2022 at 7:20 AM Ales Musil wrote:
>> >
>> > Add configuration option into NB global table
>> > called "mac_binding_removal_limit" defaulting to 0.
>> > This
Registration for the annual fall OVS+OVN conference, taking place this
year in the Boston area from November 8 to 10 and hosted by Red Hat,
Inc. is now open. The registration link may be found at:
https://www.eventbrite.com/e/ovsovn-2022-fall-conference-tickets-403901198357
Please note that
On Mon, Aug 15, 2022 at 11:34 PM Ales Musil wrote:
>
>
>
> On Tue, Aug 16, 2022 at 4:14 AM Numan Siddique wrote:
>>
>> On Tue, Aug 16, 2022 at 3:07 AM Han Zhou wrote:
>> >
>> > On Mon, Aug 15, 2022 at 1:23 AM Dumitru Ceara
wrote:
>> > >
>> > > On 8/15/22 08:46, Numan Siddique wrote:
>> > > > "
On Wed, Aug 17, 2022 at 03:49:09PM +0300, Andrey Zhadchenko wrote:
> CRIU is preserving ifindexes of net devices after restoration. However,
> current Open vSwitch API does not allow to target ifindex, so we cannot
> correctly restore OVS configuration.
>
> Use ovs_header->dp_ifindex during
On Wed, Aug 17, 2022 at 03:49:08PM +0300, Andrey Zhadchenko wrote:
> Hi!
>
> CRIU currently do not support checkpoint/restore of OVS configurations, but
> there was several requests for it. For example,
> https://github.com/lxc/lxc/issues/2909
Ah right, I remember that. :)
>
> The main problem
CRIU is preserving ifindexes of net devices after restoration. However,
current Open vSwitch API does not allow to target ifindex, so we cannot
correctly restore OVS configuration.
Use ovs_header->dp_ifindex during OVS_DP_CMD_NEW as desired ifindex.
Use OVS_VPORT_ATTR_IFINDEX during
Hi!
CRIU currently do not support checkpoint/restore of OVS configurations, but
there was several requests for it. For example,
https://github.com/lxc/lxc/issues/2909
The main problem is ifindexes of newly created interfaces. We realy need to
preserve them after restore. Current openvswitch API
On 7/25/22 23:34, Han Zhou wrote:
> When ovn-controller is restarted, it may need multiple iterations of
> main loop before completely download all related data from SB DB,
> especially when ovn-monitor-all=false, so after restart, before it sees
> the related localnet ports from SB DB, it treats
On 8/9/22 08:46, Frode Nordahl wrote:
> On Sat, Aug 6, 2022 at 1:49 AM Han Zhou wrote:
>>
>>
>>
>> On Thu, Aug 4, 2022 at 7:09 AM Dumitru Ceara wrote:
>>>
>>> On 7/25/22 23:34, Han Zhou wrote:
Also remove the reset mechanism when DB is reconnected, because at DB
reconnection the data
On 7/25/22 23:34, Han Zhou wrote:
> When ovn-controller is restarted, it may need multiple iterations of
> main loop before completely download all related data from SB DB,
> especially when ovn-monitor-all=false, so after restart, before it sees
> the related localnet ports from SB DB, it treats
On 7/25/22 23:34, Han Zhou wrote:
> In some cases we need to know if ovn-controller started long enough and
> has enough iterations of input processing, primarily to ensure it has
> downloaded and handled a complete initial view of the SB DB (and of
> course the local OVS DB), so that it won't
On 7/25/22 23:34, Han Zhou wrote:
> When handling port_binding changes, it is possible that new
> local_datapaths are added, and the fields of the local_datapath, such as
> localnet_port, external_ports, etc. need to be updated for the newly
> added local_datapaths.
>
> This problem doesn't
Currently queue_userspace_packet will call kfree_skb for all frames,
whether or not an error occurred. This can result in a single dropped
frame being reported as multiple drops in dropwatch. This functions
caller may also call kfree_skb in case of an error. This patch will
consume the skbs
Frames sent to userspace can be reported as dropped in
ovs_dp_process_packet, however, if they are dropped in the netlink code
then netlink_attachskb will report the same frame as dropped.
This patch checks for error codes which indicate that the frame has
already been freed.
Signed-off-by: Mike
On 8/17/22 09:18, Ales Musil wrote:
> It can happen that northd and SB DB are updated before ovn-controller
> in that case the new MAC binding would be added with timestamp=0.
> In combination with enabled MAC binding aging, the affected rows
> would be deleted over and over until the controller
On 8/17/22 13:45, yangchang wrote:
> bond link status change comes from carrier and lacp may_enable ,when
> carrir does not change and lacp change, prompt of LACP will be more accurate.
>
> Signed-off-by: yangchang
> ---
> ofproto/bond.c | 10 --
> 1 file changed, 8 insertions(+), 2
On 8/16/22 15:27, Simon Horman wrote:
> On Tue, Aug 16, 2022 at 03:15:38PM +0200, Ilya Maximets wrote:
>> On 8/16/22 14:50, Simon Horman wrote:
>>> Chaoyong He says:
>>>
>>> This PR is the updates rte_flow phases 1 and 2 for OVS-DPDK:
>>>
>>> * Support offload of set IPv4/IPv6 DSCP action
>>> *
Bleep bloop. Greetings yangchang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib
bond link status change comes from carrier and lacp may_enable ,when
carrir does not change and lacp change, prompt of LACP will be more accurate.
Signed-off-by: yangchang
---
ofproto/bond.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/ofproto/bond.c
References: <20220817112948.59356-1-simon.hor...@corigine.com>
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected
From: Tianyu Yuan
When we apply meter police on both directions of TCP traffic, the
dumped stats is shown same (as shown below). This issue is introduced
by modifying the stats update strategy.
...,in_port(6),eth(),eth_type(0x0800),ipv4(frag=no), packets:1488557,
bytes:2089059644, used:0.040s,
Bleep bloop. Greetings yangchang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed patch
On 8/17/22 11:32, ychen wrote:
> hi,
>when we send 2 packets with different dest mac in 10s(fast datapath flow
> aging time), with the same userspace flow action, but the second packet act
> incorrectly.
>
> 1. problem phenomenon:
> userspace flow:
>
bond link status change comes from carrier and lacp may_enable ,when
carrir does not change and lacp change, prompt of LACP will be more accurate.
Signed-off-by: yangchang
---
lib/bond.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/bond.c b/lib/bond.c
index
hi,
when we send 2 packets with different dest mac in 10s(fast datapath flow
aging time), with the same userspace flow action, but the second packet act
incorrectly.
1. problem phenomenon:
userspace flow:
when segmentation fault occured in ovn-northd,monitor will try to
restart the ovn-northd daemon process every 10s.
Assume the following scenarios: There is a segmentation fault and
the ovn-northd daemon process does not restart properly everytime.
New fds are created each time the ovn-northd
On Tue, Aug 16, 2022 at 12:57 PM Mohammad Heib wrote:
> The local_datapath->peer_ports list contains peers pointers
> to lsp<-->lrp ports that are supposed to be router end ports,
> those pointers are added and deleted to the local_datapath->peer_ports
> when logical switch port of type router
On Tue, Aug 16, 2022 at 4:47 PM Dumitru Ceara wrote:
> Reported by UndefinedBehaviorSanitizer when running in a sandbox:
> controller/ovn-controller.c:374:21: runtime error: null pointer passed
> as argument 2, which is declared to never be null
> /usr/include/string.h:44:28: note: nonnull
On Wed, Aug 17, 2022 at 9:59 AM Olaf Seibert via dev <
ovs-dev@openvswitch.org> wrote:
> Commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 cloned the external_ids
> to ids, then passed them to sbrec_port_binding_set_external_ids().
> The intermediate step is unneeded (and caused a memory leak).
>
Commit 7b56f69580e1f390d9c6753a2cb8f0dbfbb4c467 cloned the external_ids
to ids, then passed them to sbrec_port_binding_set_external_ids().
The intermediate step is unneeded (and caused a memory leak).
Pass the external_ids directly.
Signed-off-by: Olaf Seibert
---
northd/northd.c | 4 +---
1
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#128 FILE: ovn-nb.xml:166:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#99 FILE: northd/inc-proc-northd.c:227:
/* XXX: The
On Tue, Aug 16, 2022 at 1:07 PM Dumitru Ceara wrote:
> On 8/16/22 08:33, Ales Musil wrote:
> > It can happen that northd and SB DB are updated before ovn-controller
> > in that case the new MAC binding would be added with timestamp=0.
> > In combination with enabled MAC binding aging, the
On Tue, Aug 16, 2022 at 1:26 PM Dumitru Ceara wrote:
> On 8/16/22 13:05, Dumitru Ceara wrote:
> > On 8/16/22 08:33, Ales Musil wrote:
> >> Add MAC binding aging mechanism, that utilizes
> >> the timestamp column of MAC_Binding table.
> >> When the MAC binding exceeds the threshold it is
> >>
It can happen that northd and SB DB are updated before ovn-controller
in that case the new MAC binding would be added with timestamp=0.
In combination with enabled MAC binding aging, the affected rows
would be deleted over and over until the controller is upgraded.
To prevent the before mentioned
Add configuration option into NB global table
called "mac_binding_removal_limit" defaulting to 0.
This option allows to limit number of MAC bindings
that can be removed by the aging mechanism in a single
transaction. The 0 means that the mechanism is disabled.
If the limit is reached next removal
The struct ovn_datapath could not be used outside the northd.c
move it to northd.h that it can be used by other .c files later on.
Reported-at: https://bugzilla.redhat.com/2084668
Acked-by: Dumitru Ceara
Acked-by: Mark Michelson
Acked-by: Han Zhou
Signed-off-by: Ales Musil
---
v7: Rebase on
Add MAC binding aging mechanism, that utilizes
the timestamp column of MAC_Binding table.
When the MAC binding exceeds the threshold it is
removed from SB DB, this is postponed only in case
we receive update ARP with update to MAC address.
The threshold is configurable via option
Add helper source file for creating index
over MAC binding table.
Reported-at: https://bugzilla.redhat.com/2084668
Acked-by: Dumitru Ceara
Acked-by: Mark Michelson
Acked-by: Han Zhou
Signed-off-by: Ales Musil
---
v7: Rebase on top of current main.
---
controller/ovn-controller.c | 8
The new timestamp column in MAC_Binding is
populated with current time whenever the row is
created or the MAC address is updated.
This can be utilized by MAC binding aging mechanism,
when we can check if enough time has passed since the
creation/update.
Reported-at:
Add MAC binding aging mechanism, that
should take care of stale MAC bindings.
The mechanism is configurable per logical
router, with option called
"mac_binding_age_threshold", which is 0 by
default. The zero also indicates that the
aging mechanism is disabled.
The aging is based on timestamp in
In PMD, cycle cost for each rxq is saved so that we know each rxq's
load. But rxq that doesn't receive a packet is skipped. In fact,
polling no-packet rxq costs cycles as well. In my test, 100w pps
rxq(vhostuser) cost cycles 87,553,850,086 while no-packet rxq costs
cycles 353,402,306.
In asign
On 2022-08-14 5:45 PM, Ilya Maximets wrote:
'wc.masks.tunnel.metadata.present.len' must be a mask for the same
field in the flow key, but in the tc_flower structure it's the real
length of metadata masks.
That is correctly handled for the individual opt->length, setting all
the masks to 0x1f
On 2022-08-14 5:46 PM, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores everything it doesn't understand. This is
causing, for example, offloaded ERSPAN tunnels to not work, because
flow is offloaded, but ERSPAN options are not
78 matches
Mail list logo
