Re: [ovs-dev] [PATCH ovn] tests: Add missing ovn_wait_remote_input_flows() implementation.

2022-09-01 Thread Dumitru Ceara
On 9/1/22 22:17, Dumitru Ceara wrote: > This implementation was removed by accident between V4 [0] and V5 [1] > of a7c7d4519e50 ("controller: avoid recomputes triggered by SBDB > Port_Binding updates."). > > [0] >

[ovs-dev] [PATCH ovn] tests: Add missing ovn_wait_remote_input_flows() implementation.

2022-09-01 Thread Dumitru Ceara
This implementation was removed by accident between V4 [0] and V5 [1] of a7c7d4519e50 ("controller: avoid recomputes triggered by SBDB Port_Binding updates."). [0] https://patchwork.ozlabs.org/project/ovn/patch/20220819151853.2149088-1-xsimo...@redhat.com/ [1]

Re: [ovs-dev] [PATCH] rhel: Update the spec file and distribution docs.

2022-09-01 Thread Flavio Leitner
Hi, If I recall correctly, the openvswitch-dpdk package was obsoleted in 2016 in favor of having only one package with dpdk enabled. Of course, upstream can decide whether it makes sense to follow that or not. Another thing is that openvswitch-fedora.spec should work much better with RHEL-8

[ovs-dev] [PATCH v3] tests: Use _DAEMONIZE macro's to start tcpdump.

2022-09-01 Thread Eelco Chaudron
Using [NETNS|OVS]_DAEMONIZE will start tcpdump in the background, and it will also make sure it gets killed in corner cases. For the check_pkt_len tests, we also kill tcpdump between individual tests in the same test case to avoid confusion when analyzing results. This also required some changes

[ovs-dev] [PATCH] ofproto-dpif-upcall: Print more data on unassociated datapath ports.

2022-09-01 Thread Ilya Maximets
When OVS fails to find an OpenFlow port for a packet received from the upcall it just prints the warning like this: |INFO|received packet on unassociated datapath port N However, during the flow translation more information is available as if the recirculation id wasn't found or it was a

[ovs-dev] [PATCH] rhel: Update the spec file and distribution docs.

2022-09-01 Thread Ilya Maximets
'openvswitch' and 'openvswitch-dpdk' packages are not available starting with RHEL 8. The only option to get an official OVS build is to use FDP repository, which is not available with the default RHEL subscription. Also, the spec file is outdated. We need python3, not python2. Some headers are

Re: [ovs-dev] [PATCH v2] ovs-tcpdump: Cleanup mirror port on SIGHUP/SIGTERM

2022-09-01 Thread Ilya Maximets
On 8/31/22 21:45, Mike Pattrick wrote: > On Thu, Aug 25, 2022 at 6:14 AM Daniel Ding wrote: >> >> If ovs-tcpdump received HUP or TERM signal, mirror and mirror >> interface should be destroyed. This often happens, when >> controlling terminal is closed, like ssh session closed, and >> other users

Re: [ovs-dev] [PATCH v2] tests: Use NETNS_DAEMONIZE instead of NS_CHECK_EXEC to start tcpdump.

2022-09-01 Thread David Marchand
On Thu, Sep 1, 2022 at 3:33 PM Eelco Chaudron wrote: > >> -AT_CHECK([cat p3.pcap | awk '{print $NF}' | uniq -c | awk > >> '{$1=$1;print}'], [0], [dnl > >> +AT_CHECK([cat p3.pcap | awk 'NF{print $NF}' | uniq -c | awk > >> '{$1=$1;print}'], [0], [dnl > > > > I don't see the relation with

Re: [ovs-dev] [PATCH v2] tests: Use NETNS_DAEMONIZE instead of NS_CHECK_EXEC to start tcpdump.

2022-09-01 Thread Eelco Chaudron
On 1 Sep 2022, at 14:11, David Marchand wrote: > On Wed, Aug 31, 2022 at 1:21 PM Eelco Chaudron wrote: >> >> Using NETNS_DAEMONIZE will start tcpdump in the background, and it will >> also make sure it gets killed in corner cases. >> >> For the check_pkt_len tests, we also kill tcpdump between

[ovs-dev] [PATCH ovn] ovn-nbctl: Simplify load balancer related code.

2022-09-01 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- Note: this change is just cosmetic, no functionality should be affected by it. --- utilities/ovn-nbctl.c | 50 ++- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/utilities/ovn-nbctl.c

Re: [ovs-dev] [PATCH v2] tests: Use NETNS_DAEMONIZE instead of NS_CHECK_EXEC to start tcpdump.

2022-09-01 Thread David Marchand
On Wed, Aug 31, 2022 at 1:21 PM Eelco Chaudron wrote: > > Using NETNS_DAEMONIZE will start tcpdump in the background, and it will > also make sure it gets killed in corner cases. > > For the check_pkt_len tests, we also kill tcpdump between individual > tests in the same test case to avoid

[ovs-dev] [PATCH v3] netdev-dpdk: fix tx_dropped counters value

2022-09-01 Thread Robin Jarry
Packets that could not be transmitted because the TXQ are full should be taken into account in the global ovs_tx_failure_drops as it was the case before commit 29b94e12d57d ("netdev-dpdk: Refactor the DPDK transmit path."). netdev_dpdk_eth_tx_burst() returns the number of packets that were *not*

Re: [ovs-dev] [PATCH v2] netdev-dpdk: fix tx_dropped counters value

2022-09-01 Thread Robin Jarry
Hi Mike, Mike Pattrick, Aug 31, 2022 at 18:09: > On Wed, Aug 3, 2022 at 4:58 AM Robin Jarry wrote: > > dropped += netdev_dpdk_eth_tx_burst(dev, qid, pkts, cnt); > > +stats.tx_failure_drops += dropped; > > Hello Robin, > > I think this will double count tx_failure_drops if there were any

Re: [ovs-dev] [PATCH] github: Skip debian packaging for dpdk-latest.

2022-09-01 Thread Stokes, Ian
> > On 8/25/22 14:52, David Marchand wrote: > > > Debian packaging target builds OVS against a packaged DPDK version. > > > As a result, it is not relevant in the dpdk-latest branch which follows > > > DPDK development branch. > > > > > > Signed-off-by: David Marchand > > > --- > > >

Re: [ovs-dev] [PATCH] github: Skip debian packaging for dpdk-latest.

2022-09-01 Thread David Marchand
On Wed, Aug 31, 2022 at 2:29 PM Ilya Maximets wrote: > > On 8/25/22 14:52, David Marchand wrote: > > Debian packaging target builds OVS against a packaged DPDK version. > > As a result, it is not relevant in the dpdk-latest branch which follows > > DPDK development branch. > > > > Signed-off-by: