Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Fix bond port unable to capture jumbo frames.

2022-10-11 Thread Ilya Maximets
On 10/10/22 22:07, Aaron Conole wrote: > mit...@outlook.com writes: > >> From: Lin Huang >> >> Currently the ovs-tcpdump utility creates a tap port to capture the >> frames of a bond port. >> >> If a user want to capture the packets from the bond port which member >> interface's mtu is more than

Re: [ovs-dev] [PATCH] ovsdb: Fix race for datum JSON string reference counter.

2022-10-11 Thread Ilya Maximets
On 10/10/22 17:13, Dumitru Ceara wrote: > On 10/10/22 15:11, Ilya Maximets wrote: >> Compaction thread supposed to not change anything in the database >> it is working on, since the same data can be accessed by the main >> thread at the same time. However, while converting database rows >> to

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Print more data on unassociated datapath ports.

2022-10-11 Thread Ilya Maximets
On 9/29/22 18:40, Mike Pattrick wrote: > On Thu, Sep 1, 2022 at 11:43 AM Ilya Maximets wrote: >> >> When OVS fails to find an OpenFlow port for a packet received >> from the upcall it just prints the warning like this: >> >> |INFO|received packet on unassociated datapath port N >> >> However,

Re: [ovs-dev] [PATCH] json: Fix deep copy of objects and arrays.

2022-10-11 Thread Ilya Maximets
On 10/10/22 17:13, Dumitru Ceara wrote: > On 7/1/22 13:11, Ilya Maximets wrote: >> When reference counting for json objects was introduced the >> old json_clone() function became json_deep_clone(), but it >> still calls shallow json_clone() while cloning objects and >> arrays not really producing

[ovs-dev] [PATCH v5 ovn 7/7] Document experimental support for co-hosted controllers

2022-10-11 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- NEWS| 2 ++ controller/ovn-controller.8.xml | 12 2 files changed, 14 insertions(+) diff --git a/NEWS b/NEWS index 224a7b83e..63afcea9d 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ Post v22.09.0 - + -

[ovs-dev] [PATCH v5 ovn 6/7] Add connectivity test for 2 controllers on the same host

2022-10-11 Thread Ihar Hrachyshka
Signed-off-by: Ihar Hrachyshka --- tests/ovn.at | 123 +++ 1 file changed, 123 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 3c76ba49c..1d69de96e 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -33170,3 +33170,126 @@

[ovs-dev] [PATCH v5 ovn 5/7] Don't touch tunnel ports from a different br-int

2022-10-11 Thread Ihar Hrachyshka
When multiple controllers are running using the same vswitchd, controllers should delete only those tunnel ports that belong to the integration bridge that is managed by the controller instance. This makes sure multiple controllers don't step on each other when running using the same vswitchd

[ovs-dev] [PATCH v5 ovn 3/7] Allow to override system-id via file

2022-10-11 Thread Ihar Hrachyshka
Before the patch, system-id could be configured via a global config option in ovsdb. This patch adds another option - configure system-id via a file. This is achieved by writing the desired system-id into the following file location: ${OVN_SYSCONFDIR}/system-id-override. The file is read on

[ovs-dev] [PATCH v5 ovn 2/7] Support ovn-...- specific global ovsdb options

2022-10-11 Thread Ihar Hrachyshka
Before the patch, all controller instances were reading configuration from the same external-ids:ovn-* options. This patch adds support for distinct config otions for different chassis names stored in the same ovsdb global config object. To configure an option for a distinct chassis name, an

[ovs-dev] [PATCH v5 ovn 1/7] Include "chassis index" into tunnel port name

2022-10-11 Thread Ihar Hrachyshka
This is in preparation to support multiple separate controller instances with distinct chassis names operating on the same vswitchd instance. To avoid conflicts, this patch introduces a unique "index" (from 0-9a-z range) into the port name. Each chassis allocates a separate index for itself on

[ovs-dev] [PATCH v5 ovn 4/7] Support passing chassis name via CLI

2022-10-11 Thread Ihar Hrachyshka
This patch adds support for the desired system-id (chassis name) to be passed via CLI: $ ovn-controller -n If passed, CLI overrides any settings stored in ovsdb or in system-id-override file. This may be useful when running multiple controller instances using the same vswitchd instance.

[ovs-dev] [PATCH v5 ovn 0/7] Support 2+ controllers on the same vswitchd

2022-10-11 Thread Ihar Hrachyshka
v1: initial series v2: change tunnel port naming scheme: include "chassis index" instead of its name for source chassis. v2: formatting adjustments. v3: fixed build due to ovs_abort missing arguments. v3: added documentation to CLI and system-id-override file. v3: added documentation for

Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper

2022-10-11 Thread Xin Long
On Tue, Oct 11, 2022 at 10:06 AM Aaron Conole wrote: > > Aaron Conole writes: > > > Xin Long writes: > > > >> A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > >> applies on a confirmed connection: > >> > >> WARNING: CPU: 0 PID: 1251 at

Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper

2022-10-11 Thread Aaron Conole
Aaron Conole writes: > Xin Long writes: > >> A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' >> applies on a confirmed connection: >> >> WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 >> RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack] >> Call

Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper

2022-10-11 Thread Aaron Conole
Xin Long writes: > A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > applies on a confirmed connection: > > WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 > RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack] > Call Trace: > >

Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper

2022-10-11 Thread Paolo Abeni
Hello, On Thu, 2022-10-06 at 15:45 -0400, Xin Long wrote: > A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > applies on a confirmed connection: > > WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 > RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack]

Re: [ovs-dev] [PATCH v6 6/9] dpif-mfex: Modify set/get MFEX commands to include inner.

2022-10-11 Thread Ferriter, Cian
Hi Sunil, I'll respin the patch set based on these documentation comments with your Ack. Thanks, Cian > -Original Message- > From: dev On Behalf Of Pai G, Sunil > Sent: Tuesday 11 October 2022 11:52 > To: Amber, Kumar ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org; Amber, Kumar ; >

Re: [ovs-dev] [PATCH v6 6/9] dpif-mfex: Modify set/get MFEX commands to include inner.

2022-10-11 Thread Pai G, Sunil
Hi Amber, One comment below , rest looks good to me. > -Original Message- > From: dev On Behalf Of Kumar Amber > Sent: Thursday, October 6, 2022 3:54 PM > To: ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar > > Subject: [ovs-dev] [PATCH v6 6/9]

Re: [ovs-dev] [PATCH] netdev-linux: Allow meter to work in tc software datapath

2022-10-11 Thread 0-day Robot
References: <20221011093527.367783-1-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected

[ovs-dev] [PATCH] netdev-linux: Allow meter to work in tc software datapath

2022-10-11 Thread Simon Horman
From: Baowen Zheng Add tc action flags when adding police action to offload meter table. There is a restriction that the flag of skip_sw/skip_hw should be same for filter rule and the independent created tc actions the rule uses. In this case, if we configure the tc-policy as skip_hw, filter

Re: [ovs-dev] [PATCH] tests: fix reference output for meter offload stats

2022-10-11 Thread Simon Horman
On Fri, Oct 07, 2022 at 01:37:45PM +0200, Eelco Chaudron wrote: > > > On 15 Sep 2022, at 14:03, Ilya Maximets wrote: > > > On 9/15/22 13:56, Ilya Maximets wrote: > >> On 9/15/22 13:38, Tianyu Yuan wrote: > >>> > >>> On 9/15/22 19:28, Ilya Maximets wrote: ... > This looks very strange to

Re: [ovs-dev] [PATCH ovn v3 2/3] northd: add drop-debug-mode to add explicit drops

2022-10-11 Thread Adrian Moreno
On 10/10/22 18:12, Dumitru Ceara wrote: On 10/10/22 17:55, Adrian Moreno wrote: On 10/10/22 13:56, Dumitru Ceara wrote: On 9/27/22 09:31, Adrian Moreno wrote: Add a new config flag called "drop-debug-mode" that makes northd add an explicit default drop to all tables that currently do not

[ovs-dev] [PATCH v5 1/1] userspace: Add SRv6 tunnel support.

2022-10-11 Thread Nobuhiro MIKI
SRv6 (Segment Routing IPv6) tunnel vport is responsible for encapsulation and decapsulation the inner packets with IPv6 header and an extended header called SRH (Segment Routing Header). See spec in: https://datatracker.ietf.org/doc/html/rfc8754 This patch implements SRv6 tunneling in userspace