Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

On Tue, Oct 25, 2022 at 5:51 AM Han Zhou wrote: > > > On Sun, Oct 23, 2022 at 10:21 PM Ales Musil wrote: > > > > > > > > On Sun, Oct 23, 2022 at 10:16 PM Han Zhou wrote: > >> > >> > >> > >> On Fri, Oct 21, 2022 at 1:37 AM Ales Musil wrote: > >> > > >> > Run ovs_list_init on list_node from

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix some issues with CT zone assignment.

On Mon, Oct 24, 2022 at 9:18 PM Mark Michelson wrote: > On 10/24/22 04:43, Ales Musil wrote: > > > > > > On Mon, Oct 24, 2022 at 8:53 AM Ales Musil > > wrote: > > > > Hi Mark, > > > > please see my comment below. > > > > Thanks for the review. > > > > > On

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

On Mon, Oct 24, 2022 at 5:22 PM Xavier Simonart wrote: > In the following scenario: > - interface "old" is created and external_ids:iface-id is set (to lp) > - interface "new" is created and external_ids:iface-id is set (to same lp) > - interface "old" is deleted > flows related to lp were

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

On Sun, Oct 23, 2022 at 10:21 PM Ales Musil wrote: > > > > On Sun, Oct 23, 2022 at 10:16 PM Han Zhou wrote: >> >> >> >> On Fri, Oct 21, 2022 at 1:37 AM Ales Musil wrote: >> > >> > Run ovs_list_init on list_node from desired flow. >> > Not doing that can potentially cause crash on >> >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix some issues with CT zone assignment.

On 10/24/22 04:43, Ales Musil wrote: On Mon, Oct 24, 2022 at 8:53 AM Ales Musil > wrote: Hi Mark, please see my comment below. Thanks for the review. On Fri, Oct 21, 2022 at 8:38 PM Mark Michelson mailto:mmich...@redhat.com>> wrote: An

Re: [ovs-dev] [PATCH v2 1/1] lib: Correct the stats of packet_count and byte_count on Windows

On 10/21/22 17:53, Wilson Peng wrote: > From: Wilson Peng > > The stats is got via function call ofputil_decode_flow_stats_reply() and > for OpenFlow15 it will also call oxs_pull_entry__(). Currently we found on > Windows the counter is incorrect. > > From the output below, it is incorrect for

Re: [ovs-dev] [PATCH] tests: Fix filtering of whole-second durations.

On Thu, Oct 6, 2022 at 3:37 PM Ilya Maximets wrote: > > Current macros are unable to filter whole seconds, e.g. 'duration:6s'. > This is causing random test failures, most frequently in CirrusCI: > > ./dpif-netdev.at:370: ovs-ofctl -O OpenFlow13 meter-stats br0 | strip_timers > --- - > +++

[ovs-dev] [PATCH ovn] ovn: Remove SBREC_TABLE_HA_CHASSIS ctl_table

From: "jun.gu" Fix bug that ovn-sbctl daemon process exit when list non-existed ha_chassis. Submitted-at: https://github.com/ovn-org/ovn/pull/151 Signed-off-by: Jun Gu --- utilities/ovn-sbctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/utilities/ovn-sbctl.c b/utilities/ovn-sbctl.c

Re: [ovs-dev] [PATCH 2/8] python: include aliases in ofp_fields.py

On Mon, Oct 17, 2022 at 9:18 AM Adrian Moreno wrote: > > We currently auto-generate a dictionary of field names and decoders. > However, sometimes fields can be specified by their cannonical NXM or > OXM names. > > Modify gen_ofp_field_decoders to also generate a dictionary of aliases > so it's

[ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

In the following scenario: - interface "old" is created and external_ids:iface-id is set (to lp) - interface "new" is created and external_ids:iface-id is set (to same lp) - interface "old" is deleted flows related to lp were deleted. Note that after "new" interface is created, flows use "new"

Re: [ovs-dev] [PATCH v2] tc: On last action use drop action attribute instead of pipe

On Sun, Oct 23, 2022 at 09:28:53AM +0300, Roi Dayan wrote: > > > On 23/10/2022 9:27, Roi Dayan wrote: > > OVN is setting ct drop rule with a ct clear action. > > OVS datapath behavior is if there is no forward action > > the default is drop. > > TC behavior is to continue with next match. > >

Re: [ovs-dev] [PATCH ovn 4/4] pinctrl: Send RARPs for external ipv6 interfaces

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn 2/4] northd: handle own rarps like garps

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] [PATCH ovn 4/4] pinctrl: Send RARPs for external ipv6 interfaces

previously garps/rarps were only sent for NAT IPs if these had an ipv4 address attached. For lsp's on gateway routers that do not have an ipv4 address assigned (e.g. if they are ipv6 only) no rarps where send out. This causes traffic outages when changing the priority of a gateway chassis as the

[ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

in order to easily add future ipv6 test cases the common `ovn_attach` function should also support ipv6 addresses. Signed-off-by: Felix Huettner --- tests/ovn-macros.at | 9 + tests/ovn.at| 22 +++--- 2 files changed, 16 insertions(+), 15 deletions(-) diff

[ovs-dev] [PATCH ovn 2/4] northd: handle own rarps like garps

Previously graceful rarps sent from ovn-controller were handled as normal packets and flooded to other routers. As the other routers should already have that information, we can skip flooding (just like it is done for GARPs already) and thereby mitigate ovs refusing to send the packet because of

[ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

We need to be able to handle rarp fields in order to ensure we can handle rarp messages we send ourselves. This will be used by the next patch in the series. Signed-off-by: Felix Huettner --- lib/logical-fields.c | 8 lib/ovn-util.c | 2 +- ovn-sb.xml | 2 ++ 3 files

[ovs-dev] [PATCH ovn 0/4] Send Rarps for ipv6 router lsp

previously garps/rarps where only sent for "external" lsp's if these had an ipv4 address attached. For lsp's on gateway routers that do not have an ipv4 address assigned (e.g. if they are ipv6 only) no rarps were send out. This causes traffic outages when changing the priority of a gateway

Re: [ovs-dev] [PATCH ovn] ovn: Remove SBREC_TABLE_HA_CHASSIS ctl_table

On 10/24/22 12:08, Dumitru Ceara wrote: > From: "jun.gu" > > Fix bug that ovn-sbctl daemon process exit when list non-existed > ha_chassis. > > Submitted-at: https://github.com/ovn-org/ovn/pull/151 > Signed-off-by: Jun Gu > --- I pushed this to the main branch, thanks for the contribution!

Re: [ovs-dev] [PATCH ovn] ovn: Remove SBREC_TABLE_HA_CHASSIS ctl_table

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author jun.gu needs to sign off. WARNING: Unexpected sign-offs from developers who

[ovs-dev] [PATCH ovn] ovn: Remove SBREC_TABLE_HA_CHASSIS ctl_table

From: "jun.gu" Fix bug that ovn-sbctl daemon process exit when list non-existed ha_chassis. Submitted-at: https://github.com/ovn-org/ovn/pull/151 Signed-off-by: Jun Gu --- utilities/ovn-sbctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/utilities/ovn-sbctl.c b/utilities/ovn-sbctl.c

[ovs-dev] [PATCH v3 ovn] controller: improve buffered packets management

Improve buffered packet management in ovn-controller avoid useless loop in run_buffered_binding routine and using datapath key and output port key as buffered_packets_map hashmap hash. Add new selftest for buffered packets. Signed-off-by: Lorenzo Bianconi --- Changes since v2: - improve hash

Re: [ovs-dev] [PATCH v2 ovn] controller: improve buffered packets management

> Hi Lorenzo, > > see some minor comment inline. Hi Ales, thx for the review > > > On Fri, Oct 14, 2022 at 11:41 AM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > Improve buffered packet management in ovn-controller avoid useless loop > > in run_buffered_binding routine and

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix some issues with CT zone assignment.

On Mon, Oct 24, 2022 at 8:53 AM Ales Musil wrote: > Hi Mark, > > please see my comment below. > > > On Fri, Oct 21, 2022 at 8:38 PM Mark Michelson > wrote: > >> An issue was filed where CT zone 0 was assigned to both a logical router >> SNAT and to a logical port. CT zone 0 is typically

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix some issues with CT zone assignment.

Hi Mark, please see my comment below. On Fri, Oct 21, 2022 at 8:38 PM Mark Michelson wrote: > An issue was filed where CT zone 0 was assigned to both a logical router > SNAT and to a logical port. CT zone 0 is typically "reserved" and not > assigned by ovn-controller; however, since SNAT

Re: [ovs-dev] [PATCH ovn v3] ovn-controller: Fixed missing flows after interface deletion

Hi Xavier, some minor comments below. On Thu, Oct 20, 2022 at 4:53 PM Xavier Simonart wrote: > In the following scenario: > - interface "old" is created and external_ids:iface-id is set (to lp) > - interface "new" is created and external_ids:iface-id is set (to same lp) > - interface "old" is

Re: [ovs-dev] [PATCH v2 ovn] controller: improve buffered packets management

Hi Lorenzo, see some minor comment inline. On Fri, Oct 14, 2022 at 11:41 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Improve buffered packet management in ovn-controller avoid useless loop > in run_buffered_binding routine and using datapath key and output port > key as