Re: [ovs-dev] [PATCH v3 1/1] netdev-offload-tc: Reserve lower tc prios for ip ethertypes

2022-11-08 Thread Roi Dayan via dev
On 02/11/2022 15:08, Ilya Maximets wrote: > On 11/2/22 14:01, Simon Horman wrote: >> On Wed, Nov 02, 2022 at 01:52:18PM +0100, Eelco Chaudron wrote: >>> >>> >>> On 2 Nov 2022, at 13:46, Roi Dayan wrote: >>> From: Paul Blakey Currently ethertype to prio hmap is static and the firs

Re: [ovs-dev] [PATCHv4 net-next 0/4] net: add helper support in tc act_ct for ovs offloading

2022-11-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (master) by Paolo Abeni : On Sun, 6 Nov 2022 15:34:13 -0500 you wrote: > Ilya reported an issue that FTP traffic would be broken when the OVS flow > with ct(commit,alg=ftp) installed in the OVS kernel module, and it was > caused by that TC di

Re: [ovs-dev] [PATCH v3 1/1] netdev-offload-tc: Reserve lower tc prios for ip ethertypes

2022-11-08 Thread Simon Horman
On Tue, Nov 08, 2022 at 10:42:19AM +0200, Roi Dayan wrote: > > > On 02/11/2022 15:08, Ilya Maximets wrote: > > On 11/2/22 14:01, Simon Horman wrote: > >> On Wed, Nov 02, 2022 at 01:52:18PM +0100, Eelco Chaudron wrote: > >>> > >>> > >>> On 2 Nov 2022, at 13:46, Roi Dayan wrote: > >>> > From:

Re: [ovs-dev] [PATCH v3 1/1] netdev-offload-tc: Reserve lower tc prios for ip ethertypes

2022-11-08 Thread Simon Horman
On Tue, Nov 08, 2022 at 06:58:15AM -0500, Simon Horman wrote: > On Tue, Nov 08, 2022 at 10:42:19AM +0200, Roi Dayan wrote: > > > > > > On 02/11/2022 15:08, Ilya Maximets wrote: > > > On 11/2/22 14:01, Simon Horman wrote: > > >> On Wed, Nov 02, 2022 at 01:52:18PM +0100, Eelco Chaudron wrote: > > >

[ovs-dev] [PATCH ovn] northd: bypass connection tracking for statless flows when there are LB flows present

2022-11-08 Thread venu.iyer via dev
Currently, even statless flows are subject to connection tracking when there are LB rules (for DNAT). However, if a flow needs to be subjected to LB, then it shouldn't be configured for stateless. A stateles flows means we should not track it, and this change exempts stateless flows from being tr

[ovs-dev] [PATCH ovn] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-11-08 Thread venu.iyer via dev
Currently, even stateless flows are subject to connection tracking when there are LB rules (for DNAT). However, if a flow needs to be subjected to LB, then it shouldn't be configured as stateless. A stateless flow means we should not track it, and this change exempts stateless flows from being t

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for statless flows when there are LB flows present

2022-11-08 Thread 0-day Robot
Bleep bloop. Greetings venu.iyer, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author venu.iyer needs to sign off. WARNING: Unexpected sign-offs from developers who are n

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for statless flows when there are LB flows present

2022-11-08 Thread venugopal iyer via dev
Please ignore this patch, resending the patch with typos in the comments fixed. thanks, -venu On Tuesday, November 8, 2022 at 07:40:41 AM PST, venu.iyer via dev wrote: Currently, even statless flows are subject to connection tracking when there are LB rules (for DNAT). However, if a f

[ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-08 Thread Dan Williams
If no arguments are given report the current memory trim setting. Signed-off-by: Dan Williams --- ovsdb/ovsdb-server.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 7a6bfe0a03c09..8c997cf5caf67 100644 --- a/ovsdb/

Re: [ovs-dev] [PATCH] rculist: Fix iteration macros.

2022-11-08 Thread Alin-Gabriel Serdean
Acked-by: Alin-Gabriel Serdean -Original Message- From: dev On Behalf Of Ilya Maximets Sent: Friday, November 4, 2022 4:26 PM To: ovs-dev@openvswitch.org Cc: Subrata Nath ; Dumitru Ceara ; Ilya Maximets Subject: [ovs-dev] [PATCH] rculist: Fix iteration macros. Some macros for rculist h

Re: [ovs-dev] dpif-netdev: fix flow allocation size

2022-11-08 Thread Mike Pattrick
On Fri, Nov 4, 2022 at 2:46 AM Peng He wrote: > > The tail of the struct dp_netdev_flow contains a whole netdev_flow_key > struct. > > We need to first minus the size of netdev_flow_key then add back > the real size of this netdev_flow_key. > > Signed-off-by: Peng He > --- > lib/dpif-netdev.c |

Re: [ovs-dev] [PATCH ovn v3 0/4] Send Rarps for ipv6 router lsp

2022-11-08 Thread Numan Siddique
On Fri, Nov 4, 2022 at 5:00 AM Felix Hüttner via dev wrote: > > previously garps/rarps where only sent for "external" lsp's if these > had an ipv4 address attached. For lsp's on gateway routers that do > not have an ipv4 address assigned (e.g. if they are ipv6 only) no > rarps were send out. > > T

[ovs-dev] [PATCH v7 ovn 0/3] Introduce lb affinity timeout support

2022-11-08 Thread Lorenzo Bianconi
Introduce load-balancer affinity timeout in order to dnat connections received from the same client to a given load-balancer to the same backend if received in the affinity timeslot specified by the CMS. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2127959 Changes since v6: - fix hair

[ovs-dev] [PATCH v7 ovn 1/3] actions: introduce commit_lb_aff action

2022-11-08 Thread Lorenzo Bianconi
commit_lb_aff action translates to an openflow "learn" action that inserts a new flow in the OFTABLE_CHK_LB_AFFINITY table. The new flow is used to match on the the 5-tuple and set REGBIT_KNOWN_LB_SESSION bit. Moreover the new flow stores backend IP and port in register REG4 and REG8[0..15] respect

[ovs-dev] [PATCH v7 ovn 2/3] actions: introduce chk_lb_aff action

2022-11-08 Thread Lorenzo Bianconi
chk_lb_aff action checks if the packet under consideration matches the new flow in table OFTABLE_CHK_LB_AFFINITY. If so, then the 1-bit destination register is set to 1. chk_lb_aff will be used to add affinity timeout support to load balancer connections. Acked-by: Mark Michelson Signed-off-by: L

[ovs-dev] [PATCH v7 ovn 3/3] northd: rely on new actions for lb affinity

2022-11-08 Thread Lorenzo Bianconi
Rely on the following new actions in order to introduce affinity timeout support to load-balancer sessions: - commit_lb_aff - chk_lb_aff Introduce the following tables in switch and router pipelines respectively: - S_SWITCH_IN_LB_AFF_CHECK - S_SWITCH_IN_LB_AFF_LEARN - S_ROUTER_IN_LB_AFF_CHECK - S_

Re: [ovs-dev] [PATCH] learn: Fix parsing immediate value for a field match.

2022-11-08 Thread Simon Horman
On Sat, Nov 05, 2022 at 11:11:53AM +0100, Ilya Maximets wrote: > The value is right-justified after the string parsing with > parse_int_string(), i.e. it is in BE byte order and aligned > to the right side of the array. > > For example, the 0x10011 value in a 4-byte field will look > like 0x00 0x0

Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: Check the condition to reset pseudo header checksum on Rx side

2022-11-08 Thread alinserdean
Resending email because ovn mail blocked the first one. -Original Message- From: Alin-Gabriel Serdean Sent: Tuesday, November 8, 2022 8:01 PM To: 'Wilson Peng' ; 'd...@openvswitch.org' Subject: RE: [ovs-dev] [PATCH v1 1/1] datapath-windows: Check the condition to reset pseudo header c

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread alinserdean
Resending email because ovn mail blocked the first one. -Original Message- From: Alin-Gabriel Serdean Sent: Tuesday, November 8, 2022 8:08 PM To: 'Wilson Peng' ; 'd...@openvswitch.org' Subject: RE: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system

Re: [ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-08 Thread Dumitru Ceara
On 11/8/22 13:04, Dan Williams wrote: > If no arguments are given report the current memory trim setting. > > Signed-off-by: Dan Williams > --- Hi Dan, > ovsdb/ovsdb-server.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb

[ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-08 Thread Dan Williams
If no arguments are given report the current memory trim setting. Signed-off-by: Dan Williams --- ovsdb/ovsdb-server.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 7a6bfe0a03c09..8c997cf5caf67 100644 --- a/ovsdb/

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: rely on new actions for lb affinity

2022-11-08 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 96 characters long (recommended limit is 79) #211 FILE: northd/northd.c:28

Re: [ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-08 Thread 0-day Robot
Bleep bloop. Greetings Dan Williams, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Dan Williams needs to sign off. WARNING: Unexpected sign-offs from developers wh

Re: [ovs-dev] dpif-netdev: fix flow allocation size

2022-11-08 Thread Simon Horman
On Fri, Nov 04, 2022 at 06:46:05AM +, Peng He wrote: > The tail of the struct dp_netdev_flow contains a whole netdev_flow_key > struct. > > We need to first minus the size of netdev_flow_key then add back > the real size of this netdev_flow_key. Hi Peng, It seems to me that as a result of th

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread Simon Horman
On Thu, Oct 13, 2022 at 10:50:51PM +0800, Wilson Peng wrote: ... > @@ -165,8 +166,19 @@ netdev_windows_system_construct(struct netdev *netdev_) > if (strcmp(netdev_get_type(&netdev->up), "internal") && ret) { > return ret; > } > + > ofpbuf_delete(buf); > > +/* if ovs

Re: [ovs-dev] [PATCH] ovsdb-server: make ovsdb-server/memory-trim-on-compaction appctl command report state

2022-11-08 Thread Simon Horman
On Tue, Nov 08, 2022 at 01:17:57PM -0500, Dumitru Ceara wrote: > On 11/8/22 13:04, Dan Williams wrote: > > If no arguments are given report the current memory trim setting. > > > > Signed-off-by: Dan Williams > > --- > > Hi Dan, > > > ovsdb/ovsdb-server.c | 10 -- > > 1 file changed, 8

[ovs-dev] [PATCH v2 1/1] datapath-windows: Check the condition to reset pseudo header checksum on Rx side

2022-11-08 Thread Wilson Peng
From: Wilson Peng If ovs node running on Windows is processing NAT action on the RX side, it will reset pseudo header checksum only if the L4 checksum is same as the calculated pseudo header checksum before NAT action. Without the fix, if the L4 header checksum is filled with a pseudo header c

Re: [ovs-dev] [PATCH v1 1/1] datapath-windows: Check the condition to reset pseudo header checksum on Rx side

2022-11-08 Thread Wilson Peng via dev
Hi Alin, Thanks for the comments. V2 version is sent out and it corrects the name Off issue and rename the added variables. As this is bug fix, please help apply It back to branch 3.0-2.14 also. Regards Wilson From: dev on behalf of alinserd...@gmail.com Date: Wednesday, November 9, 2022 at 02

[ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread Wilson Peng
From: Wilson Peng In the recent Antrea project testing, some port could not be created on Windows. When doing debug, our team found there is one case happening when multiple ports are waiting for be created with correct port number. Some system type port will be created netdev successfully and

Re: [ovs-dev] [PATCH v1 1/1] netdev-windows: Add checking when creating netdev with system type on Windows

2022-11-08 Thread Wilson Peng via dev
Hi Simon, Thanks for the comments and I have uploaded new patch with the Updated notations in the patch. And also, I have updated the error log Combined with the debug diff in the related reported issue https://github.com/openvswitch/ovs-issues/issues/262 Regards Wilson From: dev on behalf of

[ovs-dev] Broken links in OVN-tutorial

2022-11-08 Thread Шагов Георгий via dev
Hello Team! Please consider the tutorial link: https://www.openvswitch.org/support/dist-docs-2.5/tutorial/OVN-Tutorial.md.html All the links to setup files into the page are broken. For instance: https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/setup.sh https://github.com/openvswi