Eelco Chaudron 于2022年12月13日周二 20:36写道：
>
>
> On 10 Dec 2022, at 1:37, Peng He wrote:
>
> > Patch v5 has statistics issues.
> >
> > In order to solve this issue, we had a discussion.
> >
> > below is the quote of the email.
> >
> > ”
> > After a second thought, I think maybe keeping INCONSISTENT j
On Fri, Dec 16, 2022 at 12:32 AM Dumitru Ceara wrote:
> On 12/7/22 16:34, Ales Musil wrote:
> > In order to have the SNAT action available for
> > related traffic store the flag in CT register.
> >
> > Extend the ct_lb and ct_lb_mark action to
> > allow additional parameter that sets the
> > corr
On 12/15/22 22:43, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> I more-or-less randomized the time of day since this will be at some
> point early tomorrow for me. I plan to regenerate the patch with the
> correct time when I actually push the commit.
> ---
> NEWS | 2
On 12/15/22 22:43, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> I more-or-less randomized the time of day since this will be at some
> point early tomorrow for me. I plan to regenerate the patch with the
> correct time when I actually push the commit.
> ---
> NEWS | 3
On 12/7/22 16:34, Ales Musil wrote:
> In order to have the SNAT action available for
> related traffic store the flag in CT register.
>
> Extend the ct_lb and ct_lb_mark action to
> allow additional parameter that sets the
> corresponding flag if needed in ct_label/ct_mark
> register. This allows
On 12/7/22 22:02, Mark Michelson wrote:
> Thanks, Ales!
>
> Acked-by: Mark Michelson
>
Thanks Mark and Ales!
I pushed this to the main branch and to 22.12.
Regards,
Dumitru
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mail
On 12/15/22 22:30, Vladislav Odintsov wrote:
> Thanks Numan for the review.
>
> It seems that for some reason appeared a memory leak, which constantly
> reproduces.
Do you mean this one?
Direct leak of 64 byte(s) in 1 object(s) allocated from:
#0 0x49a052 in calloc
(/home/runner/work/ovn/o
Signed-off-by: Mark Michelson
---
I more-or-less randomized the time of day since this will be at some
point early tomorrow for me. I plan to regenerate the patch with the
correct time when I actually push the commit.
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 +++
Mark Michelson (2):
Set release date for 22.12.0.
Prepare for 22.12.1.
NEWS | 5 -
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 12 insertions(+), 3 deletions(-)
--
2.38.1
___
dev mailing list
d...@ope
Signed-off-by: Mark Michelson
---
I more-or-less randomized the time of day since this will be at some
point early tomorrow for me. I plan to regenerate the patch with the
correct time when I actually push the commit.
---
NEWS | 2 +-
debian/changelog | 2 +-
2 files changed, 2 insert
On Thu, Dec 15, 2022 at 12:02 PM Vladislav Odintsov wrote:
>
> v2 -> v3:
> - Split patch #3 by two: first fixes a bug with duplicated route
> advertisement and will be considered for back-porting; the second one
> changes ovn-ic SB:Route schema and documents ovn-ic upgrade details.
> -
On Mon, Dec 12, 2022 at 1:28 AM venu iyer wrote:
>
> Currently, even stateless flows are subject to connection tracking when
there are
> LB rules (for DNAT). However, if a flow needs to be subjected to LB, then
it shouldn't
> be configured as stateless.
>
> Stateless flow means we should not track
Thanks Numan for the review.
It seems that for some reason appeared a memory leak, which constantly
reproduces.
I’ll give it a time tomorrow to find the source of a problem.
Regards,
Vladislav Odintsov
> On 16 Dec 2022, at 00:21, Numan Siddique wrote:
>
> On Thu, Dec 15, 2022 at 12:02 PM Vlad
To do this we factor the memory trimming code out into its own module,
memory-trim. We use this now for both the lflow cache (in
ovn-controller) and for ovn-northd.
Signed-off-by: Dumitru Ceara
---
controller/lflow-cache.c | 68 +-
lib/automake.mk |2 +
li
Dumitru Ceara (2):
ovn-northd: Add IDL memory usage information.
northd: Add automatic memory trimming when idle.
controller/lflow-cache.c | 68 --
lib/automake.mk | 2 +
lib/memory-trim.c| 120 +++
lib/memor
Signed-off-by: Dumitru Ceara
---
northd/ovn-northd.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 82d2874d66..3a575b02a5 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -849,7 +849,8 @@ main(int argc, char *
tor. 15. des. 2022, 20:45 skrev Dan Williams :
> On Thu, 2022-12-15 at 19:46 +0100, Frode Nordahl wrote:
> > On Thu, Dec 15, 2022 at 7:16 PM Dan Williams wrote:
> > > On Thu, 2022-12-15 at 19:04 +0100, Frode Nordahl wrote:
> >
> > [ snip ]
> >
> > > > Thank you for proposing this patch!
> > > >
>
On Thu, 2022-12-15 at 19:46 +0100, Frode Nordahl wrote:
> On Thu, Dec 15, 2022 at 7:16 PM Dan Williams wrote:
> > On Thu, 2022-12-15 at 19:04 +0100, Frode Nordahl wrote:
>
> [ snip ]
>
> > > Thank you for proposing this patch!
> > >
> > > We've been seeing reports of schema upgrades failing in
Add extension that allows to flush connections from CT
by specifying fields that the connections should be
matched against. This allows to match only some fields
of the connection e.g. source address for orig direrction.
Reported-at: https://bugzilla.redhat.com/2120546
Signed-off-by: Ales Musil
-
Currently, the CT can be flushed by dpctl only be specifying
the whole 5-tuple. This is not very convenient when there are
only some fields known to the user of CT flush. Add new struct
ofputil_ct_match which represents the generic filtering that can
be done for CT flush. The match is done only on
Add extension that will allow to flush
connection from CT specified by full
orig 5-tuple or partial match that combines
orig or reply direction.
Ales Musil (2):
ofp, dpif: Allow CT flush based on partial match
openflow: Add extension to flush CT by generic match
NEWS
On Thu, Dec 15, 2022 at 7:16 PM Dan Williams wrote:
> On Thu, 2022-12-15 at 19:04 +0100, Frode Nordahl wrote:
[ snip ]
> > Thank you for proposing this patch!
> >
> > We've been seeing reports of schema upgrades failing in the too and
> > have waited for some way to reproduce and see if this wou
On 12/15/22 15:38, Timothy Redaelli wrote:
> On Tue, 13 Dec 2022 12:57:08 +0100
> Ilya Maximets wrote:
>
>> On 12/5/22 15:36, Ilya Maximets wrote:
>>> On 12/4/22 09:23, Roi Dayan wrote:
On 30/11/2022 17:55, Ilya Maximets wrote:
> On 11/14/22 20:41, Timothy Redaelli wrote:
>
On Thu, 2022-12-15 at 19:04 +0100, Frode Nordahl wrote:
> Hello, Dan,
>
> On Thu, Dec 15, 2022 at 6:57 PM Dan Williams wrote:
> >
> > Signed-off-by: Dan Williams
> > ---
> > utilities/ovs-lib.in | 13 +
> > 1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/utili
Hello, Dan,
On Thu, Dec 15, 2022 at 6:57 PM Dan Williams wrote:
>
> Signed-off-by: Dan Williams
> ---
> utilities/ovs-lib.in | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
> index 13477a6a9e991..36e63312b6cba 10
Signed-off-by: Dan Williams
---
utilities/ovs-lib.in | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
index 13477a6a9e991..36e63312b6cba 100644
--- a/utilities/ovs-lib.in
+++ b/utilities/ovs-lib.in
@@ -475,11 +475,16 @@
On Tue, Nov 22, 2022 at 12:54 PM Lorenzo Bianconi
wrote:
>
> Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health
> check support.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094
> Signed-off-by: Lorenzo Bianconi
Hi Lorenzo,
Thanks for adding this missing fe
On 15/12/2022 01:12, Thilak Raj Surendra Babu wrote:
Hi Kevin,
Apologize for the late reply.
Please find my replies inline.
Hi Thilak,
Thanks for your comments. Replies below.
Just a small thing on email format. If possible, could you send replies
inline (i.e. not top-post and original mail
Add new uniq index to OVN IC Southbound Route table to prevent same
routes installation.
Also document ovn-ic upgrade details & note new schema change to known
possible duplicate records, which can fail the schema convert.
Signed-off-by: Vladislav Odintsov
---
Documentation/intro/install/ovn-upg
1. Remove excess nbrec_logical_router variable.
2. Remove excess call to add_static_to_routes_ad().
3. Remove double nexthop check in ic_route_find().
Signed-off-by: Vladislav Odintsov
Acked-by: Dumitru Ceara
---
ic/ovn-ic.c | 21 +
1 file changed, 5 insertions(+), 16 deleti
Advertize one route (ip_prefix, nexthop, route_table, transit_switch,
availability_zone) only once.
Signed-off-by: Vladislav Odintsov
---
ic/ovn-ic.c | 84 ++---
tests/ovn-ic.at | 60 +++
2 files changed, 111 inserti
Signed-off-by: Vladislav Odintsov
Acked-by: Dumitru Ceara
---
ic/ovn-ic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c
index 2bc96d36c..0d5e5f5d9 100644
--- a/ic/ovn-ic.c
+++ b/ic/ovn-ic.c
@@ -757,6 +757,7 @@ port_binding_run(struct ic_context
Before this patch if one deletes transit switch through which there were
routes in ICSB:Route table, such routes were left forever in the DB.
Now we validate that each ICSB:Route has an appropriate transit switch.
Signed-off-by: Vladislav Odintsov
Acked-by: Dumitru Ceara
---
ic/ovn-ic.c |
v2 -> v3:
- Split patch #3 by two: first fixes a bug with duplicated route
advertisement and will be considered for back-porting; the second one
changes ovn-ic SB:Route schema and documents ovn-ic upgrade details.
- Address Dumitru's comment regarding loggin rate-limit.
v1 -> v2:
- S
Ales Musil writes:
> Add extension that allows to flush connections from CT
> by specifying fields that the connections should be
> matched against. This allows to match only some fields
> of the connection e.g. source address for orig direrction.
>
> Reported-at: https://bugzilla.redhat.com/2120
Make it clear which of the DB args is the clusterd one.
Signed-off-by: Dan Williams
---
ovsdb/ovsdb-tool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
index 60f353197bfd7..33719d38a4d09 100644
--- a/ovsdb/ovsdb-tool.c
+++ b/ovsdb/ov
Coucou Robin,
On Mon, Dec 12, 2022 at 4:16 PM Robin Jarry wrote:
>
> Some control protocols are used to maintain link status between
> forwarding engines (e.g. LACP). When the system is not sized properly,
> the PMD threads may not be able to process all incoming traffic from the
> configured Rx
Thanks Dumitru! Is there any BZ/Jira ticket I could follow?
Thanks,
Kuba
On 12/12/22 7:41 AM, Dumitru Ceara wrote:
> On 12/5/22 17:07, Dumitru Ceara wrote:
>> On 9/30/22 12:43, Dumitru Ceara wrote:
>>> On 9/20/22 22:18, Mark Michelson wrote:
Thanks Ales,
Acked-by: Mark Michelson
>
Ales Musil writes:
> On Thu, Dec 15, 2022 at 4:28 PM Paolo Valerio wrote:
>
> Ales Musil writes:
>
> > Currently, the CT can be flushed by dpctl only be specifying
> > the whole 5-tuple. This is not very convenient when there are
> > only some fields known to the user of CT flus
On Tue, Dec 13, 2022 at 12:02 AM Frode Nordahl
wrote:
>
> On Mon, Dec 12, 2022 at 5:25 PM Ilya Maximets wrote:
> >
> > On 12/12/22 17:17, Frode Nordahl wrote:
> > > On Mon, Dec 12, 2022 at 2:55 PM Frode Nordahl
> > > wrote:
> > >>
> > >> On Mon, Dec 12, 2022 at 12:20 PM Ilya Maximets
> > >> wr
On Thu, Dec 15, 2022 at 4:28 PM Paolo Valerio wrote:
> Ales Musil writes:
>
> > Currently, the CT can be flushed by dpctl only be specifying
> > the whole 5-tuple. This is not very convenient when there are
> > only some fields known to the user of CT flush. Add new struct
> > ofputil_ct_match w
Ales Musil writes:
> Currently, the CT can be flushed by dpctl only be specifying
> the whole 5-tuple. This is not very convenient when there are
> only some fields known to the user of CT flush. Add new struct
> ofputil_ct_match which represents the generic filtering that can
> be done for CT fl
The commit mentioned below causes the ovs_flow_tbl_lookup() function
to be called with the masked key. However, it's supposed to be called
with the unmasked key. This due to the fact that the datapath supports
installing wider flows, and OVS relies on this behavior. For example
if ipv4(src=1.1.1.1/
On Tue, 13 Dec 2022 12:57:08 +0100
Ilya Maximets wrote:
> On 12/5/22 15:36, Ilya Maximets wrote:
> > On 12/4/22 09:23, Roi Dayan wrote:
> >>
> >>
> >> On 30/11/2022 17:55, Ilya Maximets wrote:
> >>> On 11/14/22 20:41, Timothy Redaelli wrote:
> conf.db is by default at /etc/openvswitch, but i
On 15 Dec 2022, at 12:45, Ilya Maximets wrote:
> On 12/14/22 17:33, Eelco Chaudron wrote:
>> The commit mentioned below causes the ovs_flow_tbl_lookup() function
>> to be called with the masked key. However, it's supposed to be called
>> with the unmasked key.
>
> Hi, Eelco. Thanks for the fix
On Tue, Dec 13, 2022 at 10:07 AM Xavier Simonart wrote:
>
> Hi Mark, Ales
>
> Thanks for your review and feedback.
> I'll send v2 for patch 4 and 7, and comments on patch 10.
>
> Thanks
> Xavier
>
> On Mon, Dec 12, 2022 at 10:33 PM Mark Michelson wrote:
>
> > Hi Xavier. I did a review of this ser
> -Original Message-
> From: dev On Behalf Of Eelco Chaudron
> Sent: Wednesday 14 December 2022 11:17
> To: Finn, Emma
> Cc: d...@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v8] odp-execute: Add ISA implementation of set_masked
> IPv6 action
>
>
>
> On 8 Dec 2022, a
When a flow gets modified, i.e. the actions are changes, the tc layer will
remove, and re-add the flow. This is causing all the counters to be reset.
This patch will remember the previous tc counters and adjust any requests
for statistics. This is done in a similar way as the rte_flow implementati
On 12/14/22 18:07, Dumitru Ceara wrote:
> On 12/14/22 16:40, Mark Michelson wrote:
>> On 12/14/22 10:30, Dumitru Ceara wrote:
>>> On 12/14/22 16:28, Mark Michelson wrote:
This looks good to me. Thanks Dumitru!
Acked-by: Mark Michelson
>>>
>>> Thanks!
>>>
Just to double-che
This reverts commit 59e8cb8a053d50f49629be8b6fd614562d066404.
Commit broke the package install on a clean system and also doesn't
seem to manage access rights for created symlinks correctly.
Revert it until a proper solution is proposed.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-d
Currently, the CT can be flushed by dpctl only be specifying
the whole 5-tuple. This is not very convenient when there are
only some fields known to the user of CT flush. Add new struct
ofputil_ct_match which represents the generic filtering that can
be done for CT flush. The match is done only on
Add extension that allows to flush connections from CT
by specifying fields that the connections should be
matched against. This allows to match only some fields
of the connection e.g. source address for orig direrction.
Reported-at: https://bugzilla.redhat.com/2120546
Signed-off-by: Ales Musil
-
Add extension that will allow to flush
connection from CT specified by full
orig 5-tuple or partial match that combines
orig or reply direction.
Ales Musil (2):
ofp, dpif: Allow CT flush based on partial match
openflow: Add extension to flush CT by generic match
NEWS
On 12/14/22 17:33, Eelco Chaudron wrote:
> The commit mentioned below causes the ovs_flow_tbl_lookup() function
> to be called with the masked key. However, it's supposed to be called
> with the unmasked key.
Hi, Eelco. Thanks for the fix!
Could you, please, add more information to the commit me
Compiling with GCC and -fsanitize=undefined throws
a warning [0]. To avoid that, use the original
ovnact pointer with the inner size rather than getting
the inner "struct ovnact" from the "struct ovnact_load".
At the same time simplify the computation of size for
ovnacts_format call.
[0]
In funct
On 12/15/22 09:31, Vladislav Odintsov wrote:
> Hi Dumitru,
>
> Regards,
> Vladislav Odintsov
>
>> On 12 Dec 2022, at 17:57, Dumitru Ceara wrote:
>>
>> On 12/12/22 14:39, Vladislav Odintsov wrote:
>>> Hi Numan, Dumitru,
>>>
>>> I forgot one thing about a possible upgrade recommendation for the us
Hi Dumitru,
Regards,
Vladislav Odintsov
> On 12 Dec 2022, at 17:57, Dumitru Ceara wrote:
>
> On 12/12/22 14:39, Vladislav Odintsov wrote:
>> Hi Numan, Dumitru,
>>
>> I forgot one thing about a possible upgrade recommendation for the users.
>> Fix can be applied much easier: just upgrading all
57 matches
Mail list logo
